mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
385,389 Commits 1 Branch 0 Tags
3bb7557d541328194eae928fda32b73650f13360
Commit Graph

268 Commits

Author SHA1 Message Date
Oliver Specht
fa91dd31f3 5th step to remove tools/rtti.hxx 
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-11-11 10:49:30 +00:00
Stephan Bergmann
08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar 
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-09 08:34:40 +00:00
Stephan Bergmann
a80bab7058 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
 2015-11-06 09:34:39 +01:00
Noel Grandin
59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Benjamin Ni
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b" 
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2015-11-02 23:40:57 +01:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Noel Grandin
065c8b48a6 use uno::Reference::set method instead of assignment 
Change-Id: I58410209f32f988f258a588364e0b037c2790211
 2015-10-30 08:10:22 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
66ef464799 clang-analyzer-deadcode.DeadStores 
Change-Id: I2ef946572a61eb766454d2df0cb2ff523050ed7e
 2015-10-06 15:31:15 +02:00
Caolán McNamara
e9ae1b64af checkUnoObjectType etc always deref their ptr arg, convert to ref 
Change-Id: Iabdb057fb2dc05cfb8c98864dc5109360b50633a
 2015-10-02 11:38:58 +01:00
Caolán McNamara
e31cd8f3ae coverity#1325250 Unchecked dynamic_cast 
Change-Id: Id52cad11d2ca4ef42a31c0905ee123ccd53e0677
 2015-10-01 14:41:29 +01:00
Andrea Gelmini
9e4c87be31 Fix typos 
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 05:53:57 +00:00
Oliver Specht
d3c7c9ea81 tdf#94559: first step to remove rtti.hxx 
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff

Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-29 12:26:20 +00:00
Noel Grandin
751c771adc loplugin:mergeclass, merge BiNode with NameNode, Obj0Type with ObjkType 
Change-Id: Icbc0dfc6096a6e2c651dad4fe9f78d176f389390
 2015-09-08 09:20:31 +02:00
Stephan Bergmann
37a6fdf890 loplugin:stringconstant also for cases using char const v[] = "..." 
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
 2015-09-03 09:34:00 +02:00
Stephan Bergmann
ba4276efa3 loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: I349e1b9e3ea81c0684c6234497b6d44b47666b09
 2015-08-31 08:04:43 +02:00
Noel Grandin
50097a8bb2 basic,basctl: inline some use-once typedefs 
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
 2015-08-04 08:55:56 +02:00
Noel Grandin
b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Noel Grandin
b4ee16da65 com::sun::star->css in basic 
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 09:39:36 +00:00
Noel Grandin
22b094f5d8 loplugin:unusedmethods basic 
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1
Reviewed-on: https://gerrit.libreoffice.org/17044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-15 09:07:05 +00:00
Takeshi Abe
7640e244db tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, in basic.

Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36
Reviewed-on: https://gerrit.libreoffice.org/16719
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-06 07:28:21 +00:00
Andrea Gelmini
ffa8892c5a Fix typos 
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-04 10:23:17 +00:00
Noel Grandin
07d85c4499 remove SFX_NOTIFY macro 
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects

Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
 2015-06-24 12:06:34 +02:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]> 
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-06-17 15:50:45 +00:00
Julien Nabet
3754474cde Typos 
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
 2015-06-13 09:13:52 +02:00
Stephan Bergmann
761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Caolán McNamara
8e22cd40ec cppcheck: noExplicitConstructor 
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
 2015-06-02 08:57:56 +01:00
Noel Grandin
afcf1ecee1 loplugin:loopvartoosmall 
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
 2015-05-29 08:48:41 +02:00
Stephan Bergmann
ef6877c167 loplugin:cstylecast: nop between pointer types of exactly same spelling 
Change-Id: I1e4363f917a978434fb11368918435da12531dc6
 2015-05-11 12:49:03 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
2fc4a8c811 Add support for cppu::UnoType<void> 
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
 2015-04-01 12:48:44 +02:00
Stephan Bergmann
4f2a236da4 Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: I69cac41fd3db1e99ecb55e23ac81c67046f81cb4
 2015-04-01 08:35:28 +02:00
Stephan Bergmann
0bd502af47 Clean up remaining C-style casts among void pointers 
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
 2015-03-29 09:17:47 +02:00
Stephan Bergmann
c3fb36ed26 Clean up C-style casts from pointers to void 
Change-Id: I6dd7c7fbaf0d4b22abba0a7b1f5e37f0a46d0747
 2015-03-28 19:09:17 +01:00
Julien Nabet
b33788cb6b Typos 
Change-Id: I665a56fcad10e136e949a10497f6ab8813af9968
 2015-03-25 21:19:59 +01:00
Noel Grandin
b2d2d72a7e loplugin:constantfunction: basic 
Change-Id: I1c9a33cefb68bec978b2a922c2c3ef00f2a7a1b4
 2015-03-24 10:31:17 +02:00
Julien Nabet
5f6fcb4e7c Typos 
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
 2015-03-08 16:45:30 +01:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Stephan Bergmann
4130c64355 Some more loplugin:cstylecast: basic 
Change-Id: Ib22bc7408d333a7080fa44c9c3ac9535ccf00752
 2015-01-20 09:06:45 +01:00
Caolán McNamara
7f476fea47 boost::unordered_map -> c++11 std::unordered_map 
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
 2014-12-27 23:00:45 +00:00
Stephan Bergmann
39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Stephan Bergmann
0f5e917024 Introduce rtl::OUStringLiteral1 
...to use single ASCII character literals "more directly" in the OUString API
(instead of having to go via an intermediary OUString ctor call).  Especially
useful for character literals that are defined as const variables or via macros
("direct" uses of character literals in the OUString API can often simply be
replaced with single-character string literals, for improved readability).

(The functions overloaded for OUStringLiteral1 are those that are actually used
by the existing LO code; more could potentially be added.  The asymmetry in the
operator ==/!= parameter types is by design, though---writing code like

  'x' == s

is an abomination that shall not be abetted.)

Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
 2014-12-17 16:39:33 +01:00
Michael Weghorn
93124f7710 reduce scope of local variables 
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Ic4bf3bd8f5982d2ea2f25a28c0dd61084c59af11
Reviewed-on: https://gerrit.libreoffice.org/13331
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-12-06 14:12:31 +00:00
Caolán McNamara
12bcfec04f markup with event type not checker type 
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
 2014-11-05 14:58:00 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Caolán McNamara
cb0e009a9e document array_vs_singleton dismissals 
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
 2014-10-30 10:10:09 +00:00
Noel Grandin
059f5a95b2 loplugin: cstylecast 
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
 2014-10-02 07:37:19 +02:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00