Commit Graph

2033 Commits

Author SHA1 Message Date
Noel Grandin
a508f639a0 mark UNO structs as SAL_WARN_UNUSED, where possible
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26 13:26:25 +02:00
Noel Grandin
fe3fd05966 add mapKeysToSequence/mapValuesToSequence methods to comphelper
and use them

Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec
Reviewed-on: https://gerrit.libreoffice.org/20055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-20 08:14:13 +00:00
Noel Grandin
2554efabb6 use comphelper::containerToSequence
in chart2, we remove a local equivalent of the method

Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-19 09:33:29 +02:00
Noel Grandin
21a9bc8716 no need to take a mutex when only dealing with stack-local data
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65
Reviewed-on: https://gerrit.libreoffice.org/19979
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16 11:37:11 +00:00
Noel Grandin
8569c6d0ad use initialiser list for Sequence<OUString>
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16 08:35:42 +00:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString>
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString>
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 10:13:08 +00:00
Caolán McNamara
8325fcb56d cppcheck: noExplicitConstructor
Change-Id: Ife26f55c28c4631aec4ba4105225bfca72da8bff
2015-11-13 10:17:26 +00:00
Stephan Bergmann
65464ed098 loplugin:nullptr (automatic rewrite)
Change-Id: I9b7d8de65780325175d24965057596b88d3c0f05
2015-11-10 10:31:37 +01:00
Noel Grandin
b5df54c5bc java: add some @Override annotations
Change-Id: I291db1dff5ab3ce40fda6f822a0e3ff1e6ef36c1
Reviewed-on: https://gerrit.libreoffice.org/19855
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 11:14:56 +00:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
Stephan Bergmann
729c70a242 loplugin:stringconstant: elide explicit ctor usage (manually due to macros)
Change-Id: Ib023c89256d50ebe15231a96f6106f60198d362e
2015-11-06 12:32:43 +01:00
Stephan Bergmann
801b914324 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: If0f1446a25f423b8cbfe6346f7a691f4f2618ad0
2015-11-06 09:36:56 +01:00
Noel Grandin
b73db446ac java: combine nested if statements
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-05 14:55:15 +02:00
Noel Grandin
0eb9f56db5 use uno::Reference::set method instead of assignment
Change-Id: I2b592fd3327f4bbe4685e84711dc9d6f19222a97
2015-11-05 07:41:29 +02:00
Noel Grandin
59b072e22b yyyyy
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
Stephan Bergmann
6ccf68622e No need for this debug code
Change-Id: I05a6d15a0c54ca5457d662c2467cb15c14991a0a
2015-11-02 23:30:58 +01:00
Caolán McNamara
4ea0390faa cppcheck: noExplicitConstructor
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-11-02 10:16:38 +00:00
Noel Grandin
b5db48ada1 no need to use OUString constructor in call to createInstance
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01 15:25:43 +00:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30 08:59:59 +00:00
Noel Grandin
d95a27f944 com::sun::star->css in scaddins,sccomp,scripting
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4
Reviewed-on: https://gerrit.libreoffice.org/19629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-28 06:31:27 +00:00
Caolán McNamara
2f9bd9ac4d cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I5578dc3885945c013064cecf2ca86e7ca734368f
2015-10-25 15:41:02 +00:00
Caolán McNamara
d6a3c5786b coverity#1326446 Dereference null return value
Change-Id: I18b3e0cc30e05e9a53a0f7ae9997b9f190f192f4
2015-10-25 15:41:01 +00:00
Caolán McNamara
337661a989 coverity#1326446 Dereference null return value
Change-Id: Ief00b565147bd4a08c4fd6de9df71d9126dc1f75
2015-10-22 16:45:09 +01:00
Caolán McNamara
9740a474a4 coverity#1326429 Dereference null return value
Change-Id: Ib047f6cb255610422afb423006b58e0da7eacead
2015-10-22 16:45:09 +01:00
Caolán McNamara
86d275366a coverity#1326553 Dereference before null check
Change-Id: I1fe2e0477f136f31b854672878d0544d9492d51b
2015-10-20 21:18:35 +01:00
Caolán McNamara
f8ce21a346 coverity#1326552 Dereference before null check
Change-Id: I5a3fb6b5e9966a8e0c5dd0175e4f4f3292025a2c
2015-10-20 21:18:35 +01:00
Caolán McNamara
e9fc41292b Revert "coverity#1327168 see if stock SuppressWarnings is sufficient to"
that didn't work

This reverts commit 04a7df738a.

Change-Id: I5e4dfc28c03668eebb0fe8056beede7ef0b05ee5
2015-10-20 21:18:31 +01:00
Noel Grandin
a2fa0ded8a cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I98e5590f61434ed1b1081b5b592622f9bcf037ec
2015-10-16 12:50:49 +02:00
Caolán McNamara
04a7df738a coverity#1327168 see if stock SuppressWarnings is sufficient to
silence UrF: Unread field, some sources online suggest that it
might be the case

Change-Id: I2287da343e97bec93e0aaf7a82a408c18ab76d9b
Reviewed-on: https://gerrit.libreoffice.org/19396
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-15 15:59:27 +00:00
Caolán McNamara
585757d3fe coverity#1326240 Explicit null dereferenced
Change-Id: Ic84b5fbff0fbd7b8a750a7e40f2dffafe868b5d5
2015-10-15 14:26:06 +01:00
Caolán McNamara
f1e4e73dfc coverity#1326238 Explicit null dereferenced
Change-Id: Id02dcf1a1fac22eae0a2e01596521eefee9ecbf3
2015-10-15 14:26:06 +01:00
Caolán McNamara
52e8a80628 coverity#1326236 Explicit null dereferenced
Change-Id: Ic89c9b39f5f9c260581130da528bc0f514d4ef06
2015-10-15 14:26:05 +01:00
Caolán McNamara
5d5e14e97e coverity#1326899 HE: Equal objects must have equal hashcodes
and...

coverity#1326898 HE: Equal objects must have equal hashcodes
coverity#1326897 HE: Equal objects must have equal hashcodes
coverity#1326896 HE: Equal objects must have equal hashcodes
coverity#1326895 HE: Equal objects must have equal hashcodes

Change-Id: Ic9cb7542c1bf0608a97e5b4756b737cdf1bb4bd8
2015-10-15 09:12:36 +01:00
Noel Grandin
06907141b9 cid#1326116 Unchecked return value
Change-Id: If33ea9c4e4388cc1b7d15847f32dd2228b047363
2015-10-15 09:29:29 +02:00
Noel Grandin
a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Noel Grandin
3cc4b81b76 java:using "this" with a static field makes no sense
Change-Id: I79a38ff2ec50d3a3687cac7ed7688bbbcaf2208c
2015-10-14 16:07:50 +02:00
Caolán McNamara
d9bb701494 coverity#1326568 Unused value
Change-Id: Idf1efef484d3a89bd56ba9a6807d4191ef95cb41
2015-10-14 15:02:41 +01:00
Caolán McNamara
6946b688f6 coverity#1327113 UrF: Unread field
Change-Id: I4cc7faaf0ac74c4e1baa2e978d8dea9bc8d7b6d0
2015-10-14 15:02:41 +01:00
Caolán McNamara
d46134e55b coverity#1327178 UuF: Unused field
Change-Id: Ie9ed1f86a3a51d766987d631605dc561e9748f99
2015-10-14 15:02:41 +01:00
Noel Grandin
43cbaac5b9 cid#1326361 Data race condition
Change-Id: Ia61737232d816bb05f3aedbe76e7905262906a79
2015-10-14 12:30:57 +02:00
Noel Grandin
fb451a14c0 cid#1326674 DLS: Dead local store
Change-Id: I8168d3703022c9a1baed6e82c43a04ffa0ca52c0
2015-10-14 12:05:51 +02:00
Noel Grandin
ec0c4ce0a0 cid#1326345 Check of thread-shared field evades lock acquisition
Change-Id: I11fc66358c13c6bb1b6f109980384131b38ef18b
2015-10-14 09:55:16 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
Andrea Gelmini
a55c272845 Fix typos
Change-Id: Idd4b0f7b6c422abd6790185b5d48082b294bae64
Reviewed-on: https://gerrit.libreoffice.org/18968
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 07:06:16 +00:00
Andrea Gelmini
0e5318aa75 Script: better way to detect Windows
Change-Id: I0e99443f3715cde4414d14b2fa507ecab0995c6d
Reviewed-on: https://gerrit.libreoffice.org/18937
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30 06:56:42 +00:00
Caolán McNamara
3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Takeshi Abe
f3c7e69536 scripting: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I2a59d42efbb1aeef5078d0b0744b5a3c0559affa
Reviewed-on: https://gerrit.libreoffice.org/18123
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-09-03 17:53:31 +00:00
Stephan Bergmann
049a665bd8 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I4c29e8b2c86816114ea2566348901710f601fd92
2015-08-31 08:02:13 +02:00