mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
422,006 Commits 1 Branch 0 Tags
3d44b720f58366398e7f59c00dba6339712a670f
Commit Graph

67 Commits

Author SHA1 Message Date
Julien Nabet
932c9065ee Use for-range loops in mysqlc 
Change-Id: I3ff3fa5dca6b6b9060b0b38d875e1b7dec1f8245
Reviewed-on: https://gerrit.libreoffice.org/52127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-30 07:03:40 +02:00
Noel Grandin
1b67ad6ff8 remove connectivity OSubComponent 
push the logic that is still necessary down into the subclasses

Change-Id: I99424f0b3c654c5652991a4140b17ceb02224e50
Reviewed-on: https://gerrit.libreoffice.org/49087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-02 11:21:36 +01:00
Stephan Bergmann
5072e01d07 More loplugin:cstylecast: mysqlc 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I4bc61dbaf5d920e75269564cd92b19ae05046ca6
 2018-01-12 20:19:40 +01:00
Noel Grandin
7af521827e use rtl::Reference in mysqlc 
instead of manual ref-counting

Change-Id: I7b7c350613976463620a54757add6061cf383a4c
Reviewed-on: https://gerrit.libreoffice.org/43183
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-06 10:21:26 +02:00
Noel Grandin
3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin
4250b25c6a teach unnecessaryparen loplugin about identifiers 
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-10 09:57:24 +02:00
Noel Grandin
469076317d loplugin:unusedfields l10ntools..rsc 
Change-Id: I78785eeab436910c9e8733924a7c43fa998ba36f
Reviewed-on: https://gerrit.libreoffice.org/39491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-04 11:26:09 +02:00
Noel Grandin
cb37c5f0f3 loplugin:unusedfields in jvmfwk..mysqlc 
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08
Reviewed-on: https://gerrit.libreoffice.org/39099
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 08:59:20 +02:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Andrea Gelmini
5bea199bae Fix typos 
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b
Reviewed-on: https://gerrit.libreoffice.org/34803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-02 12:39:35 +00:00
Stephan Bergmann
b61214c91d Remove dynamic exception specifications from !LIBO_INTERNAL_ONLY 
...only odk/examples/ remains to be clean up

Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
 2017-01-27 10:40:41 +01:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox 
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:12:00 +00:00
Noel Grandin
a005fbeddc OSL_TRACE->SAL in framework..sal 
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9
Reviewed-on: https://gerrit.libreoffice.org/31903
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:10:04 +00:00
Noel Grandin
b1f8cf3782 loplugin:singlevalfields 
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76
Reviewed-on: https://gerrit.libreoffice.org/30476
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-02 13:06:37 +00:00
Stephan Bergmann
a6060e02f7 Fix typo relase_ChildImpl -> release_ChildImpl 
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
 2016-07-12 15:57:36 +02:00
Stephan Bergmann
227f6998d5 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Ie511eeb586e8c592bc255a09eff1bcf673a29ea9
 2016-04-20 17:25:45 +02:00
Noel Grandin
e18b08363a loplugin:unusedmethods 
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
 2015-12-21 10:20:31 +02:00
Noel Grandin
1f86864e97 loplugin:unusedfields various 
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
 2015-11-25 13:57:29 +02:00
Noel Grandin
773a07a94e fix mysqlc build 
after my commit 96c26b0d9d
"use initialiser for Sequence<OUString>"

the mysqlc module is compiled as external code, so it
cannot see the initialiser syntax constructor for Sequence

Change-Id: I072e6271ec33637e28dd8225724296e90967329d
 2015-11-16 08:34:54 +02:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Stephan Bergmann
1ddbbfdda8 loplugin:nullptr (automatic rewrite) 
Change-Id: Ie77375d781164232ea0cd94c3d2a5d027c49669e
 2015-11-10 10:31:32 +01:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Stephan Bergmann
e2462a3897 loplugin:simplifybool 
Change-Id: I2520ff8ca5f9c0dd68cc4c5cdc377d455c87898d
 2015-07-16 14:00:18 +02:00
Stephan Bergmann
948a3ece9a loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I18ea5378c165912e988d0c951aab3d83754cf6ca
 2015-06-08 16:26:34 +02:00
Stephan Bergmann
ecad097109 Remove dead code 
Change-Id: Id2b755c500c32392cdb5cc84ee901f0737347350
 2015-05-08 14:37:28 +02:00
Michael Meeks
af48ad2120 fix erroneous disposeOnce calls. 
Change-Id: I4ce39e6d6534d1481f7e6b759d61040606da839c
 2015-04-28 15:34:54 +01:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Stephan Bergmann
2339a5bd50 More loplugin:simplifybool 
Change-Id: Ic26c9e044b0e2225db8e218f39409338a69e7047
 2015-04-27 15:30:59 +02:00
Stephan Bergmann
39950c5b7c loplugin:simplifybool 
Change-Id: Icbd2ce16467c574243d223ae68e79ca043a2ca45
 2015-04-24 12:36:24 +02:00
Stephan Bergmann
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs. 
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
 2015-04-23 18:39:07 +02:00
Noel Grandin
d7a84ce840 vclwidget: only call dispose() once 
by using a new utility method in vcl::Window
This means that we don't have to make all our dispose
methods safe to call more than once.

Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
 2015-04-10 10:55:36 +01:00
Stephan Bergmann
d081dda43f loplugin:constantfunction 
Change-Id: I368de78b99369982cd17a8e7ac8c36b4e7e60b41
 2015-03-25 12:46:55 +01:00
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements 
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
 2015-02-23 09:26:58 +02:00
Stephan Bergmann
d5c86be04e No need for RTL_USING in addition to LIBO_INTERNAL_ONLY 
Change-Id: Iaa65658aed6bb4abb20a4d95dc9c6caf7c1c764b
 2014-12-19 14:28:13 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Vinicius Vendramini
5c8ea6d943 fdo#83991 - cleanup whitespace after folding comment removal. 
Change-Id: I31149484d626013ddcd52356be7d416b435cebcc
 2014-10-23 10:39:22 +01:00
Vinicius Vendramini
f73112e229 fdo#83991 - remove redundant function folding comments. 
Change-Id: I630aeedc31099e11d4bd0e91a05943e926efd61e
 2014-10-22 12:03:35 +01:00
Stephan Bergmann
f94fffaf52 mysqlc: std::auto_ptr -> std::unique_ptr 
Change-Id: I0eb5f9fab5955d1f5790d3f5d269e069aff1c201
 2014-09-30 12:28:53 +02:00
Stephan Bergmann
dbf99dfb98 mysqlc: sal_Bool -> bool 
Change-Id: Ie479e1671b03fbb958886d4c01ecff41b2ad1d23
 2014-07-02 08:42:58 +02:00
Noel Grandin
6b50e21473 deb#749592 mysql-connector doesn't work with remote connections 
and also
fdo#77584 mysql-connector doesn't work over SSH tunnel

Not sure exactly how this got broken, I suspect that the UI code
has started unconditionally passing down the properties, just filling
them with empty spaces for the unused ones.

Anyhow, this appears to fix the problem.

Change-Id: I7ac2a0d6bae610f47d2a28daa9beb3ef0e2dbb52
Reviewed-on: https://gerrit.libreoffice.org/9565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-30 08:24:31 -05:00
Noel Grandin
624a116d14 use OUString::startsWith() 
Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
 2014-05-29 09:01:40 +02:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin
794f09f195 simplify ternary conditions "xxx ? true : yyy" 
Look for code like:
   xxx ? true : yyy;
Which can be simplified to:
   xxx || yyy

Change-Id: Ib7ca86580bfd0cf04674328a3c0cf3747de4758d
 2014-05-06 07:45:25 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
396248a6bf Get rid of macros 
Change-Id: Ic43441201309c3b466ed3dc7a5e85d0d006c0e44
 2014-02-03 11:15:55 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Noel Grandin
ef90021abe convert OUString !compareToAscii to equalsAscii 
Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
 2013-11-11 12:58:12 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Fridrich Štrba
730df392f5 Do not try to dlopen a static internal libmariadb 
Change-Id: Ib624089418e22c050e951acc4c487572c7e0ea25
 2013-03-11 10:09:49 +01:00