Stephan Bergmann
40d6b81b9e
Replace map to sal_Bool with map to bool
...
(Though this looks like it wants to use a set instead of a map, anyway.)
Change-Id: I755581d3915dca902e7b96efea16d4d29cb0158a
2016-04-20 17:25:34 +02:00
Julien Nabet
2b60e64c18
Use const_iterator when possible (whole dbaccess)
...
Change-Id: I3d10a7914353b384fc7a2195a70398869f675211
Reviewed-on: https://gerrit.libreoffice.org/23570
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2016-03-28 18:39:16 +00:00
Noel Grandin
bf7690bc1b
convert EComposeRule to scoped enum
...
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
2016-02-25 13:50:25 +02:00
Noel Grandin
5805be0b34
boost::mem_fn->std::mem_fn in dbaccess
...
Change-Id: I9156e106d12b670e94bab899a4f67a35701ae5ac
2016-02-01 10:13:30 +02:00
Andrea Gelmini
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
Maxim Monastirsky
22328a224d
New saving behavior
...
Changes in this commit:
- AlwaysAllowSave config is gone. Saving is always permitted, unless in
a read only document. Also changed the behavior in dbaccess to match
sfx2.
- The toolbar save button is always enabled, to always give access to
the dropdown. That's the case even in a read only document, except
that it changes to DROPDOWNONLY, and the save as command icon+tooltip.
In table/query designers we still disable the button in read only state.
- When the document is modified, the toolbar button gets a special icon
to indicate that.
TODO:
- Icons for the document modified state are still missing. I added some
fake links to Tango's links.txt in order to test the new behavior.
These links shouldn't stay as-is in a production version!
Change-Id: I56c169bf48b78faaf53c2989ce8624f8297ffb6e
Reviewed-on: https://gerrit.libreoffice.org/20839
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com >
Tested-by: Maxim Monastirsky <momonasmon@gmail.com >
2015-12-23 09:38:25 +00:00
Noel Grandin
25aec383f9
use initialiser for Sequence<OUString>
...
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"
Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:18:55 +00:00
Stephan Bergmann
89c4edc13f
loplugin:nullptr (automatic rewrite)
...
Change-Id: I2bba104b1bff30910864e45b5b032533099742ff
2015-11-10 10:31:22 +01:00
Stephan Bergmann
add39c3cc1
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: I14bdbad2469d05eb25514d7ab995acb8c6ef7bd1
2015-11-06 09:35:25 +01:00
Caolán McNamara
ddc2809202
boost->std
...
Change-Id: Idfbcfa1e5ba7bff92e98693c33c4b33a6beda08f
2015-09-17 14:12:07 +01:00
Tor Lillqvist
730da2a1e8
WaE: not necessary to pass this argument, it defaults to the same value
...
[loplugin:defaultparams].
Change-Id: I962bcf4c3de625bb6843cb7aa9ca0f4d6ba5187e
2015-09-07 10:37:25 +03:00
Daniel Robertson
899c21ce5d
dbaccess: replace for_each with range-based for
...
Replace complex uses of ::std::for_each with a range-based for-loop.
Change-Id: I82331f16cc1994dd9ef36eb80d67b64171cecc74
Reviewed-on: https://gerrit.libreoffice.org/18355
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-07 07:18:33 +00:00
Takeshi Abe
7d8b03256e
dbaccess: simplify code by using std::any_of/std::none_of
...
Change-Id: I03ed512ba20206ed38428efe324f54f79abe1933
Reviewed-on: https://gerrit.libreoffice.org/15616
Tested-by: Jenkins <ci@libreoffice.org >
Tested-by: David Tardon <dtardon@redhat.com >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-05-06 14:41:26 +00:00
Michael Meeks
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
Stephan Bergmann
756a93250b
More loplugin:simplifybool
...
Change-Id: I23fc4ef513dff2d378f09a196f8e2d0db9da900d
2015-04-27 15:30:54 +02:00
Stephan Bergmann
2240118177
Improved loplugin:literaltoboolconversion looking into cond. exprs.
...
...automatic rewriter fixes
Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
Michael Meeks
f12488405c
dbaccess: convert new to ::Create.
...
Also convert svtools' WizardShell::createPage.
Change-Id: I09bd40ef4748aa2de7b49eeefc95be06b545ea05
2015-04-20 15:13:23 +01:00
Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Michael Meeks
8a65284fe3
Automated conversion of VclPtr construction to use Instance template.
...
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10 13:40:25 +01:00
Michael Meeks
5d133eb621
first half of non-scriptable, Instance constructor conversion.
...
Change-Id: If73bb41bfa805e22609748f25971724b4778edb3
2015-04-10 13:27:16 +01:00
Noel Grandin
61b224f392
vclwidget: fixup locally allocated vcl::Window objects
...
They need to be wrapped in ScopedVclPtr in order to be disposed properly.
Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
2015-04-10 12:37:44 +01:00
Noel Grandin
00f2787a4a
vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtr
...
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133
Conflicts:
sw/qa/tiledrendering/tiledrendering.cxx
2015-04-09 22:17:00 +01:00
Julien Nabet
119d19678a
Typo: form the table->from the table
...
Change-Id: I41f5ac20eff8d2ebd75ea13fff12154306cbacf4
2015-03-13 21:34:02 +01:00
Caolán McNamara
7e1eb03a39
callcatcher: remove some more recently discovered unused methods
...
Change-Id: Ib01e444b24ad9288970066a47f3fcf3dbee1fc49
2015-02-04 20:36:27 +00:00
Stephan Bergmann
17fe6b54cd
dbaccess: Use appropriate OUString functions on string constants
...
Change-Id: I1d63c9123ad985cb3424b0ac0ad30c12e39f8170
2014-12-18 14:12:24 +01:00
Michael Weghorn
141469eb83
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I8931ff46394923d672e08b3a5c9ab75bb6ffb0a9
Reviewed-on: https://gerrit.libreoffice.org/13385
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-12-09 03:20:51 +00:00
Thorsten Behrens
7d68c0f5ad
Slightly less verbose adaptation to boost-1.56.0
...
This fixes up 45dfbdca6a
Change-Id: I754fec5c94d51cbae69ad1155f57b0bb53788ba5
2014-12-05 16:17:24 +01:00
Noel Grandin
a28e7f7aa9
loplugin: cstylecast
...
Change-Id: Ie478d1fcfd3b64d7a2128887c216b5e0b4501ab9
2014-10-03 15:20:04 +02:00
Noel Grandin
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Stephan Bergmann
b396ae62f7
dbaccess: sal_Bool -> bool
...
Change-Id: Ifad71823e72be71cbd9f9f58a51f4553ff54e4d4
2014-09-12 16:15:27 +02:00
Jörg Sonnenberger
45dfbdca6a
Fix build with boost-1.56.0.
...
Change-Id: I61686bf61ff1e0561c385492c563e4495456ca47
Signed-off-by: Thomas Klausner <wiz@NetBSD.org >
2014-08-29 10:10:15 +01:00
Caolán McNamara
db83365b3b
convert TABLE_DESIGN_ALL_ROWS_DELETED with custom buttons to .ui
...
Change-Id: Id4b5573cd7e20f841e25ba17f17e98b78fb759cc
2014-08-25 16:45:26 +01:00
Caolán McNamara
9b12086313
convert TABLE_DESIGN_SAVEMODIFIED with custom buttons to .ui
...
Change-Id: Id0ea1a0a8de1cdd363ee462003406c5625b0e4af
2014-08-25 16:45:25 +01:00
Caolán McNamara
7e61e4f32a
QueryBox QUERY_SAVE_TABLE_EDIT_INDEXES -> MessageDialog + string
...
Change-Id: I36e6d376936caa847e68a43f64c8fe892afba1ca
2014-08-21 15:02:27 +01:00
Caolán McNamara
116f362ef2
coverity#1213514 Uncaught exception
...
Change-Id: I475b8c9bdcea120ac7ba24862000a16d9f4127c0
2014-05-27 21:08:35 +01:00
Caolán McNamara
a97cd4dd3b
coverity#1215312 Uncaught exception
...
Change-Id: I844561cc6f858b6aed55caaf0d92529486cb486e
2014-05-23 08:54:37 +01:00
Noel Grandin
794f09f195
simplify ternary conditions "xxx ? true : yyy"
...
Look for code like:
xxx ? true : yyy;
Which can be simplified to:
xxx || yyy
Change-Id: Ib7ca86580bfd0cf04674328a3c0cf3747de4758d
2014-05-06 07:45:25 +02:00
Noel Grandin
fee4efcb54
dbaccess: sal_Bool->bool
...
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
2014-04-17 11:17:21 +02:00
Stephan Bergmann
ae59446aab
Clean up function declarations and some unused functions
...
Change-Id: Ie4f6197e42db298b4a3dcb6befdbd72dff6ea2b7
2014-04-13 22:40:55 +02:00
Noel Grandin
8d6a99f67e
dbaccess: sal_Bool->bool
...
Change-Id: Ida8ee14bb6350fad815d741ca7a2b7db04a8ed11
2014-04-03 09:17:47 +02:00
Stephan Bergmann
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Stephan Bergmann
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
Alexander Wilms
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
Arnaud Versini
5b2ba8ed5d
DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Conflicts:
dbaccess/source/ui/dlg/tablespage.cxx
Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-21 16:20:10 +00:00
Stephan Bergmann
854da46a4b
This shall probably use the value of getMaxColumnsInIndex()
...
Change-Id: I1ae85e416440768ab40c817506d5b106289c4d72
2014-01-14 21:28:06 +01:00
Stephan Bergmann
ecc060715a
-Werror,-Wunused-member-function
...
Change-Id: If7618661da2b6c919ec05abace03723cb961c741
2013-11-14 10:15:04 +01:00
Noel Grandin
3ef88d370e
remove unnecessary use of OUString constructor in DBACCESS module
...
Change-Id: I831a6506211be30c5b743c20724904c903c5b3c0
2013-11-11 11:21:24 +02:00
Caolán McNamara
45e366eadb
drop unnecessary tools/string includes
...
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
Noel Grandin
b47e4dbc08
convert more of dbaccess from String to OUString
...
seemed to have missed this the first time around
Change-Id: I8b7b78c95c576b178e3e181c7589da81e5189ee3
2013-10-01 10:08:44 +02:00
Noel Grandin
d11ed5a57e
convert dbaccess module from String to OUString
...
Change-Id: I110c925f8d955dfd841cdd1092c13df4d8205393
2013-10-01 10:08:43 +02:00