Commit Graph

189 Commits

Author SHA1 Message Date
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
6a38eace8c Remove visual noise from basic
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:09:17 +00:00
Norbert Thiebaud
295bc8703f basic: remove use of sal_uIntptr in favor of more appropriate type
Change-Id: Ie878f43c7245838519fe7477b039827b079dde63
Reviewed-on: https://gerrit.libreoffice.org/8214
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-25 00:26:43 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Noel Grandin
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
Caolán McNamara
fcf23e8a44 coverity#706117 Allocation too small for type
Change-Id: I1bb2bd26e533cf5b7de5225f0bcf323446e69f63
2014-01-24 15:22:55 +00:00
Stephan Bergmann
1b33a38e32 Whatever those "true" arguments to SotStorage ctor may once have meant
...is lost to history, but they are effectively equivalent to pssing default
SorageMode nStorageMode = 0 today, as the only thing that is done with that
nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx)
is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED
(0x44).

Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
2014-01-17 18:45:13 +01:00
Tor Lillqvist
dde119c8f2 basic/global.hxx is private to basic
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
2013-12-11 10:36:58 +02:00
Caolán McNamara
5d61c4f8be CID#738563 uninitialized member
Change-Id: I5413099beb3b30f92b58f973fa4bb03f29e7f5c3
2013-10-07 09:16:24 +01:00
Takeshi Abe
ea1e3b77d4 sal_Bool to bool
Change-Id: I16ddbcf100e21d6c05fccbe24faca2932a605902
2013-10-02 10:00:44 +09:00
Noel Grandin
41dec09ed3 convert BASIC from String to OUString
Change-Id: I4b046e4c460305acad29862341092af948639215
2013-09-17 09:05:52 +02:00
Norbert Thiebaud
6a08067902 OUString convertion for unotools
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-02 07:31:30 +00:00
Noel Grandin
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
Thomas Arnhold
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
Takeshi Abe
1e50f78927 sal_Bool to bool
Change-Id: Ibc63340b3ae431c7cdac78893dbdd1989ebe5ff9
2013-03-25 10:54:06 +09:00
Thomas Arnhold
59b5ff7574 basic: translation of all debug messages
runtime.cxx: Added some output instead of nothing.

Change-Id: Ia25ae4b5fe8661a8a3ac317bc0562e1339640cd8
2013-03-11 21:36:43 +01:00
Thomas Arnhold
a2454a42ad fdo#43460: use isEmpty()
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-09 20:32:39 +01:00
Thomas Arnhold
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
Jean-Noël Rouvignac
63bcb139b9 Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21 15:04:17 +00:00
Luboš Luňák
9c06700874 fix build
Change-Id: I2588b69280abbc510ee2fdc9845df56616db8b95
2013-01-03 19:06:15 +01:00
Marcos Paulo de Souza
695f4a18e6 fdo#57950: Fix some chained appends in basic
Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1515
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-03 17:07:41 +00:00
Marcos Paulo de Souza
c40cd8a4f2 Remove all occurences of RTL_* and ::rtl prefix from basic
This is a big commit, so thanks for your time reviewing this :)

Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-03 10:07:39 +01:00
Noel Grandin
bb121c864c fdo#46808, Convert frame::Desktop to new style service.
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-21 10:57:09 +02:00
Michael Stahl
af452fda33 fix more warning C4804 unsafe use of type bool
... from commit bbf1bcd9ad

Change-Id: Ic8e52f6848e09a274133f2d8fd1c4044cae4b039
2012-11-08 18:54:01 +01:00
Norbert Thiebaud
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
Julien Nabet
99ddd57693 Fix .Len -> getLength
Change-Id: Ibe3e97a6fa59098b9234e4aae04118abc4e37eea
2012-11-04 11:12:48 +01:00
Norbert Thiebaud
d92814f462 basic: preliminary cosmetic clean-up
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03 20:24:28 -05:00
Norbert Thiebaud
bbf1bcd9ad basic: String -> OUString in basicmanager
Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5
2012-11-03 20:24:26 -05:00
Stephan Bergmann
ee582e991a Missing #include
Change-Id: I63e68bd37b46f339d09d97a6bf6edfeaa6a7df1d
2012-10-29 23:07:24 +01:00
Arnaud Versini
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
Michael Meeks
f88c4a5bc1 dung out namespacing clutter.
Change-Id: I14794ca0cd2a8ea84ba41e1dc689503647696e3a
2012-09-17 16:30:45 +01:00
Takeshi Abe
00b7328732 sal_Bool to bool
Change-Id: Ie8a128db35bebcdcee5eda984a7875339418d9bb
2012-09-07 09:57:39 +09:00
Stephan Bergmann
24391f6057 Some clean up of previous commit
Change-Id: I14097acf09e9663af7d7abc5f0c9d481880ecc51
2012-09-05 14:56:19 +02:00
Noel Grandin
1c7a54e3a1 fdo#46808, Adapt frame::ModuleManager UNO service to new style
Create a merged XModuleManager2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Explicitly document the XNameReplace interface in the IDL, which
is already implemented by the service, since there is code currently using it.

Change-Id: Ib46349174b1ce495c240031e93c9427fc33d9853
2012-09-05 14:56:19 +02:00
Takeshi Abe
9e2f8b9ec2 Fix typo ImpLoadLibary
Change-Id: I773678437aae6577f22078e97bcac1377c4307d8
Reviewed-on: https://gerrit.libreoffice.org/495
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-08-28 19:53:36 +00:00
Takeshi Abe
71c1de8f01 Remove unused member variable
Its reference through IsFoundInPath() was dropped at 4c3f33d8d5

Change-Id: I764808d8a59089a05eccedd297a61aa6e76b01e0
2012-08-28 00:20:47 +09:00
Takeshi Abe
6ce769a1ad Remove useless member variable
Its usage was died at ac25ae2544

Change-Id: Ic98a0c36ceb02259b4f3b890f5ea701e56adbb68
2012-08-28 00:20:47 +09:00
Takeshi Abe
0d5d4bacb2 Remove unused member variable
its usefulness was gone at ac25ae2544

Change-Id: I606cd4adb6dc92cc6d981e1da7ce3ecf2160c28e
2012-08-17 09:49:44 +09:00
Michael Meeks
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
Caolán McNamara
104261010a some UniString->rtl::OUString
Change-Id: Ie69b30094da25df23a36baca2c7723d6a41f48c3
2012-07-09 12:16:56 +01:00
Caolán McNamara
bccf34c19a ditch String::CreateFromAscii
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
2012-07-03 21:24:35 +01:00
Thomas Arnhold
57154616f0 Remove UNO includes comments
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
2012-06-29 09:25:09 +02:00
Caolán McNamara
ba23ece286 probably the last uses of the one argument String::CreateFromAscii variant
Change-Id: I36aab317da2f69f12aaefc24895ad9eaa6b69a7c
2012-06-28 13:53:36 +01:00
Caolán McNamara
9bf2d51927 callcatcher: chainsaw out some unnecessary code
Change-Id: I88de7a942fbc9e0c51a3261236f5203f037d2392
2012-06-15 15:41:13 +01:00
Tor Lillqvist
fd58025dc7 Fix eleven year old typo
No idea if it has actually caused any uninteded behaviour, or if this
fix now then causes something to break.
2012-04-24 12:22:10 +03:00
Takeshi Abe
a9bad6b8f9 made the search straightforward 2012-04-13 02:18:05 +09:00
Caolán McNamara
3f82d94bdc String::CreateFromInt32->rtl::OUString::valueOf 2012-04-10 12:49:48 +01:00
Szabolcs Dezsi
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
Elton Chung
99ff0ab0b2 Remove unused code from basic 2012-03-05 18:54:28 +02:00
Tor Lillqvist
c91f279e7e Revert "Build libsb with a few dummy classes also for --disable-scripting"
Nah, these dummy classes would turn out quite complex anyway. Better
to just use ifdefs elsewhere, the number required is not that large.

This reverts commit 6d33801b44.
2012-03-05 02:05:24 +02:00