Commit Graph

178 Commits

Author SHA1 Message Date
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
Caolán McNamara
75cb13c406 coverity#738618 Uninitialized scalar field
Change-Id: Ib54d8f080a8590a3deb75ec26383ef3f44636375
2014-02-21 12:40:29 +00:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Stephan Bergmann
9cc60839f3 bool improvements
Change-Id: I294b930214ce82033402afecf2b3eb2d04299505
2014-01-28 20:26:29 +01:00
Arnaud Versini
5b2ba8ed5d DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Conflicts:
	dbaccess/source/ui/dlg/tablespage.cxx

Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 16:20:10 +00:00
Caolán McNamara
48ed1d39a0 make dbaccess xub_StrLen free
Change-Id: I2c91c23f3dabacdb4ee65c18dc73f096041b74a9
2014-01-15 15:36:23 +00:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Stephan Bergmann
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
Noel Grandin
3ef88d370e remove unnecessary use of OUString constructor in DBACCESS module
Change-Id: I831a6506211be30c5b743c20724904c903c5b3c0
2013-11-11 11:21:24 +02:00
Noel Grandin
296329a926 convert xub_StrLen to sal_Int32
convert for loops using xub_StrLen to use sal_Int32

Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
2013-11-06 08:51:22 +02:00
Noel Grandin
3d65dfa3c9 convert xub_StrLen to sal_Int32
Converts code that calls comphelper::string::getTokenCount() to
use sal_Int32 to store the return value.

Change-Id: I439605a39d29b1309649e30f3ff40dfa412efcde
2013-11-05 13:18:14 +02:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
Noel Grandin
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
Caolán McNamara
44fa08ed89 CID#1103679 calm coverity re invalid iterators
Change-Id: Iad07aa59c6016752ec9467945d737380d214c3c0
2013-10-11 08:51:26 +01:00
Noel Grandin
b47e4dbc08 convert more of dbaccess from String to OUString
seemed to have missed this the first time around

Change-Id: I8b7b78c95c576b178e3e181c7589da81e5189ee3
2013-10-01 10:08:44 +02:00
Caolán McNamara
98de5b40c8 Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-25 19:24:23 +02:00
Jelle van der Waa
2ec606730b fdo#62475 removed pointless comments
Conflicts:
	dbaccess/source/filter/xml/xmlfilter.cxx
	dbaccess/source/ui/dlg/ConnectionPage.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/odbcconfig.cxx
	dbaccess/source/ui/querydesign/querycontroller.cxx

Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-27 16:11:09 +00:00
Takeshi Abe
e2e15148fc Mark as const/static
Change-Id: I54a7daee7345e7c0c5c3f866d5c365722b567eff
2013-08-04 00:54:12 +09:00
Caolán McNamara
cf6a74af53 XubString->OUString
Change-Id: I1049249741f445ad7bd9c070f99812c4404597c9
2013-07-11 14:31:44 +01:00
Lionel Elie Mamane
1bc4a49d9b QueryDesign: in criteria, remove column_ref when table *and* column name match
As opposed to only the column name

Change-Id: I261d13f23214f950daa55a5b63cd486e59a0e127
2013-04-26 16:49:48 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Lionel Elie Mamane
f01c378870 continue String->OUString conversion
Change-Id: I44b816d6a270e8877e0db1408df4da3434932800
2013-04-04 16:34:49 +02:00
Lionel Elie Mamane
e32fd06507 more efficent & readable
Change-Id: If24a2a8488f1b1142b12540e4b8b00eb26bd7873
2013-04-04 15:37:51 +02:00
Lionel Elie Mamane
e60eca1cfc replace only single wildcard by table.*
not any string beginning with "*"

Change-Id: I6afe4db0ae69632990eafb288f715ae9cf7ad837
2013-04-04 15:37:31 +02:00
Ricardo Montania
7ee37c3ac6 String::AppendAscii cleanup in dbaccess
Change-Id: I6a6d695c9e4b850bc19a3a80c2d8343147724df6
Reviewed-on: https://gerrit.libreoffice.org/3068
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-28 16:46:15 +00:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
Michael Stahl
38d3e115c1 vcl: make Region ctors explicit to prevent overloading desasters
Change-Id: Id36d125b4940418833bec31a4710d6cd545629e0
2013-03-13 22:29:46 +01:00
Luc Castermans
21bbd59a70 ersetzen => replace in stead of translate
Change-Id: I8d355d58c3720201554c68be0c82245383eec1ed
2013-03-04 11:04:07 +00:00
Luc Castermans
a61881fc00 translated German comments
Change-Id: I6d9b646d9d70dcbf97f7faacc8b15578a597b2a1
2013-03-04 11:02:03 +00:00
Thomas Arnhold
405caad685 loplugin: unused variables
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25 03:14:00 +01:00
Jean-Noël Rouvignac
63b0ce97ba fdo#38838 searched, replaced and removed String::CreateFromInt32().
I ran the following code replace:
    s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/

And finally removed String::CreateFromInt32().

Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5
Reviewed-on: https://gerrit.libreoffice.org/2279
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-24 12:59:02 +00:00
Chr. Rossmanith
3270fc628b use OUString(Buffer) in class Edit
replaced Len() with isEmpty() where appropriate

Change-Id: I5a5847d6055f376fd5f86079aa1736541d790fff
Reviewed-on: https://gerrit.libreoffice.org/1892
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2013-02-04 18:51:15 +00:00
Lionel Elie Mamane
d931b994a4 show errors as errors, not warning
Change-Id: I32e514fbfbd323b688b25b9e2165d0c76e3c4db5
2013-01-23 16:32:53 +01:00
Lionel Elie Mamane
f1bde8cb0e fix handling of subqueries in query design
- don't remove parentheses around subqueries
   (without the parentheses, it is not valid SQL)
   * when saving a Field (name value) typed by the user interactively
   * when parsing SQL and constructing the initial Query Design view

 - automatically add the necessary parentheses
   when a SELECT statement is entered as column name

Also:

In code saving a Field (name value) typed by the user interactively,
factorise some common code

Assorted minor fixes (typos in comments, etc)

Change-Id: I3843258323c903cba23238b0730ec4eb5875f792
2013-01-23 16:32:53 +01:00
Caolán McNamara
830f44b1ca we only ever want the preferred window size from GetOptimalSize
so remove the MAX and MIN options and simplify the whole lot

Change-Id: Iaaf350c37e01f7fce434af760bcddb9b7d7135ea
2013-01-14 16:04:17 +00:00
Eike Rathke
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
Kohei Yoshida
43cd14d317 Fix the Windows build breakage by reorganizing svtools headers.
Also removed a fair amount of implicit inline methods to promote use
of more forward declaration.

Change-Id: I5ad21f0d7abc85281708b7e87f1036b02a053627
2012-11-16 16:18:37 -05:00
Caolán McNamara
104261010a some UniString->rtl::OUString
Change-Id: Ie69b30094da25df23a36baca2c7723d6a41f48c3
2012-07-09 12:16:56 +01:00
Caolán McNamara
bccf34c19a ditch String::CreateFromAscii
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
2012-07-03 21:24:35 +01:00
Thomas Arnhold
47009fbf51 Remove unused dbexch.hrc
The only part where one definition was used was commented out.

All other definitions in the hrc file were unused.

Change-Id: I257e61b96271685e9321211846a0021059924abe
2012-06-21 11:54:18 +02:00
Michael Meeks
577cf8ff67 re-base on ALv2 code. 2012-06-14 17:41:07 +01:00
Caolán McNamara
8f5629fd5a remove EraseLeadingChars and EraseTrailingChars
Change-Id: Ib9797fe97cd008cc6508ce8cec47dc5373416892
2012-06-11 14:46:46 +01:00
Michael Meeks
b1ca0f2472 targetted SAL_N_ELEMENTS reversion.
Change-Id: I58636bc87bc17ff2b35621ad554bd05f5c1dab20
2012-05-31 13:09:03 +01:00
Michael Meeks
a0bbb2a1af targetted SAL_N_ELEMENTS reversion.
Change-Id: I181c5b5dd24836ff0398aa5ed03915c2c7c55183
2012-05-31 13:09:03 +01:00
Takeshi Abe
5d9b072cef removed duplicate includes in dbaccess 2012-03-30 00:42:35 +09:00
Lionel Elie Mamane
470feb03f1 fdo#47370 properly duplicate (invisible) out-of-order sort columns
Keep track of position of previous sorting column and use it to decide whether to duplicate invisible new sort column
2012-03-20 11:07:13 +01:00
Stephan Bergmann
bd205223ec New IMPL_LINK_NOARG to work around SAL_UNUSED_PARAMETER problem
...see ebe26f72e9 "WaE: 'unused' attribute ignored when parsing type"
for the problem.
2012-03-01 18:00:32 +01:00
Lionel Elie Mamane
53ca46cdff translate german comments 2012-02-09 18:47:32 +01:00
Caolán McNamara
bacfd2dc4c add a comphelper::string::getTokenCount
suitable for conversion from [Byte]String::GetTokenCount
converted low-hanging variants to rtl::O[UString]::getToken loops
added unit test
2012-01-05 09:18:19 +00:00