Commit Graph

110 Commits

Author SHA1 Message Date
Alexander Wilms
bc1b0fca47 Remove visual noise from reportbuilder
Change-Id: I4063ea1ea95ddd1a3c220ca0da89cdcd78f62410
Reviewed-on: https://gerrit.libreoffice.org/8294
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:17:11 -06:00
Julien Nabet
f1a73892b3 Typo: apropriate -> appropriate
Change-Id: I05e23039dc3ae0b6595c87fe550f4228ad93d5d6
2014-02-25 22:04:17 +01:00
Julien Nabet
9bbb7ca9f7 Typo: formating -> formatting
Change-Id: If4aba89909a3ef049a756182c37d8a5d6812ae70
2014-02-06 22:41:48 +01:00
Lionel Elie Mamane
b0e3c6b8fa typo in comment
Change-Id: I900a8956fd9eae330bf12829bc94c8b18b1c6513
2014-02-05 07:43:04 +01:00
Lionel Elie Mamane
7ce47d69b3 fdo#69873 FixedText (label) is implemented as no value
And the actual label is put as *body* of the cell.
I'd prefer that the value be put as string-value attribute of the cell,
but since in the report definition the label is as body
(as opposed to as an attribute), it is easier that way.

We could move (actually *copy* for backwards compatibility reasons)
the label to an attribute of the rpt:fixed-content element
(similar to the rpt:formula attribute of rpt:formatted-text)
but it is not obvious this is completely desirable:
Indeed it would keep us from putting anything more complex than a string there
(which we don't do anyway now, but thinking of future extensibility here);
I'll leave the exploration of that idea to the indefinite future.

Change-Id: Ia0f7460718ee35a971117e2f79c0997e17e1095e
2014-02-05 07:43:03 +01:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Michael Stahl
070ca1e280 jfreereport: stop pointlessly renaming the jar files
Change-Id: Ia2c5ce1176496e98643e2cefc65d4c6d0cf9c781
2013-10-25 23:31:30 +02:00
Lionel Elie Mamane
0089d3ae94 fdo#62994 reportbuilder survive empty formula
Change-Id: I1da053871d107730ad9a135deb48313d8a877d89
2013-10-08 20:42:37 +02:00
Andras Timar
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
Lionel Elie Mamane
6a1ad344a8 fdo#69147 report sort columns are RESULT columns
as opposed to table columns or other expressions.
So it makes no sense to slap a table name on them.
Notwithstanding HSQLDB 1.8 (our embedded database) bugs.

Change-Id: Ib5d0b1479e29b9efeafca9ebc2eb7ed8e0f42b79
2013-09-13 12:08:02 +02:00
Lionel Elie Mamane
fc92c1abeb fdo#67930 don't use variables for formattedtext in header/footer
I don't know why it was going through variables.
Instead, put the value where it is supposed to,
like for formattedtext in detail section.
Try it, and if something breaks, we can revert.

This also works around fdo#67930

Change-Id: Ia7f08afd8a037d3ac75676c5221ddb36aa791354
2013-08-12 18:43:37 +02:00
Lionel Elie Mamane
c4ed358201 a date is a date, not a float
Change-Id: Id9beab6a9cd9b7fa15ce0699b6eeb8a1e32448fe
2013-07-23 19:25:42 +02:00
Lionel Elie Mamane
cab9b82fb3 fdo#67186 switch reporbuilder to null date == 1899-12-30
This brings it in line with the default for other LibreOffice
components (e.g. Calc), or with the only supported value (e.g. Writer
tables), respectively.

Configure Pentaho jfreereport to also take null date == 1899-12-30

This combined allows reportbuilder to make absolutely no fiddly
conversion itself, leaving them to jfreereport and Writer table
cell format.

Also:

 - Make absolutely no conversion itself, also e.g. for booleans.

 - ODF compliance: make the value-type match the set foo-value attribute.

 - Use value-type="void" instead of empty value-type="string"

Change-Id: I67990232dbc9e86ac3fa37cd0c20edecb87cf8ee
2013-07-23 19:25:41 +02:00
Noel Grandin
95e1ecbf89 remove some unnecessary casts
Change-Id: I63b0ce257b40caa53aef337e953ce8d07862d292
2013-05-06 11:45:48 +02:00
Noel Grandin
64e85a4cc8 Java cleanup, remove unused imports
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
2013-04-26 08:29:38 +02:00
Lionel Elie Mamane
3a4534be65 fdo#330191 a NULL value of float type is not NaN
but it is *still* NULL.

This was initially done to "fix" i#108092,
but i#112652 comment 13 suggests this may have been fixed more cleanly.

Change-Id: I2b76af2182715bc489cb89dd45d6b77d5038b506
2013-04-24 19:27:24 +02:00
Noel Grandin
8d87758d65 Java cleanup, remove the rest of the unnecessary casts
Change-Id: Ia61d250f6b3711abc29569c5ece38a6f87e38daa
Reviewed-on: https://gerrit.libreoffice.org/3432
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-19 07:52:08 +00:00
Lionel Elie Mamane
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
Thomas Arnhold
c32b6be06b fdo#60724 correct spelling
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
Lionel Elie Mamane
b8537fba16 fdo#36858
1) No valueType (Format/Number/General) is like float valueType (Format/Number/any other)
2) We use 1/1/1900 as startdate for number-from-date, stick to it more consistently

Change-Id: Ib1008d1c30be602d8173457738c915087ed17391
2013-04-12 19:05:35 +02:00
Stephan Bergmann
87cb8d784c java.lang.String.isEmpty is only since 1.6
Change-Id: I43fd404e96192af3c0a8734c4547cee3b906c935
2013-04-11 16:11:20 +02:00
Lionel Elie Mamane
eb39389da8 reportbuilder: do not use empty tablename
Change-Id: I03ed5e810468ee206820a250c740b80c0ceda432
2013-04-10 18:16:00 +02:00
David Ostrovsky
90a326c702 fdo#61950 move report builder from bundled extensions to plain code
For test sample report from fdo#61726 can be used.

Change-Id: Iacf8ddc4cf8ad0a408d72e18ecb7237476afeffe
Reviewed-on: https://gerrit.libreoffice.org/2718
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-03-18 15:30:44 +00:00
Lionel Elie Mamane
4178806bb0 reportbuilder: make "Group on" not-"Each Value" actually work
Change-Id: Id5d73f9aac48ebfb6987e5bf0df37e62f1817bdc
2013-03-12 18:16:45 +01:00
David Ostrovsky
6f28efc2a8 fdo#61726: rename report-builder package to org.libreoffice.report
To prevent future clashes with uno name space rename the
com.sun.star.report package to org.libreoffice.report.

Bump the version to 1.2.4.

Change-Id: Ia06cb7ad8c1528c1d5b5eeb70f1e4b2aa854b70f
Reviewed-on: https://gerrit.libreoffice.org/2578
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-03-11 08:56:40 +00:00
David Ostrovsky
3c14d6545b remove ReportEngine2 interface
Typical anti pattern in java is the overuse of interfaces.
You only need an interface in java, if you have multiple
different implementations. Otherwise you don't.

Change-Id: If8b62adc56385f9b839dab36e8cbbf9f715e6017
2013-03-06 21:22:46 +01:00
David Ostrovsky
cde76a3205 fdo#61726 java class collision with new idl
Change-Id: I90ea912fd0cc54068843d21cb2585e78e70a3d71
2013-03-06 01:16:11 +01:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
Lionel Elie Mamane
55c53570e0 janitorial: typo in comment
Change-Id: Ia3d8612e3774ee62b6d885cc9ab801361642c3a3
2013-02-19 12:35:03 +01:00
Lionel Elie Mamane
9f015df355 add comment
Change-Id: Id14dd289f8803378838725fbe08e327c9b1d233d
2013-02-19 12:35:03 +01:00
Lionel Elie Mamane
532421d208 fdo#52948 fix print-repeated-values=no with formatted values
Factorise the "should this element be printed" decision into an
utility function, which is used by
1) AbstractReportElementLayoutController
   (in charge of non-formatted values: string, image, OLE object, ...)
   which already obeyed PrintRepeatedValues.
2) TableCellLayoutController
   (in charge of formatted values: dates, numbers, ...)
   which blissfully ignored PrintRepeatedValues,
   but obeyed the display condition.

Rename the inconsistently named
 PrintWhenGroupChange
 PrintWhenGroupChanges
 print-only-when-group-change
 print-when-group-change
to
 PrintWhenGroupChange / print-when-group-change

Change the meaning of "PrintWhenGroupChange" to "override
PrintRepeatedValues in first occurrence in group". Since this feature
never worked under the old semantics, no loss of feature. Since we
change the XML attribute name, no ascending compatibility problem: it
will be reset to its default value.

Pursuant to the new meaning of PrintWhenGroupChange, change its
default to *true*, which is the sane default.

Change-Id: Idbe8e90565a354f70db222d047b3d51eeddbbb9f
2013-02-19 12:35:02 +01:00
José Guilherme Vanz
1994d859e3 fdo#51304 Remove @author annotation
This commit removes @author annotations, some templates comments. It has some
cleanup.

Change-Id: I995ba7b06d661fcec17f26c368d9449c0bf5ab45
Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1146
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-24 00:02:15 +00:00
José Guilherme Vanz
4395680011 fdo#51304: Remove @author annotation
This commit removes some @author annotations and some cleanup.

Change-Id: Iaf2c4465825dc73af6c1d7377ae847262721c22b
Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1122
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-20 05:15:45 +00:00
Jose Guilherme Vanz
f6739073ed Remove commented code and empty methods
This patch removes commented code and some empty private methods

Change-Id: I4a79e521399a07873030f021a97c01cf8d2e81d7
Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/844
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2012-10-10 06:56:57 +00:00
Noel Grandin
a5ff5aad59 Java5 update, Convert ArrayList and Vector code to use generics
Change-Id: I6cf6fa8e55005ffdc1d173aeee1e374efbb214fd
2012-09-10 23:43:37 +02:00
Noel Grandin
bf4352084b Java cleanup, remove unnecessary imports
Change-Id: Iacfcb2e16cb0e3c25a4cd0678a374fe5111284f7
2012-09-06 17:13:58 +02:00
Stephan Bergmann
86a60b3655 fdo#38791: Do not use java.awt, causes problems on Mac OS X
On Mac OS X, it apparently suffices to execute "new java.awt.Dimension()" to run
into "Apple AWT Java VM was loaded on first thread -- can't start AWT" (see
<http://developer.apple.com/library/mac/#technotes/tn2005/tn2147.html> "JNI
Development on Mac OS X - Thread-Safe JNI Programming - Calling AWT/Swing From
AppKit").

The solution here is simple, in that uses of java.awt.Dimension can be replaced
with com.sun.star.awt.Size without loss of functionality.  However, there are
still occurrences of java.awt.Image and java.awt.Toolkit lurking
(reportbuilder/java/com/sun/star/report/SOImageService.java,
reportbuilder/java/com/sun/star/report/pentaho/output/ImageProducer.java,
reportbuilder/java/com/sun/star/report/pentaho/output/OfficeDocumentReportTarget.java)
for which it might be sheer luck that they do not seem to cause trouble yet.

Change-Id: I33e9f74c50ebddc11bd1d9a48c55dc8f8700345d
2012-08-23 14:34:56 +02:00
Michael Meeks
cf342fe928 re-base on ALv2 code. Includes:
reportbuilder, license file not needed.
    Patch contributed by Armin Le Grand
    http://svn.apache.org/viewvc?view=revision&revision=1305814
    Adapting extras/ to our wordbook setup.
2012-07-18 15:00:25 +01:00
Noel Grandin
f4cca7347f Convert Java code in reportbuilder to use Java5 generics
Change-Id: Ia8a0206c6c81f2a4212dc92b80a9d6965ad8bd63
2012-06-29 22:02:58 +02:00
Michael Meeks
2005a34318 re-base on ALv2 code. 2012-06-29 15:51:49 +01:00
Michael Meeks
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
Michael Meeks
b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
David Tardon
755eaff58d remove unused source 2012-05-29 07:25:01 +02:00
David Tardon
6bf04a4328 gbuildize reportbuilder 2012-05-29 07:25:00 +02:00
Michael Stahl
e476a7632c .java files don't need executable bits 2012-03-23 21:58:12 +01:00
Michael T. Whiteley
dcfd4beb21 childs -> children 2011-12-08 11:32:41 +02:00
mst
e2ba981485 fs34c: check if description can be read and return ccorrect name for shapetype
* found as LGPLv3-only fix at svn rev 1172124 (http://svn.apache.org/viewvc?view=revision&revision=1172124)
2011-11-29 17:57:30 +01:00
Stephan Bergmann
2be37f241f Clean up after component passivation. 2011-11-22 21:56:07 +01:00
Caolán McNamara
04c5a36ab8 avoid using com.sun.org apis 2011-10-25 13:50:33 +01:00
Jan Holesovsky
57826b92af Fix reportbuilder build with MinGW. 2011-09-22 19:50:24 +02:00