mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,366 Commits 1 Branch 0 Tags
4df2bc90cc7bef84a826b8d261c08e71c3e1887d
Commit Graph

112 Commits

Author SHA1 Message Date
Noel Grandin
83721f4365 makeAny->Any in basctl..chart2 
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61
Reviewed-on: https://gerrit.libreoffice.org/33867
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:50:50 +00:00
Caolán McNamara
74b92741b8 b*, c*: load BitmapEx resources instead of Image ones 
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
 2017-01-16 11:45:35 +00:00
bansan85
a631e0fe94 Add move column right and move row up in DataTable 
Change-Id: Ib224a99636dfbb4451aa26263573af2f3d31b84a
Reviewed-on: https://gerrit.libreoffice.org/32265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-12-21 08:25:12 +00:00
Noel Grandin
22d0d2455f loplugin:expandablemethods in chart2 
Change-Id: Ie6650628683ec7c67359351eec0e09033f2b50cb
Reviewed-on: https://gerrit.libreoffice.org/30750
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-11 06:59:15 +00:00
Jacek Fraczek
f004aa9951 tdf#89307: Removed SvRef::operator T*() 
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-10 08:48:30 +00:00
Noel Grandin
954f752cf1 convert MapUnit to scoped enum 
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-05 06:51:20 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros 
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
 2016-10-05 07:56:12 +02:00
Noel Grandin
f22fa99460 loplugin:countusersofdefaultparams in canvas,chart2 
Change-Id: Id66a706171b73affeb508812744028d9f30133af
Reviewed-on: https://gerrit.libreoffice.org/27868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-05 06:26:59 +00:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly 
since...

commit ba81e5c6bd
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
 2016-07-26 11:26:52 +01:00
Jochen Nitschke
194d4a02b9 chart2: remove unused ContainerHelper.hxx includes 
remove using namespace :💹:ContainerHelper;
to match other uses

Change-Id: I343086a6b7d70c84499b209680973431c7317219
Reviewed-on: https://gerrit.libreoffice.org/27184
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-07-13 12:58:55 +00:00
Jochen Nitschke
4ca9e85538 replace simple macros in chart2 
with static constantants or a named value (enum)

Change-Id: I8ef21bc3b9797ed9319e790fc12241d59f07b88c
Reviewed-on: https://gerrit.libreoffice.org/25760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-02 07:31:39 +00:00
Jochen Nitschke
150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Noel Grandin
ce66911720 loplugin:constantparam in svtools 
Change-Id: I1a3c4a36e29a6712c589ffd3aaada593880d978d
Reviewed-on: https://gerrit.libreoffice.org/23304
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-17 10:28:09 +00:00
Noel Grandin
6fc3fd29a6 loplugin:unusedmethods unused return value in chart2 
Change-Id: Ibd8ae8ade2a1037deac1e29ce1b867c2847a9dff
 2016-01-11 10:49:24 +02:00
Stephan Bergmann
40c4a08652 loplugin:nullptr (automatic rewrite) 
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
 2015-11-10 10:31:18 +01:00
Noel Grandin
6f1313b3d4 convert Link<> to typed 
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-16 09:11:29 +00:00
Noel Grandin
0e8a40e8b8 calling IsSet() before Call() on Link<> is unnecessary 
the Call() already does a check

Found with:
git grep -A 1 -w 'IsSet()'
    | grep -B 1 '.Call('
    | grep ':'
    | cut -d ':' -f 1

Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
 2015-10-15 12:29:01 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Daniel Robertson
391f181c9f chart2: replace for_each with range-based for 
Replace complex uses of ::std::for_each with a range-based for-loop.

Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc
Reviewed-on: https://gerrit.libreoffice.org/19143
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2015-10-08 09:06:46 +00:00
Noel Grandin
e85b2333bc convert Link<> to typed 
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-24 16:19:37 +00:00
Caolán McNamara
33cddeea13 boost->std 
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-14 19:32:42 +00:00
Caolán McNamara
f5ace6b29e no need to set the help id twice 
Change-Id: Idb903eaacf35d7b826086aae0b56fb1f496c25da
 2015-08-12 17:00:56 +01:00
Eike Rathke
711b34d590 tdf#92997 obtain a date/time edit format according to field value 
Bloody workaround hack for the fact that Chart does not handle
category/x-axis times internally and is not able to pass its own axis
numberformat to its own databrowser editor.

Change-Id: I016695ad0104366c0bb636b449a2014ade31aca3
 2015-08-10 15:20:02 +02:00
Noel Grandin
7410217b7d loplugin:unusedmethods chart2 
Change-Id: Ib7e8824e9e7f912963fbf07111ee3aa97773ceca
Reviewed-on: https://gerrit.libreoffice.org/17167
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 06:34:23 +00:00
Noel Grandin
2b5ebcc45b chart2: typed Link<> 
Change-Id: I98c882d64cb4d6430390ac705f3f2208dd523598
 2015-07-08 08:59:06 +02:00
Caolán McNamara
0f71828a95 cppcheck: noExplicitConstructor 
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
 2015-06-08 11:14:38 +01:00
Michael Meeks
ba81e5c6bd tdf#91702 - fix stack-based MessBox allocation. 
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-29 12:16:28 +00:00
Michael Meeks
cc7b8dab75 tdf#91633 - dispose chart data-table entries correctly. 
Change-Id: Ia26df029888f47a0395ea3c8bd7e0e51a1706c2a
 2015-05-26 17:54:28 +01:00
Stephan Bergmann
3ead3ad52f Gradually typed Link 
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
 2015-04-30 10:20:00 +02:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Noel Grandin
7ab8b08b6c loplugin:staticmethods 
Change-Id: Iab2f10b000ef41fb090e0034785d4ed0bda4cf43
 2015-04-23 13:08:48 +02:00
Noel Grandin
ed54799117 convert EBBF_ constants to scoped enum 
Change-Id: I6f281001a96ebfbca20f3e8dd3423945e119eef0
 2015-04-22 10:28:39 +02:00
Noel Grandin
0578aa4de2 convert BROWSER_ constants to scoped enum 
and fix a couple of places where it was mixing these flags up with the
WinBits flags and calling the wrong constructor.

Change-Id: I65c66bdd5a263e2f1db179c853f3f00e9ac7659e
 2015-04-22 10:28:39 +02:00
Michael Meeks
5ea025e637 chart2: convert new to ::Create. 
Change-Id: I14887bab5ced6e5915a8ecbc277017cec37a82ca
 2015-04-17 22:01:46 +01:00
Michael Meeks
23d833dd3f Move OutputDevice members to VclPtr: chart2, sfx2, cui. 
Change-Id: If9228f8777edd4532e9a167eae23095c5e232a6c
 2015-04-10 12:22:44 +01:00
Noel Grandin
c72fac2696 vclwidget: convert lots more sites to use VclPtr 
seems there was a lot of shared_ptr usage floating around...

Change-Id: Icd05243170eb8493709275fc36bf986fc194b781
 2015-04-10 11:20:46 +01:00
Noel Grandin
d7a84ce840 vclwidget: only call dispose() once 
by using a new utility method in vcl::Window
This means that we don't have to make all our dispose
methods safe to call more than once.

Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
 2015-04-10 10:55:36 +01:00
Noel Grandin
0a61ce1c8e vcl: VclPtr conversion in chart2 
Change-Id: Iae82331e812836ff4c97617227d316bfe15b23df
 2015-04-09 21:23:20 +01:00
Noel Grandin
0339e648a8 loplugin:constantfunction: chart2 
Change-Id: I2ec1eaf9faa23779fbdf53771dbba1936c6aa3f9
 2015-03-23 09:42:23 +02:00
Radu Ioan
a8e6f0bea0 tdf#39440 - cppcheck cleanliness 
Fixed some cppcheck defects

Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-02-17 06:15:54 +00:00
Stephan Bergmann
acb7ca4283 chart2: Use appropriate OUString functions on string constants 
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
 2014-12-18 14:12:23 +01:00
Noel Grandin
8dbde0845a fdo#82577: Handle Region 
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
 2014-09-30 09:58:23 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Markus Mohrhard
3575dba98d remove whitespaces 
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
 2014-07-02 23:03:07 +02:00
Kohei Yoshida
483a4b546c Flush modified data to the model when pressing OK in the data table dialog. 
This dialog used to have no OK / Cancel buttons, and the data would get
flushed when the dialog got dismissed.  This behavior got lost during the
dialog conversion.

Also, SaveModified() does check whether or not the data table is modified.
No need to call IsModified() before calling SaveModified().

Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c
 2014-06-27 11:35:11 -04:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Noel Grandin
329332ba52 chart2: sal_Bool->bool 
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
 2014-04-15 15:23:29 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
9604eb8758 svtools: sal_Bool->bool 
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
 2014-03-24 08:12:09 +02:00
Noel Grandin
f661ac03e0 svtools: sal_Bool->bool 
Change-Id: I22d8869551f46d2a0607f670f937853f394b6acf
 2014-03-24 08:12:09 +02:00