Andrea Gelmini
3dfdd18707
Fix typos
...
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1
Reviewed-on: https://gerrit.libreoffice.org/16710
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:22:11 +00:00
Caolán McNamara
1d498fb0fe
some other coverity things
...
Change-Id: I89ffd2b918f8707cde1b1d015c1ad35ef484b69c
2015-07-02 11:39:34 +01:00
Caolán McNamara
4e4760ef42
coverity#1308596 Uncaught exception
...
Change-Id: I0784ad02e540757a0cb25b0e216b7bab4d2061f8
2015-06-29 09:43:31 +01:00
Noel Grandin
03e6cc9130
loplugin:staticmethods
...
Change-Id: I912187d6c481a2ba61fed9c01998bf6f3c08a6a0
2015-05-05 09:30:40 +02:00
Noel Grandin
282e954477
loplugin: cstylecast
...
Change-Id: I42cd0be78478536322357ca7a03cf30e624b1afc
2014-10-28 08:11:26 +02:00
Jan Holesovsky
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d
.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e
.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
David Tardon
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
Juan Picca
47a2d7642d
fdo#81356: convert Fraction to boost::rational<long> - wip
...
* Added rational util functions used by Fraction class not
available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
1. fraction.IsValid() -- rational only allow valid values, ie
denominator() != 0
2. rational.denominator() == 0 -- always false
3. rational.denominator() < 0 -- always false but implementation
detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
boost::rational throws the exception boost::bad_rational
Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-10-09 11:33:33 +00:00
Noel Grandin
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Noel Grandin
8e4dc1d760
create type-safe bitfield for sc insert/delete flags
...
The most important part of the change is in sc/inc/global.hxx
It creates a type-safe struct that prevents the accidental interaction
between regular integer types and the flags struct.
It also provides utility methods that make combining and testing the
flags type-safe.
Change-Id: Ibc5b20058b1655df913490682b679afd1297b36d
Reviewed-on: https://gerrit.libreoffice.org/11071
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2014-09-04 09:05:34 -05:00
Markus Mohrhard
37e6631cc5
remove whitespace
...
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
Noel Grandin
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Noel Grandin
e7bc3cab01
remove boilerplate in UNO Exception constructor calls
...
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Kohei Yoshida
2fc4f5cd75
Register OpenGL windows to ScGridWindow upon file load.
...
Change-Id: I6fdce232ef41079f20a983dc72da032196078858
2014-05-19 16:03:28 -04:00
Noel Grandin
6dda3d45c9
sc: sal_Bool->bool
...
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-23 11:11:51 +02:00
Markus Mohrhard
c4c51709ea
whitespace cleanup in sc
...
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-06 17:19:54 +02:00
Alexander Wilms
84862db95a
Remove visual noise from sc
...
Conflicts:
sc/source/ui/inc/docfunc.hxx
Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8
Reviewed-on: https://gerrit.libreoffice.org/8301
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-03 11:04:44 -06:00
Caolán McNamara
38f6bd69c5
missing vim modelines
...
Change-Id: I51a2e95ef0a8c8e17bc996ae0c3639717f36de3f
2014-03-02 20:08:14 +00:00
Caolán McNamara
fa8dc4f9c8
fix coverity#1187656
...
Change-Id: Ida09e0efd48477b8811cbc4302c57f06a9b1a432
2014-03-02 20:08:14 +00:00
Caolán McNamara
a2bdb9ab23
coverity#1187656 Logically dead code
...
Change-Id: Id82a05b5de843d4695b0b3ef66fa103153b24d3a
2014-03-02 20:08:13 +00:00
Noel Grandin
6086f30e9b
sal_Bool->bool
...
Change-Id: Ia5ecfe267692c91e8468b48efb05942506060899
2014-02-19 13:05:14 +02:00
Noel Grandin
ab5c5702ba
sal_Bool->bool
...
Change-Id: I2dad64e3d7ba90a9d2f4779697a02272b9ccad9f
2014-02-19 13:05:11 +02:00
Stephan Bergmann
cc2606a785
bool improvements
...
Change-Id: I740c0e18eefc64cb5f1da5b88ceb77289790ec37
2014-01-28 20:26:23 +01:00
Noel Grandin
1d2f7047f2
convert sc/source/ui/vba/*.cxx from String to OUString
...
Change-Id: If696cdf2293464dc2a21cab4bdc4f77223cf26c9
2013-10-08 10:03:09 +02:00
Thomas Arnhold
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
Noel Grandin
a39c96af53
fdo#46808, Convert sheet::GlobalSheetSettings service to new style
...
Change-Id: If5fc10e408427fe5d87968a0ad51a3142f895709
2013-05-13 09:38:02 +02:00
Luboš Luňák
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Thomas Arnhold
39d45390f4
removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
...
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms
Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 10:48:30 +00:00
Thomas Arnhold
8b27d78b4a
automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
...
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 09:00:26 +00:00
Michael Meeks
16155fdc39
re-base on ALv2 code. Includes:
...
Patches contributed by Herbert Duerr
i#118735 prevent endless loop if vlookup/hlookup doesn't find anything
http://svn.apache.org/viewvc?view=revision&revision=1239673
Patches contributed by Andre Fischer
remove lp_solver
http://svn.apache.org/viewvc?view=revision&revision=1199180
i#118160: Added external CoinMP library.
http://svn.apache.org/viewvc?view=revision&revision=1233909
Patches contributed by Armin Le-Grand
i#118485 - Styles for OLEs are not saved.
http://svn.apache.org/viewvc?view=revision&revision=1182166
i#118524: apply patch, followup fixes to 118485
http://svn.apache.org/viewvc?view=revision&revision=1186077
Patches contributed by lihuiibm
i#108860 - Fix range validation.
http://svn.apache.org/viewvc?view=revision&revision=1242846
i#118954 Chart data will lost after copy to different file
http://svn.apache.org/viewvc?view=revision&revision=1301345
Patches contributed by Ariel Constenla-Haile
Fix Linux build breaker: extra qualification on member
http://svn.apache.org/viewvc?view=revision&revision=1301591
i#118696 - i#118697 - Fix some Sheet Tab Color API issues
http://svn.apache.org/viewvc?view=revision&revision=1225428
i#118697 - Fix uninitialized variable
http://svn.apache.org/viewvc?view=revision&revision=1225859
i#118771 - ScUndoImportTab should preserve tab background color
http://svn.apache.org/viewvc?view=revision&revision=1230356
i#118921 - Repaint linked sheet tab background color after updating link
http://svn.apache.org/viewvc?view=revision&revision=1245177
i#118927 - Undo/Redo "Update Link" does not reset sheet tab color
http://svn.apache.org/viewvc?view=revision&revision=1245241
i#118747 - Copy tab color when transferring sheets across documents
http://svn.apache.org/viewvc?view=revision&revision=1230355
Patch contributed by Oliver Rainer-Wittman
i#118012 - methods <ScBroadcastAreaSlot::AreaBroadcast(..)> and
<ScBroadcastAreaSlot::AreaBroadcastInRange(..)> adapt stl-container
iteration in order to avoid destroyed iterators during iteration.
http://svn.apache.org/viewvc?view=revision&revision=1297916
Patches contributed by Mathias Bauer
gnumake4 work variously
http://svn.apache.org/viewvc?view=revision&revision=1394707
http://svn.apache.org/viewvc?view=revision&revision=1394326
http://svn.apache.org/viewvc?view=revision&revision=1396797
http://svn.apache.org/viewvc?view=revision&revision=1397315
Patch contributed by Daniel Rentz
calc69: #i116936# fix VBA symbol Cells
http://svn.apache.org/viewvc?view=revision&revision=1172135
Patches contributed by leiw:
i#118546 CPU 100% on switched off AutoCalculate with Conditional
Formatting on date values
http://svn.apache.org/viewvc?view=revision&revision=1301380
Re-add new function documentation. Many various cleanups.
Add missing calc66: #o11817313# also look at formula result
number format, remove redundant binaries.
2012-12-04 07:17:12 +00:00
Daniel Rentz [dr]
191bf98991
calcvba: #164410# improve VBA compatibility implementation in various areas:
...
Excel symbols, MSForms symbols, document and forms event handling
Conflicts:
sc/source/ui/docshell/docsh.cxx
sc/source/ui/unoobj/docuno.cxx
sc/source/ui/vba/vbaapplication.cxx
sc/source/ui/vba/vbaapplication.hxx
sc/source/ui/vba/vbaeventshelper.cxx
sc/source/ui/vba/vbaglobals.cxx
sc/source/ui/vba/vbarange.cxx
sc/source/ui/vba/vbawindow.cxx
sc/source/ui/vba/vbaworkbook.cxx
sc/source/ui/vba/vbaworkbooks.cxx
sc/source/ui/vba/vbaworksheets.cxx
sc/util/makefile.mk
2012-12-04 07:17:06 +00:00
Stephan Bergmann
c2ca6fabd1
Use comphelper::getComponentContext
...
...and some further clean up.
Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
Matúš Kukan
5c87937273
unusedcode: more removing
...
Change-Id: Ic8be585925edd63724d28a255c9e33170a4a041e
2012-09-26 11:46:52 +02:00
Noel Power
4597483e00
targetted VBA re-work.
2012-09-12 12:49:49 +01:00
Caolán McNamara
bccf34c19a
ditch String::CreateFromAscii
...
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
2012-07-03 21:24:35 +01:00
Santiago Martinez
fdd3427a58
Removed unused code.
2012-03-08 11:17:08 +05:30
Kohei Yoshida
6984153093
String to rtl::OUString.
2011-08-26 19:34:42 -04:00
Noel Power
705030ab50
fix for bnc#707486 allow copy for suitable multi-area Ranges
...
also remove the extra CopyToClip ( and CopyToClip4VBA ), merged the functionality to remove the existing copy and paste.
2011-07-26 20:06:30 +01:00
Markus Mohrhard
5038cdc71d
some cleanup in vba
2011-05-11 14:36:55 +02:00
Markus Mohrhard
c831d4236f
use sheet local db data in ScVbaRange::Autofilter
...
Signed-off-by: Kohei Yoshida <kyoshida@novell.com >
2011-05-09 14:47:50 -04:00
Markus Mohrhard
ff0fec9260
fixed problem with return value in ScVbaWorksheet::createSheetCopyInNewDoc
2011-04-26 09:33:25 +01:00
Michael Meeks
970dfb78ae
more merge fixes, compiles and links now
2011-03-15 09:56:18 +00:00
Kohei Yoshida
1a5aaf0b88
Some attempts to get the VBA code to build.
2011-03-15 01:58:39 -04:00
Kohei Yoshida
12343c1556
Merge commit 'ooo/DEV300_m101' into integration/dev300_m101
2011-03-10 20:21:13 -05:00
Mikhail Voytenko
cd42389ad6
removetooltypes01: #i112600# remove tooltypes from sc
2011-01-17 13:20:22 +01:00
René Kjellerup
7fea18e09a
comment crean up in sc
...
cleaned some added comments from silencing the compiler.
WritePicPr(...) has been removed since it seems unused by all
accounts.
2010-11-08 14:59:18 -05:00
René Kjellerup
892231d6dc
Warning free sc module
2010-11-03 12:34:09 -04:00
Noel Power
65389fcbb7
Merge commit 'origin/master' fix conflicts and more trailing ws
...
Conflicts:
sc/source/ui/undo/undodat.cxx
sc/source/ui/vba/excelvbahelper.cxx
sc/source/ui/vba/vbadialog.cxx
sc/source/ui/vba/vbahelper.cxx
sc/source/ui/vba/vbapagesetup.cxx
2010-10-13 12:41:26 +01:00
Sebastian Spaeth
63bb42ab7d
Add vim/emacs modelines to all source files
...
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com )
Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de >
2010-10-13 10:57:18 +02:00