Commit Graph

9 Commits

Author SHA1 Message Date
Noel Grandin
e0846b7abe loplugin:simplifybool can't invert conditions involving float types
so revert some of the changes from

    commit 7a1c21e53f
    loplugin:simplifybool for negation of comparison operator

Change-Id: I937d575b86c1e418805d399b0dc16ae91876b4fe
Reviewed-on: https://gerrit.libreoffice.org/45130
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23 14:11:24 +01:00
Stephan Bergmann
52dbe0c99b Make not warning about !! in loplugin:simplifybool consistent
...so that 640e03da11 "loplugin:simplifybool re-
activate the !! warning", which did not warn about

  !!( nAttribs & ucb::ContentInfoAttribute::KIND_FOLDER )

in ucb/source/core/ucbcmds.cxx (involving sal_Int32 and sal_Int16), would not
have warned about

  !!(nMode & nUpdateMode)

in sfx2/source/appl/workwin.cxx (ivolving o3tl::typed_flags<SfxVisibilityFlags>)
either.

Change-Id: Ibe955592951a04b1bd9a9b4e8cc502024bc1d460
Reviewed-on: https://gerrit.libreoffice.org/45083
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23 10:03:16 +01:00
Noel Grandin
7a1c21e53f loplugin:simplifybool for negation of comparison operator
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-23 06:59:31 +01:00
Noel Grandin
640e03da11 loplugin:simplifybool re-activate the !! warning
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b
Reviewed-on: https://gerrit.libreoffice.org/45035
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22 07:44:16 +01:00
Stephan Bergmann
b35bb38f18 Clean away temporarily added using declarations
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
2017-11-07 11:50:47 +01:00
Andrea Gelmini
ce343470c3 Fix typos
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea
Reviewed-on: https://gerrit.libreoffice.org/18941
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:00:18 +00:00
Stephan Bergmann
dbb75877c2 loplugin:simplifybool: Need to ignore imp. casts when determining literals
Change-Id: I6b25ef369a9d445322f7500630a6a4ed38ae7d8f
2015-04-27 15:31:04 +02:00
Stephan Bergmann
5beac3c0b7 Add clarifying comment
Change-Id: Ie891404a4d21e1917e5e653737e35257df3dfcae
2015-04-24 15:01:20 +02:00
Stephan Bergmann
2d855ab9d0 loplugin:simplifybool
Change-Id: I44b563269a68cd2d57a906e10939ac290a0a2ebd
2015-04-24 12:36:32 +02:00