mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
355,401 Commits 1 Branch 0 Tags
529e7619c5258aec91c33dd57b9fa12c3e85cfeb
Commit Graph

224 Commits

Author SHA1 Message Date
Stephan Bergmann
529e7619c5 loplugin:staticcall 
Change-Id: I78895f3524086e1d00d9e8eafd52e505f786320b
 2014-06-13 17:54:25 +02:00
Lionel Elie Mamane
ade17fc916 fdo#79786 implement getFormOperations for data grid (table view) 
Change-Id: I704057b25ca11633ba62fbb834bd2e6095f348f3
Reviewed-on: https://gerrit.libreoffice.org/9685
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2014-06-09 06:41:43 +00:00
Thomas Arnhold
70c8b4567f WaE: warning C4101: 'e' : unreferenced local variable 
Change-Id: Ib5aa5f401eabedfdaebea1dea8f48f284dbccdd5
 2014-06-04 08:30:27 +02:00
Lionel Elie Mamane
8eb341ac9e fdo#73352 don't crash if clearWarnings throws an SQLException 
Change-Id: If67bda43589834e4c922056145bc60884728cb8a
Reviewed-on: https://gerrit.libreoffice.org/9591
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2014-05-31 03:56:12 +00:00
Noel Grandin
ca86511a6e dbaccess: remove SAL_INFO's that only make function entry 
Change-Id: Ibdf92698446d0a7aed7c474ec7d3ea720cd2c2a6
 2014-05-14 10:00:03 +02:00
Noel Grandin
fee4efcb54 dbaccess: sal_Bool->bool 
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
 2014-04-17 11:17:21 +02:00
Tor Lillqvist
6835d9f307 It's "its", not "it's" 
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
 2014-04-10 20:22:50 +03:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Noel Grandin
8d6a99f67e dbaccess: sal_Bool->bool 
Change-Id: Ida8ee14bb6350fad815d741ca7a2b7db04a8ed11
 2014-04-03 09:17:47 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Noel Grandin
3194d22a24 connectivity: sal_Bool->bool and fix method name 
Convert method name
  getBoleanComparisonPredicate
to
  getBooleanComparisonPredicate

Change-Id: I00c726b1fecd8352dc49f2af98c3ae3c799ef424
 2014-04-01 07:38:08 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
b1de52241c svtools: sal_Bool->bool 
Change-Id: Iaa489318f25107e91fc8133523fbd9d724493314
 2014-03-24 08:12:08 +02:00
Stephan Bergmann
2f3be98732 dbaccess: simplify deprecated XTypeProvider.getImplementationId 
Required some clean-up of getImplementationId vs. getUnoTunnelImplementationId
confusion.

Change-Id: I645dd80d24efe7ed5224b220911eed8ad880b7c0
 2014-03-10 17:39:54 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Stephan Bergmann
ad73967e99 Remove unnecessary extractInterface 
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
 2014-02-24 08:08:00 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool 
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
 2014-02-17 17:55:19 +01:00
Stephan Bergmann
9cc60839f3 bool improvements 
Change-Id: I294b930214ce82033402afecf2b3eb2d04299505
 2014-01-28 20:26:29 +01:00
Arnaud Versini
5b2ba8ed5d DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR. 
Valgrind is capable of detecting such bugs. No need for extra macros.

Conflicts:
	dbaccess/source/ui/dlg/tablespage.cxx

Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 16:20:10 +00:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Jelle van der Waa
2ec606730b fdo#62475 removed pointless comments 
Conflicts:
	dbaccess/source/filter/xml/xmlfilter.cxx
	dbaccess/source/ui/dlg/ConnectionPage.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/odbcconfig.cxx
	dbaccess/source/ui/querydesign/querycontroller.cxx

Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
 2013-08-27 16:11:09 +00:00
Tor Lillqvist
d3a221df1a Fix error: reference to 'ErrorCondition' is ambiguous 
Either 'connectivity::ErrorCondition' or
'com::sun:⭐:sdb::ErrorCondition'.

Change-Id: Ifeaa895497c8635b7801b2e79400634b11541373
 2013-07-10 20:48:50 +03:00
Radu Ioan
61db96daa8 fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO 
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: I26761cf1d4c1cfe21dec7d8ede6df6f177bf2c3e
Reviewed-on: https://gerrit.libreoffice.org/4620
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
 2013-07-03 07:59:33 +00:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Miklos Vajna
51c18e8e80 dbaccess: this can happen, that's why we check for it 
Change-Id: Icc85dde5cc53a6880ac83d687bad498ab984c4cf
 2013-05-30 09:33:02 +02:00
Chris Sherlock
2fd73a725f Potty mouth 
Change-Id: I276fa2fa24b5553a748e6e628129d54419e69c9a
Reviewed-on: https://gerrit.libreoffice.org/3843
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2013-05-10 13:11:30 +00:00
Gergő Mocsi
59bc10eb46 fdo#38838, String to OUString, in dbaccess/source/ui/browser 
Applied fdo#38838 in dbaccess/source/ui/browser, +
RTL_CONSTASCII_USTRINGPARAM removals

Change-Id: I8a565cdae7fd9da1de05525c602ce011542ab4d5
Reviewed-on: https://gerrit.libreoffice.org/2538
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-15 01:03:35 +00:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling 
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
 2013-03-03 17:14:16 +01:00
Thomas Arnhold
405caad685 loplugin: unused variables 
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
 2013-02-25 03:14:00 +01:00
Noel Grandin
92f14ced5e fdo#46808, Adapt frame::TaskCreator UNO service to new style 
The service already existed, it just did not have an IDL file.

Change-Id: I157c53d09b612da0178432100b8928013f811706
 2013-01-15 09:56:00 +02:00
Matúš Kukan
68aecf0dd8 remove unused variables [-Werror,-Wunused-private-field] 
Change-Id: I3cb08dd52c5a34be6585ac9fc0c4b6bb04b6ae8c
 2012-12-23 15:31:04 +01:00
Noel Grandin
bb121c864c fdo#46808, Convert frame::Desktop to new style service. 
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
 2012-12-21 10:57:09 +02:00
Noel Grandin
b9a4a0b965 fdo#46808, Convert connectivity::SQLError to use XComponentContext... 
...instead of comphelper::ComponentContext.

Change-Id: I40384c2d7cfcabd06506321d686dd8e7c7c5f266
 2012-12-10 08:05:49 +02:00
Noel Grandin
773ad75b0d fdo#46808, Adapt util::NumberFormatsSupplier UNO service to new style 
Change-Id: I58436d9eea0c38d14cde2dc01aa463d5d71912e9
 2012-12-06 13:20:31 +02:00
Noel Grandin
0666e43c45 fdo#46808, use service constructor for i18n::CharacterClassification 
Change-Id: I0499ad7de27b1539e97f01ab8aa0ef2d6713ae76
 2012-11-05 18:05:00 +01:00
Stephan Bergmann
dd11a1e57a Fixes/improvements on previous commit 
* UUIInteractionHandler still needs to implement XInitialization.

* Moved ambiguating InteractionHandler typedef out of the way.

* Removed InteractionHandler.createDefault, as it was originally stated that "it
  is strongly recommended that [the "Parent"] property is supplied."

* Added back documentation about Parent and Context.

* Simplified some call-sites to directly use XInteractionHandler2.

Change-Id: I1029b8f3cf079171c75920cafaaa44b5bbada883
 2012-10-04 14:42:52 +02:00
Noel Grandin
c25cb8a641 fdo#46808, Adapt task::InteractionHandler UNO service to new style 
Since we don't need to expose XInitialisation, we can make the new-style
service implement XInteractionHandler2.

Change-Id: Ib27beed1c12df17592c6472d6f58c233d2c41558
 2012-10-04 14:42:52 +02:00
Stephan Bergmann
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification 
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
 2012-09-19 13:16:38 +02:00
Noel Grandin
3a36408b73 fdo#46808, Adapt util::NumberFormatter UNO service to new style 
Create a merged XNumberFormatter2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Change-Id: I57f35cde0a9dbbe91c1d2c3d068cb3a97c7245e3
 2012-09-03 15:55:06 +02:00
Stephan Bergmann
4a69252e2c -Werror,-Wunused-private-field (Clang towards 3.2) 
Change-Id: I55ad905bef36b54fadc245bfb22f687e47d20c3a
 2012-08-31 09:04:17 +02:00
Lionel Elie Mamane
3655f25465 fdo#48807 autofilter should not use LIKE operator 
This demonstrates a confusion between *values* and *patterns*

Change-Id: I207aa53950166e915bbad22b022c88d07ee6300d
 2012-08-30 05:23:06 +02:00
Caolán McNamara
bccf34c19a ditch String::CreateFromAscii 
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
 2012-07-03 21:24:35 +01:00
Thomas Arnhold
57154616f0 Remove UNO includes comments 
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
 2012-06-29 09:25:09 +02:00
Michael Meeks
577cf8ff67 re-base on ALv2 code. 2012-06-14 17:41:07 +01:00
Caolán McNamara
8f5629fd5a remove EraseLeadingChars and EraseTrailingChars 
Change-Id: Ib9797fe97cd008cc6508ce8cec47dc5373416892
 2012-06-11 14:46:46 +01:00
Thomas Arnhold
3770bbbdba Remove superfluous empty lines on top 
More than two lines are removed for readability.

Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
 2012-06-09 04:57:58 +02:00
Caolán McNamara
8a0685d49f make ResId::toString a non-static member 
Change-Id: I756c0a19bea7b1cc0e290d9f382a04d655819bfb
 2012-04-30 11:22:09 +01:00