Commit Graph

49 Commits

Author SHA1 Message Date
Noel Grandin
8a22bc93e0 update unnecessaryoverride plugin to find pure forwarding methods
which can be replaced with using declarations.

Is there a more efficient way to code the search? Seems to slow the
build down a little.

Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f
Reviewed-on: https://gerrit.libreoffice.org/30157
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:56:17 +00:00
Noel Grandin
7cf9028d3b loplugin:unnecessaryoverride in forms/framework
Change-Id: Ia2aabec5af5559903be09e1ef81d156a7538ab3f
2016-10-05 13:53:28 +02:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin
36313d93ac improve unnecessaryoverride plugin
to ignore ImplicitCastExpr when calling superclass method

Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1
Reviewed-on: https://gerrit.libreoffice.org/27279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19 05:39:46 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara
7ba7a974f6 cppcheck: noExplicitConstructor
Change-Id: I32c6728ce7423fd997cdbec66feb8a6ba39948d2
2015-10-07 15:11:03 +01:00
Noel Grandin
de020fc9c3 com::sun::star->css in forms/
Change-Id: I1c09e88f839bdf11c6ff809ec95769e8f729c7cd
2015-10-02 08:20:11 +02:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
Stephan Bergmann
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
Caolán McNamara
5d39063581 coverity#1308583 Uncaught exception
Change-Id: Ibc6a8e437d81769b9a77d0a52e98f71b1c7e7d51
2015-06-29 09:43:35 +01:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Philipp Weissenbacher
0f8ed32913 fdo#39468 Translate German comments, clean some ws
Conflicts:
	forms/source/component/FormComponent.cxx
	forms/source/component/FormattedField.cxx

Change-Id: I76dacfff3aa6f5680a1e81c97281c4f744ec1ceb
Reviewed-on: https://gerrit.libreoffice.org/11622
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25 08:49:03 +00:00
Thomas Arnhold
28ac97dce1 forms: expand DECLARE_XCLONEABLE
Change-Id: I2a468e40489797e33935b79a27459ab408558124
2014-06-04 08:30:25 +02:00
Chris Laplante
04f31d13c5 Remove ASCII art, useless comments and whitespace from forms module
Change-Id: Ib6157a493092a137a6b0bf5b96d0e760d307f9da
Reviewed-on: https://gerrit.libreoffice.org/9472
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-25 14:35:17 -05:00
Stephan Bergmann
93f5d5a919 The opaque PostUserEvent IDs are actually pointers
...so declare them as such.  This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.

While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent.  And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.

Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
Noel Grandin
c0d037a6ec forms: sal_Bool->bool
Change-Id: Ifa15f4ed3107b1075b504f09d2cae69ee38d347a
2014-05-06 12:38:16 +02:00
Stephan Bergmann
6ac0e1399a Remove silly PUT_SEMICOLON_AT_THE_END
...and rather live with macro calls not terminated by semicolons until those
macros are gone for good anyway.  Completely remove unused
DECLARE_UNO3_XCOMPONENT_DEFAULTS.

Change-Id: I0d4eb5a91736004b0da2b09fce860e57f6d1ddbd
2014-04-07 17:27:39 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Thomas Arnhold
bdf7b2715e fixincludeguards.sh: forms
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
2013-11-05 09:28:53 +01:00
Noel Grandin
d209e13319 fdo#46808, Convert comphelper::ComponentContext in forms module
Change-Id: I8a9913d964633381f00c0a4885cc655805fa1974
2013-06-03 10:00:03 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Michael Meeks
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
Marcel Metz
5845c5b6ec Removed unnecessary tools/link.hxx includes. 2012-01-06 23:55:50 +01:00
Caolán McNamara
b77940e5af add modelines to .hxx files as well 2010-10-28 15:48:02 +01:00
Jens-Heiner Rechtien
36de66bdf0 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Oliver Bolte
c9e236cc23 CWS-TOOLING: integrate CWS dba32j
2009-11-26 09:30:10 +0100 msc  r277648 : #100000 fix urgent testscript error
2009-11-25 10:27:56 +0100 msc  r277625 : #i100000 fix urgent testscript error
2009-11-17 22:16:46 +0100 fs  r277544 : CWS-TOOLING: rebase CWS dba32j to branches/OOO320@277531 (milestone: OOO320:m5)
2009-11-17 14:26:47 +0100 fs  r277535 : ooops, didn't mean to commit this uncommented line
2009-11-14 20:50:29 +0100 fs  r277505 : add a --disable-pango switch to SM's configure options, and add a patch which makes certain code respect it (well, respect it better than currently, by not using some pango_x_* functions, which are not always available, even when pango itself is present)
2009-11-14 20:47:41 +0100 fs  r277504 : spelling
2009-11-13 14:04:00 +0100 fs  r277502 : #i100764# (commit approved by ab@openoffice.org): getModelFromBasic: do not start with the parent's parent when looking for ThisComponent, but walk up the anchestor chain, starting with the immediate parent
2009-11-13 11:04:15 +0100 fs  r277496 : #i100764# better heuristics for determining whether or not to participate in the ThisComponent game
2009-11-13 11:02:30 +0100 fs  r277495 : #i100764# set the WB_EXT_DOCUMENT style at the backing component's container window, when creating it without the TaskCreator (which would normally do this)
2009-11-11 13:49:11 +0100 fs  r277452 : #i106816#
2009-11-11 13:48:53 +0100 fs  r277451 : fix the CREATETARBAL target, which is expected to create the zips used as prebuilts. The *inc.zip missed the NSS files in case NSS was built externally
2009-11-11 12:15:34 +0100 fs  r277449 : update ignore list
2009-11-11 12:09:23 +0100 fs  r277448 : add a link to the Mozilla build tools download location
2009-11-11 12:07:16 +0100 fs  r277447 : add a link to the Mozilla build tools download location
2009-11-06 16:23:12 +0100 fs  r277393 : #i106643#
2009-11-03 23:20:29 +0100 fs  r277328 : #i106574#
reverted the recent fix for issue #i105235#, and implemented a better one.
2009-11-02 12:59:48 +0100 fs  r277294 : #i106550# errorOccured: also display the error when we're not in a nested form action - form actions are allowed to be triggered by other instances as well
2009-12-01 09:53:35 +00:00
Kurt Zenker
99d686e5a6 INTEGRATION: CWS dba30d (1.19.10); FILE MERGED
2008/05/27 12:28:02 fs 1.19.10.1: #i89657# refactoring, so that our binding's getValue is only called when our mutex is not locked
2008-06-25 10:57:49 +00:00
Kurt Zenker
52de308606 INTEGRATION: CWS dba30b (1.17.76); FILE MERGED
2008/04/15 21:52:44 fs 1.17.76.2: RESYNC: (1.17-1.18); FILE MERGED
2008/02/26 08:28:58 fs 1.17.76.1: remove unused code
Issue number:  #i86305#
Submitted by:  cmc@openoffice.org
Reviewed by:   frank.schoenheit@sun.com
2008-05-05 14:21:39 +00:00
Rüdiger Timm
05f3a3db77 INTEGRATION: CWS changefileheader (1.17.82); FILE MERGED
2008/04/01 15:16:30 thb 1.17.82.3: #i85898# Stripping all external header guards
2008/04/01 12:30:22 thb 1.17.82.2: #i85898# Stripping all external header guards
2008/03/31 13:11:33 rt 1.17.82.1: #i87441# Change license header to LPGL v3.
2008-04-11 07:12:33 +00:00
Oliver Bolte
fb93450667 INTEGRATION: CWS hb02 (1.16.44); FILE MERGED
2007/02/01 12:09:38 fs 1.16.44.2: #i74051# split describeFixedProperties in describeFixedProperties and describeAggregateProperties
2007/01/31 10:55:27 fs 1.16.44.1: changed handling of properties in the course of #i74051#
2007-03-09 12:26:13 +00:00
Oliver Bolte
df6372f7ee INTEGRATION: CWS sb59 (1.15.28); FILE MERGED
2006/08/29 16:10:59 sb 1.15.28.1: #i67487# Made code warning-free (wntmsci10).
2006-10-12 10:11:41 +00:00
Jens-Heiner Rechtien
6043c9df26 INTEGRATION: CWS warnings01 (1.13.68); FILE MERGED
2006/05/23 17:40:52 sb 1.13.68.2: RESYNC: (1.13-1.14); FILE MERGED
2006/03/15 07:55:33 fs 1.13.68.1: #i57457# warning-free code (unxsols4)
2006-06-19 11:49:47 +00:00
Vladimir Glazounov
a495915c25 INTEGRATION: CWS internatiodel (1.13.46); FILE MERGED
2006/02/10 19:31:14 er 1.13.46.1: #i52115# move LangIDs and ISO conversion from tools to i18npool; introduce class MsLangId and libi18nisolang
2006-04-07 14:23:29 +00:00
Rüdiger Timm
44d7646f3d INTEGRATION: CWS ooo19126 (1.12.56); FILE MERGED
2005/09/05 13:50:20 rt 1.12.56.1: #i54170# Change license header: remove SISSL
2005-09-08 21:40:49 +00:00
Vladimir Glazounov
951bb70718 INTEGRATION: CWS eforms4 (1.11.50); FILE MERGED
2004/12/10 09:12:13 fs 1.11.50.1: #i36359# when communicating with an external value binding, try some other types than double, depending on the current format
2005-03-23 10:29:58 +00:00
Rüdiger Timm
304b7d10d4 INTEGRATION: CWS dba13 (1.10.32); FILE MERGED
2004/06/18 13:53:14 fs 1.10.32.1: #i29828# clear the shared formatter instance earlier than upon library unloading
2004-07-06 12:38:27 +00:00
Rüdiger Timm
6dda90133e INTEGRATION: CWS frmvalidation (1.9.36); FILE MERGED
2004/03/11 16:46:16 fs 1.9.36.1: mass checkin
- #i25106# core for validating form controls via external XValidator instances
- moved the services/interfaces related to binding form controls to external
  value suppliers into css.form.binding (out of drafts.css.form/component)
2004-04-02 09:52:52 +00:00
Oliver Bolte
c319fcc3b5 INTEGRATION: CWS formcelllinkage (1.8.92); FILE MERGED
2003/10/01 09:18:25 fs 1.8.92.1: #i18994# merging the changes from the CWS fs002
2003-10-21 07:58:16 +00:00
Frank Schönheit
b0c4be1488 #105577# properly (hopefully :) implemented XClonable 2002-12-02 08:56:36 +00:00
Vladimir Glazounov
0647e3cc4b #92075# exception specification 2001-09-12 15:12:33 +00:00
Frank Schönheit
62c5fa9973 #74241# be an XSQLErrorBroadcaster - so we can broadcast errors during the commit 2001-08-28 13:30:12 +00:00
Frank Schönheit
76c9383ffe #87149# changed the property listening at the aggregate
upon construction: _first_ register as listener, _then_ set the delegator
upon disposing:    stop listening, but _do_not_release_ the ref
upon destruction:  release the ref which the multiplexer has for the aggregate
2001-05-31 13:03:04 +00:00
Frank Schönheit
f936664e9d #81738# correctly calculate the TreatNumeric flag in _loaded 2001-02-13 16:41:39 +00:00
Ocke Janssen
81c8196ae8 namespace changes 2000-11-23 07:48:15 +00:00
Frank Schönheit
cdbcbba768 migrated from unotools to comphelper 2000-10-19 10:52:20 +00:00
Jens-Heiner Rechtien
bf4154eb53 initial import 2000-09-18 15:33:13 +00:00