Commit Graph

1900 Commits

Author SHA1 Message Date
Noel Grandin
690cf2a5ac no point in having both SAL_WARN and OSL_FAIL for the same thing
Change-Id: I1beafff257e968a62184f8b1d8cf2a3a24e7c945
Reviewed-on: https://gerrit.libreoffice.org/32039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-15 16:20:54 +00:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-15 06:45:14 +00:00
Caolán McNamara
8bd9db9038 gtk3: implement opengl support for slideshow
all of them work, except "Fall" doesn't look right, but it has
the exact same problem under gtk2/gen to.

Change-Id: I73cb9c0fb8211f727198be78d90d4f80a4f8c7c8
Reviewed-on: https://gerrit.libreoffice.org/31214
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13 11:34:24 +00:00
Caolán McNamara
482d7ce61b change from glew to epoxy
because that works under wayland out of the box and gtk3 uses it already

Change-Id: Iefaac31e325534a81a5389f752804af917c1baef
Reviewed-on: https://gerrit.libreoffice.org/31213
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13 11:33:18 +00:00
Noel Grandin
4ef9ccea6c OSL_TRACE -> SAL in sfx2..svx
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e
Reviewed-on: https://gerrit.libreoffice.org/31799
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11 18:56:16 +00:00
Noel Grandin
bfde4866e0 convert DecodeMechanism to scoped enum
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
Caolán McNamara
eab6ed9f00 getVerticesSize got renamed to getVerticesByteSize
Change-Id: I7eff6eeb92aede6beb4412aa3e574ae75d651d8b
2016-12-05 09:37:50 +00:00
Caolán McNamara
5809f506f4 rework diamond transition to use only opengl core
cause that's all we've got in gtk3

Change-Id: I6a47e344ccd39ba63e7a51ae18f89bb05bb642c4
Reviewed-on: https://gerrit.libreoffice.org/31496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-05 09:25:43 +00:00
Stephan Bergmann
fbb3f88df5 loplugin:unnecessaryoverride (dtors) in slideshow
Change-Id: I5c4bc26bc51347e453ce69913edc52cf1f1aa821
2016-12-05 08:59:33 +01:00
Stephan Bergmann
7915c9087c warning C4018: '<' : signed/unsigned mismatch
Change-Id: I5e6a6debf01886c283f5a2d6b9cacc00a44f7134
2016-12-02 16:20:19 +01:00
David Tardon
3830059b65 get vertices count without jumping through hoops
Change-Id: I0cab6b2f9fffc8cf9fc5059b8dc48fa9407e42b5
2016-12-02 15:17:52 +01:00
David Tardon
8ca055f56f rename to avoid further misunderstandings
Change-Id: Ibcfae1b3ec118d74921312a80eb56c97c623f4a9
2016-12-02 15:17:52 +01:00
Caolán McNamara
2d2329f441 coverity#1371200 Missing move assignment operator
adjust things to not need one

Change-Id: I1079f50d8813f86c4828be602687b4cbffe61415
2016-12-02 10:58:04 +00:00
Caolán McNamara
579feb4d84 glDrawArrays takes num of indices, not size of storage
this stops the strange missing corner seen during the diamond
transition

Change-Id: If806a0a3303eb38644bb6d3a479cadbd5fe9ca25
2016-11-30 14:24:04 +00:00
Stephan Bergmann
bd614b9135 Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLY
i.e., css::uno::Any function template specializations

  Any::has<Any>() const
  Any::get(Any const &) const
  operator >>=(Any const &, Any &)
  operator <<=(Any &, Any const &)

that don't make much sense (the first is always true, the rest can be replaced
with operator =, which additionally supports move semantics).  For 3rd-party
compatibility, do this only for LIBO_INTERNAL_ONLY, however.

However, some generic template code did benefit from operator >>= working also
for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that
operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny,
complementing the existing toAny.

Change-Id: I8b1b5f803f0b909808159916366d53c948206a88
Reviewed-on: https://gerrit.libreoffice.org/30022
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-21 19:44:56 +00:00
Noel Grandin
bb674aa550 loplugin:unusedfields
Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17 13:10:42 +00:00
Noel Grandin
41ea741cd8 loplugin:unnecessaryvirtual in sfx2..svtools
Change-Id: Ib34e14806f7cc9a97ecfd68687ab17ee5c1f022b
Reviewed-on: https://gerrit.libreoffice.org/30652
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07 09:39:55 +00:00
David Tardon
04055cd8d9 fix doc comment to match code
This has been wrong since the initial commit...

Change-Id: I271375ba10c37aa9b198476955d66af9fc019e27
2016-10-31 20:16:04 +01:00
David Tardon
7445399af8 convert angle from degrees to radians for glm
This makes simple (i.e., not implemented as a shader) OpenGL transitions
work correctly again.

Change-Id: I773f686089bce3611940743b1a7f5046093886e8
2016-10-31 20:16:04 +01:00
Noel Grandin
7195c7e8b8 loplugin:expandablemethods in slideshow
Change-Id: I3a7207e0566bc4b871b364da3180ce67e1099de8
2016-10-27 10:59:09 +02:00
David Tardon
093d7b1c68 rename dir to follow suit
Change-Id: I894e6a089e99ed6cec3a970ffa0cce9cbd9a9e1a
2016-10-25 16:11:13 +02:00
David Tardon
c5423234f3 remove unnecessary dir and name prefix
Change-Id: I57b8d8b187fe7b8a99f2f90d696cd8c97b8a07b6
2016-10-25 16:11:12 +02:00
Noel Grandin
1aa69bd5d4 loplugin:countusersofdefaultparams in sd..slideshow
Change-Id: Iaf10935d8f231676333018a5954d97defe35acf6
2016-10-24 10:44:30 +02:00
Noel Grandin
40fc2c1a0d loplugin:expandablemethodds in sfx2..starmath
Change-Id: Ia4c411f5a9a68c2f344188ce6b6bc1815c89f993
Reviewed-on: https://gerrit.libreoffice.org/30055
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20 06:12:24 +00:00
Caolán McNamara
5f6af959fa InfoFont/Color is not used by vcl now
anywhere anyone wanted to Get[Font|Color] give it the Label
ones instead.

why this is exposed through uno is bewildering, stubbed those
out for the moment

Change-Id: I7a31d027287436be1c075c76a370047efd010bf3
2016-10-05 20:52:29 +01:00
Noel Grandin
954f752cf1 convert MapUnit to scoped enum
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05 06:51:20 +00:00
Noel Grandin
c4cd079b8f loplugin:unusedmethods in sc..vcl
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8
Reviewed-on: https://gerrit.libreoffice.org/29183
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22 18:56:58 +00:00
Michael Stahl
b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15 12:01:11 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin
a881fd7e66 convert RasterOp to scoped enum
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-05 08:21:46 +02:00
Michael Stahl
cea58d4c27 slideshow: stop whining about PresenterCanvas' lack of XUpdatable
Change-Id: I1e447f5eccb41325d96e9c4cb1598a05e702badc
2016-08-31 16:01:19 +02:00
Noel Grandin
86c0ce4d46 loplugin:countusersofdefaultparams
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e
Reviewed-on: https://gerrit.libreoffice.org/28451
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29 08:41:53 +00:00
Noel Grandin
a402785625 loplugin:countusersofdefaultparams in sfx2..svgio
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0
Reviewed-on: https://gerrit.libreoffice.org/27903
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05 11:56:06 +00:00
Noel Grandin
069d71b725 loplugin:countusersofdefaultparams in shell..starmath
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6
Reviewed-on: https://gerrit.libreoffice.org/27672
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01 06:05:58 +00:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27 06:48:25 +00:00
David Tardon
a0d3168ee4 tdf#97195 make diamond transition work again
Change-Id: I28236dd0c7dbd4e1798055229b2db2d0101a493e
2016-07-19 10:51:00 +02:00
Stephan Bergmann
9f994a9753 loplugin:staticmethods
Change-Id: If898ac15d958d4f0a5bcf0062a8d9869ef5e84e5
2016-07-11 16:35:22 +02:00
David Tardon
c726059adf tdf#97195 fix crash in diamond shape transition
The setScene() function was a hack from the beginning--it was only
introduced to avoid the need to override displaySlides_() in
DiamondTransition. And it worked until someone started to make false
assumptions about the scene, like that it is unchanging or that both
slides have the same (non-zero) number of elements...

Change-Id: I401cccc4dfbcba0a5f5544d3aac94d1cae027c99
2016-07-11 16:04:59 +02:00
Stephan Bergmann
7a0a0babf6 loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Iaeeb594821f8b2875ca08afdf62d442d33e186ba
2016-07-07 18:59:55 +02:00
Muhammet Kara
b6b34d5383 Clarify calculation precedence tdf#39440
Use parentheses to clarify the code.

Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc
Reviewed-on: https://gerrit.libreoffice.org/25677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-05 09:35:40 +00:00
Noel Grandin
48a8d6d843 loplugin:singlevalfields in various
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e
Reviewed-on: https://gerrit.libreoffice.org/26738
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28 11:21:17 +00:00
Mayank Gupta
16ddfa21d6 Slideshow: Add 'Oval' Shape Transition variant
Committer's note: There is no Oval or Ellipse transition in MSO formats,
so fallback to circle on export to those.

Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24
Reviewed-on: https://gerrit.libreoffice.org/23661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-10 12:14:40 +02:00
jan iversen
4bcb4774a3 Revert "Slideshow: Add 'Oval' Shape Transition variant"
The patch caused problems with the export filter tests, to check that you need to add --with-export-validation to your autopen.input 

see https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation for more info on how to set it up

This reverts commit 248c5ea771.

Change-Id: Ib3b8fa7bf80630feeca1f24dfb1ceb5a945d7162
Reviewed-on: https://gerrit.libreoffice.org/26114
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09 15:25:23 +00:00
Mayank Gupta
248c5ea771 Slideshow: Add 'Oval' Shape Transition variant
Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24
Reviewed-on: https://gerrit.libreoffice.org/23661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09 09:54:55 +00:00
Mark Page
22fa9289fd tdf#96099 Remove various smart pointer typedefs
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f
Reviewed-on: https://gerrit.libreoffice.org/26014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08 11:09:44 +00:00
David Tardon
66592cc3dd initialize the counter
Change-Id: I55c2a95a860dc814569b00c2edc9e135feb95bcd
2016-06-08 07:18:33 +02:00
Noel Grandin
8e8a88ec1a loplugin:unusedfields
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d
Reviewed-on: https://gerrit.libreoffice.org/25724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02 06:32:07 +00:00
Stephan Bergmann
5d78d488fd Can use boost::make_optional
...reportedly available since Boost 1.34, and configure.ac checks for at least
Boost 1.47.

Change-Id: I07952de220f1eee5f91ad83a1965420eb6b09ada
2016-06-01 17:19:49 +02:00
Noel Grandin
b0950b1578 Remove CycleMode enum
to never takes any value other than NORMAL

Change-Id: I9558ee8864537c695ce1172a0cfad421d5f591ee
Reviewed-on: https://gerrit.libreoffice.org/25587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30 06:35:15 +00:00
Noel Grandin
850a8d27ca Convert GRAPHIC to scoped enum
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27 12:59:23 +00:00