Noel Grandin
569c7da252
extract some common code for checking if a functions address was taken
...
Change-Id: I292b4e9bf17c83f83ff43ac4c5870d33092d0c71
2017-10-27 13:55:43 +02:00
Stephan Bergmann
5670f65cce
-Werror=unused-function
...
Change-Id: I2858c6cb74b96ffe6a799dc2ab02cbbe1c56abc7
2017-10-27 13:45:39 +02:00
Szymon Kłos
bb72ef2a15
ODP: export TextPreRotateAngle
...
Change-Id: I13eb005195ebbdee5016bf279cba423e388723a0
Reviewed-on: https://gerrit.libreoffice.org/43910
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com >
Tested-by: Szymon Kłos <szymon.klos@collabora.com >
2017-10-27 13:39:27 +02:00
Noel Grandin
1a6b373d99
use std::unique_ptr in SwUndoTransliterate
...
Change-Id: I4c3480104cbec53a395bd11702949984fca452a0
Reviewed-on: https://gerrit.libreoffice.org/43899
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-27 13:21:11 +02:00
Caolán McNamara
bbb104d70d
ofz#3830 Integer-overflow
...
Change-Id: Ia58552034aba32e9ecf00745d0cadc1e323c3c41
Reviewed-on: https://gerrit.libreoffice.org/43933
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 13:05:18 +02:00
Stephan Bergmann
dc38de4fc1
...and one more fix for DbusIpcThread,
...
switching back to a "Close" message-to-self without a response (as it had been
before dc3ff192f3
"Avoid further unwanted
interference of DbusIpcThread::execute/close"). Especially on a first start of
LO (where it restarts after creating the UserInstallation), it had been observed
that DbusIpcThread::close was blocked waiting on a reply in
dbus_connection_send_with_reply_and_block while DbusIpcThread::enable had
already successfully (i.e., without emitting any of the SAL_WARNs) proceeded
past sending the reply and was blocked on closeDone_.wait(). However that can
happen---it should be clear by now that I don't understand anything at all about
DBus. :(
Change-Id: Id5f368a60b2d8dd8b7074308ac1ad6b6545131ff
2017-10-27 12:44:40 +02:00
Michael Stahl
404208f23c
emfio: don't reinvent read_uInt16s_ToOUString
...
Change-Id: Ib12923762b5dd4d255c89a5acc54fdc5678a58ed
2017-10-27 12:37:46 +02:00
Michael Stahl
a3cb93b391
remove GetSwapFloat nonsense from all 3 EMF readers
...
SvStream::ReadFloat already does that, and SvStream is initialised
to SvStreamEndian::LITTLE by default.
Change-Id: I5859e43014533bcebef9d4b8f0678c516193b92e
2017-10-27 12:37:45 +02:00
Noel Grandin
39a2401807
use std::unique_ptr in SwLayouter
...
Change-Id: I5e43710da971957af9953930dea7e103644d3f17
Reviewed-on: https://gerrit.libreoffice.org/43898
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-27 12:37:58 +02:00
Caolán McNamara
7ee3953ce5
ofz#3819 Integer-overflow
...
Change-Id: Ic45692152b039c0ee2f5659d7739c3a2517c5e83
Reviewed-on: https://gerrit.libreoffice.org/43876
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 12:28:30 +02:00
Caolán McNamara
6b760dc4bb
ofz#3826 Divide-by-zero
...
with fLeftStart == 1.0 (is allowed, see comment at mfCut) the whole
BezierSegment is needed and does not need to be cut at all so best would be to
add it to 'while' loop, after that the 'rest' will be added anyways so, add
'fLeftStart < 1.0' or 'fLeftStart != 1.0' (since limited to [0.0 .. 1.0]) to
the while in line 120 should do it
Change-Id: Ida87e06247d169482df26e665985753e634e149e
Reviewed-on: https://gerrit.libreoffice.org/43935
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 12:15:52 +02:00
Caolán McNamara
1f0e40db86
ofz#3834 Divide-by-zero
...
Change-Id: I654152b964c6228efeb8b7cc7203064338fd1dd6
Reviewed-on: https://gerrit.libreoffice.org/43934
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 12:02:16 +02:00
Noel Grandin
ab60b88390
use std::unique_ptr in DocumentRedlineManager
...
Change-Id: Iba073b3a251827fefaba790e33dfc7c01b0b2154
Reviewed-on: https://gerrit.libreoffice.org/43897
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-27 11:05:37 +02:00
Stephan Bergmann
11cf64b730
Better fix for CppunitTest_services
...
...than 25313923b0
"Fix CppunitTest_services for
constructor-based implementations..." (which this commit reverts again). My
claim that "the 'factory' would be the object itself" is nonsense, it would
rather be an ImplementationWrapper (but one that was freshly created for each
ServiceManager::createContentEnumeration).
Change-Id: I85c683cff6f9ba78d0f8567a53f8fcbc56fe55cf
2017-10-27 10:37:26 +02:00
Noel Grandin
8136a87d9a
loplugin:constantparam was not always using canonical location for function
...
Change-Id: I8a15da534ba2cf9968cba0ee1f1bb74d7e3a0d54
2017-10-27 10:31:42 +02:00
Noel Grandin
8a39134d5c
no need to build the parent tree twice
...
lets just use the built in parents stuff
Change-Id: I7bb705acfcd6c8c18168676b0cdb13c26ba5b95a
2017-10-27 10:31:42 +02:00
Noel Grandin
5585bc2fbb
rename loplugin::Plugin::parentStmt
...
to getParentStmt and rename parentFunctionDecl to getParentFunctionDecl,
so I don't keep using accidentally naming my variables the same as the
functions.
Change-Id: I66f9452458c8b439e5132191ac5219fb6d420708
2017-10-27 10:31:42 +02:00
Caolán McNamara
13c26e565b
Updated core
...
Project: help 4df523054a84cbade8cf2aff4f72400baca9ca55
Related: tdf#113455 update help to 'disable' the spinbuttons for special case
now that there's a checkbox for the special 'clear' state rather than
special empty spin button hackery to store this state
Change-Id: I72756336a6c7fe68aec7efcf53e7b8dfb4c3d8d1
2017-10-27 10:02:24 +02:00
Caolán McNamara
005ad924ce
hwp fuzzing timeout
...
Change-Id: I88656c558dfe1ef6e701ba54633bfe251bc4e279
Reviewed-on: https://gerrit.libreoffice.org/43884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:57:55 +02:00
Caolán McNamara
e027d29568
coverity#1420315 Unchecked dynamic_cast
...
Change-Id: Ie522a0691ce269a4cc090057ddb54d8d0b1fa5e6
Reviewed-on: https://gerrit.libreoffice.org/43918
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:57:42 +02:00
Caolán McNamara
1b87cdadb8
support stock text in checkboxes and radiobuttons
...
Change-Id: I03b2e125736b7f8a7127174a7a837760f76f8249
Reviewed-on: https://gerrit.libreoffice.org/43893
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:57:27 +02:00
Caolán McNamara
bdd7c74a49
Resolves: tdf#113455 Impossible to clear width/height in pages
...
Change-Id: I88f80d417108822ceeb73c07cb49892925a2e57f
Reviewed-on: https://gerrit.libreoffice.org/43891
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:57:07 +02:00
Caolán McNamara
75c642dae3
coverity#1420317 Unchecked dynamic_cast
...
Change-Id: I33d065780ece2aab5f5a07d0dfd5493005a22b33
Reviewed-on: https://gerrit.libreoffice.org/43917
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:56:48 +02:00
Caolán McNamara
c15ac2c2ce
ofz#3813 Integer-overflow
...
Change-Id: Ibc14583137aae0d46e501927e602a510339abe38
Reviewed-on: https://gerrit.libreoffice.org/43872
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:56:29 +02:00
Caolán McNamara
85b698cbd3
ofz#3812 Divide-by-zero
...
Change-Id: I1a278302b995137d3e73620c003534498a59ba14
Reviewed-on: https://gerrit.libreoffice.org/43870
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:56:14 +02:00
Caolán McNamara
3fc4211a0f
ofz#3811 Integer-overflow
...
Change-Id: Ia08ac1ae46d4af6df7b0a590752e17a6d9a6836e
Reviewed-on: https://gerrit.libreoffice.org/43869
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-10-27 09:56:02 +02:00
Noel Grandin
8f3ca2e63b
tdf#113422 Crash in: ScPreview::MouseMove(MouseEvent const &)
...
regression from
commit 0ad8447d31
dyncolcontainer: convert nRight to std::vector
Change-Id: I9cdf80115a2be73ec2b30fd875a904de3333fddf
Reviewed-on: https://gerrit.libreoffice.org/43905
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-27 09:53:31 +02:00
Miklos Vajna
4f5ef1750b
sw: clean up temporary debug code in frmpaint
...
Change-Id: I1bdb332e40a2cf612b249dafa7620f700af19833
Reviewed-on: https://gerrit.libreoffice.org/43927
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2017-10-27 09:08:30 +02:00
Noel Grandin
ac8901d9d2
loplugin:finalclasses in sc
...
Change-Id: I83438eaf2c1045a9212a63ed9fd8b3371e9b06aa
Reviewed-on: https://gerrit.libreoffice.org/43896
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-27 08:53:23 +02:00
Noel Grandin
f5457c856f
Revert "use rtl::Reference in SwChartDataSequence"
...
This reverts commit cdd4b528a4
.
The manual acquire()/release() is necessary to prevent a double-delete
if the exception is thrown
Change-Id: I5acc0840befba3981e13b084b8d347f8a2766e70
Reviewed-on: https://gerrit.libreoffice.org/43889
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-27 08:53:15 +02:00
Mike Kaganski
9be47276cd
VisualStudioIntegrationGenerator: honor defines' values
...
Before this, -D_WIN32_WINNT=0x0601 used to land to VS project simply
as _WIN32_WINNT (without value).
Change-Id: I68ebdc24c3181c5d9e046280756e4cefee3de46c
Reviewed-on: https://gerrit.libreoffice.org/43928
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
Tested-by: Mike Kaganski <mike.kaganski@collabora.com >
2017-10-27 08:33:26 +02:00
Julien Nabet
eb9525a6ae
Replace lists by vectors in filtask (ucb)
...
Change-Id: I5b4359727ebf58bc121325d490e63f2c919dd7ab
Reviewed-on: https://gerrit.libreoffice.org/43921
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-10-27 07:41:10 +02:00
Andrea Gelmini
21fe5ef04d
Fix typos
...
Change-Id: I96f64b7c259f04a67684bb699ea3cc43b68e40fa
Reviewed-on: https://gerrit.libreoffice.org/43913
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-10-27 07:40:01 +02:00
Julien Nabet
98895a5fd2
Replace list by vector in ucbstore (ucb)
...
Change-Id: I1ff394ecd1fe805d671d666d8bc2522c33c40b50
Reviewed-on: https://gerrit.libreoffice.org/43922
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-10-27 07:14:58 +02:00
Eike Rathke
ba9f44d6ee
Implement LocaleData2, XLocaleData5, LocaleDataItem2, tdf#81671
...
Change-Id: Idba5a30bc44c7b2bd951f954ea3bfd048b022660
Reviewed-on: https://gerrit.libreoffice.org/43920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Eike Rathke <erack@redhat.com >
2017-10-27 03:06:22 +02:00
Thorsten Behrens
91987a559b
fix windows packaging
...
Change-Id: Id9e306877125b66f908d24048d236c55483330d0
Reviewed-on: https://gerrit.libreoffice.org/43916
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2017-10-26 23:44:21 +02:00
Mike Kaganski
55ad81533a
gbuild-to-ide: handle -U undefs correctly
...
Previously, defines string like this:
-DDBG_UTIL -DNOMINMAX -D_DLL -UNOMINMAX
would produce this defines list:
DBG_UTIL;NOMINMAX;_DLL -UNOMINMAX
where last "define" is incorrect; proper list should be
DBG_UTIL;_DLL
so that the undef'ed element would be properly eliminated from the
result. This patch takes care of this.
Change-Id: Ia66a1d6d0a6e0bbfd0022b22285b005609871336
Reviewed-on: https://gerrit.libreoffice.org/43923
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
Tested-by: Mike Kaganski <mike.kaganski@collabora.com >
2017-10-26 23:27:59 +02:00
Michael Stahl
dd35dccdf6
RepositoryExternal.mk: fix inverted gpg condition
...
(regression from 16598d526e
)
Change-Id: Ic621979926a9629aa8d8fb95a80957850ae0661b
2017-10-26 23:26:19 +02:00
Stephan Bergmann
6f065a7aff
Avoid undefined left shift of signed integer
...
...after 022b1b2a40
"tdf#96505 Get rid of cargo
cult long integer literals"
Change-Id: I9e5cc9d63c2eddd1ad766c2f6b01a9ff49a09bfd
2017-10-26 23:24:41 +02:00
Michael Stahl
11d2f3d6e1
vcl: make MapMode constructor explicit
...
Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().
Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26 23:17:45 +02:00
Michael Stahl
213f7c02d4
vcl: print MapMode
...
Change-Id: I3d4f15cd4929b553673f1a1d8950b6c9082a0cdc
2017-10-26 23:17:44 +02:00
Michael Stahl
ac07b5150d
tools: print some Fractions
...
Change-Id: Idc4668cba7412d0b4a3e486a8629c7f95a701091
2017-10-26 23:17:44 +02:00
Michael Stahl
230d05ea28
configure: JDK 1.3 won't work
...
Change-Id: Ibd26816cb00b3b8b2514aca536906b689c8cbd5e
2017-10-26 23:17:43 +02:00
Tor Lillqvist
8cd958a48e
Add a comment in CreateTableStyle() related to the AOO fix for #i120723#
...
Change-Id: Ic2eadf1942927efb6a6b209db591e869b61362f4
2017-10-26 23:34:04 +03:00
Tor Lillqvist
84eb42728a
Don't abbreviate "First" as "Fst"
...
Change-Id: I16726fbc8bf4f67fe1018d54437d59b715738bfe
2017-10-26 23:34:04 +03:00
David Tardon
cb0eb72ec4
blind attempt to fix build on big endian
...
Change-Id: I4dc2d5a5fbbded5f4c7a1417c150fe6b1a73a69d
2017-10-26 22:26:47 +02:00
Eike Rathke
4ef0497488
New decimalSeparatorAlternative, LocaleDataItem2, XLocaleData5, tdf#81671
...
... and LocaleData2 service, which is necessary with new-style
services because optional interface at published service is not
possible.
Change-Id: I77703243a961b5385eaea146e4c9c42d5f30e1ad
2017-10-26 21:35:04 +02:00
Stephan Bergmann
7cc8b8254f
Add test for o3tl::saturating_add
...
Change-Id: I19bb1d566bd80f859810b4023d965c8fd80b98f2
2017-10-26 21:30:08 +02:00
Stephan Bergmann
1061875d67
Make loplugin:implicitboolconversion find the same in C++17 and pre-C++17
...
...see a2d814ac1d
"loplugin:implicitboolconversion" and 24eeb4d286
"loplugin:implicitboolconversion" for things previously only found in C++17. As
expected, no further occurrences were found.
Change-Id: Id0ab621b82dc3c40c8b5801413fceb73ade1408a
2017-10-26 21:07:17 +02:00
Stephan Bergmann
e02e0f4081
Use compat::getSubExprAsWritten; clean up
...
Change-Id: I8f984c3b3833437f6b4d65ab99da608a6868ff74
2017-10-26 21:04:03 +02:00