Noel Grandin
602647c241
loplugin:unnecessaryvirtual
...
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6
Reviewed-on: https://gerrit.libreoffice.org/27981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-08 13:06:58 +00:00
Miklos Vajna
389d4d4142
sfx2: introduce SfxViewShell::GetViewShellId()
...
This is quite similar to SwFrame::GetFrameId(), i.e. it assigns a
numeric identifier to each instance to help debugging, as those
identifiers are stable accross runs.
Change-Id: I9cc57e316435f0284a1d481a956a703be859d67e
Reviewed-on: https://gerrit.libreoffice.org/27669
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29 11:39:22 +00:00
Noel Grandin
508c95f1b6
improve passstuffbyref return analysis
...
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27 06:48:25 +00:00
Noel Grandin
98c90acdfc
loplugins: more consistent naming of output files
...
Change-Id: Ia26f697cb16078f235c94e4cff449a60c1bbd74e
2016-07-25 13:23:10 +02:00
Noel Grandin
69dbf6f086
clang 3.8 does not seem to have EvaluateAsFloat
...
Change-Id: I0d846a2e9bc6db192cbf8f5dbce104c11ff409b4
2016-07-25 09:44:06 +02:00
Noel Grandin
62462664be
fix for overrideparam loplugin
...
Change-Id: Ibf4d3ffee0bfe335c479a15fcd183dfd8c207335
2016-07-25 09:20:24 +02:00
Noel Grandin
594dd232c8
loplugin:overrideparam enable checking that default values match
...
Change-Id: I4ca21d12d6f5dd4bb0b2705f7e36249082b0838c
2016-07-25 08:14:06 +02:00
Noel Grandin
938821fb08
new loplugin overrideparam
...
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.
Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25 06:09:17 +00:00
Noel Grandin
36313d93ac
improve unnecessaryoverride plugin
...
to ignore ImplicitCastExpr when calling superclass method
Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1
Reviewed-on: https://gerrit.libreoffice.org/27279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19 05:39:46 +00:00
Stephan Bergmann
e8b2fc7a92
Adapt to older Clang that don't have CompoundStmt::body_front
...
Change-Id: I41555c0a2b35ad950797f65e02ed1ee060c4bf0a
2016-07-18 11:46:41 +02:00
Stephan Bergmann
018e89337d
Improve loplugin:unnecessaryoverride
...
<sberg> thorsten, remember what that "TODO" in
SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly,
in a909acb7009acadffa53e74ea05ddb88803490f1 ?
<thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review
me'
<sberg> thorsten, OK, thanks (that override will eventually go away with
loplugin:unnecessaryoverride, and the TODO comment be lost)
Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac
Reviewed-on: https://gerrit.libreoffice.org/27232
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:08:07 +00:00
Noel Grandin
6e72f0251b
new loplugin unnecessary override
...
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:05:41 +00:00
Stephan Bergmann
ba94c97644
loplugin:cstylecast: Better heuristic...
...
to determine code shared between C and C++
Change-Id: I1fadf69bf9d0a2bde527b7c3f2ec4c687d70e4ae
2016-07-12 17:53:16 +02:00
Stephan Bergmann
a6060e02f7
Fix typo relase_ChildImpl -> release_ChildImpl
...
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
2016-07-12 15:57:36 +02:00
Noel Grandin
e12fbdd64b
only traverse the dtor's statements once
...
rather than twice, once implicitly from TraverseCXXDestructorDecl and
explicitly from VisitCXXDestructorDecl
Change-Id: I62a794faa530f2b54b82c86de0629afa28f30091
Reviewed-on: https://gerrit.libreoffice.org/27139
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12 09:33:30 +00:00
Noel Grandin
03fefeec99
new plugin constparams
...
very basic detection of pointer and reference params that can be const.
Off by default until the relevant changes have landed.
Change-Id: I88bba4e67307e3fb0e11dad252ec59c913828763
2016-07-12 10:54:43 +02:00
Noel Grandin
52b91f3454
new loplugin fragiledestructor
...
fix up a small number of places that it finds
Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4
Reviewed-on: https://gerrit.libreoffice.org/26566
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12 08:45:14 +00:00
Stephan Bergmann
3510a48794
loplugin:literaltoboolconversion: Better heuristic...
...
to determine code shared between C and C++
Change-Id: Ib1f3892b388ebd6a67cc88831a99dfb4ccdfbc2f
2016-07-11 21:30:34 +02:00
Stephan Bergmann
744c924754
Adapt to Clang 3.4 again
...
Change-Id: I33c1cee01593b06efca6e1aae283ce80d5cd77be
2016-07-11 18:09:55 +02:00
Stephan Bergmann
6f8d047519
loplugin:salbool: Better heuristic to determine code shared between C and C++
...
Change-Id: I09c9c57d5adeb665cc2508fad9727085a3289bfb
2016-07-11 16:32:28 +02:00
Stephan Bergmann
f541b99855
loplugin:nullptr: Better heuristic to determine code shared between C and C++
...
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-11 14:32:07 +02:00
Stephan Bergmann
9d80c032fe
loplugin:redundantcast: redundant static_casts
...
Change-Id: I4d50b77745d68a23136221ef06f327137e89fa7e
2016-07-08 16:47:31 +02:00
Stephan Bergmann
eba4f69a32
loplugin:passstuffbyref also for {css::uno,rtl}::Reference
...
Change-Id: I76cfdcd031430dc10c464896af2e79221e9da0c3
2016-07-07 18:59:55 +02:00
Noel Grandin
716844c6ab
restore loplugin:vclwidget checking for calling clear() on VclPtr fields
...
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405
Reviewed-on: https://gerrit.libreoffice.org/26806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-06 06:38:30 +00:00
Noel Grandin
7001ca25ec
merge LineProperties with chart::ErrorBar
...
Change-Id: Ic3490a15339ff981e90a86cb69c206c231db9161
Reviewed-on: https://gerrit.libreoffice.org/26932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 10:51:09 +00:00
Noel Grandin
64354e6479
merge BibTabPage with BibGeneralPage
...
Change-Id: I16a80e7e98fdd2be08b5a8ce586b709a3720e694
Reviewed-on: https://gerrit.libreoffice.org/26929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 09:44:26 +00:00
Noel Grandin
b9854c60c6
merge tdoc_ucp::OfficeDocumentsEventListener with
...
tdoc_ucp::ContentProvider
Change-Id: I4c743ce3d61d048ae9cf762462d9042337cd9d47
Reviewed-on: https://gerrit.libreoffice.org/26903
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 08:24:39 +00:00
Noel Grandin
add9a35ba6
merge CGMOutAct with CGMImpressOutAct
...
Change-Id: I4d3d59b6c34edef9cd5bfd460f6379e4d1afa460
Reviewed-on: https://gerrit.libreoffice.org/26930
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 08:24:18 +00:00
Noel Grandin
dac06d9cb0
merge svt::StoreString with svt::StoreContentURL
...
Change-Id: I6f2a7102c697cecc96e8b950b499bc9b0f91240e
Reviewed-on: https://gerrit.libreoffice.org/26904
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 06:32:27 +00:00
Noel Grandin
f81316af4f
merge sdr::event::EventHandler with sdr::event::TimerEventHandler
...
Change-Id: Id81c6b67d95d976dae417cf225bd43347c716d06
Reviewed-on: https://gerrit.libreoffice.org/26905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 12:55:14 +00:00
Noel Grandin
6964c17415
merge sfx2::IXmlIdRegistrySupplier with SfxObjectShell
...
Change-Id: I7e8bad6b1c944f14b850b91b902b82613c26faeb
Reviewed-on: https://gerrit.libreoffice.org/26899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 12:28:41 +00:00
Noel Grandin
c752aad433
merge vcl::DisplayConnectionDispatch with vcl::DisplayConnection
...
Change-Id: I0eb83905896e1d7549a5bd4adde45e9d69209401
Reviewed-on: https://gerrit.libreoffice.org/26888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 12:21:58 +00:00
Noel Grandin
3459ab4a5d
merge ftp::ResultSetFactory with ResultSetFactoryI
...
Change-Id: I061145fefef33aa3e7349adf7da03222c3b2a911
Reviewed-on: https://gerrit.libreoffice.org/26898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 10:58:42 +00:00
Noel Grandin
20b9cbd0e5
merge toolkit::NameContainer_Impl with toolkit::ScriptEventContainer
...
Change-Id: I14e9401056e31ee9d4ad5945a73ca31969430b4c
Reviewed-on: https://gerrit.libreoffice.org/26891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 10:55:08 +00:00
Stephan Bergmann
45129b0a20
loplugin:badstatics: new static only found with libc++
...
Change-Id: I93f12629fe6aa4bddae7379a5a7ac4f4c42c7923
2016-06-30 21:14:45 +02:00
Stephan Bergmann
2ea01fb900
loplugin:badstatics: further (Linux-only) static only found with libc++
...
Change-Id: I048212e3feb3f548d5a65940dd71ccb71cade778
2016-06-30 12:53:40 +02:00
Stephan Bergmann
944ed68645
Explain usage of -isystem instead of -I
...
Change-Id: Ib7153db5c2c1542ff7e9a0daa6d7124225c7701c
2016-06-30 09:27:58 +02:00
Stephan Bergmann
4d54e24026
Who needs that $(CLANGDIR)/tools/clang/include anyway?
...
It was included ever since 02a8d36ebf3d54784903f2899eafe010bedf2f4c "initial
support for clang compiler plugins" but will probably point at either a non-
existing dir or a dir in the Clang source tree (that does not even contain all
the include files that the corresponding installation dir would contain, as some
include files are generated during the build). For a properly installed LLVM/
Clang, all include files should be found underneath a single include/ dir.
Change-Id: Ie23cb1ae701eed1ee78448eb6c828d07b15121c2
2016-06-30 09:15:46 +02:00
Michael Stahl
11f69994b0
compilerplugins: -isystem /usr/include breaks the build
...
... on Fedora 24, and it's a Bad Idea in general because it breaks
"#include_next" ordering of GCC's and glibc's variously distributed
headers.
Change-Id: I0c8b51a6d7191ec9cc5187636ea2717e8fd97715
2016-06-29 22:37:22 +02:00
Stephan Bergmann
ded8e74df2
loplugin:badstatics: whitelist some more statics
...
...which use std containers and are only found at all with the libc++ container
implementations, not the libstdc++ ones.
Change-Id: Ic9af06139823befad4af1a9a825cba10c115aceb
2016-06-29 21:51:35 +02:00
Stephan Bergmann
8614502d73
Further clean-up
...
Change-Id: I884acbc85108f9cbd5e244c73a1f4c58a8c89613
2016-06-29 18:27:38 +02:00
Stephan Bergmann
a292402565
Further clean-up
...
Change-Id: I2b867a93fd8c5cf3c1e4f53863c441478d9201e1
2016-06-29 15:13:25 +02:00
Stephan Bergmann
ac265f6210
Further clean-up
...
Change-Id: I16b8bfe2c4a337acf188ec8ffa2ed084ca437faa
2016-06-29 11:38:22 +02:00
Stephan Bergmann
5d88bf766c
Further clean-up
...
Change-Id: Ice5fcb8f598b079afde3346f569d9619f1383506
2016-06-29 11:31:13 +02:00
Stephan Bergmann
1294013bf5
sc/source/core/tool/scmatrix.cxx no longer triggers this?
...
Change-Id: Ie8d18d66e89621f0cb4762ed5abfe2ec39788f72
2016-06-29 09:25:52 +02:00
Stephan Bergmann
733198de1b
Remove support for Clang < 3.4
...
Change-Id: I81e97c5f720535b33dd3ce72d01151765e4e93a0
2016-06-29 09:15:25 +02:00
Stephan Bergmann
1ce7176ba1
Remove support for Clang < 3.3
...
Change-Id: I185852a738bac10dc6d331afccfcbc7ae1225cb1
2016-06-29 08:55:27 +02:00
Stephan Bergmann
6439d93cbe
typo
...
Change-Id: I31053ae472f74eaf3a86159a273424174329d0bd
2016-06-29 08:54:33 +02:00
Stephan Bergmann
94cba04b33
Further clean-up
...
Change-Id: Id07b37629eb2a0b6d33297bffcf86d41c5d6fbe2
2016-06-29 07:31:26 +02:00
Stephan Bergmann
0d3f9667bb
AllocatorTraits::size can be static after all
...
Change-Id: If9ce8a094af878497e980cdcfaf11604d613e5b8
2016-06-28 22:38:57 +02:00