698 Commits

Author SHA1 Message Date
Stephan Bergmann
f94d4952dc Commit loplugin:returnunique to store/, for reference
Change-Id: I359d8ab47276e5c801522251d5e141946d94ca5d
2015-10-06 12:44:37 +02:00
Noel Grandin
7e776c0027 loplugin:unusedmethods
Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
2015-10-06 10:17:02 +02:00
Noel Grandin
8a248d69cc loplugin:mergeclasses
in this case, just rename the baseclass so that it matches the
other places we do this

Change-Id: I21704db7352f72e43636dde9e92c8bef61b7e251
2015-10-06 09:26:14 +02:00
Noel Grandin
946b9a04c4 loplugin:mergeclasses
and move the boost-depending code inside the module, no need to expose
that dependency and include that header in all client code.

Change-Id: Ib991572d7a54a9ad16825d688e76f8e3a824803c
2015-10-06 08:41:58 +02:00
Noel Grandin
d451de7f08 loplugin:mergeclasses
Change-Id: I592eef7503bd0b492f73ea5216f436302ad79ca8
2015-10-06 08:41:58 +02:00
Noel Grandin
4e2a8b78be loplugin:mergeclasses
Change-Id: I7c8c60aab31517d595a7e37c3789fa1e515ec3ee
2015-10-06 08:41:58 +02:00
Noel Grandin
58aea3f36c loplugin:unusedmethods
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 10:43:24 +00:00
Andrea Gelmini
ce343470c3 Fix typos
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea
Reviewed-on: https://gerrit.libreoffice.org/18941
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:00:18 +00:00
Noel Grandin
34180700b2 loplugin:removeunusedmethods, remove unused stuff
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
Stephan Bergmann
e710170d90 Avoid ambiguity with C++14 std::make_unique
Change-Id: I81b8bed175527bab02ffdd2fa17fa6a66c243d95
2015-09-29 15:04:21 +02:00
Daniel Robertson
ef779d339e tdf#94389 compilerplugins: clang 3.7.0
Fix errors that occur in build with clang 3.7.0

Change-Id: I0e8743f2b6a288d10b4e78e884ce34cfca4dd77c
Reviewed-on: https://gerrit.libreoffice.org/18738
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-21 13:53:47 +00:00
Noel Grandin
c542679e72 move mergeclasses loplugin result file to compilerplugins/
to keep it out of the top-level folder

Change-Id: I4bb95b8ae856462e9638f43fde1553e49dd31cc9
2015-09-08 13:10:05 +02:00
Noel Grandin
d7efea29cd new loplugin mergeclasses
Idea from Norbert (shm_get) - look for classes that are
(a) not instantiated
(b) have zero or one subclasses
and warn about them - would allow us to remove a bunch of abstract
classes that can be merged into one class and simplified

Change-Id: I4e43fdd2f549b5cbe25dcb7cee5e9dd3c1df8ba0
2015-09-08 08:09:26 +02:00
Stephan Bergmann
37a6fdf890 loplugin:stringconstant also for cases using char const v[] = "..."
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-09-03 09:34:00 +02:00
Stephan Bergmann
3286c6c854 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I0d1c988aad308435542dbd381fcf6bf7e1af6290
2015-08-31 14:39:13 +02:00
Stephan Bergmann
7c473eb789 Enable loplugin:defaultparams
Change-Id: Ie0a17569d1216816fd6357cd2ba1e125d2172408
2015-08-21 18:07:36 +02:00
Noel Grandin
d163e206a7 loplugin:cstylecast, put the CastKind info back
Change-Id: Ia438d3a383cdc6c0343fa116488730a130f634af
2015-08-21 10:33:08 +02:00
Noel Grandin
54f1a882cc fix my previous change to cstylecast loplugin
in commit 5a58e809fceada72cecc389588bcd792eb3d8105

Change-Id: I43c7fa9dda04a11a9a6424b461b3915da968fe27
2015-08-21 10:24:30 +02:00
Noel Grandin
5a58e809fc loplugin:cstylecast
and improve the error message in the plugin

Change-Id: I8719832a48e14c132f463340fbbc537845f82b0b
2015-08-20 10:26:24 +02:00
Noel Grandin
fb2ad7ce2d new loplugin automem
find places where we should be using std::unique_ptr

Change-Id: I5b9defe778fdc4738ecea381215396874db59e66
2015-08-20 09:55:43 +02:00
Stephan Bergmann
65aa35fbee Don't trigger assert in clang::ParmVarDecl::getDefaultArg
Change-Id: Ica385b513d87d639496ac470da296e871b093ab4
2015-08-14 13:18:56 +02:00
Noel Grandin
48c4810edf defaultparams loplugin should be off by default for now
Change-Id: If432f002804678a80963b02e57eba8d314a6f34c
2015-08-14 12:03:39 +02:00
Noel Grandin
8601307838 loplugin: defaultparams
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
2015-08-14 10:52:46 +02:00
Noel Grandin
4712396b3b loplugin: defaultparams
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-11 09:48:17 +02:00
Noel Grandin
9d307abeec new loplugin: defaultparams
find places where we do not need to be passing a parameter to a
function, because that function has a default value which matches the
value we are passing.

Change-Id: I04d1fd6275204dd4925e6563282464f461123632
2015-08-11 08:25:33 +02:00
Noel Grandin
9c1f700aff improve refcounting loplugin to check SvRef-based classes
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883
Reviewed-on: https://gerrit.libreoffice.org/17521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 11:26:04 +00:00
Noel Grandin
403c13487c loplugin:unusedmethods
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 09:39:22 +00:00
Stephan Bergmann
1caec42837 -Werror,-Wunused-parameter
Change-Id: Iede9204bf93014e757c4fdf4a8363a90b7577dbc
2015-08-04 10:34:50 +02:00
Noel Grandin
3d5dc80b07 fix crash in refcounting plugin
introduced by commit c15b4cf39a74176cee64795129d76f411d2c0a69
"Adapt to current Clang trunk towards 3.7"

Change-Id: I00f58d3bc79e641df9bba4e9b1d5c8463b87dc42
2015-08-04 10:25:48 +02:00
Stephan Bergmann
b9d0fe1cec Workaround for libc++
Change-Id: Iee5243231d695299609ca31741f6da2d517f524f
2015-08-04 09:39:36 +02:00
Stephan Bergmann
a2052db259 Workaround for ObjCIvarDecl problem
Change-Id: I7eb0fccce4b8268e5d9559b2eb12778d0d288c6b
2015-08-04 09:38:44 +02:00
Stephan Bergmann
c15b4cf39a Adapt to current Clang trunk towards 3.7
Change-Id: Ibb2c641d49a1773be789c9259f53a040db6f605f
2015-08-04 09:36:32 +02:00
Noel Grandin
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
Noel Grandin
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
Noel Grandin
38023af6c1 loplugin:unusedmethods
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a
Reviewed-on: https://gerrit.libreoffice.org/17312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24 10:36:20 +00:00
Noel Grandin
96d44c9b07 loplugin:unusedmethods sc
Change-Id: I7bdb1889a942d63370731764a58f4ab524dedd8a
Reviewed-on: https://gerrit.libreoffice.org/17287
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22 13:02:57 +00:00
Noel Grandin
407731c9f4 loplugin:unusedmethods sw
Change-Id: Ied51535fa169451fc4991237122817a34a59f6fe
Reviewed-on: https://gerrit.libreoffice.org/17256
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 13:30:13 +00:00
Noel Grandin
f3872352b3 fix my previous commit
Change-Id: I287d99a46eda90718a3c4ec2c92f7b063babeb24
2015-07-21 14:43:01 +02:00
Noel Grandin
07645b443a workaround clang-3.5 issue in unusedmethods loplugin
Change-Id: Ie67518536932e24e9cff7a8b75b42e90e9f67673
2015-07-21 14:39:35 +02:00
Noel Grandin
3d2f43438d loplugin:unusedmethods sd
Change-Id: I9b5399ace50db3259df2e619f28ae547a38e6c6d
Reviewed-on: https://gerrit.libreoffice.org/17254
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 09:05:41 +00:00
Noel Grandin
6ea66657eb loplugin:unusedmethods writerfilter
Change-Id: I52441115e14da6c1bcd7ba4926a0f3cc0620366e
Reviewed-on: https://gerrit.libreoffice.org/17236
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 07:58:51 +00:00
Noel Grandin
c714b43b01 loplugin:unusedmethods oox
Change-Id: I5381e0da0efc1f951e248cfcfb35fc680ace94e4
Reviewed-on: https://gerrit.libreoffice.org/17225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 06:50:55 +00:00
Noel Grandin
e103bf6cfd loplugin:unusedmethods dbaccess
Change-Id: Ifa16acc6d90ebd4f56c5662959010f6228228cb5
Reviewed-on: https://gerrit.libreoffice.org/17209
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 11:56:11 +00:00
Noel Grandin
600ed089e2 loplugin:unusedmethods sfx2
Change-Id: I40be06a4859a38ef64b6267515917f625a5f176d
2015-07-20 10:57:07 +02:00
Noel Grandin
9f4f237a38 loplugin:unusedmethods svl
Change-Id: If86cc43fda4d138cf7f678d81fa2b35f68f3c03b
Reviewed-on: https://gerrit.libreoffice.org/17162
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 06:33:44 +00:00
Noel Grandin
0f732c41bc loplugin:unusedmethods lotuswordpro
Change-Id: I17927d48a75c332f1ddc3853145b14daac17f9c0
2015-07-17 11:50:06 +02:00
Noel Grandin
89ef4dea32 loplugin:unusedmethods cui
Change-Id: I8a4cb855054c487d7a8307ad219f10b06db3248b
2015-07-17 10:36:50 +02:00
Noel Grandin
5a7bf1b32c loplugin:unusedmethods slideshow
Change-Id: I66b6cddb638a9fc1228d3ea9df5d112300a00eb3
Reviewed-on: https://gerrit.libreoffice.org/17128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 06:49:23 +00:00
Noel Grandin
4ca2cf1b7e loplugin:unusedmethods sfx2
Change-Id: I98c455d89f76fbcacf74929a4e8775b4da697f62
Reviewed-on: https://gerrit.libreoffice.org/17069
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16 05:47:52 +00:00
Noel Grandin
82da70787a loplugin:unusedmethods connectivity
Change-Id: Ie9f3daa49b02dddc7b56d1f5fb58a229f53d4513
Reviewed-on: https://gerrit.libreoffice.org/17043
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 07:45:23 +00:00