mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
398,949 Commits 1 Branch 0 Tags
Commit Graph

789 Commits

Author SHA1 Message Date
Noel Grandin
c4cd079b8f loplugin:unusedmethods in sc..vcl 
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8
Reviewed-on: https://gerrit.libreoffice.org/29183
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-22 18:56:58 +00:00
Noel Grandin
1c15a20df8 loplugin:unusedmethods unused returns 
Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30
Reviewed-on: https://gerrit.libreoffice.org/29178
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-22 13:13:05 +00:00
Noel Grandin
fd22e36ff5 loplugin:unnecessaryvirtual 
Change-Id: I7b1aa65a557f3855939ad8b183bba8ff656946f8
Reviewed-on: https://gerrit.libreoffice.org/29173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-22 12:44:50 +00:00
Stephan Bergmann
4c70a1a666 Check harder whether file is really under WORKDIR 
1977b57bc9aaea71252358fa502110c348153c70 "vcl: loplugin:override" had only hit
in out-of-tree builds, where the #include in the generated
workdir/CustomTarget/vcl/unx/kde4/tst_exclude_socket_notifiers.moc is an
absolute path.  For in-tree builds, the generated #include line is
"../../../../../vcl/unx/kde4/tst_exclude_socket_notifiers.hxx", so the returned
getFileName() is .../workdir/../../../../../vcl/..., so was erroneously
considered to be under WORKDIR.

Change-Id: I9abef04b90ecb4921087a53ff196b833940085e5
 2016-09-22 08:50:43 +02:00
Noel Grandin
b18e1bc61c loplugin:unusedfields 
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24
Reviewed-on: https://gerrit.libreoffice.org/29078
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-20 10:45:14 +00:00
Stephan Bergmann
075489b4b8 Adapt loplugin:dllprivate to DISABLE_DYNLOADING 
Change-Id: I721cfeaa144c773ead457e1c9138009d4071a06a
 2016-09-20 10:31:21 +02:00
Noel Grandin
1658bd231b loplugin:unusedenumvalues 
Change-Id: I9dcc9f73af6db5b4f7cc946bc28931e5c230b34c
Reviewed-on: https://gerrit.libreoffice.org/29012
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-19 10:44:05 +00:00
Noel Grandin
e592877844 loplugin:unusedenumvalues 
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b
Reviewed-on: https://gerrit.libreoffice.org/28942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-18 11:02:45 +00:00
Noel Grandin
a2b77b4368 loplugin:singlevalfields in basic..idl 
Also fix obvious bug in the initialisation of the
connectivity::odbc::OConnection::m_bClosed field.
Probably closes some kind of connection leak there.

Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82
Reviewed-on: https://gerrit.libreoffice.org/28932
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-16 08:30:26 +00:00
Noel Grandin
96e9ffa647 loplogin:singlevalfields in include/ 
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc
Reviewed-on: https://gerrit.libreoffice.org/28931
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-16 06:19:38 +00:00
Noel Grandin
309b65a092 Some of our supported compilers don't do constexpr, which means 
o3tl::typed_flags can't be 'static const'

Change-Id: Ia2e40353f7a1b9e66617fa42f9eed6213f9e2d62
 2016-09-15 13:02:24 +02:00
Noel Grandin
27be818190 loplugin:singlevalfields in l10ntools..sax 
and ignore URE headers in the plugin

Change-Id: I939df744c1173cf0f67d515f6c3fb4ac4cb25588
 2016-09-15 13:02:24 +02:00
Noel Grandin
3b48b3cc92 loplugin:singlevalfields in sc..vcl 
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
 2016-09-15 11:30:42 +02:00
Noel Grandin
c3c4ae5fda use split() to simplify loplugin python code 
Change-Id: Ib6d7acf54ca6c12a3b096435f8a621244df88b4f
 2016-09-15 08:51:14 +02:00
Noel Grandin
6df2c90c08 loplugin:countusersofdefaultparams in vcl 
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979
Reviewed-on: https://gerrit.libreoffice.org/28891
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-15 06:35:33 +00:00
Noel Grandin
20a9e101d9 loplugin:constantparam 
clean up the plugin a little, and try to catch params which are default
constructed, which doesn't seem to be working yet

Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12
Reviewed-on: https://gerrit.libreoffice.org/28861
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 08:47:06 +00:00
Stephan Bergmann
a53808c0ed loplugin:dllprivate 
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
 2016-09-13 22:26:22 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
25e4e9694c handle nullptr in various clang plugins 
since we are using it so widely now, instead of NULL

Change-Id: I990ff1334f657663e8791ab064d69e56636fe6e7
 2016-09-12 08:22:03 +02:00
Noel Grandin
b1164b07f9 loplugin:constantparam in sd 
Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c
Reviewed-on: https://gerrit.libreoffice.org/28774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-10 11:28:16 +00:00
Stephan Bergmann
31dc693029 loplugin:refcounting: No more special-handling of SvXMLImportContext 
...after 32ccb4ea863651c22bf33cc15012971d2a2d2810 "resolve the snafu with 2
separate refcounted bases"

Change-Id: Iaf13deb0b83b6dfe1a2cf3863e07cf042c8e4f47
 2016-09-09 09:46:39 +02:00
Noel Grandin
d2143eacaf teach loplugin constantparam about default param values 
Change-Id: I334622bd34d8349f5b3988122d282b1062b225bb
 2016-09-06 12:59:13 +02:00
Noel Grandin
d69066115c improve loplugin:countusersofdefaultparams to check constructors 
and their call sites

Change-Id: Ie068cfe2a8f7c3887d38f186a5e91b0cfdcad236
 2016-09-06 12:56:45 +02:00
Maxim Monastirsky
671ac3a922 Looks like the menu highlight handler is now unused 
Change-Id: I75ff4bce35e7940e07b760f672e08ffe0dd208f8
Reviewed-on: https://gerrit.libreoffice.org/28580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2016-09-01 09:39:52 +00:00
Stephan Bergmann
c5d8cb41a5 loplugin:stringconstant: adapt to improved OUStringLiteral1 
Change-Id: I5c9bfbb97f0eabe1ea691faf522d22070243d234
 2016-08-30 15:30:36 +02:00
Stephan Bergmann
bdd60f1f5e Adapt loplugin:stringconstant to improved OUStringLiteral1 
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0
Reviewed-on: https://gerrit.libreoffice.org/28447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-08-29 11:44:44 +00:00
Stephan Bergmann
2c10714426 Make OUStringLiteral1 a wrapper around UTF-16 instead of just ASCII 
...not merely an ASCII character

Change-Id: Id2b381b35fe3a15574728ed973d60263dfef7249
Reviewed-on: https://gerrit.libreoffice.org/28446
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-08-29 11:44:31 +00:00
Noel Grandin
86c0ce4d46 loplugin:countusersofdefaultparams 
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e
Reviewed-on: https://gerrit.libreoffice.org/28451
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-29 08:41:53 +00:00
Stephan Bergmann
28cb2c1764 loplugin:refcounting: also cover temporaries being directly stack managed 
Change-Id: Ib0f7c60df1d2fba0d4d9d3fa6faf3bb97867ebc0
 2016-08-26 12:40:43 +02:00
Stephan Bergmann
6a1bebcc89 Remove wrong check through template args from containsXInterfaceSubclass 
...that was probably only there as a workaround for cases (equally wrongly)
covered by the check for !hasAnyDependentBase in isDerivedFrom.  And the latter
appears to no longer be necessary, probably because the cases it happened to
cover intentionally are now covered correctly through some other logic that got
added to this plugin meanwhile.

Change-Id: Ife6370b4f966198fc731813afe62d765450382e6
 2016-08-26 12:36:12 +02:00
Stephan Bergmann
e3e66f7b07 Minor improvements of loplugin:staticaccess 
Change-Id: I731aab418fb42922208afdaa60d98ccd76377dab
 2016-08-26 12:35:24 +02:00
Stephan Bergmann
6810f00d09 loplugin:staticaccess: Extend loplugin:staticcall to cover all access... 
to static members (data, in addition to function) via class member access
syntax.  Also covers the (somewhat obscure) access to enumerator members.

Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
 2016-08-25 17:16:14 +02:00
Noel Grandin
b8064bdf7f new loplugin: countusersofdefaultparams 
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04
Reviewed-on: https://gerrit.libreoffice.org/28353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-25 06:37:42 +00:00
Stephan Bergmann
fb21736979 Move loplugin:returnbyref to store 
...it complains about

  SbxValues * data() { return &aData; }

(include/basic/sbxvar.hxx) returning by pointer rather than reference, but I see
nothing wrong with that.

Change-Id: I1e65ed47322d3b52d0e34a8233f146af86e209f3
 2016-08-21 21:20:40 +02:00
Noel Grandin
95be297746 loplugin:unusedenumvalues in sw 
Change-Id: Ia5faa65cd7824183cead2634edab96b5d23a6c02
Reviewed-on: https://gerrit.libreoffice.org/28072
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-17 06:43:45 +00:00
Stephan Bergmann
63d94a6c50 Fix check for aMinusSign in chart2/inc/SpecialUnicodes.hxx 
Change-Id: I15e344874d90cc38acb219e7c07579d68af89043
 2016-08-16 09:16:55 +02:00
Noel Grandin
127f70d66a new loplugin to check for static OUStrings 
that are better declared as OUStringLiteral

Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567
Reviewed-on: https://gerrit.libreoffice.org/27377
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-16 06:30:09 +00:00
Noel Grandin
d30a4298bd loplugin:unusedenumconstants in package..svtools 
Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172
Reviewed-on: https://gerrit.libreoffice.org/28052
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-12 06:58:39 +00:00
Noel Grandin
045879b557 new loplugin unusedenumvalues 
Change-Id: I2efcb0332cca23bd53088121b4cbfc702011d0b9
 2016-08-11 13:03:54 +02:00
Noel Grandin
3716b14426 loplugin:constantparam 
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886
Reviewed-on: https://gerrit.libreoffice.org/28016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-11 06:05:32 +00:00
Noel Grandin
e5d24f50b7 clang3.9 compatibility 
Change-Id: Idbba88f1a890c068c9813aff2287f0983d1b8742
 2016-08-10 13:02:02 +02:00
Noel Grandin
602647c241 loplugin:unnecessaryvirtual 
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6
Reviewed-on: https://gerrit.libreoffice.org/27981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-08 13:06:58 +00:00
Miklos Vajna
389d4d4142 sfx2: introduce SfxViewShell::GetViewShellId() 
This is quite similar to SwFrame::GetFrameId(), i.e. it assigns a
numeric identifier to each instance to help debugging, as those
identifiers are stable accross runs.

Change-Id: I9cc57e316435f0284a1d481a956a703be859d67e
Reviewed-on: https://gerrit.libreoffice.org/27669
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-07-29 11:39:22 +00:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Noel Grandin
98c90acdfc loplugins: more consistent naming of output files 
Change-Id: Ia26f697cb16078f235c94e4cff449a60c1bbd74e
 2016-07-25 13:23:10 +02:00
Noel Grandin
69dbf6f086 clang 3.8 does not seem to have EvaluateAsFloat 
Change-Id: I0d846a2e9bc6db192cbf8f5dbce104c11ff409b4
 2016-07-25 09:44:06 +02:00
Noel Grandin
62462664be fix for overrideparam loplugin 
Change-Id: Ibf4d3ffee0bfe335c479a15fcd183dfd8c207335
 2016-07-25 09:20:24 +02:00
Noel Grandin
594dd232c8 loplugin:overrideparam enable checking that default values match 
Change-Id: I4ca21d12d6f5dd4bb0b2705f7e36249082b0838c
 2016-07-25 08:14:06 +02:00
Noel Grandin
938821fb08 new loplugin overrideparam 
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-25 06:09:17 +00:00
Noel Grandin
36313d93ac improve unnecessaryoverride plugin 
to ignore ImplicitCastExpr when calling superclass method

Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1
Reviewed-on: https://gerrit.libreoffice.org/27279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-19 05:39:46 +00:00