mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
409,907 Commits 1 Branch 0 Tags
66d19e8f6acda6de9300d86cb15edd2dd5f7228f
Commit Graph

130 Commits

Author SHA1 Message Date
Stephan Bergmann
e9bae752fe ChooseMacro rMacroDesc parameter is unused 
...ever since 49751c8765 "INTEGRATION: CWS tbe11"

Change-Id: I038616f5e69bbf1fa04c2fff3ca63e381549aa89
 2017-06-28 17:15:36 +02:00
Caolán McNamara
5ba99a8055 drop IDE_RESSTR 
Change-Id: Iee1479d472d224bdf19890bbac29d9eeb4e3d00d
 2017-05-17 21:08:15 +01:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Tor Lillqvist
013d9789c7 Drop :: prefix from std in [a-b]*/ 
Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd
Reviewed-on: https://gerrit.libreoffice.org/34320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 21:50:23 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Mike Kaganski
450762b224 tdf#68118: Pass current document frame to SvxScriptSelectorDialog 
... through MacroChooser
Without this, current document's macros library is unavailable in
"Assign" dialog

Change-Id: I83baa3b98858260eab61e8f4fefde3f9979c6d83
Reviewed-on: https://gerrit.libreoffice.org/30600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-11-14 08:56:42 +00:00
Noel Grandin
78b4a1fb01 update vclwidget loplugin to find ref-dropping assigment 
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.

Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9
Reviewed-on: https://gerrit.libreoffice.org/30749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-11 06:55:41 +00:00
Jacek Fraczek
f004aa9951 tdf#89307: Removed SvRef::operator T*() 
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-10 08:48:30 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros 
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
 2016-10-05 07:56:12 +02:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly 
since...

commit ba81e5c6bd
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
 2016-07-26 11:26:52 +01:00
Arnold Dumas
aee49860ee tdf#100726: Improve readability of OUString concatenations 
Change-Id: I7018f3c339ffcab7d46d97f1d3784da1be644f0a
Reviewed-on: https://gerrit.libreoffice.org/26870
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-04 10:24:30 +00:00
Noel Grandin
f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Stephan Bergmann
4b0a3da4c5 loplugin:nullptr (automatic rewrite) 
Change-Id: I27f1d5ee55338372b1c24187b63d23ae39e0a8b3
 2015-11-10 10:31:16 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar 
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-09 08:34:40 +00:00
Caolán McNamara
3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Stephan Bergmann
d8160fa834 Revert overly aggressive removal of include statements 
...from 4758ab313d "Removed useless includes in
basctl/source/basicide/ tree"

Change-Id: I754b964baf4c8a48f6ca79d6a214bab1f3325b6d
 2015-09-13 22:17:46 +02:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed 
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
 2015-08-28 09:49:56 +02:00
Noel Grandin
9072c5c855 convert SbxFlagsBits to scoped enum 
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
 2015-07-28 08:35:34 +02:00
Caolán McNamara
9a36ba20c5 coverity#1308514 Uncaught exception 
Change-Id: I62d3d390ff9d1a44d8704b41ef62fff5d532bcc4
 2015-06-28 17:55:49 +01:00
Julien Nabet
b226928c6d cppcheck: redundantCondition [part1] 
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
 2015-06-14 12:17:55 +02:00
Noel Grandin
e0b2e6e3f7 loplugin:loopvartoosmall 
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
 2015-05-29 08:48:41 +02:00
Philippe Jung
1379e2feaa Rewrite all calls like Dialog(params).Execute() 
Replace all calls looking like
  ADialog(some params).Execute()
by
  ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()

Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-28 08:44:31 +00:00
Stephan Bergmann
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK... 
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
 2015-05-10 11:25:47 +02:00
Stephan Bergmann
4a760a8d0b Replace IMPL_STATIC_LINK[_TYPED] with more useful variants 
Change-Id: Ic59c2c9079dce37ad76b6a1396a719d372253674
 2015-05-10 11:25:42 +02:00
Stephan Bergmann
e6c08b6b30 Remove unnecessary STATIC_LINK macro 
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
 2015-04-29 18:29:59 +02:00
Noel Grandin
d320bc8a6f calling static member function through member call syntax 
Change-Id: I29e8faa03f668a7471b47e7aca3c2400f034c3b6
 2015-04-14 15:14:36 +02:00
Michael Meeks
e985155bc5 Misc. other fixing. 
Change-Id: Iffdb9951daaf38489f6b788e07d9b14256459fd4
 2015-04-10 19:33:50 +01:00
Michael Meeks
cf13f78703 Lost more cleanup and fixing post re-basing. 
Change-Id: Ia5317b93484d31af978a5276bc6697848130225d
 2015-04-10 18:36:40 +01:00
Noel Grandin
3bf4ada33f dialogs lifetimes should be wrapped in ScopedVclPtr 
Change-Id: Ica8467af599fb3f9313bfa916fec8b7792a6000f
 2015-04-10 15:51:48 +02:00
Michael Meeks
8a65284fe3 Automated conversion of VclPtr construction to use Instance template. 
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
 2015-04-10 13:40:25 +01:00
Noel Grandin
61b224f392 vclwidget: fixup locally allocated vcl::Window objects 
They need to be wrapped in ScopedVclPtr in order to be disposed properly.

Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
 2015-04-10 12:37:44 +01:00
Noel Grandin
6d0c89123f vclwidget: fix more places that should be wrapping in VclPtr 
Change-Id: I31c9115662da2f81e1b22be91ee58e2862076b8e
 2015-04-10 11:40:50 +01:00
Noel Grandin
00f2787a4a vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtr 
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133

Conflicts:
	sw/qa/tiledrendering/tiledrendering.cxx
 2015-04-09 22:17:00 +01:00
Noel Grandin
4e6410ba01 loplugin:constantfunction: unotools 
Change-Id: Icf543973dc9edde270016c8af7e4c08c57eff650
 2015-03-19 10:45:00 +02:00
Caolán McNamara
938caeaf58 cppcheck: cstyleCast 
Change-Id: I3a1aaafe30f13f2eb388f7db3d78ecafaf0a4a2d
 2015-03-09 16:27:47 +00:00
Michael Weghorn
3338f47918 reduce scope of local variables 
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9
Reviewed-on: https://gerrit.libreoffice.org/13330
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-08 08:01:58 +00:00
Andrea Gelmini
4758ab313d Removed useless includes in basctl/source/basicide/ tree 
It compiles on Windows and Linux, here, with flags:
   --with-help --with-java --with-lang="it"
Made with the ignorant brute force of removing each include
one by one.
The tree with each commit (used to bisect) it's here:
https://github.com/Gelma/core/commits/gr_push_brute_force_slot_2

Conflicts:
	basctl/source/basicide/bastype2.cxx

Change-Id: If88eebb6ecba6ae7ab1e98713b66b10f1ad57dca
Reviewed-on: https://gerrit.libreoffice.org/12963
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-12-05 09:12:26 +00:00
Noel Grandin
50a8c89f36 loplugin: cstylecast 
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
 2014-10-23 12:36:14 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Caolán McNamara
a107bdfdfc ErrorBox->MessageDialog 
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
 2014-08-18 10:57:21 +01:00
Caolán McNamara
2d4c90e82e coverity#736990 Uncaught exception 
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
 2014-04-25 20:19:11 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
aef614d093 auto_ptr -> scoped_ptr 
Change-Id: I19fbc4f6e0fb0d53a72759e5faf9c86c595e8e17
 2014-02-07 18:43:31 +01:00
Norbert Thiebaud
cde4fdb2d0 basctl: include <> for external includes 
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
 2013-11-11 22:37:25 -06:00
Noel Grandin
9a5997374f convert basctl module from String to OUString 
Change-Id: Iac38d4fd5d1d8b5c305bbb20eb1b40a7c7dec9bf
 2013-10-01 10:08:40 +02:00
Caolán McNamara
81202ae748 Related: fdo#38838 remove UniString::CompareIgnoreCaseToAscii 
Change-Id: I4a9b34d63d2534a35aa9a878b8c2bec15262c2be
 2013-09-22 20:32:02 +01:00
Noel Grandin
6f2adb1a04 convert basctl/source/inc/basobj.hxx from String to OUString 
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
 2013-09-17 09:06:16 +02:00
Caolán McNamara
5efc15f000 reduce use of UniString from ResID ctor 
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
 2013-07-28 16:45:48 +01:00
Noel Power
61027ca6eb improve performance switching modules in large Libraries fdo#66148 
object catalog when updated, updates ( all ) entries and was parsing
the source for every method in every module

Change-Id: Id68e3c24d597d29a86d3507a7dc20745c96dd2a2
 2013-06-27 16:39:09 +01:00