Commit Graph

24 Commits

Author SHA1 Message Date
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-14 10:24:47 +02:00
Noel Grandin
48b8898bd7 clang-tidy performance-unnecessary-value-param in basctl
Change-Id: Ie48eb08edd1335661d1ef57ae652713143951317
2016-04-12 12:05:01 +02:00
Noel Grandin
9cde33eba1 com::sun::star->css in basctl
Change-Id: If0013cdd734a58397ab4972f9cca5584f05d1715
Reviewed-on: https://gerrit.libreoffice.org/17164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 14:17:13 +00:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Caolán McNamara
c622304965 V813: Decreased performance
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-03-04 00:51:57 +00:00
Noel Grandin
248145f99e Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14 08:10:22 +00:00
Thomas Arnhold
5973c2d34a fixincludeguards.sh: basctl 2014-04-19 11:10:07 +02:00
Ricardo Montania
b596ce9bb1 OUString cleanup finished in basctl
Change-Id: I6d18f5cde7866828ca95ccff702eb86d2e40c58d
Reviewed-on: https://gerrit.libreoffice.org/925
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2012-10-27 15:48:27 +00:00
Uray M. János
81f72a3c3a Cleanup in basctl (raw pointers)
Lots of raw pointers have been converted to boost::scoped_ptr to reduce
the number of 'delete's and the possibility of memory leaks.
Some pointers have been converted to references, to reduce the needless
checking for nullptrs, and so simplifying the code.
Also some #define-s have been converted to C++ constants or enumerations.

Change-Id: Ifbeb78f744bac7a96c8a446ff4db90dedf85fe26
2012-09-07 11:20:48 +02:00
Uray M. János
c20f15c1eb Basic IDE: namespace basctl
Now all names in basctl are in namespace 'basctl'.
There were lots of names that included the word 'Basic' or 'BasicIDE' in
it, e.g. BasicIDEData, BasicDocumentEntry, BasicTreeListBox,
BasicIDEModule, IDEBaseWindow etc. This information is now stored in the
namespace name, so the names could be shortened: basctl::DocumentEntry,
basctl::TreeListBox, basctl::Module, basctl::BaseWindow etc.
Some other minor changes:
* LibInfos, LibInfoItem, LibInfoKey ->
  LibInfos, LibInfos::Item, LibInfos::Key
* The header guards are now uniformly BASCTL_FILENAME_HXX, instead of
  e.g. _FILENAME_HXX, which is undefined behaviour because of the '_'.
* namespace BasicIDE, BasicIDEGlobals, basicide -> namespace basctl
* BASICIDE_TYPE_MODULE, ... -> basctl::TYPE_MODULE, ...

Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b
Reviewed-on: https://gerrit.libreoffice.org/501
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2012-08-29 20:48:28 +00:00
Michael Meeks
39669162e0 re-base on ALv2 code. 2012-06-12 17:03:23 +01:00
August Sodora
a82a873150 String->OUString 2011-11-28 22:17:15 -05:00
August Sodora
3d7bc23e23 Remove last include of tools/string.hxx in basctl 2011-11-08 13:38:52 +00:00
August Sodora
e505b16440 Remove superfluous includes and forward decls 2011-11-07 12:55:26 +00:00
Caolán McNamara
b77940e5af add modelines to .hxx files as well 2010-10-28 15:48:02 +01:00
Jens-Heiner Rechtien
36de66bdf0 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm
eab612ef62 INTEGRATION: CWS changefileheader (1.8.54); FILE MERGED
2008/04/01 10:47:48 thb 1.8.54.2: #i85898# Stripping all external header guards
2008/03/28 16:05:06 rt 1.8.54.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:12:28 +00:00
Jens-Heiner Rechtien
2634b5627c INTEGRATION: CWS ab34 (1.6.20); FILE MERGED
2007/07/24 14:02:47 ab 1.6.20.3: RESYNC: (1.6-1.7); FILE MERGED
Solved conflict
2007/07/24 13:04:58 ab 1.6.20.2: #i77072# Removed conflicts with m222
2007/07/24 10:17:26 ab 1.6.20.1: #i77072# Drag & Drop support in Dialog Organizer
2007-08-03 09:00:15 +00:00
Jens-Heiner Rechtien
cb8911c85e INTEGRATION: CWS ab35 (1.6.8); FILE MERGED
2007/05/21 09:28:22 ab 1.6.8.1: #i77640# Single Dialog Export
2007-06-26 15:53:22 +00:00
Oliver Bolte
642f6fa7c0 INTEGRATION: CWS basmgr02 (1.5.2); FILE MERGED
2007/02/21 09:33:04 fs 1.5.2.1: #i73331# encapsulate (nearly) all usages of SfxObjectShell in the ScriptDocument class
2007-03-15 15:02:52 +00:00
Rüdiger Timm
8311e19303 #i74038# Extra qualification removed from 'resetResourceForDialog'. 2007-02-01 07:25:03 +00:00
Rüdiger Timm
51f9e342c5 INTEGRATION: CWS ab32 (1.2.6); FILE MERGED
2007/01/18 13:52:59 ab 1.2.6.2: #i73077# Rename Resource IDs according to renamed dialog/control
2007/01/18 07:38:37 ab 1.2.6.1: #i73053# Clipboard support for dialog resources
2007-01-29 15:53:04 +00:00
Vladimir Glazounov
71d0b29433 INTEGRATION: CWS pj71 (1.2.12); FILE MERGED
2007/01/10 09:37:47 pjanik 1.2.12.1: #i73295#: Remove extra qualification. Patch from Maho.
2007-01-18 13:18:59 +00:00
Jens-Heiner Rechtien
974a1dfe24 INTEGRATION: CWS ab31 (1.1.2); FILE ADDED
2006/12/18 15:40:20 ab 1.1.2.5: #i72282# Save and reset current locale before/after Basic run
2006/12/15 14:01:59 ab 1.1.2.4: #i72282# New method LocalizationMgr::handleTranslationbar()
2006/12/13 18:38:48 pb 1.1.2.3: fix: #i72282# forward SfxObjectShell
2006/12/13 11:17:17 ab 1.1.2.2: #i72282# Delete resources for deleted controls
2006/12/13 08:50:17 ab 1.1.2.1: #i72282# class LocalizationMgr
2007-01-02 14:52:27 +00:00