mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
409,907 Commits 1 Branch 0 Tags
66d19e8f6acda6de9300d86cb15edd2dd5f7228f
Commit Graph

1767 Commits

Author SHA1 Message Date
Noel Grandin
5e028ad5dc simplify some string handling in tracing calls 
Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3
Reviewed-on: https://gerrit.libreoffice.org/39159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 14:38:14 +02:00
Noel Grandin
19f3b88c1e loplugin:oncevar chart2 
Change-Id: I2dd0939db440b5357225395e88680dd0b0fdbf43
Reviewed-on: https://gerrit.libreoffice.org/38970
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 07:51:22 +02:00
Jochen Nitschke
a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Michael Stahl
3f405b1af3 configure: remove --enable-directx 
This used to require extra SDKs in days of yore but now just always build
those libraries on WNT.

Change-Id: I92c0a35917df42e136c022c762f0333f657a9ec6
 2017-06-16 16:56:42 +02:00
Stephan Bergmann
841d8a6093 loplugin:redundantcast (clang-cl) 
Change-Id: Ic61ed0cb1d64b27abe0007e28c7b261de3ab7114
 2017-06-02 10:35:29 +02:00
Noel Grandin
0b2f1292b3 loplugin:comparisonwithconstant in chart2 
Change-Id: I95787007b26cdcf0d5d1617ecd0e55d377b551d7
Reviewed-on: https://gerrit.libreoffice.org/37941
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-23 11:22:08 +02:00
Noel Grandin
fd00bd0f69 loplugin:unusedfields 
make it a little smarter in dealing with fields that are smart pointers

Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11
Reviewed-on: https://gerrit.libreoffice.org/37751
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-19 09:17:06 +02:00
Stephan Bergmann
52ef15cbdb Revert "Fix typos" 
This reverts commit 26a67002fc.  "Iff" is not a
typo, see 2a65bf32ec "Revert 'Typo: iff->if'".
 2017-05-18 21:58:31 +02:00
Andrea Gelmini
26a67002fc Fix typos 
Only replaced "iff" with "if"

Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581
Reviewed-on: https://gerrit.libreoffice.org/37782
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2017-05-18 18:55:17 +02:00
Noel Grandin
6df22f0ec5 loplugin:checkunusedparams various 
Change-Id: I5d1cc807134230d86e0226a12fada204004312d3
Reviewed-on: https://gerrit.libreoffice.org/37675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-16 14:20:27 +02:00
Jochen Nitschke
959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Chris Sherlock
97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock
b8fc5aee3c tdf#43157: convert most of canvas codebase away from OSL_ASSERT to assert 
Change-Id: Ie6a5942dcac62a0bc3b589ff0b82922b313f88a8
 2017-05-07 09:37:20 +10:00
David Ostrovsky
de030cd7a2 gbuild: Remove MSVC 2013 legacy code 
Uwinapi is discontinued.

Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01
Reviewed-on: https://gerrit.libreoffice.org/23198
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
 2017-04-21 18:18:44 +02:00
Stephan Bergmann
071dcb5f6a loplugin:redundantinline (clang-cl) 
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430
Reviewed-on: https://gerrit.libreoffice.org/36063
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-04-04 12:06:18 +00:00
Miklos Vajna
a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle 
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-03-31 06:27:11 +00:00
Andrea Gelmini
5262883672 Fix typos 
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e
Reviewed-on: https://gerrit.libreoffice.org/35617
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-25 08:43:01 +00:00
Stephan Bergmann
6291574d94 Remove unused #include <ctype.h> 
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
 2017-03-23 17:55:31 +01:00
Stephan Bergmann
0f49fdd70e Remove unused #include <cctype> 
Change-Id: I9c61e1b558104fa55d887a6c32e1ef2b03f1d1a0
 2017-03-23 15:22:46 +01:00
Noel Grandin
ed76d1d350 loplugins:redundantcast teach it about c-style typedef casts 
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-23 09:48:10 +00:00
Caolán McNamara
376ae93f48 ofz#887 support avoiding reading config 
Change-Id: Ic7e0e65b15c7b6a01a10d6004230ad71a2d439d2
 2017-03-17 21:27:44 +00:00
Miklos Vajna
a6209ba6a8 vcl: OutputDevice::GetGlyphBoundRects()'s nIndex and nBase is always the same 
So keeping just nIndex is enough.

Change-Id: I5d3a0e6b4a6ce1305a56cf50e7ff181a098f6412
Reviewed-on: https://gerrit.libreoffice.org/35336
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-03-17 20:18:46 +00:00
Stephan Bergmann
4084d5dd5b loplugin:unoany (clang-cl) 
Change-Id: I14351561764811562a2c2904b6f7db6148e55c9b
 2017-03-14 14:40:50 +01:00
Andrea Gelmini
6fab286b2a Fix typos 
Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524
Reviewed-on: https://gerrit.libreoffice.org/34808
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-03 07:42:39 +00:00
Noel Grandin
198c41c4fe new loplugin unoany 
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-28 10:17:47 +00:00
Stephan Bergmann
3ef509a1d9 loplugin:loopvartoosmall 
Change-Id: I4dce711021557e6e0b1fb661285d32292b0478b6
 2017-02-26 21:58:10 +01:00
Noel Grandin
58f75fb66a drop ModulationMode enum 
since we only ever use the MODULE_NONE enumerator

Change-Id: Icd075bb01b5938dbd75b901521d084ddd6469963
 2017-02-17 07:57:52 +02:00
Noel Grandin
51d474abdb drop cairocanvas::ColorType enum 
since we only use the one enumerator value

Change-Id: Ifec39f4845348c753a6207795c62b27a7af1bbcd
 2017-02-17 07:57:52 +02:00
Tor Lillqvist
6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Andrea Gelmini
417bc89880 Fix typos 
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c
Reviewed-on: https://gerrit.libreoffice.org/34199
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
 2017-02-13 09:37:18 +00:00
Noel Grandin
65b7b6322b loplugin:unusedenumconstants read-only constants in vcl 
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2
Reviewed-on: https://gerrit.libreoffice.org/34018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-08 12:42:52 +00:00
Noel Grandin
8a16f665b1 makeAny->Any in canvas..configmgr 
Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e
Reviewed-on: https://gerrit.libreoffice.org/33869
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 10:44:01 +00:00
Tor Lillqvist
385c207e3a tdf#105620: Probably better to not ignore initial x0 and y0 
So add to them instead of just assigning. In the bugdoc the initial
values were zero, but maybe in some other cases they aren't.

Change-Id: I3d399fe4aab9260817f171d4e69388a19eb85d21
 2017-02-01 14:16:07 +02:00
Tor Lillqvist
b220bc6d82 tdf#105620: Fix placement of image embedded in graphic 
Change-Id: I419e44d72f594fab0774152720f55c1d7d5366e6
Reviewed-on: https://gerrit.libreoffice.org/33723
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-01 11:43:30 +00:00
Noel Grandin
0681a6ee28 more SAL_WARN_UNUSED 
Change-Id: Idf44fe0302b4504c443f083e527b63b2461ada85
 2017-01-31 14:05:11 +02:00
Noel Grandin
1c3e84d819 teach lolugin:stringconstant about calling constructors 
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
   Foo(OUString("xxx"), 1)

Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-31 08:56:20 +00:00
Tor Lillqvist
93a49ee2a2 Drop meaningless forward declaration 
Change-Id: I29e09ad50e8adb2c5dd99014872be9c3f0fdcdbd
 2017-01-30 13:14:09 +02:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor.. 
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-28 09:22:55 +00:00
Tor Lillqvist
5b2f40d918 Fix comments to match reality 
Change-Id: I99b49a3c8472b063316baeebdaa89119832a2a1b
 2017-01-27 12:10:27 +02:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Aron Budea
bb50474225 tdf#100151: Dispose of window if DX device creation failed 
Before, if the device lacked Direct3D capabilities, VclPtr
handling became compromised, and caused a crash. This was
particularly a problem in virtualized/remote desktop
connections in Windows.

Now mpWindow instance is disposed of right away if DX
device creation fails.

Change-Id: I639340380affdb31a93ce6dccd8df33a0a466df6
Reviewed-on: https://gerrit.libreoffice.org/33413
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-01-23 17:44:19 +00:00
Stephan Bergmann
f22e5db80b loplugin:externvar (clang-cl) 
Change-Id: Ied0ee5f637e83fe7819c68e3f4ea4634f21ac3f6
 2017-01-11 13:42:39 +01:00
Stephan Bergmann
6f710c79e2 New loplugin:externvar: canvas 
Change-Id: If11977a086dd7bd7d76782577db619fd272e814c
 2017-01-09 15:44:18 +01:00
Stephan Bergmann
c38aa3b734 loplugin:salbool 
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
 2017-01-06 11:19:42 +01:00
Khaled Hosny
d538d3d841 This fallback code makes no sense any more 
Ito probably made sense only with bitmap fonts which we no longer
support, and if we don’t need the fallback for printer devices then we
don’t need it on screen either (that whole printer/screen distinction
needs to die someday).

Change-Id: Icf77cd70f0f1b2c186a3c856900295caba72e903
Reviewed-on: https://gerrit.libreoffice.org/31914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
 2016-12-14 00:28:15 +00:00
Caolán McNamara
48b561c770 post glew->epoxy, we don't need to link to win openg32 and mac OpenGL 
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed
Reviewed-on: https://gerrit.libreoffice.org/31954
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-12-13 21:01:48 +00:00
Caolán McNamara
482d7ce61b change from glew to epoxy 
because that works under wayland out of the box and gtk3 uses it already

Change-Id: Iefaac31e325534a81a5389f752804af917c1baef
Reviewed-on: https://gerrit.libreoffice.org/31213
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-12-13 11:33:18 +00:00
Noel Grandin
3a705ab405 OSL_TRACE->SAL in avmedia..canvas 
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
 2016-12-13 08:14:00 +02:00
Noel Grandin
d6f2dd831a remove useless Mutex guards 
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-12 09:16:09 +00:00
Arnaud Versini
4282ea67c2 canvas: remove useless MutexGuards 
Change-Id: I7a6f55ad7f3a26a88263660b97dd8650858890f8
Reviewed-on: https://gerrit.libreoffice.org/31859
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-11 18:55:07 +00:00