Commit Graph

21 Commits

Author SHA1 Message Date
Olivier Hallot
b9d0d608b0 Fix screenshot missing quotes in code snippet
The code snippet suggested has no quotes in atttributes values.

Change-Id: I604fb34827da3bebf3f6759b491d719a96854754
Reviewed-on: https://gerrit.libreoffice.org/38893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-19 15:24:15 +02:00
Caolán McNamara
2155e04d63 make string translation loading more uniform
change various ResId classes that use conversion operator to OUString to
functions that return a OUString

drop various defines

drop unnecessary toString calls

Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92
Reviewed-on: https://gerrit.libreoffice.org/37817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19 15:40:40 +02:00
Tor Lillqvist
6de3688cc6 Drop :: prefix from std in c*/
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-15 23:01:23 +00:00
Noel Grandin
2d48f5fc0a convert VCLEVENT constants to scoped enum
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07 07:10:39 +00:00
Katarina Behrens
7ac70669da screenshotannotation: Trim the textfield, add scrollbar
to prevent it from growing too large and thus distorting the dialog

Change-Id: Iaa27d3085ec314246565cae79ab7d627a94a3bff
Reviewed-on: https://gerrit.libreoffice.org/30898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-16 12:36:58 +00:00
Katarina Behrens
2a83720fd1 screenshotannotation: Fix bookmark snippets
Change-Id: I245000b48775955dcf72f362829df7594e8b637b
Reviewed-on: https://gerrit.libreoffice.org/30880
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-16 09:26:52 +00:00
Katarina Behrens
81f6384a50 screenshotannotation: include image size in XML markup
Change-Id: I1c02055280b929ddd3ad12e6f6562c95bfe2a48a
Reviewed-on: https://gerrit.libreoffice.org/30870
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-15 20:08:49 +00:00
Katarina Behrens
fab262f115 screenshot annotation: More readable markup
this should placate clang too

Change-Id: Ida2cceebd5870b5896fb125e51e4cb67ad253d92
2016-10-25 11:26:49 +02:00
Katarina Behrens
ae3fb69ebc screenshot annotation: put back removed fields
I hate you loplugin !!!

Change-Id: I01067b04005a59b7ecb10a5a72ab6090b7f040a8
2016-10-25 11:26:49 +02:00
Katarina Behrens
dcbfb99fc5 screenshot annotation: insert markup for annotated widgets
Change-Id: I82b8c541239271e3acfa6d8ad45b752fa1554931
2016-10-25 11:26:48 +02:00
Katarina Behrens
3298e8b8ec screenshot annotation: Display markup for embedding the image
Change-Id: I06fd744fabd66ee02123790718a899d9e0dcb6b7
2016-10-25 11:26:48 +02:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
Noel Grandin
b18e1bc61c loplugin:unusedfields
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24
Reviewed-on: https://gerrit.libreoffice.org/29078
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20 10:45:14 +00:00
Julien Nabet
aaea58f490 cppcheck: redundantIfRemove
Change-Id: I8576c5042265399de6d9c72ffd67bce0fb256923
Reviewed-on: https://gerrit.libreoffice.org/28661
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-04 09:59:17 +00:00
Stephan Bergmann
9e00f6d70c loplugin:vclwidgets
Change-Id: Icce2f463d9263de4c0e40b38600677dbe74d83b3
2016-08-29 09:16:02 +02:00
Stephan Bergmann
31714a78eb loplugin:unreffun
Change-Id: If65f8ef5accad8d6317b07938ec97c7b129763b5
2016-08-29 07:48:10 +02:00
Jochen Nitschke
854dfdc944 loplugin:salbool
Change-Id: Icfc96f978a0fd73ceadbe3a4d57b9758e244ff2b
Reviewed-on: https://gerrit.libreoffice.org/28436
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28 12:55:22 +00:00
Jochen Nitschke
bf7a7d6d10 loplugin:implicitboolconversion
Change-Id: I6fa51f65e75ca84f746ff5d1c7dcf97a5225d2d2
Reviewed-on: https://gerrit.libreoffice.org/28435
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28 12:55:01 +00:00
Jochen Nitschke
0140d931e1 loplugin:defaultparams
Change-Id: I9e6b81855e421186af92e53c71f5ba9bd8005319
Reviewed-on: https://gerrit.libreoffice.org/28433
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28 10:04:31 +00:00
Armin Le Grand
c665e7f630 screenshot: fixup some details for screenshot dlg
Edge-rounding and linewidth for selection/cursor, default
filename for save dialog. Code cosmetics.

Change-Id: I8a76d68f4f3070458ec4ba51a81bb046057218ab
2016-08-28 00:32:50 +02:00
Armin Le Grand
e2d26860f9 screenshot: added functionality to dialog
Moved code to cui, added abstraction for AbstractDialog,
adapted rendering, changed selection, added better selection
visualization, added save ressources and dialog, creating
pure screenshot with annotation display

Change-Id: I533d9f559ee17cd46105b934bcf4beef87b96168
2016-08-28 00:32:50 +02:00