mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
409,907 Commits 1 Branch 0 Tags
66d19e8f6acda6de9300d86cb15edd2dd5f7228f
Commit Graph

128 Commits

Author SHA1 Message Date
Noel Grandin
27fa7eff1d loplugin:oncevar in cui 
Change-Id: I1bbd37a82f238327b5e52110c62cdd2a9b0a9c14
Reviewed-on: https://gerrit.libreoffice.org/39001
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 10:40:56 +02:00
Jochen Nitschke
a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Jochen Nitschke
febbad7263 cleanup unused css/frame/* includes 
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 13:05:38 +02:00
Noel Grandin
17a2c9e8e2 clang-tidy performance-unnecessary-value-param 
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-05 09:22:51 +02:00
Stephan Bergmann
1649c76401 loplugin:stringcopy: cui 
Change-Id: I5166036e4173292c9a7291a1a846e661fbbcd010
 2017-05-19 17:18:38 +02:00
Caolán McNamara
2155e04d63 make string translation loading more uniform 
change various ResId classes that use conversion operator to OUString to
functions that return a OUString

drop various defines

drop unnecessary toString calls

Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92
Reviewed-on: https://gerrit.libreoffice.org/37817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-05-19 15:40:40 +02:00
Caolán McNamara
cda860a8c9 can drop CUI_RESSTR now 
Change-Id: I2e2319e661614dc8ba464479324b4719bcfa120e
 2017-05-18 09:25:33 +01:00
Noel Grandin
389da66dfc remove unused uno::Reference vars 
found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:56:01 +02:00
Maxim Monastirsky
e4d7511d7e tdf#106681 Styles category for the Add Commands dialog 
Change-Id: I7332967863697d3ad68a533b9fc603de2fdc87ef
Reviewed-on: https://gerrit.libreoffice.org/37422
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
 2017-05-09 11:22:56 +02:00
Caolán McNamara
d7559de4f7 remove bitmaps from .src files 
and into includeable .hlst files, add them to
postprocess/CustomTarget_images.mk
to continue only including used bitmaps in icon-theme zips

Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e
Reviewed-on: https://gerrit.libreoffice.org/36941
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-04-25 17:02:15 +02:00
Noel Grandin
48e83f7be2 makeAny->Any in cppuhelper..cui 
Change-Id: Ia54e6e9b71df68bd04c304a0bb02da8ebac74420
Reviewed-on: https://gerrit.libreoffice.org/34603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-24 09:17:34 +00:00
Stephan Bergmann
6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Caolán McNamara
74b92741b8 b*, c*: load BitmapEx resources instead of Image ones 
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
 2017-01-16 11:45:35 +00:00
Noel Grandin
6b8ee3c9ba convert VclButtonsType to scoped enum 
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
 2016-12-21 16:19:37 +00:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox 
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:12:00 +00:00
Jochen Nitschke
0c6c37cb01 cleanup unused includes (related to tdf#88206) 
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx

compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only
implbase*.hxx stuff is used.

Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995
Reviewed-on: https://gerrit.libreoffice.org/31686
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-06 18:17:06 +00:00
Stephan Bergmann
d2615f96ac Improve some error reporting 
Change-Id: Ibfdb0eeebec785438d46a0e8e6e9f4c847bfb807
 2016-11-02 10:33:49 +01:00
Noel Grandin
eca5ea9f79 make the AbstractDialog stuff extend from VclReferenceBase 
Because some stuff wants to multiple-inherit from VclAbstractDialog and
OutputDevice-subclasses, and we'd prefer to keep all the lifetime
management through a single smart pointer class (VclPtr)

The change in msgbox.cxx and window.cxx is to workaround a bug in
VS2013 to do with virtual inheritance and delegating constructors.

Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773
Reviewed-on: https://gerrit.libreoffice.org/29140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-27 06:08:30 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros 
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
 2016-10-05 07:56:12 +02:00
Noel Grandin
a2b77b4368 loplugin:singlevalfields in basic..idl 
Also fix obvious bug in the initialisation of the
connectivity::odbc::OConnection::m_bClosed field.
Probably closes some kind of connection leak there.

Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82
Reviewed-on: https://gerrit.libreoffice.org/28932
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-16 08:30:26 +00:00
Noel Grandin
1e49e33c26 loplugin:constantparam in chart2..connectivity 
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 06:40:30 +00:00
nadith
bd4c80b856 tdf#100726: Improve readability of OUString concatenation 
module cui and dbaccess fixed

Change-Id: Ief6fca46622fe4e0da804c9a874f7ec93a0fd7af
Reviewed-on: https://gerrit.libreoffice.org/27770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-04 09:34:11 +00:00
Noel Grandin
b860b73f2b Convert VCL_MESSAGE to scoped enum 
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933
Reviewed-on: https://gerrit.libreoffice.org/25720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-01 06:46:29 +00:00
Noel Grandin
c47b170c71 Convert SelectionMode to scoped enum 
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1
Reviewed-on: https://gerrit.libreoffice.org/25611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-30 06:41:28 +00:00
Noel Grandin
d4d2fc2479 clang-tidy modernize-make-unique 
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b
Reviewed-on: https://gerrit.libreoffice.org/25138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 08:33:10 +00:00
Caolán McNamara
71c4a2b761 mpDefDialogParent is not used since 2002 
i.e.

commit c0ae87cb5f
Author: Stephan Schäfer <ssa@openoffice.org>
Date:   Tue Oct 22 08:39:05 2002 +0000

    #103442# choose DefDialogParent on-the-fly

and so calling SetDefDialogParent doesn't achieve anything

Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
 2016-05-12 10:09:26 +01:00
Jochen Nitschke
4054901d69 cppcheck: silence known condition warning in cui 
Change-Id: I8dfe3aa3c133ebb8ab6de058ae8335513bfb3f3b
Reviewed-on: https://gerrit.libreoffice.org/24199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-18 15:55:37 +00:00
Stephan Bergmann
8274655443 Remove empty scriptdlg.hrc 
Change-Id: I4a4bf1aa1d6afe819c22288474be302fe95740d1
 2016-04-12 15:50:24 +02:00
Noel Grandin
f520af1735 clang-tidy performance-unnecessary-value-param in cui 
Change-Id: I93a09bf8e475ec1aa2ebf7754c7048c81696922b
 2016-04-12 11:25:18 +02:00
Stephan Bergmann
b58d56c510 loplugin:nullptr (automatic rewrite) 
Change-Id: I7257532b90e3e393d56d5349531c9ad397523bca
 2015-11-10 10:31:22 +01:00
Caolán McNamara
22b80ac8e2 boost->std 
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-14 12:54:25 +00:00
Noel Grandin
61623d5b90 convert Link<> to typed 
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
 2015-09-08 08:16:46 +02:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed 
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
 2015-08-28 09:49:56 +02:00
Noel Grandin
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void> 
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
 2015-08-26 11:15:35 +02:00
Noel Grandin
4c6d1a2636 loplugin: defaultparams 
Change-Id: I81537289a40bdc30bd8d896dc5364f0989205e39
 2015-08-14 10:52:46 +02:00
Noel Grandin
0c5f72b06f com::sun::star->css in cui 
Change-Id: I70ee15db7c8de507fa21a9dfc705f518f223a70b
Reviewed-on: https://gerrit.libreoffice.org/17385
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-29 06:45:22 +00:00
Noel Grandin
7d6d18e74a convert INPUTMODE_ constants to scoped enum 
Change-Id: Ib2e37bb320c1edba7246a6611df3b89b764346db
 2015-07-28 08:35:35 +02:00
Stephan Bergmann
5456d59651 loplugin:simplifybool 
Change-Id: Idab14666c3ffdc6c1a20e14bd1a7745a844468a1
 2015-07-16 14:00:16 +02:00
Stephan Bergmann
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK... 
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
 2015-05-10 11:25:47 +02:00
Michael Meeks
cf6bfd6668 tdf#91052 - use macros to standardize 'make' constructors for VclBuilder. 
When complete - should ease the switch to VclPtr<>::Create.

Change-Id: Idf876e2eeb830b36dd86e84317277cc88e1dc013
 2015-05-09 20:37:54 +01:00
Stephan Bergmann
5eb6bd4db7 lopluign:staticmethods: Handle DECL_LINK 
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
 2015-05-08 19:15:32 +02:00
Michael Meeks
6fd3e56090 Catch another erroneous 'make' constructor function. 
Change-Id: I4a674b44bce1f3c3f5c3de2639863ff4b4fcd41e
 2015-05-07 16:13:51 +01:00
Stephan Bergmann
3ead3ad52f Gradually typed Link 
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
 2015-04-30 10:20:00 +02:00
Michael Meeks
354df32a6d cui: convert new to ::Create. 
Change-Id: Ifad69772a4954f14772cca9eeae913e546eff477
 2015-04-18 21:58:58 +01:00
Noel Grandin
7a1fad0d4f convert ScopedVclPtr to ScopedVclPtrInstance 
Change-Id: I22a9d9c313a81ccee885b9c8785d4b008a6f2058
 2015-04-10 16:13:34 +02:00
Noel Grandin
3bf4ada33f dialogs lifetimes should be wrapped in ScopedVclPtr 
Change-Id: Ica8467af599fb3f9313bfa916fec8b7792a6000f
 2015-04-10 15:51:48 +02:00
Michael Meeks
8a65284fe3 Automated conversion of VclPtr construction to use Instance template. 
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
 2015-04-10 13:40:25 +01:00
Michael Meeks
5d133eb621 first half of non-scriptable, Instance constructor conversion. 
Change-Id: If73bb41bfa805e22609748f25971724b4778edb3
 2015-04-10 13:27:16 +01:00
Noel Grandin
61b224f392 vclwidget: fixup locally allocated vcl::Window objects 
They need to be wrapped in ScopedVclPtr in order to be disposed properly.

Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
 2015-04-10 12:37:44 +01:00
Noel Grandin
0556598b35 vclwidget: check for calling delete on subclasses of vcl::Window 
Change-Id: I7fb7cf919e3f46dd03a18b1cb95fa881915f9642
 2015-04-10 11:59:25 +01:00