Stephan Bergmann
c63bf22b21
eFunc is unused
...
...ever since the code's introduction with
dab7a6e9f5
"INTEGRATION: CWS insight01"
Change-Id: Id9cd9c365a802dd9b67c1dfb297007c2b8ebc0bc
2017-07-02 22:07:30 +02:00
Tor Lillqvist
601aadd016
loplugin:oncevar in the !HAVE_FEATURE_JAVA case
...
Change-Id: I77807b409ec4db3215160d4c123c186738e9b162
2017-06-30 23:57:06 +03:00
Noel Grandin
497e40ad03
improve refcounting loplugin
...
to find ref-counted classes being managed via other smart pointer
classes.
Hopefully prevent needing fixes like
642ae256ea
"ChangedUIEventListener is refcounted, mustn't be helt by unique_ptr"
Change-Id: I6b0c5f8f87ce3546a8a1104ce1000470c09459bd
Reviewed-on: https://gerrit.libreoffice.org/39378
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-29 09:35:30 +02:00
Stephan Bergmann
5f53dfc505
-Werror=ignored-qualifiers (GCC 8)
...
Change-Id: Ie7fa59f573791fca0530294ef5a5e0863e1285b1
2017-06-28 10:57:32 +02:00
Andrea Gelmini
ec5f7d8134
Fix typo
...
To complete commit 3f3181522b
Change-Id: Ia6784899e39be6822577e3b8d5f4082ed765fd5e
Reviewed-on: https://gerrit.libreoffice.org/39271
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-06-27 13:15:49 +02:00
Noel Grandin
3f3181522b
s/catched/caught
...
Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264
Reviewed-on: https://gerrit.libreoffice.org/39164
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-26 08:59:38 +02:00
jan Iversen
5a72018557
iOS, convert CPPUnittest to noop
...
unittest is not supported for iOS
due to the way it is build
Change-Id: I0682c5252231668edc2ec186147b872ef6fcc695
2017-06-23 21:40:12 +02:00
Noel Grandin
55ff9d3e2d
loplugin:unusedfields in dbaccess
...
Change-Id: I3f32573f25b4861799124905cefb3d9166570989
Reviewed-on: https://gerrit.libreoffice.org/39135
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-23 09:00:40 +02:00
Noel Grandin
58ae5fb5ff
loplugin:oncevar in cppcanvas..drawinglayer
...
Change-Id: I5456aad61fb0dfe6830eae62b91d1a6399d6343f
Reviewed-on: https://gerrit.libreoffice.org/39128
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-23 08:59:30 +02:00
Noel Grandin
528632660b
convert ErrCode to strong typedef
...
would have preferred to re-use o3tl::strong_int, of which this
is a modified copy, but there are lots of convenience accessors
which are nice to define on the class.
Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a
Reviewed-on: https://gerrit.libreoffice.org/38497
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-21 08:42:30 +02:00
Jochen Nitschke
a5dba7dbec
remove unused osl/mutex.hxx includes
...
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-06-18 13:38:25 +02:00
Noel Grandin
a6aa57ff59
use ERRCODE_NONE instead of 0
...
peeling off a small chunk of my ErrCode strong_int conversion
Change-Id: Idc89e8496083beed7608cba705cd981139eb7111
Reviewed-on: https://gerrit.libreoffice.org/38777
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-14 15:42:31 +02:00
Jochen Nitschke
a3bedb7ae8
use local statics for getUnoTunnelImplementationId
...
replace uses of double checked locking pattern and
rtl::Static
Change-Id: I479d9d94f652b4fb4c67388405823a5f4e2b6ed4
Reviewed-on: https://gerrit.libreoffice.org/38690
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-13 09:13:37 +02:00
Jochen Nitschke
febbad7263
cleanup unused css/frame/* includes
...
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-12 13:05:38 +02:00
Johnny_M
567fe6d351
Translate and fix the from-German translation of "UNO binding"
...
This is a follow-up on commit 905c0892a5
( https://gerrit.libreoffice.org/37917 ), for the same reason.
Change-Id: I0bdaeb1cf6d87f730558d15adb820cfbcaeed172
Reviewed-on: https://gerrit.libreoffice.org/38542
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2017-06-07 21:44:17 +02:00
Julien Nabet
39487b1495
tdf#37859: Odb data copied to Calc showed wrong encoding in Windows
...
Blind fix since I don't have Windows.
If it works, many thanks to:
- Urmas (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c16 )
- Himajin100000 (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c35 )
Change-Id: I9fd84977eab8410ec022b6e34f1a636326eaf56a
Reviewed-on: https://gerrit.libreoffice.org/38253
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Eike Rathke <erack@redhat.com >
2017-06-07 16:14:52 +02:00
Noel Grandin
de8caac6be
replace SVSTREAM_OK with ERRCODE_NONE
...
since the first is #define'd to the second, and offers no extra value
Change-Id: I2c67e09ea3aa5361b8e7dfe7a20858c6ae054450
Reviewed-on: https://gerrit.libreoffice.org/38406
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-06 08:15:57 +02:00
Stephan Bergmann
f41eea8521
Improved loplugin:cstylecast to reference types: dbaccess
...
Change-Id: I298c4d8b8244488964ae1e63dabb8bf400c3fb32
2017-06-05 21:18:12 +02:00
Julien Nabet
f749e7d705
typo: checkNotUninitilized->checkNotUninitialized
...
Change-Id: I6d19b7824f829f6747144614b3c733a02dbdae79
Reviewed-on: https://gerrit.libreoffice.org/38415
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-06-05 19:28:20 +02:00
Stephan Bergmann
ff77fdbe29
Improved loplugin:redundantcast const_cast handling: dbaccess
...
Change-Id: I7a40549601a9a396c8adec16806b1f76f78734a2
2017-06-02 13:31:31 +02:00
Stephan Bergmann
7d81894613
Improved loplugin:redundantcast static_cast handling: dbaccess
...
Change-Id: I4037cff3213f9885353ba0f5a810ceba68cb17b5
2017-06-02 09:37:50 +02:00
Andrea Gelmini
1d857ca26f
Fix typos
...
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56
Reviewed-on: https://gerrit.libreoffice.org/38208
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-06-01 10:51:01 +02:00
Noel Grandin
307be8c9ce
clang-tidy readability-redundant-control-flow
...
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04
Reviewed-on: https://gerrit.libreoffice.org/38215
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-31 08:33:40 +02:00
Jochen Nitschke
709040e0ad
remove duplicate 'using namespace'
...
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440
Reviewed-on: https://gerrit.libreoffice.org/38201
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-30 21:15:03 +02:00
Noel Grandin
2ccde70d60
teach redundantcast plugin about functional casts
...
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-30 08:50:31 +02:00
Julien Nabet
182a62e0f1
Related tdf#108068: Retrieve error from Firebird engine
...
Change-Id: If89a904740e54e81c2f2ae790ba8d05d830b0a5b
Reviewed-on: https://gerrit.libreoffice.org/38043
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
2017-05-30 07:56:04 +02:00
Noel Grandin
ef513fd4b0
remove unnecessary use of OString::getStr
...
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-28 19:44:08 +02:00
Johnny_M
39adbb9593
Translate German comments and debug strings (leftovers in dirs d...)
...
Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "d".
Additionally, one FormatEntry in dtrans/source/win32/ftransl/ftransl.cxx
is translated as well.
Change-Id: Ia9b3df0210830bd65443883b5f27d56aef811437
Reviewed-on: https://gerrit.libreoffice.org/37600
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-05-22 22:06:56 +02:00
Jochen Nitschke
a0b93fe081
cleanup unused css/script/ includes
...
but keep exception includes in headers for now
Change-Id: I826828675a2d14b906e57068cbced2e790e12bce
Reviewed-on: https://gerrit.libreoffice.org/37846
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-20 10:23:38 +02:00
Stephan Bergmann
5de6294a94
loplugin:stringcopy: dbaccess
...
Change-Id: I7d9c876a57b4390d1f5d86ae4d9a3f703c56f0c8
2017-05-19 17:18:33 +02:00
Noel Grandin
fd00bd0f69
loplugin:unusedfields
...
make it a little smarter in dealing with fields that are smart pointers
Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11
Reviewed-on: https://gerrit.libreoffice.org/37751
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-19 09:17:06 +02:00
Caolán McNamara
1807db242a
DBACORE_RESSTRING can go now
...
Change-Id: I0d1f5372dc6a29af62d3d85c5f771e1e8884626e
2017-05-18 10:08:43 +01:00
Caolán McNamara
32dc38e319
fix documentation now
...
Change-Id: I1583b0f7fb0f99166606e327cdda3bbdcbe698da
Reviewed-on: https://gerrit.libreoffice.org/37691
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-05-16 22:53:41 +02:00
Noel Grandin
4582acb3ee
remove some unnecessary locking
...
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c
Reviewed-on: https://gerrit.libreoffice.org/37602
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-15 08:40:46 +02:00
Noel Grandin
389da66dfc
remove unused uno::Reference vars
...
found by temporarily marking Reference as SAL_WARN_UNUSED.
Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-12 09:56:01 +02:00
Noel Grandin
2962ceec4b
remove some unnecessary temporary OUStrings
...
found with:
git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return
Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02
Reviewed-on: https://gerrit.libreoffice.org/37463
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-11 09:26:28 +02:00
Jochen Nitschke
959496794c
cleanup osl/diagnose.h includes
...
with command
> git grep -l osl/diagnose.h *.cxx |
xargs grep -L -w 'OSL_\w*' |
xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'
headers need more work
Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-05-09 15:41:46 +02:00
Noel Grandin
12191a4f30
make loplugin constantparam smarter about string params
...
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-09 13:52:30 +02:00
Noel Grandin
719a2adfbd
remove unnecessary empty OUString fields and vars
...
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7
Reviewed-on: https://gerrit.libreoffice.org/37394
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-09 08:28:56 +02:00
Noel Grandin
4763091bbe
loplugin:constantparam
...
Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2
Reviewed-on: https://gerrit.libreoffice.org/37390
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-09 08:28:04 +02:00
Jochen Nitschke
b3eb843766
cleanup tools/debug.hxx includes
...
with command
> git grep -l tools/debug.hxx |
xargs grep -L DBG_ |
xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'
don't change files in includes/ and */pch
Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-08 08:33:01 +02:00
Noel Grandin
034e9de08e
loplugin:checkunusedparams in xmloff
...
Change-Id: I59d2cb1f69882b62e6fe732e9d9214feec8a79a2
Reviewed-on: https://gerrit.libreoffice.org/37283
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-08 08:29:26 +02:00
Noel Grandin
185ed3ddb8
teach loplugin:constantparam about simple constructor calls
...
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9
Reviewed-on: https://gerrit.libreoffice.org/37280
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-08 08:29:03 +02:00
Chris Sherlock
97eb00c75e
revert OSL_ASSERT changes
...
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07 17:03:35 +10:00
Chris Sherlock
f1ac23866d
tdf#43157: convert dbaccess module away from OSL_ASSERT to assert
...
Change-Id: I14537ea5c9499df4d9ded48071b066fd8a99a0ce
2017-05-07 13:23:49 +10:00
Julien Nabet
3d4e1d13cf
tdf#107652: Crash relation Design window
...
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=057cde3f8aedc48401bfe864a5b03ef29dd8b641
"convert join table view menu to .ui"
Change-Id: I6703f7b9b24b67dab87f0b64351d75b3051b5379
Reviewed-on: https://gerrit.libreoffice.org/37314
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-05-06 11:32:45 +02:00
Noel Grandin
076758857a
fix spelling, methode -> method
...
Change-Id: I1c7a4e657601e28d9d50d86e24c4e0ba7579b9d4
Reviewed-on: https://gerrit.libreoffice.org/37289
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-05 15:39:08 +02:00
Noel Grandin
93a9b70c7f
loplugin:checkunusedparams in svtools
...
Change-Id: Iea68d7c0683740acaf4f85c14efe2a33e0cf13e7
Reviewed-on: https://gerrit.libreoffice.org/37201
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-05 08:53:47 +02:00
Noel Grandin
57f1934bda
convert HTML_TOKEN_IDS to scoped enum
...
Change-Id: I525506e0103e4f17e5b8b95f15c1285d65b93de9
Reviewed-on: https://gerrit.libreoffice.org/37220
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-05 08:38:36 +02:00
Noel Grandin
0dbf528c29
loplugin:checkunusedparams in cppcanvas and dbaccess
...
Change-Id: Ia66e6326f3d1750b4e46a3f9f7127e7ed4aa99ca
Reviewed-on: https://gerrit.libreoffice.org/37068
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-02 08:19:37 +02:00