Commit Graph

87 Commits

Author SHA1 Message Date
Andrea Gelmini
ddc1429bf3 Fix typos
Change-Id: I85214642167d9c7876fd0fdc2cb7cf8e85765614
Reviewed-on: https://gerrit.libreoffice.org/35627
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 17:11:53 +00:00
Noel Grandin
427678b9cf remove noise UUUU tags in comments
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00
Reviewed-on: https://gerrit.libreoffice.org/35161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14 08:23:53 +00:00
Tor Lillqvist
b57d51e32f Drop :: prefix from std in [de]*/
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4
Reviewed-on: https://gerrit.libreoffice.org/34377
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-17 18:41:19 +00:00
Noel Grandin
30e39e4793 loplugin:expandablemethods in drawinglayer..editeng
Change-Id: Ic7fe13651e18b4eec90ef3fd8d7aab81197e0f39
Reviewed-on: https://gerrit.libreoffice.org/30707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09 10:34:31 +00:00
Noel Grandin
e4cb0742c8 loplugin:expandablemethodds in include/connectivity..drawinglayer
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4
Reviewed-on: https://gerrit.libreoffice.org/30136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23 12:09:33 +00:00
Noel Grandin
ef637a1c4e loplugin:expandablemethodds in dbaccess..drawinglayer
Change-Id: Iee9143999f5c94040dadd378006f2a429ca0edb5
Reviewed-on: https://gerrit.libreoffice.org/30012
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:30:48 +00:00
Tor Lillqvist
714de95ec5 Remove nonsense comments: // bitfield
Surely the actual bitfield syntax is enough to tell the code reader
that it is a bitfield.

Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-13 11:09:06 +03:00
Stephan Bergmann
269b58a046 Missing operator definition
Change-Id: I39d3b68ca317a4a259b77532efc0897fc89a6fe9
2016-08-25 14:19:41 +02:00
Noel Grandin
b9ab0dd3e5 cid#1371276 Missing move assignment operator
also cid#1371234, cid#1371249, cid#1371208,
cid#1371250, cid#1371258, cid#1371266, cid#1371257,
cid#1371221

Change-Id: I18d952887b684e1999d003cec0f668789c851b52
2016-08-25 13:34:46 +02:00
Noel Grandin
3d8154789b cid#1371277 Missing move assignment operator
Change-Id: Ic737733f5951d5b21660a12a7a01202bd9bc303c
2016-08-25 13:14:46 +02:00
Noel Grandin
cff0edb0b8 cid#1371284 Missing move assignment operator
Change-Id: I84d4cfe58f9659b468a1fd62b7974fcdbf0bb1f3
2016-08-25 13:03:47 +02:00
Noel Grandin
877dfa3783 cid#1371288 Missing move assignment operator
Change-Id: I5181c76f558e1806de01f21422c715cc93f3cb3d
2016-08-25 12:58:57 +02:00
Noel Grandin
37ffcb1ce7 fix windows build, doesn't like default move methods
Change-Id: I6e756a11aa07722ff18ed13219b780f3db3bc4a0
2016-08-25 12:30:35 +02:00
Noel Grandin
9fda8f5ad6 fix move operator= and add move constructors
followup to:
  19828cc0 "cid#1371315 Missing move assignment operator"
and
  0e748707 "cid#1371320 Missing move assignment operator"

Change-Id: Id2479fef41cf8d98eef9246f3a86e6c9289c3d58
2016-08-25 12:05:59 +02:00
Noel Grandin
065913d8aa cid#1371309 Missing move assignment operator
Change-Id: Ic00f39793f0341820ccce912f4350644a90104c5
2016-08-25 11:51:03 +02:00
Noel Grandin
19828cc01f cid#1371315 Missing move assignment operator
Change-Id: I9da0ffe856a0a40094c1c553bb2c5e05d8d3ef5d
2016-08-25 11:41:30 +02:00
Noel Grandin
5c5209c2d9 Convert GradientStyle to scoped enum
Change-Id: I1da151dd25648e363ba88bf88caa3e820f0ee424
Reviewed-on: https://gerrit.libreoffice.org/25270
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23 09:20:31 +00:00
Noel Grandin
4a98af674c Convert HatchStyle to scoped enum
Change-Id: I27878a67457d32e6922dfb6da73f896ff6ab1d01
Reviewed-on: https://gerrit.libreoffice.org/25271
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23 07:31:31 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18 10:03:44 +00:00
Armin Le Grand
657413b5de Refactor 3D renderer to use multithreading
This try uses full 3D renderers working on the same ZBuffer
target, but are capable to render one stripe per thread.
This is rougher in granularity and uses multiple cores better
than the first try (see gerrit 24393) which was too fine-granular
being based on scanline render parallelization.
SecUred some more classes based on SdrPrimitive3D for multi-
theaded usage (places where local buffered stuff is done)

Change-Id: I4ddd5885ad41dd6432d0695e528818a86e427bfd
Reviewed-on: https://gerrit.libreoffice.org/24538
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-05-06 10:11:03 +00:00
Armin Le Grand
75d9f7a433 Complete drawinglayer attributes
All DrawingLayer Atrributes used for ptimitives need a default
constructor. Since the o3tl::cow_wrapper is used in combination
with a static default incarnation of the impl class it is better
to define that. Also needed is a working isDefault() implementation
that compares the impl class to the static default. Added missing
stuff for this.

Change-Id: I98e9fee7343112cd979b972229423ac0ef3994a6
Reviewed-on: https://gerrit.libreoffice.org/24496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-05-01 13:46:04 +00:00
Regina Henschel
32cec4ca8b tdf#48066 render stroke-miterlimit correctly in SVG import
The property stroke-miterlimit is transported to the renderers
via a new member mfMiterMinimumAngle in class LineAttribute
Several drawPolyLine methods are adapted. This patch does not
include changes in MetaAction. Presentation mode, printing, and
PDF-export is still wrong.

Corrected LineJoinMiter to LineJoinBevel in canvas, that s closer
to NONE. Removed DrawPolyLine method without MiterMinimumAngle
and adapted calls accordingly.

Change-Id: I6bcd24add5d85c4d9a39e3788e0682091c5fc9c4
Reviewed-on: https://gerrit.libreoffice.org/23946
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2016-04-26 16:42:27 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Noel Grandin
47283424b1 drawinglayer: com::sun::star->css
Change-Id: I65706e3e87c1ce287020c90a89f7dc00866bef64
Reviewed-on: https://gerrit.libreoffice.org/18501
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-12 19:53:35 +00:00
Caolán McNamara
267f401e2a cppcheck: noExplicitConstructor
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
Noel Grandin
42f771d6e9 convert B2DLineJoin to scoped enum
Change-Id: I4fb8f2c9e2080e3aa542d2ccf838e6784baa8429
2015-06-04 08:30:24 +02:00
Thorsten Behrens
cd6ee5de8e comments: fix mis-use of eventual in English
The adjective was used as the German meaning, which translates to
maybe or possibly.

Change-Id: Iaf5b38f628b23796829a1c4bd3919d4e13b874f0
2015-05-24 21:50:20 +02:00
Thorsten Behrens
551c204740 Fix tdf#87509 - default sdr attribute is special object.
The drawinglayer attributes signal defaultness by object identity, not
value equalness. That should fix a number of subtle cache and redraw
problems.

Change-Id: I049ffda228a48db71cef108571805c6e41e4b149
2015-05-24 21:49:44 +02:00
Andras Timar
f62af191bf typo: strech -> stretch
Change-Id: I0de1cfaa0df460c7bc8e49752b31056f95c30053
Reviewed-on: https://gerrit.libreoffice.org/15628
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2015-05-05 07:25:21 +00:00
Andras Timar
c79a5f87b1 remove executable bit
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-17 15:11:14 +02:00
Stephan Bergmann
5e57caa1fd Clean up function declarations and some unused functions
Change-Id: I2b743ee6e184af5f9020309ea5e184aa17c19405
2014-04-09 09:56:50 +02:00
Armin Le Grand
6e61ecd096 Merge back branch alg_writerframes to trunk
(cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62)

Conflicts:
	comphelper/inc/comphelper/TypeGeneration.hxx
	comphelper/source/property/TypeGeneration.cxx
	cui/source/factory/dlgfact.hxx
	cui/source/inc/cuitabarea.hxx
	cui/source/tabpages/tabarea.cxx
	cui/source/tabpages/tabarea.hrc
	cui/source/tabpages/tabarea.src
	cui/source/tabpages/tparea.cxx
	drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx
	drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
	drawinglayer/source/texture/texture.cxx
	editeng/inc/editeng/unotext.hxx
	editeng/source/items/frmitems.cxx
	include/drawinglayer/texture/texture.hxx
	include/editeng/brushitem.hxx
	include/svx/sdr/primitive2d/sdrdecompositiontools.hxx
	include/svx/svxids.hrc
	include/xmloff/xmltypes.hxx
	reportdesign/source/ui/misc/UITools.cxx
	sc/source/ui/drawfunc/drawsh.cxx
	sfx2/source/dialog/tabdlg.cxx
	svl/source/undo/undo.cxx
	svx/inc/svx/unoshprp.hxx
	sw/Library_sw.mk
	sw/inc/doc.hxx
	sw/inc/format.hxx
	sw/inc/frmfmt.hxx
	sw/inc/swatrset.hxx
	sw/inc/unomap.hxx
	sw/inc/unoprnms.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/attr/format.cxx
	sw/source/core/attr/swatrset.cxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docfly.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/inc/frame.hxx
	sw/source/core/inc/frmtool.hxx
	sw/source/core/layout/atrfrm.cxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/fntcache.cxx
	sw/source/core/uibase/app/docst.cxx
	sw/source/core/uibase/app/docstyle.cxx
	sw/source/core/uibase/shells/drawdlg.cxx
	sw/source/core/uibase/shells/frmsh.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unomap.cxx
	sw/source/core/unocore/unoprnms.cxx
	sw/source/core/unocore/unostyle.cxx
	sw/source/ui/fmtui/tmpdlg.cxx
	sw/source/ui/fmtui/tmpdlg.src
	sw/source/ui/frmdlg/frmdlg.cxx
	sw/source/ui/frmdlg/frmpage.src
	sw/source/ui/inc/frmsh.hxx
	xmloff/source/text/txtprhdl.cxx
	xmloff/source/text/txtprmap.cxx

Change-Id: Id3ffaa83bb5594d287f1ac8f2c1c9cf55c70946d
2014-03-28 14:31:08 +01:00
Markus Mohrhard
092eecb7d7 remove whitespace
Change-Id: I81a24a7affa7dffcc3dac65248444679c3c49925
2014-03-20 01:10:19 +01:00
Noel Grandin
43c5a22e63 remove unused code in drawinglayer
drawinglayer::attribute::SdrFillGraphicAttribute::getLogSize()

Change-Id: Ib1d958e57598dd3db392de98c4d2e2df1bfc98de
2014-03-05 09:17:43 +02:00
Alexander Wilms
d0d1534b6b Remove visual noise from drawinglayer
Change-Id: Ida745b9d994d09081ad3d18cdf2494a97438dc56
Reviewed-on: https://gerrit.libreoffice.org/8253
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 07:10:49 -06:00
Stephan Bergmann
70863f08d8 Use bool
Change-Id: I2d06ae03650b318a1318d0e2b026352e22404fdd
2014-01-10 17:52:55 +01:00
Armin Le Grand
01541c21b6 Resolves: #i124002# use own logical size for graphics...
do not adapt PrefSize of these in rendering stack

(cherry picked from commit b57f921795c7249d82ca739884c0116574426194)

Conflicts:
	drawinglayer/source/attribute/sdrfillgraphicattribute.cxx

Change-Id: I3eff4438a42209ad4c259dfdbed4869ae046bfc6
2014-01-09 17:02:43 +00:00
Caolán McNamara
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
Thomas Arnhold
e032254517 clean up after my cow wrapper changes
Change-Id: I42fcce936750888388e80db24b529b7543f9f4bf
2013-09-05 08:00:32 +02:00
Noel Grandin
5527d5c4e0 convert drawinglayer module from String to OUString
Change-Id: I115dfd5ca7d343b220b2a3e8aa0565f9e4689042
2013-08-22 10:49:33 +02:00
Armin Le Grand
37aa7d81aa Resolves: #i121194# Better support for graphic fill styles...
which are not bitmaps (svg, metafiles, ..)

(cherry picked from commit 7a652a2b2ab5e0d37e32185c8c5fac3af482bb76)

Conflicts:
	drawinglayer/Library_drawinglayer.mk
	drawinglayer/Package_inc.mk
	drawinglayer/inc/drawinglayer/attribute/fillgraphicattribute.hxx
	drawinglayer/inc/drawinglayer/attribute/sdrfillattribute.hxx
	drawinglayer/inc/drawinglayer/attribute/sdrfillgraphicattribute.hxx
	drawinglayer/inc/drawinglayer/primitive2d/drawinglayer_primitivetypes2d.hxx
	drawinglayer/inc/drawinglayer/primitive2d/fillgraphicprimitive2d.hxx
	drawinglayer/inc/drawinglayer/primitive2d/polypolygonprimitive2d.hxx
	drawinglayer/inc/drawinglayer/primitive3d/textureprimitive3d.hxx
	drawinglayer/inc/drawinglayer/processor2d/vclprocessor2d.hxx
	drawinglayer/inc/drawinglayer/texture/texture.hxx
	drawinglayer/inc/drawinglayer/texture/texture3d.hxx
	drawinglayer/source/attribute/fillbitmapattribute.cxx
	drawinglayer/source/attribute/sdrfillattribute.cxx
	drawinglayer/source/attribute/sdrfillgraphicattribute.cxx
	drawinglayer/source/primitive2d/fillbitmapprimitive2d.cxx
	drawinglayer/source/primitive2d/graphicprimitive2d.cxx
	drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx
	drawinglayer/source/processor2d/canvasprocessor.cxx
	svx/inc/svx/sdr/primitive2d/sdrattributecreator.hxx
	svx/source/sdr/contact/objectcontacttools.cxx
	vcl/inc/vcl/graph.hxx

unused file _vclmetafileprocessor2d.cxx deleted, was added by error

(cherry picked from commit ed0d53f8283cd3ce579a90b599118884d0db6119)

Conflicts:
	drawinglayer/source/processor2d/_vclmetafileprocessor2d.cxx

Corrected canvasProcessor usage

(cherry picked from commit 7903c33f31c457eb6ff506958c4233f2a5d39bcf)

Conflicts:
	svx/source/sdr/contact/objectcontacttools.cxx

Change-Id: I80008050b98dafc92fde043524843c13a75fe22c
d2fa667d7c127b4d735334e56093d1d4553b0a5b
e20c60c7d6472da1295a162d9a629be998861f62
2013-06-11 20:00:34 +01:00
Armin Le Grand
8f43c78e9a Resolves: #i120230# Adapt hatch processing for a more pleasant visualisation
Adapt hatch processing to keep a view-dependent minimal distance for a more
pleasant visualisation

(cherry picked from commit 6a036e7ac17a1d4394d60471bd8931d9b16b7bb4)

Conflicts:
	drawinglayer/inc/drawinglayer/attribute/fillhatchattribute.hxx
	drawinglayer/inc/drawinglayer/primitive2d/fillhatchprimitive2d.hxx
	drawinglayer/inc/drawinglayer/primitive2d/primitivetools2d.hxx
	drawinglayer/source/attribute/fillhatchattribute.cxx

Change-Id: I15cd784ef7d3e47a20308f16d370c24ef46d2f22
2013-05-02 14:16:14 +01:00
Thomas Arnhold
7470c93a7b fdo#62525: use cow_wrapper for Sdr3DObjectAttribute
Change-Id: I80e378f6a88068f5d3b36c6187b41ab8d968a0c3
2013-04-03 02:49:17 +02:00
Thomas Arnhold
d3dff92c74 fdo#62525: use cow_wrapper for SdrSceneAttribute
Change-Id: Iaedb5080f341482c3ac4f4e0548be49801c5f0b2
2013-04-03 02:49:17 +02:00
Thomas Arnhold
12012150d2 fdo#62525: use cow_wrapper for SdrLineStartEndAttribute
Change-Id: I714011f70ae4c1b9a1dcce5cb3653e918cc742b4
2013-04-03 02:49:17 +02:00
Thomas Arnhold
92261a33c8 fdo#62525: use cow_wrapper for StrokeAttribute
Change-Id: Icf5daca279902b90da98069338638c3ad432e69a
2013-04-03 02:49:17 +02:00
Thomas Arnhold
8ee042bdb5 fdo#62525: use cow_wrapper for SdrLineAttribute
Change-Id: I62b897bd49ef05a3862cb2cd91c3aa13f621e9fd
2013-04-03 02:49:17 +02:00
Thomas Arnhold
4f989f3068 fdo#62525: use cow_wrapper for SdrLightingAttribute
Change-Id: Ibd6bd31ef78f2e853ff668f64202eff89afb1234
2013-04-03 02:49:16 +02:00
Thomas Arnhold
f61b5c3654 fdo#62525: use cow_wrapper for Sdr3DLightAttribute
Change-Id: I9639746d072642d46c3f0766c473425221b1706a
2013-04-03 02:49:16 +02:00
Thomas Arnhold
f5cf7f36f9 fdo#62525: use cow_wrapper for SdrFillBitmapAttribute
Change-Id: Ib8bb849b179be12680c5adae6bf89afc5ad31563
2013-04-03 02:49:16 +02:00