Commit Graph

9653 Commits

Author SHA1 Message Date
Stephan Bergmann
349475566f loplugin:casttovoid: svtools
Change-Id: Iae781dd1f303b905653ccd1e113cfdbb7145819e
2017-07-02 22:29:22 +02:00
Markus Mohrhard
7250bc4721 notify the clipboard terminate listener before any other terminate listener
Otherwise we may have destroyed a service that is needed to generate
one of the clipboard formats requested by the system clipboard.

Change-Id: Id05de3ac569e3ed38cd97efc4c48326bc6a8db0b
Reviewed-on: https://gerrit.libreoffice.org/39429
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-02 04:42:09 +02:00
Jochen Nitschke
a679ae4c87 svtools: use implicit defined copy assignment
Change-Id: Iea061bbcf0bf6e894f1bb6028de75eb0f8e2c8f0
Reviewed-on: https://gerrit.libreoffice.org/39294
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27 13:32:01 +02:00
Noel Grandin
c937c68287 loplugin:oncevar in svtools
Change-Id: Ic97e75c81a0c00853d2f10aaf182ab476c466c86
Reviewed-on: https://gerrit.libreoffice.org/39281
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27 08:43:07 +02:00
Noel Grandin
513ac8eb79 loplugin:useuniqueptr in various
extending it to find places we can use std::unique_ptr on arrays

Change-Id: I9feb1d12d738d6931e752ecb6dd51cbc1540c81b
Reviewed-on: https://gerrit.libreoffice.org/39255
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27 08:42:36 +02:00
Yousuf Philips
3e82c30b89 tdf#108720 Add symbol fonts to isSymbolFont()
Added webdings, wingdings, and bookshelf symbol 7

Change-Id: Icbd311dbe1cd6895d04ac10aa5a275894c613c15
Reviewed-on: https://gerrit.libreoffice.org/39217
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-24 22:45:40 +02:00
Noel Grandin
5e028ad5dc simplify some string handling in tracing calls
Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3
Reviewed-on: https://gerrit.libreoffice.org/39159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23 14:38:14 +02:00
Muhammet Kara
89594b646e Add RemoveEntry method to SvTreeListBox
Allows you to remove an entry along with its children
without selecting the entry.

Change-Id: Ie833df5e0d2d3bc86ed01a70dc6f042ebb6d6a47
Reviewed-on: https://gerrit.libreoffice.org/38971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-22 16:31:41 +02:00
Jens Carl
cbe7bdfd7c tdf#39468 Translate some random German comments/terms
Change-Id: I38cb79abb2a495ccca454903bc46b407009e8290
Reviewed-on: https://gerrit.libreoffice.org/39084
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-06-22 13:38:37 +02:00
Noel Grandin
9e61a95137 loplugin:unusedfields in svtools
Change-Id: Ic8f67d40825d9843fd57535bd61bef51b470a8be
Reviewed-on: https://gerrit.libreoffice.org/39016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21 12:16:17 +02:00
Noel Grandin
528632660b convert ErrCode to strong typedef
would have preferred to re-use o3tl::strong_int, of which this
is a modified copy, but there are lots of convenience accessors
which are nice to define on the class.

Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a
Reviewed-on: https://gerrit.libreoffice.org/38497
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21 08:42:30 +02:00
Caolán McNamara
ea43d65bd3 reuse IsStarSymbol
Change-Id: Ia4df4925f9c0078d098880d2a4a5042bb309a72c
2017-06-20 11:47:08 +01:00
Eike Rathke
ecf88f83f8 Add Kituba (Democratic Republic of the Congo) [ktu-CD] to language list
Change-Id: I9ba7a9d104dd6a5e47aa62058d0602101053e9af
2017-06-19 19:25:26 +02:00
László Németh
379196bf95 add more debug names for scheduled events
Change-Id: Idb85ffe13fd5e23b9378c03b5f239f29f8008276
Reviewed-on: https://gerrit.libreoffice.org/38788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-19 08:51:32 +02:00
Caolán McNamara
2297570efb silence some exception warnings
Change-Id: I654c57642c639fa07a3f496286cc4e180bb0b241
2017-06-18 14:52:36 +01:00
Jochen Nitschke
a5dba7dbec remove unused osl/mutex.hxx includes
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-18 13:38:25 +02:00
Jochen Nitschke
6149da20dd replace misc double checked locking patterns
... with thread safe local statics

Change-Id: Ie3c8023776a388846b989f00a0be185273c0d5da
Reviewed-on: https://gerrit.libreoffice.org/38907
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17 15:43:38 +02:00
Noel Grandin
a98ac7220a TransferableObjectDescriptor::mnOle2Misc field is unused
which means that SfxObjectShell::GetMiscStatus becomes unused

Change-Id: I5c89a2cd5c77c7f08a57fdac08237aab514fc7fa
Reviewed-on: https://gerrit.libreoffice.org/38843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17 08:36:31 +02:00
Noel Grandin
a6aa57ff59 use ERRCODE_NONE instead of 0
peeling off a small chunk of my ErrCode strong_int conversion

Change-Id: Idc89e8496083beed7608cba705cd981139eb7111
Reviewed-on: https://gerrit.libreoffice.org/38777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-14 15:42:31 +02:00
Noel Grandin
546c355191 use more SAL_N_ELEMENTS part 2
Change-Id: If00e371c3cd3ae616309a172c875faed016e391b
Reviewed-on: https://gerrit.libreoffice.org/38773
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-14 15:14:27 +02:00
Jochen Nitschke
febbad7263 cleanup unused css/frame/* includes
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12 13:05:38 +02:00
Caolán McNamara
f11818696a skip copying tile when we don't need to
Change-Id: I137c69b7217801a6c86634f7e44e363ef73fd9de
Reviewed-on: https://gerrit.libreoffice.org/38667
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-12 09:57:15 +02:00
Arnaud Versini
a7532d8f06 Remove VCLExternalSolarLock and IMutex.
Next step is to remove OContextEntryGuard.

Change-Id: I9460fb67fba6f3bfb3c809b730c33f38d225a64e
Reviewed-on: https://gerrit.libreoffice.org/38411
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12 08:45:48 +02:00
Noel Grandin
d4eabd5da8 pass comphelper::PropertySetInfo around using rtl::Reference
and remove some manual ref counting

Change-Id: Ib78122fbbf914e87e0aef1f8fffe3952639e5b22
Reviewed-on: https://gerrit.libreoffice.org/38607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12 08:36:20 +02:00
Noel Grandin
027b25ecd5 use comphelper::InitPropertySequence in more places
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a
Reviewed-on: https://gerrit.libreoffice.org/38606
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-09 14:24:00 +02:00
Gabor Kelemen
f5eae04d7a tdf#107700 Translate some less common font style names
These are used in at least on of the free fonts we bundle.
Also translate a stray German comment :)

Change-Id: I3f4d83001bcfc3a8b3d490e56d9e538a8d892f0c
Reviewed-on: https://gerrit.libreoffice.org/38476
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-08 23:15:06 +02:00
Stephan Bergmann
6616e886ae Improved loplugin:cstylecast to reference types: svtools
Change-Id: I7ac860cdf68e920834a65573a6f3344855840332
2017-06-05 21:18:03 +02:00
Arnaud Versini
f2d40b8ba1 Remove all allocation of VCLExternalSolarLock.
This patch is graciously offered by Arnaud Versini.

Change-Id: I3ed5e1758d09542a2ca0533e3f4a6ceb2dbb6346
Reviewed-on: https://gerrit.libreoffice.org/38404
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05 13:41:38 +02:00
Noel Grandin
17a2c9e8e2 clang-tidy performance-unnecessary-value-param
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05 09:22:51 +02:00
Jochen Nitschke
8511ee5cd1 no need to construct unique_ptr here
and std::move is not needed when returning unique_ptr

Change-Id: I9b4d2d6b8a41b570a9bd99e44a743ff161b78c59
Reviewed-on: https://gerrit.libreoffice.org/38385
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-04 20:42:45 +02:00
Noel Grandin
0265bdb92e convert GRFILTER constants to ERRCODE_GRFILTER_
since various code mixes these constants in with ErrCode values from
other code, let us just make it into real ErrCode values.

Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95
Reviewed-on: https://gerrit.libreoffice.org/38313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-02 09:00:13 +02:00
Caolán McNamara
f681a86230 merge ofa res file into svt one
Change-Id: I3f22301e4301ab90e4a1090f2c47cf2403422282
Reviewed-on: https://gerrit.libreoffice.org/38309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-01 15:20:42 +02:00
Caolán McNamara
963137415b macro warning dialog grew an extra Cancel button
since...

commit bcad173faa
Date:   Wed Feb 8 11:12:00 2017 +0200

    Reapply "create ErrorHandlerFlags scoped enum for error handling flags""

    This effectively reverts commit 32cae6a2ea.

Change-Id: Ice41023bc741af46db3018bbb0eb08b4a339987e
2017-05-31 14:45:29 +01:00
Noel Grandin
307be8c9ce clang-tidy readability-redundant-control-flow
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04
Reviewed-on: https://gerrit.libreoffice.org/38215
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31 08:33:40 +02:00
Noel Grandin
6ed854fa98 drop LANGUAGE_USER_MALAGASY_PLATEAU define
since it's just an alias for LANGUAGE_MALAGASY_PLATEAU,
at least as far back as
commit 6b678c135d
"added/checked/aligned MS-LangIDs and mappings from new MS-LCID.pdf"

Change-Id: I18645160cb1808c967fd6efd36e1d4269e4734ff
Reviewed-on: https://gerrit.libreoffice.org/38187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30 14:07:28 +02:00
Noel Grandin
2ccde70d60 teach redundantcast plugin about functional casts
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30 08:50:31 +02:00
Noel Grandin
ef513fd4b0 remove unnecessary use of OString::getStr
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28 19:44:08 +02:00
Noel Grandin
4a340e36e8 loplugin:constantparam
add the results files so I can just see the diff in future

Change-Id: Ia20a1aa6418be95ed620719cde340c00b7b053e1
Reviewed-on: https://gerrit.libreoffice.org/37988
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-25 08:12:17 +02:00
Jochen Nitschke
2e5db24f63 remove VCLExternalSolarLock* members from ..
.. classes with OAccessibleContextHelper base.

Change-Id: I3187e88bf485e78fb78550870a87db29d958dbc0
Reviewed-on: https://gerrit.libreoffice.org/37948
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-23 18:16:48 +02:00
Miklos Vajna
6a91ea8250 vcl GraphicFilter: add ImportGraphics()
This is similar to ImportGraphic(), but can handle multiple streams with
one function call.

Change-Id: I8d5dc8de64321c3c1fb9e1037527b411fd68dca8
Reviewed-on: https://gerrit.libreoffice.org/37953
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-05-23 16:36:38 +02:00
Miklos Vajna
252e524094 svtools: add GraphicProvider::queryGraphics()
This allows moving the for() loop from oox to svtools when importing
multiple images.

That means in case later we parallelize that loop, then the performance
benefit won't be restricted to oox, but also will be available for all
clients of the graphic provider.

Change-Id: Icd7bd447e7ae623b0a8548e020d8f6ab38da47bb
Reviewed-on: https://gerrit.libreoffice.org/37945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-23 15:24:18 +02:00
Noel Grandin
d1e47b1428 enhance useuniqueptr loplugin
teach it to look for the following sequence in a destructor:
    delete m_pfoo;
    m_pfoo = nullptr;

Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380
Reviewed-on: https://gerrit.libreoffice.org/37900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-23 09:31:20 +02:00
Miklos Vajna
9b261681e5 svtools: fix mime type of PDF images
Otherwise the UNO API user can only see this image has a replacement,
but not possible to say if it's an SVG or a PDF image.

Change-Id: Ibde7915e02620acecbbb237dc3b333382d9c784a
Reviewed-on: https://gerrit.libreoffice.org/37827
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-05-19 18:56:18 +02:00
Stephan Bergmann
74dfe42baf loplugin:stringcopy: svtools
Change-Id: Ib731495da942fdd8bf0fb6f75d8697c10155886a
2017-05-19 17:16:53 +02:00
Caolán McNamara
2155e04d63 make string translation loading more uniform
change various ResId classes that use conversion operator to OUString to
functions that return a OUString

drop various defines

drop unnecessary toString calls

Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92
Reviewed-on: https://gerrit.libreoffice.org/37817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19 15:40:40 +02:00
Jan Holesovsky
4ebc177558 html import: Don't create HTML: <meta name="changedby" content="..."> postit.
Change-Id: I8deea3b60d9bb86c20539be2ad23e6b07f44e51b
Reviewed-on: https://gerrit.libreoffice.org/37729
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-05-18 11:01:03 +02:00
Tor Lillqvist
d89fa2bd49 Clean up a set of RTL-related comments
It is fairly pointless to have a comment like "--- RTL --- (mirror
mouse pos)" in front of code that obviously is related to RTL anyway,
like "if( AllSettings::GetLayoutRTL() )". Also, the fact that many
comment were exactly the same indicates that they has been added as an
in-line version control change marker.

In other places, comments were informational, but no need for them to
include yet another metasyntax, "--- RTL ---". Just "RTL:" works fine.

Change-Id: I20feef308ed8ac9d32a8bf440fc20b442753c4ff
2017-05-18 08:06:38 +03:00
Stephan Bergmann
6a84b2b5d0 Clean up local HTML_IS* macros
Change-Id: I3711b055e180f9dbb5e7d2cdb95e8c9605ca8446
2017-05-17 14:23:49 +02:00
Noel Grandin
4582acb3ee remove some unnecessary locking
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c
Reviewed-on: https://gerrit.libreoffice.org/37602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15 08:40:46 +02:00
Jochen Nitschke
05d3a1899e tdf#75280 replace uses of sal_uLong
those vars get their type from SvStream which uses sal_uInt64

Change-Id: Ia356699bb0f5e9787ae6f02e52e0b00cc2f817b1
Reviewed-on: https://gerrit.libreoffice.org/37547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12 19:34:14 +02:00