Commit Graph

210 Commits

Author SHA1 Message Date
Noel Grandin
a651dbcfca convert SdrLayerId to strong_int
Also
- rename SetOfByte to SdrLayerIDSet
- add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't
  allocate overlapping SdrLayerID values
- add a new constant SDRLAYERPOS_NOTFOUND to be returned from
  SdrLayerAdmin::GetLayerPos

Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8
Reviewed-on: https://gerrit.libreoffice.org/37467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12 09:54:23 +02:00
Noel Grandin
12191a4f30 make loplugin constantparam smarter about string params
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09 13:52:30 +02:00
Noel Grandin
0aa7c716cc loplugin:checkunusedparams in sw(part2)
Change-Id: Ic6829542628ed1f5ed7d6b3d6be1d28ed1b5c75b
Reviewed-on: https://gerrit.libreoffice.org/37292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08 11:40:01 +02:00
Noel Grandin
518cf484c7 convert TableMergeErr to scoped enum
Change-Id: Ie3d15845e47c514411baadecff92025f3e0c4e21
Reviewed-on: https://gerrit.libreoffice.org/36476
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-13 08:49:43 +02:00
Noel Grandin
890d679071 convert TableChgWidthHeightType to o3tl::typed_flags
Change-Id: I9009f3302f4d117744d80f8816ddd177bae6639d
Reviewed-on: https://gerrit.libreoffice.org/36460
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-13 08:48:23 +02:00
Jens Carl
fb4620f14e tdf#39468 Translate German comments in sw
Translate German comments and terms in sw/inc/ and sw/source

Change-Id: I1330a358db2c6cdc0512009befeafa0582ac4877
Reviewed-on: https://gerrit.libreoffice.org/36288
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-10 13:30:47 +02:00
Miklos Vajna
a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-03-31 06:27:11 +00:00
Noel Grandin
d99d143900 convert RndStdIds to scoped enum
Change-Id: I029ad67dfcbc40f3953adf485957efcbd97f23d0
Reviewed-on: https://gerrit.libreoffice.org/35328
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-20 06:52:34 +00:00
Noel Grandin
b5c2f9dee9 convert CurRectType to scoped enum
and drop read-only enumerators
RECT_OUTTABSECTION_PRT
RECT_HEADERFOOTER_PRT

Change-Id: I2d7d159cf5f1a2022c015e37df4aa71cae1e266c
2017-02-13 08:17:42 +02:00
Noel Grandin
beb8cfcf32 convert inventorId to scoped enum
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the
ScOrSwDraw enum constant

Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724
Reviewed-on: https://gerrit.libreoffice.org/31037
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21 12:09:09 +00:00
Stephan Bergmann
f1cb6a031e loplugin:staticmethods: sw
Change-Id: I2b06eb926ebc8ab04883da3272ea239a12e09436
2016-10-07 12:07:43 +02:00
Noel Grandin
480f6916ef loplugin:countusersofdefaultparams in sw
Change-Id: I65beb17816641cff6a07379b7ba234afe26806b3
Reviewed-on: https://gerrit.libreoffice.org/29488
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-04 06:36:22 +00:00
Noel Grandin
20a9e101d9 loplugin:constantparam
clean up the plugin a little, and try to catch params which are default
constructed, which doesn't seem to be working yet

Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12
Reviewed-on: https://gerrit.libreoffice.org/28861
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14 08:47:06 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin
579426f798 loplugin:constantparam in sw
Change-Id: Ic49d1c3c7b57fb213964ddc21b0f774c762aad94
2016-09-08 09:23:40 +02:00
Gulsah Kose
37a3fc1ca2 tdf#101390 Add Arrows toolbox functions on writer drawingbar.
Writer arrows toolbox includes following commands
.uno:LineArrowEnd
.uno:LineCircleArrow
.uno:LineSquareArrow
.uno:LineArrows
.uno:LineArrowStart
.uno:LineArrowCircle
.uno:LineArrowSquare
.uno:Line

Change-Id: I91af27826ea411eabfa61c11962cfb85d2d2aab2
Reviewed-on: https://gerrit.libreoffice.org/28363
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
2016-09-07 21:31:27 +03:00
Noel Grandin
228d0950f5 loplugin:countusersofdefaultparams
Change-Id: I7150494a56abc6ec9c7fba39cefe3967a475f073
2016-08-25 13:47:05 +02:00
Noel Grandin
e382aa1445 convert SdrHitKind to scoped enum
Change-Id: Ia7a18814fed7787e47ac2d3c02654a3648c5491e
2016-08-22 08:24:48 +02:00
Noel Grandin
eba160af21 convert SdrCreateCmd to scoped enum
Change-Id: I8772032dee25c790314384750b8c7277c4879318
2016-08-19 08:18:37 +02:00
Noel Grandin
fc518ed954 convert SdrDragMode to scoped enum
Change-Id: I244132d2240a46f42f14d453e5987968d274e907
2016-08-19 08:18:37 +02:00
Jakub Trzebiatowski
e7ea91f283 GSoC Writer Table Styles; Table Styles Panel
Table styles panel:
+ Added simple table style panel tab icon.
    icon-themes/galaxy/sw/imglst/sf06.png
+ Listing table styles (hierarchical, same order as in container)
+ Listing all table styles (sorted by name).
+ Listing applied table styles.
+ Listing custom styles.
+ Listing hidden styles.
+ Hide/show style.
+ Applying style by double clicking.
+ Highlight current table style.
Everything else yet to be done.

Table styles (SwTableAutoFormat):
+ "hidden" property.
+ "userDefined" property. "Default style" is not user defined. Styles loaded
from tblauto.fmt are also not user defined. Styles loaded from .odt are user
defined. Styles created manually (before binary load/save roundtrip) are user
defined.

Change-Id: I739a48ae1d7ae66f4f8c08076871437ca491bd4e
Reviewed-on: https://gerrit.libreoffice.org/27638
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-01 14:03:07 +00:00
Miklos Vajna
92474c05f8 sw: indentation fixes
Change-Id: I6cdc7cff7c45e58c9b684ff53a8dd84af7cf0c83
2016-07-15 16:26:07 +02:00
Michael Stahl
5593d9e142 sw: speed up the navigator
The call to SwTextBoxHelper::findTextBoxes() in SwDoc::GetFlyNum() made
this so unbelievably slow that in a dbgutil build opening the navigator
on the bugdoc of tdf#94212 the UI freezes because getting all the fly
frames takes longer than the 1 second timeout.

Lets's not retrieve the flys one by one but instead all at once, which
makes it usable again.

Change-Id: Ic41c1648a82dcc3f758ae1b08bac6058f541f25e
2016-06-17 14:07:15 +02:00
Mark Page
d2106d8c8c Remove the :: prefix in ::std for sw
This patch was created using a script
Variable name textual alignment is preserved to the same level

Change-Id: I6b4858f8059b8cf71fc253e87d6df634362d62e9
Reviewed-on: https://gerrit.libreoffice.org/26306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-16 08:02:23 +00:00
Michael Stahl
7b042d2865 tdf#98226: fix undo of table AutoFormat
The new call to SwTable::SetTableStyleName() was not recorded in
SwUndoTableAutoFormat and hence persisted even after Undo.

(regression from 73f4a06c0b)

Change-Id: Ia7f769dafa62f02ff8e4b0596b48266190c7a69b
2016-05-30 23:20:24 +02:00
Noel Grandin
509f0c6a8a loplugin:unusedreturntypes
and clean up the python script

Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f
Reviewed-on: https://gerrit.libreoffice.org/25439
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26 07:26:47 +00:00
Stephan Bergmann
85825e0fd5 Avoid reserved identifiers
Change-Id: I27ff0f4f0eb395d7e0a60dd604758c220a3134c4
2016-04-22 10:08:07 +02:00
Miklos Vajna
ab450ee1ca tdf#84695 sw: make TextBox in shape accessible without mouse
F2 or Enter can now switch to text edit mode.

Change-Id: I1aea09bd2fc4fa64db49b2037894082fe33af934
Reviewed-on: https://gerrit.libreoffice.org/23836
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-04-05 08:59:28 +00:00
Noel Grandin
88e5fa24ea loplugin:constantparam in sw
Change-Id: I68f1594ca3f647d055f5087def74452452f86910
Reviewed-on: https://gerrit.libreoffice.org/23718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01 11:11:04 +00:00
Noel Grandin
9585c8b8c8 loplugin:constantparam in sw
Change-Id: I56925a8fd776b3ee787cc26adbaa08c58dd022c0
2016-03-22 11:47:35 +02:00
Noel Grandin
b47cb646ff loplugin:constantparam
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-15 08:27:25 +02:00
Noel Grandin
c09b3e3237 loplugin:constantparam in sw
Change-Id: I8fa1af4a34770b71f6f4bb28b3313edf4875322b
2016-03-09 10:07:45 +02:00
Noel Grandin
ee74e401aa loplugin:unuseddefaultparam in sw (part3)
Change-Id: Ibff7ac9718929349ee7daa3febb0f8fe4a9fa4db
2016-02-29 11:11:29 +02:00
Michael Stahl
c4727a06fe sw: we don't have space to spell out "focus" in ShLooseFcs...
...but we *do* have the space to mis-spell "lose".

Change-Id: I0cb55d616dfee614e82975b7b3c25a0dcc37d0d7
2016-02-26 13:09:41 +01:00
Noel Grandin
90d892664a loplugin: unused return values
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7
Reviewed-on: https://gerrit.libreoffice.org/21628
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-21 07:18:38 +00:00
Mike Kaganski
b53d426b6f tdf#96600: use frame RTL property for determining active ruler column
Text direction doesn't necessarily coincide with it

Change-Id: I768208d6c4109d2ccd4fc9e6824f8dbd8eabe76b
Reviewed-on: https://gerrit.libreoffice.org/20820
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-01-18 08:57:59 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Robinson Tryon
49c2b9808d bin/rename-sw-abbreviations.sh
This commit renames the most annoying abbreviations in Writer (and
partially in the shared code too).

Change-Id: I77e5134f42f25e3786afa36b7a505c7e3237a9e8
2015-11-25 06:07:38 -05:00
Oliver Specht
fa91dd31f3 5th step to remove tools/rtti.hxx
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11 10:49:30 +00:00
Stephan Bergmann
01b49802c7 loplugin:nullptr (automatic rewrite)
Change-Id: I01e11fa956a249974e77dce9deebe79311f098d0
2015-11-10 10:31:53 +01:00
Ashod Nakashian
04783fd918 Misc tweaks and cleanups.
Streamlined a couple of hotspots and some
minor cleanups.

Change-Id: I85a9423e03f7e20ce78736a44d668da859a443cd
Reviewed-on: https://gerrit.libreoffice.org/19720
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-11-07 21:22:01 +00:00
Noel Grandin
7a401e5e83 com::sun::star->css in sw/inc
Change-Id: I6ffdb1deaa32156c65f997a1a1056928b7cd863d
Reviewed-on: https://gerrit.libreoffice.org/19803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06 05:44:52 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Andrea Gelmini
cf2921ccae Fix typos
Change-Id: Iad3a3d77c5d4412a5c0e0b6adcb9bff3389f863c
Reviewed-on: https://gerrit.libreoffice.org/18983
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-30 11:44:19 +00:00
Stefan Heinemann
c50eb68af3 Renamed wrongly prefixed boolean variables
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
Jan Holesovsky
09fc6fef2d sw table styles: Direct formatting takes precedence over table style.
Make sure we don't reset the direct formatting with the table style when
updating.

Change-Id: I07b4a687fd0403bd80d73732a66101b967398507
2015-09-27 22:48:21 +02:00
Jan Holesovsky
73f4a06c0b sw table styles: Insert column, split table, delete row/column.
Make these operations applying the table style too.

Change-Id: Iee2808a5a5c5f84538474b8fbc6bf53d1fab19b7
2015-09-27 22:48:21 +02:00
Jan Holesovsky
ac6f8bc92b sw table styles: Implement table styles in Writer.
This extends the table auto formats so that SwDoc keeps track of the auto
formats used in the document.  With this in mind, we can update the format of
the table with every operation like adding/removing a line, splitting a table,
etc.

So far we only have the core functionality, and cover inserting a line in
the table; more to come.

Based on work of Alex Ivan <alexnivan@yahoo.com> during GSoC 2013 - thank you!

Change-Id: I7839147e54c2f976988121a523331def9859f4c2
2015-09-27 22:48:21 +02:00
Caolán McNamara
3647626309 Give drawing objects unique names by default
when created through the UI, similar to how
frames and graphics get names.

This way they appear in the navigator by default

Change-Id: I5ec92221583494a0908948d6d0c0815980cb7050
2015-09-17 14:12:08 +01:00
Stephan Bergmann
62f489c88e loplugin:staticmethods
Change-Id: I00acce39f94653ef8e2465f15ba572b619a1c7fb
2015-09-10 23:04:36 +02:00