Stephan Bergmann
62b8119c0d
loplugin:casttovoid: toolkit
...
Change-Id: I1e1c28eac866eba90a9039aab6e1d56b3f886b9e
2017-07-02 22:28:14 +02:00
Noel Grandin
2ccde70d60
teach redundantcast plugin about functional casts
...
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-30 08:50:31 +02:00
Stephan Bergmann
039913c383
loplugin:stringcopy: toolkit
...
Change-Id: I6725d1f1e447d37de2de6442c66a9942b05d2dbf
2017-05-19 17:16:30 +02:00
Noel Grandin
7662e92c64
loplugin:redundantcast find cstyle double casts
...
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8
Reviewed-on: https://gerrit.libreoffice.org/36187
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-06 07:47:30 +00:00
Noel Grandin
ed76d1d350
loplugins:redundantcast teach it about c-style typedef casts
...
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-23 09:48:10 +00:00
Noel Grandin
198c41c4fe
new loplugin unoany
...
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-28 10:17:47 +00:00
Eike Rathke
838fab822c
Resolves: tdf#79250 add typed list to form control listbox
...
... so numeric and text data can be distinguished input.
Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-14 11:49:35 +01:00
Noel Grandin
8c00536d87
Convert WindowType to scoped enum
...
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9
Reviewed-on: https://gerrit.libreoffice.org/34219
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-14 10:44:08 +00:00
Eike Rathke
d3293c7173
Revert "Resolves: tdf#79250 add typed list to form control listbox"
...
This reverts commit e387b69967
.
It breaks toolkit.subsequentcheck with
propertyChangeListener wasn´t called for ´TypedItemList´
Back to the drawing board for the twisted property logic of forms and
toolkit uno control models.
2017-02-11 01:19:37 +01:00
Eike Rathke
e387b69967
Resolves: tdf#79250 add typed list to form control listbox
...
... so numeric and text data can be distinguished input.
Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-10 20:58:52 +01:00
Stephan Bergmann
6dce9c6757
Add missing #includes
...
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849
"Remove dynamic exception
specifications".
Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
Stephan Bergmann
e57ca02849
Remove dynamic exception specifications
...
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html >
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-01-26 12:54:43 +00:00
Caolán McNamara
f9b87a2e50
move GetXGraphic to its only user
...
Change-Id: I72ec4a7e72ca3355a97f987fab70b3e3a8e45168
2017-01-21 14:46:11 +00:00
Caolán McNamara
e22f32b654
don't need intermediate Images
...
Change-Id: I7f36ca335ee7bf24ce634393b24a76c292c9a161
2017-01-20 10:55:31 +00:00
Noel Grandin
e61521f6cf
OSL_TRACE -> SAL in sw..ucb
...
Change-Id: I18f5511f70232d91095ac8527a6c5883c36294f5
Reviewed-on: https://gerrit.libreoffice.org/31762
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-08 17:27:26 +00:00
Noel Grandin
2d48f5fc0a
convert VCLEVENT constants to scoped enum
...
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-12-07 07:10:39 +00:00
Noel Grandin
78b4a1fb01
update vclwidget loplugin to find ref-dropping assigment
...
Look for places where we are accidentally assigning a returned-by-value
VclPtr<T> to a T*, which generally ends up in a use-after-free.
Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9
Reviewed-on: https://gerrit.libreoffice.org/30749
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-11 06:55:41 +00:00
Noel Grandin
e5c1e15eda
loplugin:expandablemethods in toolkit..tools
...
Change-Id: I7221bf131d28804ee93474b11973bbc066cc2764
Reviewed-on: https://gerrit.libreoffice.org/30268
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-26 06:50:03 +00:00
Jochen Nitschke
d1ea6ecda6
replace <<= with assign for <<= with rhs Any
...
found by deleting specialization of '<<=' template
Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2016-10-18 19:16:44 +00:00
Noel Grandin
62223f9a8a
loplugin:unnecessaryoverride
...
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-13 06:47:44 +00:00
Noel Grandin
04a8ba2084
convert ScrollType to scoped enum
...
Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
2016-09-05 08:21:46 +02:00
Noel Grandin
3069878c60
std::list<sal_uInt16> -> vector
...
Change-Id: Ic08ac3fcb750ceff1f5b3201d4a3151ad567aa1f
2016-09-01 11:05:21 +02:00
Stephan Bergmann
14cd5182c5
Replace fallthrough comments with new SAL_FALLTHROUGH macro
...
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10 16:42:16 +02:00
Stephan Bergmann
b7e28df9bb
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: I04d2884dcb81482c5c3450c98cccb36096a126d4
2016-04-20 17:27:28 +02:00
Noel Grandin
789055bc2a
clang-tidy performance-unnecessary-copy-initialization
...
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-18 07:37:31 +00:00
Chris Sherlock
a238b1f8d3
Remove excess newlines
...
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-02-09 08:18:05 +00:00
Stephan Bergmann
175e2adfd1
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ied9204441c07f1f6a6026c8c1a2fa21b93b98e1a
2015-11-10 10:31:54 +01:00
Noel Grandin
4a00be7ade
com::sun::star->css in toolkit/
...
Change-Id: Ia8feca46fa64a300235730e1248fa5fda0783ba2
Reviewed-on: https://gerrit.libreoffice.org/19853
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-09 09:39:36 +00:00
Stephan Bergmann
bd63b48ab0
Avoid dangling references
...
Fixes JunitTest_sfx2_complex broken with
76e75d2dd6
"tdf#93243 replace boost::bind with
c++11 lambdas in toolkit/."
Change-Id: I3119482e4c2e978daf2c2ff34b6ee5007a29397d
2015-11-02 09:09:42 +01:00
Fabio Buso
76e75d2dd6
tdf#93243 replace boost::bind with c++11 lambdas in toolkit/
...
Change-Id: I33ba22fc5b3fa4d9b2b79f33b9abb7a2a0bbf9a2
Reviewed-on: https://gerrit.libreoffice.org/19716
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-01 11:21:08 +00:00
Noel Grandin
7cdbde4867
Initialize Sequence<beans::NamedValue> from initializer_lists
...
Change-Id: I216dcbd983dcf3df79df9fda371b93114540a9d8
2015-10-29 08:57:08 +02:00
Julien Nabet
7ca450cbe5
Related tdf#94557: Combo box entries are case-sensitive (sometimes)
...
Revert partly http://cgit.freedesktop.org/libreoffice/core/commit/?id=76f33f10309b0ee384a75a7a854858b068d60495
author Julien Nabet <serval2412@yahoo.fr > 2015-03-16 21:31:23 (GMT)
committer Caolán McNamara <caolanm@redhat.com > 2015-03-26 14:14:44 (GMT)
commit 76f33f1030
(patch)
tree e12e3b6f2c
parent 6c4100cf81
(diff)
tdf#67990: Management of case in combobox
See comments of tdf#94557 for more information
Change-Id: I0432db0c3f76c20e55d8fecb69734952dc0cf53b
Reviewed-on: https://gerrit.libreoffice.org/19260
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-10-09 06:02:29 +00:00
Matteo Casalin
1ea153bb32
Use better/auto int types, remove a couple of OUStrings copies
...
Change-Id: I911742bddba1dac2641d7d2ac1dad0ed195474dd
2015-09-12 14:18:47 +02:00
Noel Grandin
286dfc2a72
loplugin: defaultparams
...
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-08-11 09:48:18 +02:00
Michael Stahl
300b4fa81a
vcl:: replace boost::function with std::function
...
Change-Id: Ibcc536558f26ed15c59263c25bfeb690950dd3d0
2015-08-03 14:47:43 +02:00
Noel Grandin
dc7fc2074d
convert WALLPAPER constants to scoped enum
...
Change-Id: I3b4b4e8a94904e22823a263bd5446a2e1aa47661
2015-07-24 09:52:08 +02:00
Stephan Bergmann
93f0c1fdd8
loplugin:simplifybool
...
Change-Id: I9875ceec4276382d4bf96bc7e150d594df646602
2015-07-16 14:00:22 +02:00
Stephan Bergmann
e5de5696a4
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: Ib636a7566825dd4bd30cc7e8c2e6b744b619b59b
2015-06-08 16:29:04 +02:00
Noel Grandin
afcf1ecee1
loplugin:loopvartoosmall
...
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
Noel Grandin
66854d697f
convert WINDOW_DRAW flags to scoped enum
...
Change-Id: I9400a286fab18d683b4c109007961685f01b6da3
2015-05-27 11:14:26 +02:00
Stephan Bergmann
562b7b06b8
The corresponding VCL Window is not necessarily a Button
...
Change-Id: I1034ca3cf490e471650617e95fb93bc64eb5fd80
2015-05-22 13:59:30 +01:00
Noel Grandin
566922a98d
convert WINDOW constants for GetWindow() methods to scoped enum
...
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33
2015-05-22 10:37:59 +02:00
Noel Grandin
83eb114394
convert constants in include/vcl/settings.hxx to scoped enums
...
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3
Reviewed-on: https://gerrit.libreoffice.org/15828
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-05-22 06:33:12 +00:00
Michael Meeks
ce82146a6b
Merge remote-tracking branch 'origin/feature/vclptrmerge2'
2015-04-28 15:14:11 +01:00
Michael Meeks
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
Stephan Bergmann
9f387fa51c
css.awt.ItemEvent.Highlighted is of type long
...
Change-Id: Iff42783f04a9a037a6183784478ea66b04aa7d32
2015-04-28 13:44:15 +02:00
Stephan Bergmann
e710c1dbfb
loplugin:simplifybool
...
Change-Id: Ib238714477fdeadad07c470e1d9ed64b2b18f25d
2015-04-24 12:36:29 +02:00
Stephan Bergmann
2240118177
Improved loplugin:literaltoboolconversion looking into cond. exprs.
...
...automatic rewriter fixes
Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
Michael Meeks
5d5f447e73
UnoControls, toolkit, uuoi, xmlsecurity: convert new to ::Create.
...
Change-Id: I7b8c7ece656589c50fb066e9fa1565fd59f930da
2015-04-16 22:21:04 +01:00
Michael Meeks
4804ed902a
Fixup toolkit's printer code.
...
Change-Id: I1d9b0cee1c04e853d38135b84c5c8db24538176e
2015-04-10 14:34:15 +01:00