mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
409,907 Commits 1 Branch 0 Tags
66d19e8f6acda6de9300d86cb15edd2dd5f7228f
Commit Graph

1727 Commits

Author SHA1 Message Date
Stephan Bergmann
de93c6260c loplugin:casttovoid: xmloff 
Change-Id: I4f9ffd686e8e5a10bdd3f5ad4282dc4776923b62
 2017-07-02 22:27:05 +02:00
Noel Grandin
979d58c9a9 loplugin:unusedfields in toolkit..xmloff 
Change-Id: I4964ff97e0a1735dc08c6ad204cae0b08e9ffc2c
Reviewed-on: https://gerrit.libreoffice.org/39406
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-30 19:50:30 +02:00
Noel Grandin
cb96678b3f loplugin:oncevar in xmloff 
Change-Id: I0fbd37685a0006e1fbc98d2b432c2b84d13d6cc8
Reviewed-on: https://gerrit.libreoffice.org/39344
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-28 11:17:34 +02:00
Mohammed Abdul Azeem
c44d9f9e62 Using fast tokens directly: 
Replacing integer-to-integer mapped tokens with
fast Tokens direcly for branching.
Adding a macro XML_ELEMENT that combines namespace
and element tokens.

Change-Id: I8701c8af9607392843460fe726bffb6556cf9b33
Reviewed-on: https://gerrit.libreoffice.org/39275
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2017-06-27 17:51:33 +02:00
Andrea Gelmini
b9ec99ba26 Fix typos 
Change-Id: If28e198b8e1a26660e07dce49db66a651de43d3f
Reviewed-on: https://gerrit.libreoffice.org/38850
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-06-18 21:11:57 +02:00
Jochen Nitschke
a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Noel Grandin
83f9325f0d loplugin:unusedfields xmlhelp..xmlsecurity 
Change-Id: I7e680e1913c787ce0adad5be1f84668d57ad00b3
Reviewed-on: https://gerrit.libreoffice.org/38821
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-16 08:24:49 +02:00
Noel Grandin
b70fa47aec use more SAL_N_ELEMENTS part 1 
- teach comphelper::containerToSequence to handle sized arrays
- also use range based for-loop where appropriate.

Change-Id: I73ba9b6295e7b29c872ee53de7a9340969e07f99
Reviewed-on: https://gerrit.libreoffice.org/38769
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-14 14:17:14 +02:00
Troy Rollo
a5b4cb3f83 tdf#103091 conditional style conditions not saved 
Change-Id: Iccf3eb531ee3382d27105e5ccce6013707a646b6
Reviewed-on: https://gerrit.libreoffice.org/38451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-06-13 18:55:15 +02:00
Jochen Nitschke
febbad7263 cleanup unused css/frame/* includes 
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 13:05:38 +02:00
Stephan Bergmann
f9efb261dd Improved loplugin:cstylecast to reference types: xmloff 
Change-Id: Iff207fb9dfbe5cc354abdeb5833786a52bedbb3c
 2017-06-05 21:17:59 +02:00
Noel Grandin
4a340e36e8 loplugin:constantparam 
add the results files so I can just see the diff in future

Change-Id: Ia20a1aa6418be95ed620719cde340c00b7b053e1
Reviewed-on: https://gerrit.libreoffice.org/37988
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-25 08:12:17 +02:00
Stephan Bergmann
ba9c7c92d6 loplugin:stringcopy: xmloff 
Change-Id: Iec7feb114088357e8f87619ceb5dbfb228e8b5c7
 2017-05-19 17:15:54 +02:00
Noel Grandin
389da66dfc remove unused uno::Reference vars 
found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:56:01 +02:00
Noel Grandin
12191a4f30 make loplugin constantparam smarter about string params 
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 13:52:30 +02:00
Jochen Nitschke
b3eb843766 cleanup tools/debug.hxx includes 
with command
> git grep -l tools/debug.hxx |
  xargs grep -L DBG_ |
  xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'

don't change files in includes/ and */pch

Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:33:01 +02:00
Noel Grandin
034e9de08e loplugin:checkunusedparams in xmloff 
Change-Id: I59d2cb1f69882b62e6fe732e9d9214feec8a79a2
Reviewed-on: https://gerrit.libreoffice.org/37283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:29:26 +02:00
Noel Grandin
9348b322a5 clang-tidy readability-simplify-boolean-expr 
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a
Reviewed-on: https://gerrit.libreoffice.org/36450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-28 11:23:34 +02:00
Noel Grandin
c70d49c7c8 use strong_int for LanguageType 
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448
Reviewed-on: https://gerrit.libreoffice.org/36629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-26 08:50:54 +02:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Noel Grandin
8f254a45d7 loplugin:checkunusedparams in vcl 
Change-Id: I26661684e634aa15a18f78442de15c9db832f319
Reviewed-on: https://gerrit.libreoffice.org/36886
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-25 07:00:51 +02:00
Stephan Bergmann
2f01d67958 Improved loplugin:redundantcast, static_cast on arithmetic types: xmloff 
Change-Id: I67a7f0643b4773c991e780c9a715636bb3e6e6cb
 2017-04-06 18:30:23 +02:00
Noel Grandin
572e9cde74 loplugin:redundantcast find c-style bool casts 
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2
Reviewed-on: https://gerrit.libreoffice.org/36137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-05 12:21:19 +00:00
Caolán McNamara
2f33a8cd23 coverity#1403662 Mixing enum types 
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947
Reviewed-on: https://gerrit.libreoffice.org/36020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-04-02 16:31:48 +00:00
Noel Grandin
9a165a8679 use actual UNO enums in xmloff 
Change-Id: I585825ad3faf972acde548817187183029856971
Reviewed-on: https://gerrit.libreoffice.org/35914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-31 06:59:51 +00:00
Jochen Nitschke
da56de9ac4 remove type decorations on char literals 
they are only needed where type deduction fails.
left them in defines for now.

Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-30 12:21:40 +00:00
Thomas Beck
659cb84664 tdf#96505 Get rid of cargo cult "long" integer literals 
Removed "long" integer literals where applicable in some files of xmloff module

Change-Id: I96f44c00583a95f8a0ae6acf25f439936433ac08
Reviewed-on: https://gerrit.libreoffice.org/35798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-03-28 11:31:30 +00:00
Noel Grandin
ed76d1d350 loplugins:redundantcast teach it about c-style typedef casts 
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c
Reviewed-on: https://gerrit.libreoffice.org/35558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-23 09:48:10 +00:00
Noel Grandin
427678b9cf remove noise UUUU tags in comments 
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00
Reviewed-on: https://gerrit.libreoffice.org/35161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-14 08:23:53 +00:00
Caolán McNamara
e20d9867e2 Werror=maybe-uninitialized on arm toolchain 
Change-Id: If728a1da99d9146d60d15b5273a7a89764b82d51
 2017-03-13 15:51:18 +00:00
Noel Grandin
93985db341 fix android build 
Change-Id: I960768ff98137a50da44348bffeec329295ea95f
 2017-03-13 12:16:34 +02:00
Noel Grandin
7e9857c293 templatize SvXMLEnumMapEntry 
in preparation for "scoped UNO enums".

This is a little hacky: In order to limit the scope of this change,
the templated SvXMLEnumMapEntry struct actually has a fixed size field,
and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various
places, to avoid carrying the type param around.

Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83
Reviewed-on: https://gerrit.libreoffice.org/34987
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-13 09:02:22 +00:00
Stephan Bergmann
6cb9e6dad7 Remove redundant 'inline' keyword 
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-03 20:55:50 +00:00
Andrea Gelmini
d0f99b1b39 Fix typos 
Change-Id: Ibc81246e615d7c68c93e01b84584e78a79bece16
Reviewed-on: https://gerrit.libreoffice.org/34779
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-03-02 10:40:27 +00:00
Stephan Bergmann
c6f21f90e1 loplugin:subtlezeroinit: xmloff 
Change-Id: I1308f4ad4584ac7c657ab9fc2b747c4e3715337d
 2017-02-21 07:34:55 +01:00
Noel Grandin
f5245bf483 loplugin:unusedenumconstants read-only constants in xmloff 
Change-Id: I88afb3b4b3aa7d823c46062ead894561a66ac275
Reviewed-on: https://gerrit.libreoffice.org/33995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-08 08:17:46 +00:00
Stephan Bergmann
6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Noel Grandin
78f392f30a loplugin:unusedenumconstants in xmloff 
Change-Id: Ie9e6d4aa9dba97d45bf7b8afa2347d34e1651a60
Reviewed-on: https://gerrit.libreoffice.org/33871
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 12:55:29 +00:00
Noel Grandin
f4826959c1 new loplugin:unusedenumconstants 
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits

Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:59:39 +00:00
Noel Grandin
1461ebbbb5 expand out ::sax::Converter::convertNumber to OUString::number 
which results in much simpler code overall, there is no need to go via
an OUStringBuffer all the time

Change-Id: I69eba92c93f471fa9a45f97c29c56dcf3cd1ebf8
Reviewed-on: https://gerrit.libreoffice.org/33773
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 08:00:10 +00:00
Noel Grandin
9734a6e1c3 GetWasUsed can return by value, no need to be a special snowflake 
Change-Id: I4ef22fa49ee883ff0bddb49d1711e8521905502f
Reviewed-on: https://gerrit.libreoffice.org/33658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-30 06:06:36 +00:00
Noel Grandin
4142e0a0c0 loplugin: unnecessary destructor writerfilter..xmloff 
Change-Id: I511822dc874101ed3b9850b015b746a86d26c3b5
Reviewed-on: https://gerrit.libreoffice.org/33578
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-27 06:51:11 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Caolán McNamara
936fd770fa just for non exported things 
Change-Id: I448d0009d7c8ffec64fdab76897e8684afe7fcd7
 2017-01-23 10:22:21 +00:00
Caolán McNamara
aac6bb5bb3 ditch some empty dtors which match the default dtor 
Change-Id: Id2450b03e6c8c5461e92d995ea8c33d5dfd55a45
 2017-01-23 10:11:59 +00:00
Caolán McNamara
b29069d163 can use truncate instead of a new OUStringBuffer 
Change-Id: I6efd48af1e00c21675ef0697b38185008a794d7a
 2017-01-20 10:11:56 +00:00
Noel Grandin
968f6a7f02 new loplugin: useuniqueptr: unotools..xmlscript 
Change-Id: I6966d44cff644112dd837adfe7d9c4f459457271
Reviewed-on: https://gerrit.libreoffice.org/33298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-19 11:28:41 +00:00
Stephan Bergmann
76f894f248 New loplugin:externvar: xmloff 
Change-Id: I3fe731a535fe67b4cf260f9c6a36e32732695a7c
 2017-01-09 15:39:25 +01:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies 
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-15 06:45:14 +00:00
Stephan Bergmann
182dfdd00e loplugin:unnecessaryoverride (dtors) in xmloff 
Change-Id: I351ff5955d766118e3a6b2234181774af0d1f522
 2016-12-01 08:53:50 +01:00