mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
409,907 Commits 1 Branch 0 Tags
66d19e8f6acda6de9300d86cb15edd2dd5f7228f
Commit Graph

201 Commits

Author SHA1 Message Date
Thorsten Behrens
0a5d6ac82f xmlsecurity: slightly more modern c++ 
Change-Id: I680bd57a492fe04dc98f2f61ff292e44e544a483
Reviewed-on: https://gerrit.libreoffice.org/37451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-05-10 16:24:17 +02:00
Thorsten Behrens
0a4b0db012 xmlsecurity/source/framework: un-screw-up indent 
This was painful to read.

Change-Id: I34c8038f5db1b9d3f60e9541fa09bb803a680b54
Reviewed-on: https://gerrit.libreoffice.org/37450
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-05-10 01:13:09 +02:00
Noel Grandin
185ed3ddb8 teach loplugin:constantparam about simple constructor calls 
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9
Reviewed-on: https://gerrit.libreoffice.org/37280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:29:03 +02:00
Chris Sherlock
97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock
a85694c4c7 tdf#43157: convert xmlsecurity module away from OSL_ASSERT to assert 
Change-Id: Ib5297ceb307e8f8d475b7ff0523e6a57f72434a5
 2017-05-07 13:03:03 +10:00
Miklos Vajna
90d88b6e46 xmlsecurity: remove unused XMLEncryptionTemplateImpl 
Not needed since commit 0649622956
(loplugin:unusedmethods, 2017-02-21).

Change-Id: I5e8699174202c17309198e541dc904dc1b47a534
Reviewed-on: https://gerrit.libreoffice.org/35031
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-03-10 11:08:22 +00:00
Noel Grandin
0649622956 loplugin:unusedmethods 
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c
Reviewed-on: https://gerrit.libreoffice.org/34508
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-21 10:07:37 +00:00
Miklos Vajna
99263598bf xmlsecurity: remove unused DecryptorImpl 
No longer necessary since commit 50669de687
(xmlsecurity: remove unused xsec_fw_component_getFactory(), 2017-02-02).

Change-Id: I24ee6fcd01a238151058559a7bf994e27b7b64cf
Reviewed-on: https://gerrit.libreoffice.org/34332
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-02-16 10:49:19 +00:00
Miklos Vajna
91af0067c9 xmlsecurity: remove unused EncryptorImpl 
No longer necessary since commit
50669de687 (xmlsecurity: remove unused
xsec_fw_component_getFactory(), 2017-02-02).

Change-Id: Ibbc78888abcd1cb6d7f242c93f28cdaf836cca14
 2017-02-09 11:50:12 +01:00
Julien Nabet
223f1f2b81 Typos 
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52
Reviewed-on: https://gerrit.libreoffice.org/33900
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-02-03 21:09:44 +00:00
Miklos Vajna
50669de687 xmlsecurity: remove unused xsec_fw_component_getFactory() 
No longer needed since commit a4af8986c9
([API CHANGE] offapi: remove unused xsec_fw UNO services, 2017-01-26).

Change-Id: I428c07bfe2846cdc54b35a62554a21197e62245f
 2017-02-02 11:56:26 +01:00
Noel Grandin
4142e0a0c0 loplugin: unnecessary destructor writerfilter..xmloff 
Change-Id: I511822dc874101ed3b9850b015b746a86d26c3b5
Reviewed-on: https://gerrit.libreoffice.org/33578
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-27 06:51:11 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Stephan Bergmann
8ccd11e1ae New loplugin:dynexcspec: Add @throws documentation, xmlsecurity 
Change-Id: I2447c028add359952e4bd36dbdc1d5431fe48104
 2017-01-19 18:03:08 +01:00
Miklos Vajna
716db7dd4a xmlsecurity: hold XMLEncryptionTemplateImpl by rtl::Reference 
Going via UNO for a class in the same directory is an overkill.

Change-Id: Ia06561a95cd10a7aa52a1b84598f88c43e57e7a1
Reviewed-on: https://gerrit.libreoffice.org/33300
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-01-19 10:02:48 +00:00
Noel Grandin
b022985505 loplugin:unusedfields 
Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1
Reviewed-on: https://gerrit.libreoffice.org/32873
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-10 06:28:22 +00:00
Miklos Vajna
9739392cbd xmlsecurity: hold XMLSignatureTemplateImpl by rtl::Reference 
Going via UNO for a class in the same directory is an overkill.

Change-Id: I3dd09a74b6113c472402632bd54bc5bcf32f69bf
Reviewed-on: https://gerrit.libreoffice.org/32748
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-01-05 15:31:33 +00:00
Noel Grandin
46d3163f77 loplugin:unusedmethods 
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5
Reviewed-on: https://gerrit.libreoffice.org/32336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-23 04:46:35 +00:00
Miklos Vajna
517994c640 xmlsecurity: instantiate SignatureCreatorImpl directly in XSecController 
Going via UNO for a class in the same module is an overkill.

Change-Id: I3a24bc770e40be5b0a6fc34206e92f968de060ae
Reviewed-on: https://gerrit.libreoffice.org/32271
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-12-21 08:06:26 +00:00
Miklos Vajna
7920ba294b xmlsecurity: instantiate SAXEventKeeperImpl directly in XSecController 
Going via UNO for a class in the same module is an overkill.

Change-Id: I577660513022fde1576df19b412fcdb1ee2ad041
Reviewed-on: https://gerrit.libreoffice.org/31461
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-12-01 09:42:07 +00:00
Miklos Vajna
9691cea443 xmlsecurity: instantiate SignatureVerifierImpl directly in XSecController 
Going via UNO for a class in the same module sounds like an overkill.

Change-Id: Iaa5b31d1b888c8d3f1c9b47ee787504191ce3d7d
Reviewed-on: https://gerrit.libreoffice.org/31148
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-11-24 14:22:45 +00:00
Noel Grandin
5f77e6e930 update loplugin:unnnecessaryvirtual to handler destructors 
and update modules writerfilter..xmloff with the resulting changes

Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c
Reviewed-on: https://gerrit.libreoffice.org/30530
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-04 07:15:03 +00:00
Tor Lillqvist
38dc4ea899 Bin unused XSecuritySAXEventKeeper::cloneElementCollector 
Change-Id: Icc0ead769fa0a052f7d4dfbc825c96dbb513b33f
 2016-11-03 11:10:59 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
2383d557e5 clang-tidy misc-unused-alias-decls 
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124
Reviewed-on: https://gerrit.libreoffice.org/25075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 13:07:28 +00:00
Stephan Bergmann
f3059ab1dc loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I96cef821fc1d87963b8928af5dfc8ba97557da74
 2016-04-20 17:27:32 +02:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Stephan Bergmann
ec9b260029 Remove unused _USECOMPRESSEDDOCUMENTHANDLER 
...introduced with 9f34fde7a8 "libxmlsec" but
always unconditionally defined.  Fix some indentation.

Change-Id: Ib46d4d7153d84975e9bcd8351779634f8d43240c
 2016-04-12 15:50:21 +02:00
Noel Grandin
43d57d105d com::sun::star->css in xmlsecurity/ 
Change-Id: I4b89f97671ab526e5731d2f1f99802e23f3fd4b5
 2016-03-14 13:28:04 +02:00
Miklos Vajna
eb63915f0a xmlsecurity: clean up no longer relevant email addresses 
Change-Id: I224a0914bd3506b4e2ce057c53838ec78187b060
 2016-03-11 09:11:38 +01:00
Noel Grandin
b4fda7b3f9 new loplugin:constantparam 
finds parameters that are only ever being called with a single value

Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
 2016-03-08 09:04:47 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Andrea Gelmini
64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Noel Grandin
a218039d2a loplugin:unusedfields in xmlscript,xmlsecurity 
Change-Id: I5239766f2105fb1a7823215a4ffe48891e000c3d
 2015-12-21 12:45:49 +02:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Stephan Bergmann
3a2037b11c loplugin:nullptr (automatic rewrite) 
Change-Id: I2093e93e07ff19a1a1d2c8b6f221dac2bf2a2613
 2015-11-10 10:32:02 +01:00
Noel Grandin
9e8ff13eb2 use uno::Reference::set method instead of assignment 
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
 2015-11-05 13:32:17 +02:00
Noel Grandin
3d784c4af6 remove extra spaces around :: 
just makes it harder to grep for methods

Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
 2015-10-26 09:12:05 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Andrea Gelmini
4678982056 Fix typos 
Change-Id: I2cdfc4e9d8ba1acb7c2548f9394d320c6504207e
Reviewed-on: https://gerrit.libreoffice.org/18997
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
 2015-09-29 22:13:57 +00:00
Takeshi Abe
889d825879 xmlsecurity: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Ie8f972330f6bc88e205290dcbe666895b7bad43f
Reviewed-on: https://gerrit.libreoffice.org/18557
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-14 06:24:12 +00:00
Adolfo Jayme Barrientos
3e926736c7 Miscellaneous typos 
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
 2015-07-21 04:53:48 -05:00
Noel Grandin
e963a88912 formatting of public/private/protected section qualifiers 
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 09:49:35 +00:00
Andrea Gelmini
1a8915ef83 Fix typos 
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2015-06-30 15:57:12 +00:00
Stephan Bergmann
46a1538d14 loplugin:stringconstant: handle OUString+=OUString(literal) 
Change-Id: I8e819192d4464c3d03feb908b9acae5f91161fe9
 2015-06-26 13:55:36 +02:00
Stephan Bergmann
642f4e574c loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: Idcaafa47f1891858d2ac4cdc536065cbc127b7c4
 2015-06-08 16:30:07 +02:00
Julien Nabet
16f1477a2d Remove include stdio (part7) 
Change-Id: I7058ac53f4bbf96eff9a36a03279ab0753cc42ba
Reviewed-on: https://gerrit.libreoffice.org/16135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-07 15:33:38 +00:00
Stephan Bergmann
3f846cb7a4 loplugin:cstylecast: deal with those that are (technically) const_cast 
Change-Id: I7128d99926bddf5ffd0a87099c7fa3ce3a1e08e0
 2015-06-02 11:29:00 +02:00
Caolán McNamara
dcee23b7f8 cppcheck: noExplicitConstructor 
Change-Id: Idcf5460ec59cfb6f13055652c094d460c15da5ed
 2015-05-20 20:40:54 +01:00
Caolán McNamara
869e477484 cppcheck: noExplicitConstructor 
Change-Id: Iea5bb0504518b380c3fe7c238d376dc26be8a7ef
 2015-05-04 20:13:52 +01:00