mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
423,503 Commits 1 Branch 0 Tags
Commit Graph

423503 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Samuel Mehrbrodt
57cc8b2e4f Fix svg to base64 conversion 
This reverts part of ab14a9708d2937bc767c14542610ce91b56dda1e which had
a questionable fix by unconditionally removing the first 8 bytes of the svg
which led to svgs starting with

rsion="1.0" encoding="utf-8"?>

instead of

<?xml version="1.0" encoding="utf-8"?>

Change-Id: I8c4d78db1794473d20ddd77019ae81b88be0bb03
Reviewed-on: https://gerrit.libreoffice.org/54550
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-05-22 06:56:18 +02:00
Samuel Mehrbrodt
13596e704e Don't pass ODF version, just retrieve it directly 
Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf
Reviewed-on: https://gerrit.libreoffice.org/54483
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-05-22 06:55:27 +02:00
Samuel Mehrbrodt
99337b029a Rename parameter bScriptingContent -> bSignScriptingContent 
Change-Id: I227e59417719625a9752e727060f5e4f5094092d
Reviewed-on: https://gerrit.libreoffice.org/54479
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-05-22 06:53:08 +02:00
Samuel Mehrbrodt
039117eb27 Simplify SignContents_Impl by moving readonly check to caller methods 
Change-Id: I95d9b12d7e1fc715363396e10bc4adc869978c44
Reviewed-on: https://gerrit.libreoffice.org/54478
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-05-22 06:52:31 +02:00
Samuel Mehrbrodt
c4409edb4e Reduce indentation by returning early on error condition 
Change-Id: Iebf6eca68f0dcba87ab517952009ee6dfb4b588c
Reviewed-on: https://gerrit.libreoffice.org/54475
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-05-22 06:50:28 +02:00
Vasily Melenchuk
b9ebabd675 tdf#97231: basic: do not use extra wrapping for string marshaling 
previous approach did wrap string reference once again, making
practically "a pointer to pointer to string" so this code was not
working correctly for RegQueryValueExA WinAPI call.

String is already provided as a reference (see marshalString(), so
no reason to wrap its reference.

This approach was just copied from from dllmgr-x86.cxx plus some
minor changes to make both versions similar.

Change-Id: I85065112407de3f078265d2c76437814402eb1b3
Reviewed-on: https://gerrit.libreoffice.org/54645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-22 01:07:46 +02:00
Tor Lillqvist
92664be7f8 Fix misleading comment: We do check HAVE_FEATURE_READONLY_INSTALLSET... 
...at least in a couple of places, and at least for a sandboxed macOS
build that check does its job, it prevents write attempts into the app
bundle.

Change-Id: I6d243d3e8a4c77f03a8265125aefd75becbf0998
 2018-05-22 01:47:54 +03:00
Jim Raykowski
137c38a1ba tdf#117189 Fix table InsertRow redo 
Change-Id: I92ce18105550d9514b18b81080cfd0c19dfe648b
Reviewed-on: https://gerrit.libreoffice.org/53618
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-21 22:26:37 +02:00
Zdeněk Crhonek
9913458256 uitest - Calc standard filter 
Change-Id: I578e0fa94326677ce277cd24e043c699d152a5dd
Reviewed-on: https://gerrit.libreoffice.org/54636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
 2018-05-21 21:44:43 +02:00
Caolán McNamara
52eb2804bb weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFields 
Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900
Reviewed-on: https://gerrit.libreoffice.org/54541
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-21 21:40:03 +02:00
Caolán McNamara
2632adfbc2 weld SfxCheckinDialog 
Change-Id: Iaa7954baf734229683acb81819daa332b02a7733
Reviewed-on: https://gerrit.libreoffice.org/54624
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-21 21:39:50 +02:00
Tor Lillqvist
c3a4937604 loplugin:staticaccess 
Change-Id: I9e8accc56fc1d3b095390944a5ae2fc80bcbc05d
 2018-05-21 22:00:02 +03:00
Kshitij Pathania
24d43f21e9 Activated notebookbar in draw 
Added tabbed and two groupedbars mode of notebookbar.

Change-Id: I208a365139ca6c83510a73a8ffa0260b05787793
Reviewed-on: https://gerrit.libreoffice.org/54547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-05-21 20:58:18 +02:00
Michael Stahl
82e9d2e68f check-elf-dynamic-objects: Fedora 28 GTK+ depends on libfribidi.so.0 
... so add it to whitelists.

Change-Id: Ia9f55ecfa9dcbc809827070e0ae6522f1e7ba2bf
Reviewed-on: https://gerrit.libreoffice.org/54607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-05-21 20:50:49 +02:00
Takeshi Abe
338d5f14ba sw: Ask current datetime only once 
Change-Id: I99bed9a09ed1701ce441ddb0a19b5259ab37f135
Reviewed-on: https://gerrit.libreoffice.org/54621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-21 20:42:55 +02:00
Olivier Hallot
aa8ea7d8c2 Updated core 
Project: help  4e45182924569adab9bc43ec174b3c4c828c7452

tdf#102259 formula groups at Statistics tab page

Change-Id: I206139776c77e8855bd82fc5b5ffaa6c0ec60147
Reviewed-on: https://gerrit.libreoffice.org/54627
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2018-05-21 20:02:47 +02:00
Bjoern Michaelsen
0c02f3c5d6 dont use SwClient/SwModify in unocore: RefMark 
Change-Id: I021f410793c9debfe5e984d591144636d6793fd6
Reviewed-on: https://gerrit.libreoffice.org/54610
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
 2018-05-21 18:39:12 +02:00
Caolán McNamara
4da8aef204 weld ODateTimeDialog 
Change-Id: Id93147f1d442e1e5f1cfba8ef2f9e476f4f6d728
Reviewed-on: https://gerrit.libreoffice.org/54623
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-21 18:33:31 +02:00
Tor Lillqvist
17ad73232f In fact it's simpler to not have m_guid fields in these two classes at all 
We can just pass the GUID as parameter to the single member function
registerClass() that needs it. This perhaps means the same class can
be used in more cases, also for objects/classes that aren't going to
be registered and don't need any GUID.

Change-Id: I28703190c52b14236c6f613dd4acbe359c075f5c
Reviewed-on: https://gerrit.libreoffice.org/54622
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-05-21 17:59:18 +02:00
Caolán McNamara
e4d95fa557 weld SchAxisDlg 
Change-Id: I18441b4fc06b69caf12dc73e5042ad2b609a7cc5
Reviewed-on: https://gerrit.libreoffice.org/54620
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-21 17:12:36 +02:00
Olivier Hallot
03341d4e9e Updated core 
Project: help  1d9b92c466b2b920ff46987d1668f4494b9f743a

Fix media path for en-US

Change-Id: If3a9667fa3dd8c1007132448a23e75d66279a192
Reviewed-on: https://gerrit.libreoffice.org/54640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2018-05-21 16:55:11 +02:00
Caolán McNamara
8a5d6f832d weld SplinePropertiesDialog 
Change-Id: I1df0f2bce86da698205c5b36217f935e0e971de5
Reviewed-on: https://gerrit.libreoffice.org/54619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-21 16:31:44 +02:00
Tor Lillqvist
40f28cbaaa Add sal/osl/unx/file.cxx for debugging convenience 
Change-Id: Ibfc8995c4d35c33fe203b9779b10a182cf5a4294
 2018-05-21 17:14:44 +03:00
Jim Raykowski
86d2efcaf3 fix navigate by previous headings does not wrap when cursor position 
...is before first heading

unreported bug fix for a patch I made for tdf#115600

Change-Id: I7ccaad387c5ea344cda71d3cc1f185e590a1f586
Reviewed-on: https://gerrit.libreoffice.org/54059
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 16:08:16 +02:00
Samuel Thibault
d5bb7db998 gla11y: Enable warnings for more widgets missing a label 
Namely
GtkSpinButton
GtkSpinner
GtkProgressBar

Change-Id: I00c1d03cde43d23cee5e8b502a03284ac81967a5
Reviewed-on: https://gerrit.libreoffice.org/54131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 16:06:21 +02:00
Jim Raykowski
e3ffa913e5 Improve placement of tdf#117024/tdf#117283 patches 
no need to repeatedly call so relocate the patches

Change-Id: I87f8be3c1802924e76134d3221a72b04c1a03e54
Reviewed-on: https://gerrit.libreoffice.org/53919
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 16:04:26 +02:00
manujvashist
8133978853 tdf#98544 Other Options remain expanded if any checkbox is checked. 
Change-Id: I2de79da0f0a6295d4d3c294d7cf6c123fca914bc
Reviewed-on: https://gerrit.libreoffice.org/51190
Reviewed-by: Manuj Vashist <manujvashist@gmail.com>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 16:03:18 +02:00
Daniel
7c5f1caa77 tdf#117581 impress: fix selection overlay after moving table 
Change-Id: Ie5afa4fbddf86c6692a7ed68af9ef990c2f9f487
Reviewed-on: https://gerrit.libreoffice.org/54493
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 15:51:33 +02:00
Jim Raykowski
b3b169ddd9 tdf#115600 Display messages in FindBar for Footnote navigation 
...and make Footnote navigation wrap

Change-Id: Ie4ab6a5d34ba75119f900f46a983a031b84ab51a
Reviewed-on: https://gerrit.libreoffice.org/54556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 15:48:10 +02:00
Vasily Melenchuk
de9620dd45 tdf#97231: potential crash fixed 
blob2 pointer can be invalidated during marshalString() call,
because it also adds new element in data vector and thus later
access to blob2 can cause crash.

Change-Id: I2de519c363193f34b249e7250a016397b7420882
Reviewed-on: https://gerrit.libreoffice.org/54613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 15:41:09 +02:00
Khaled Hosny
6a54247c7d Partially revert "Fixup 23c5125148a8110d88385b29570bf0b7d4400458" 
This reverts most of commit e8d48dd75a1bb31b5bc500bc79fb80384a09bcc6.

Hopefully it will make the Win@42 tinderbox happy again.

Change-Id: Ie5ef2c16a62e774dcd1f6005df3d86e1973dea2d
Reviewed-on: https://gerrit.libreoffice.org/54567
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-05-21 15:13:19 +02:00
Jan Holesovsky
6ede92ec39 lokdialog: For the tunneled top-level popups, provide the position in twips. 
Change-Id: I7b1ca50b06c3bdf0958bb88946873c6ddf717b0e
Reviewed-on: https://gerrit.libreoffice.org/51952
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/54628
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
 2018-05-21 15:08:12 +02:00
Olivier Hallot
423f4ac936 Updated core 
Project: help  ffe3c4dc36948c44fc17b860c3b5020131cd391c

tdf#117593 l10n of collateral file pivot.ods

Change-Id: If487dcb74a7e8c61ee152365ba56ad0c6b010ba1
Reviewed-on: https://gerrit.libreoffice.org/54626
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2018-05-21 14:01:18 +02:00
Tor Lillqvist
79a6290969 There is nothing called o2u_anyToVariant 
Change-Id: I7118843fde87a2d587f0e4ec99d146c379da618e
 2018-05-21 13:22:58 +03:00
Tor Lillqvist
7c7b3c70e1 These fields can be const 
Change-Id: I103f06b9c7f14ac7eff9911ab5bebc4c98e7d41f
Reviewed-on: https://gerrit.libreoffice.org/54614
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-05-21 12:13:13 +02:00
Tor Lillqvist
0653ddb116 Updates by Xcode 9.3 
Change-Id: Ia9a87f3f9bdf357079c6d259d736504e0109bf57
 2018-05-21 13:04:49 +03:00
Arkadiy Illarionov
5dab28cdad tdf#96099 Remove unused typedef from shell/source/tools/lngconvex 
Also remove empty defs.hxx

Change-Id: I35f70cc13f0198623d99cfd1e294808ac90f5f02
Reviewed-on: https://gerrit.libreoffice.org/54600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-05-21 10:18:34 +02:00
Bjoern Michaelsen
83a4a6286f dont use SwClient/SwModify in unocore: Style 
Change-Id: I8b2b7378ea21ad1fcfa607aadb0f442838a6cc27
Reviewed-on: https://gerrit.libreoffice.org/54611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
 2018-05-21 09:55:11 +02:00
Takeshi Abe
622691b895 sc: Avoid looking up system clock twice to get current datetime 
Change-Id: I904067260c15263f8169f095809e642d0738f6bb
Reviewed-on: https://gerrit.libreoffice.org/53957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-21 09:11:29 +02:00
Noel Grandin
f7a011c45b loplugin:unusedfields in sc 
Change-Id: I04aee9574b97d6120fe20be97b2c0fb8187fb260
Reviewed-on: https://gerrit.libreoffice.org/54453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-21 08:58:55 +02:00
Bjoern Michaelsen
6e7e4d9f02 dont use SwClient/SwModify in unocore: Bookmark 
Change-Id: Iea03642c6b1de1160b98e3b61e831588bb6207b7
Reviewed-on: https://gerrit.libreoffice.org/54609
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
 2018-05-21 02:18:33 +02:00
Olivier Hallot
1e9304e2b0 Updated core 
Project: help  a9cecd08312f8115c657a640a05bb91f21248f0a

Add support for localized collateral files

Fix src

Change-Id: I4997884f087b625c8ac8dbf923363d97f88f7922
Reviewed-on: https://gerrit.libreoffice.org/54599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
 2018-05-21 00:32:24 +02:00
Bjoern Michaelsen
db608e8e5e dont use SwClient/SwModify in unocore: TextRange 
Change-Id: Ib87647671776e9c6ef5a9c5a7b75a638452b4555
Reviewed-on: https://gerrit.libreoffice.org/54605
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
 2018-05-20 23:15:47 +02:00
Caolán McNamara
b0a5d36c12 coverity#1435682 Unchecked return value 
and

coverity#1435683 Unchecked return value
coverity#1435685 Unchecked return value

Change-Id: I089d6bdfc80f18c38402b61177d85505fc4c4b36
Reviewed-on: https://gerrit.libreoffice.org/54589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:19:03 +02:00
Caolán McNamara
ca11699dbb coverity#1435678 Resource leak 
Change-Id: I994508d0d88fa6727c49d568956887ca1d22ce7e
Reviewed-on: https://gerrit.libreoffice.org/54588
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:17:01 +02:00
Caolán McNamara
d437650712 coverity#1435680 silence Unchecked return value 
Change-Id: Ie7e7f234d32a42ec4747f20172e92c6edc637faf
Reviewed-on: https://gerrit.libreoffice.org/54587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:16:48 +02:00
Caolán McNamara
89e54a995e coverity#1435686 silence Copy-paste error 
Change-Id: I017307e9b125dd0fe970736c6ebe482f08d54e90
Reviewed-on: https://gerrit.libreoffice.org/54586
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:16:20 +02:00
Caolán McNamara
0abc99de2c coverity#1435684 deliberate 'Constant' variable guards dead code 
Change-Id: I0a5b36ad781bfc76295e91131bdc073dac0d6ea2
Reviewed-on: https://gerrit.libreoffice.org/54585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:15:45 +02:00
Caolán McNamara
7b4a3cefdd weld ScDataPilotDatabaseDlg 
Change-Id: Ie8e9914bb8042e33a2ab2a1e07bb0203a54d5422
Reviewed-on: https://gerrit.libreoffice.org/54584
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:15:27 +02:00
Caolán McNamara
ef200af897 coverity#1435679 Uninitialized scalar field 
Change-Id: I5941e14ad36020363a55b4e3d3aa89eba4d7b3c3
Reviewed-on: https://gerrit.libreoffice.org/54583
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-20 21:14:58 +02:00