Commit Graph

349860 Commits

Author SHA1 Message Date
Caolán McNamara
aa0e805a81 coverity#704770 Unchecked dynamic_cast
Change-Id: Ib690d6ad50e89f6cf4b1046fde6bea2d669b971d
2014-04-04 12:14:20 +01:00
Caolán McNamara
9754ac4ee7 coverity#704743 Unchecked dynamic_cast
Change-Id: I35067c31c3a083791436eba9690d592f0099d3b5
2014-04-04 12:14:20 +01:00
Eike Rathke
3bc729b4b9 resolved fdo#76777 now write correct number style condition operator !=
https://gerrit.libreoffice.org/8834 and
https://gerrit.libreoffice.org/8836 will prepare 4.2.4 and 4.1.6 to
accept the correct != operator instead of <> that was written so far.

Change-Id: Ib89bbaf096e2d459767c4d05e5bf5151a1120c1a
2014-04-04 12:26:04 +02:00
Eike Rathke
dfcc851d65 accept proper number style condition != as not equal operator, fdo#76777
ODF 1.2 specifies '!=' as not equal operator in <number:number-style>
<style:map> style:condition attribute. So far '<>' is written, accept
the correct operator.

Change-Id: I6087992ee35fff5c7aa52b7cec2b83b0a78dbac1
2014-04-04 12:06:01 +02:00
Sourav
df098f6207 fdo76734-Text Box is not preserved for file created in MSWord 2007.
Issue:Only one AlternateContent is getting written in the RT file irrespective of
the number of TextBoxes in the original file which is causing the issue.
RootCause is found in DocxAttributeOutput::OutputFlyFrame_Impl where under case
sw::Frame::eTxtBox,m_aFramesOfParagraph.push_back(sw::Frame(rFrame)); is getting executed only once.
push_back should happen as many number of times as there are TextBoxes in the original file.

if(rFrame.GetFrmFmt().GetName() == m_aFramesOfParagraph[nIndex].GetFrmFmt().GetName())
	bDuplicate = true;

In the above check both the GetName() are returning values as empty which leads to
bDuplicate equals TRUE and hence push_back does not happen.
I have introduced one more check to handle this.

Also changes are made in for loop to make it more efficient.

Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
	https://gerrit.libreoffice.org/8782

Change-Id: I397aa3c4548cb57e8dacbf3fbf9ebaf87c0daa80
2014-04-04 11:39:06 +02:00
Caolán McNamara
c067735f22 make query fax number dialog a little less lame
Change-Id: I73e68fcbbff5d153196e5ad617e04c3d5c52e513
2014-04-04 10:14:24 +01:00
Miklos Vajna
8baff038be fdo#76628 RTF import: allow the same font to have multiple encodings
Commit bbe3627eec (rtftok: stop sending
sprm:CRgFtc{0,1,2} tokens, 2014-03-05) dropped support for case when a
font name is used in multiple entries in the font table, but with
different encodings.

Turns out that this is a valid use-case, so revert back to the old
behavior where the key of the encoding table is the font index, not the
font name.

Change-Id: I048dff58af801d704fd4bc75a6a4dcb0f03bf185
2014-04-04 10:53:27 +02:00
Jacobo Aragunde Pérez
ad6c7bc74c Fix -Werror=type-limits and -Werror=sign-compare
This time hopefully for real

Change-Id: I5bf06a9353ea94aef04d862ab25dfc38129b2b12
2014-04-04 10:40:52 +02:00
Matúš Kukan
e250a013ba webdav: Allow to save documents again, after locking is implemented.
We need to extend PUT method with lock token in 'If' header, so that it
does not fail on a resource locked by us.

Change-Id: I82a9e3303a34607dba8bb874d1eb0fac23b9f11d
2014-04-04 10:35:41 +02:00
Caolán McNamara
d13f1ed261 callcatcher: remove old pivot table dialog
Change-Id: I9e80a0d6661c29343103a27baa752cebbc876314
2014-04-04 09:35:20 +01:00
Caolán McNamara
f19ca44a04 callcatcher: update unused code
Change-Id: I23ad8bcbef9a0ef17aaa5d401d111c40a6560ee2
2014-04-04 09:35:19 +01:00
Caolán McNamara
9e8d4c439f coverity#707355 Uncaught exception, help coverity out here
hopefully loads of other ones too

Change-Id: I8445602adc76205448926efe23c9770cef0eb5dc
2014-04-04 09:35:19 +01:00
Caolán McNamara
675194c83d coverity#706238 Uncaught exception
Change-Id: I10bd34115be12dc752987ddbe5d93862aa072e72
2014-04-04 09:35:19 +01:00
Caolán McNamara
59432cffa9 Updated core
Project: help  296331ddff2fdc3d61fde8c762990f80bcc758e5
2014-04-04 03:34:14 -05:00
Stephan Bergmann
247bfbdb46 Move prototype to include
Change-Id: I90c093c704609429f9997f3ffed6a9a79c8956a6
2014-04-04 10:29:26 +02:00
Miklos Vajna
527440c9d9 oox: fix a few bogus SAL_WARN
The idea is that when an element is unhandled, it's either unhandled
explicitly by an empty "case..break" block (so grep can quickly find it)
or we raise a warning. Add a few placeholders for cases that we won't
probably handle better in the near future to silence warnings.

Change-Id: I41dec7802c4671550130393b4f98a8f0d8dfc059
2014-04-04 10:13:29 +02:00
Stephan Bergmann
c5a518936d Clean up unreferenced functions
Change-Id: Ie6560c806369a2d1698b4df43710f3aebb10ed6a
2014-04-04 10:05:58 +02:00
Stephan Bergmann
c8c6c8319f Clean up unreferenced functions
Change-Id: Id2c90088298d389bd1cd8efad9aa26100965d6a2
2014-04-04 10:05:58 +02:00
Stephan Bergmann
705d69a925 Clean up unreferenced functions
Change-Id: I5abc0e587cfd81f1f94c604cb58725a2f84ed33d
2014-04-04 10:05:57 +02:00
Stephan Bergmann
b323e635ee Clean up unreferenced functions
Change-Id: I1dbb864d030b61417f6d137fc967f158e9243ed7
2014-04-04 10:05:57 +02:00
Stephan Bergmann
104096f175 Missing include
Change-Id: Ifbb916e72a00a9e9925fd12e7945f178d7ae200b
2014-04-04 10:05:57 +02:00
Stephan Bergmann
b0200601d4 Clean up unreferenced functions
Change-Id: Id9cb4dbeb6b3313974b881efd6a7c43cb5e314ce
2014-04-04 10:05:57 +02:00
Stephan Bergmann
883844f21a Remove dead test code
Change-Id: Id03246fa9eefce718c36d73f84875f26d58caeba
2014-04-04 10:05:57 +02:00
Stephan Bergmann
9573cd6369 Fix ASCII-only check
...which did not work e.g. for broken single-byte input 0x80.

Change-Id: I4dff41e4f18dfce376695b438004c2af853cf4fa
2014-04-04 10:05:56 +02:00
Stephan Bergmann
bd08874073 Remove dead interlock code:
* Remove interlck_x86.s leftover from 417c85bf58
  "fdo#72598 Remove SunStudio cruft from code base."

* osl_isSingleCPU is always 0.

Change-Id: I44f633d503af0a033a977e0f812e6bd6e4282fca
2014-04-04 10:05:56 +02:00
Stephan Bergmann
c5db1e1519 Remove unnecessary factory function prototype
Change-Id: I5fd41bca54c7b716003eea92e90ddfd08ebfa95a
2014-04-04 10:05:56 +02:00
Tor Lillqvist
f565646382 Turn an unhelpful SAL_WARN into a SAL_INFO
Change-Id: Ic5551e915e724957fed74770b405c39c4e601cda
2014-04-04 10:14:12 +03:00
Muthu Subramanian
cb1384b324 cp#1000054: Avoid crashing.
Change-Id: Iedafa35cfedce1d56468774fcb6bbfa8e42612df
2014-04-04 12:10:01 +05:30
Jacobo Aragunde Pérez
240b8c63ff Fix -Werror=sign-compare
Change-Id: I3c6ff1750d3e6aa6b3b19c957847289067fc5a54
2014-04-04 00:06:28 +02:00
Jacobo Aragunde Pérez
42ced106ff oox: use HasItem instead of GetItemState
Code looks cleaner like this.

Change-Id: I43bd8d2ac40960347d60e687dcae4c17357991b0
2014-04-03 22:19:20 +02:00
Jacobo Aragunde Pérez
ae61569eea oox: Do not overwrite table style properties
Some table properties can be defined by the table style but cells can
overwrite them in their cell properties section. Our exporter was
writing all the cell properties in all cases, regardless of them
being defined by the theme or not, and we shouldn't do that if we
want the document to work properly in Word.

To fix the issue I store the style-defined cell properties (the
format of all four borders) in the table grab bag. The exporter
recovers them and compares with the cell properties before writing
them; if the cell property matches the stlye-defined one, we don't
write it to the document.

An existing unit test was slightly modified to check that the actual
cell properties are not being skipped.

Change-Id: I3aa12d76fb8f73d3fd300f254d19e1683fb6146c
2014-04-03 22:19:20 +02:00
Tomaž Vajngerl
f9636d50e6 pivot: duplicate data field handling
Change-Id: I3d367b8b638217f18143118df00324f21a0470f2
2014-04-03 21:40:42 +02:00
Caolán McNamara
d2356918b0 Updated core
Project: help  c719458fbdafdb833a17874de420876a54e6ded3
2014-04-03 14:32:59 -05:00
Caolán McNamara
49a96a4d38 deploy cunning hack to center arrow block
Change-Id: I372e373844169f216fb856107cc10b063d99e31d
2014-04-03 20:25:04 +01:00
Julien Nabet
bed63f8f09 Typo: colum->column
Change-Id: If667bd38563879a28e9ed7765582ce0fb7e8de04
2014-04-03 21:23:44 +02:00
Julien Nabet
6a38047ff8 Typos
Change-Id: Ia406e2efb1eb2685eeffdf07dcc5fad4fc2b6e94
2014-04-03 21:21:32 +02:00
Julien Nabet
786b31696b Typo: corect->correct
Change-Id: I31267af8aae35d647b8c4b0a0c5f926ad4779919
2014-04-03 21:15:54 +02:00
Eike Rathke
cc658066ae fixed display of available dictionaries strings
Since commit 9dc57be59d under
Tools->Options->LanguageSettings->WritingAids "User-defined
dictionaries" the language strings are displayed as
" '[' Language (Country) ']'"
that before was and instead should be
"[Language (Country)]"

Change-Id: Id7e7ef6ab86112c46707f1451a072dfc196aec44
2014-04-03 21:04:19 +02:00
Miklos Vajna
0695236cd7 writerfilter: DEBUG_PROTOCOL is never defined
Change-Id: I0f6de2041237282c770bd3926140836008d7d12b
2014-04-03 20:35:29 +02:00
Miklos Vajna
338f0eb554 writerfilter: unused WRITERFILTER_OOXML_DLLPUBLIC
Change-Id: I3f14017d6816d59b951c947827ca9497f2cd97fc
2014-04-03 20:35:28 +02:00
Hannah Lyhne
036b1fccbf fdo#73588: fix default alignment in RTL mode.
Change-Id: Icb932ee51dbf32d8baf4382aa00e89a680f5a41d
2014-04-03 13:41:17 -04:00
Caolán McNamara
364c989e2e convert mailmerge output page to .ui
Change-Id: Icafdd4780eebd6356bf2070ff99dbba9d6956c16
2014-04-03 17:29:06 +01:00
Miklos Vajna
5a5d948e23 bnc#821208 DOC import: fix unwanted char background in numbering char style
Word supports formatting the paragraph parker itself, and we import that
as a formatting at a position after the last character (e.g. "foo" will
have that formatting at char pos 3, which is ignored by the layout).

In addition to this hack, commit
1c22545edf (Fix issue #i119405: Numbering
text style changed after importing the *.doc, 2012-08-24) added a
SwTxtNode::TryCharSetExpandToNum() hack to Writer core, where in case
such a paragraph marker attribute is set, and the SwTxtNode has a
numbering, then also modify the associated character style as well.

As that commit already noticed, there are attributes which should not be
propagated to that character style. Extend this blacklist to ignore
RES_CHRATR_BACKGROUND as well, as Word does.

Change-Id: Idcb40d37d8688c76fbd61f28428f6e3bc995f799
2014-04-03 18:07:08 +02:00
Stephan Bergmann
8f5df0dbbe Remove unused copy ctor (and use boost::noncopyable)
Change-Id: Ib797c84e64a114df0e80067a97b714d4f97ff20a
2014-04-03 17:41:56 +02:00
Caolán McNamara
ea3277265a Resolves: fdo#76206 show 'Delete table' instead of 'Delete row'
on deleting a full table

Change-Id: I03af8bcbae41e78229163a945a74387f53787ca5
2014-04-03 15:46:18 +01:00
Caolán McNamara
5a67883ed4 coverity#1079187 Uninitialized pointer read
Change-Id: Ie3044bebc7921b0fa98f9a9a01f99ef0f2d05eb8
2014-04-03 15:46:18 +01:00
Stephan Bergmann
618dc924b4 Remove unused functions
Change-Id: Iac147aef89e7f8be2f3d16e434c76d57a950d591
2014-04-03 15:49:14 +02:00
Caolán McNamara
e813b9c259 Resolves: fdo#39793 open the 'Font' tab after Set Language ... More ...
Change-Id: I23c80a462ef473defe5536f9090167ae734553b7
2014-04-03 14:44:11 +01:00
Stephan Bergmann
993f4921f7 Remove redundant pure override
Change-Id: I5d41b22ba5b27c278d04a70987812a281dd7dba9
2014-04-03 15:43:17 +02:00
Caolán McNamara
2d37dd8d5f Resolves: fdo#76486 Uniform Arrangement of the Help Button
Change-Id: If59c5c4901aeec404099c810a021eea8b8b3d3ab
2014-04-03 14:42:37 +01:00