Commit Graph

11 Commits

Author SHA1 Message Date
Stephan Bergmann
b35bb38f18 Clean away temporarily added using declarations
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
2017-11-07 11:50:47 +01:00
Andrea Gelmini
e1e3def8cc Fix typos
Change-Id: I438b6719817e0bbb47370ec54561eed2bc402cba
Reviewed-on: https://gerrit.libreoffice.org/37783
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-21 12:59:32 +02:00
Stephan Bergmann
9b51d16771 Remove unnecessary restrictions
Change-Id: Idc0db273f7ad2d6b11113752ca01a1f2a327e991
2017-05-18 14:26:47 +02:00
Stephan Bergmann
a7551b34ad Rewrite in macro arguments
Change-Id: I6ae619edac26fe06d1f86f139b7cf71ce31146d4
2017-05-18 14:25:38 +02:00
Stephan Bergmann
64e5915b7a Avoid nested automatic rewrites
...which would come out garbled.  One place is

>             bool bRet = SfxItemState::SET == pSet->GetItemState( i, rAttr.Which() != RES_TXTATR_AUTOFMT, &pItem );

in SwAttrHandler::PushAndChg (sw/source/core/text/atrstck.cxx)

Change-Id: I1486313b25850dc59e10edb38b8bd28a30e6aa63
2017-05-18 14:21:58 +02:00
Stephan Bergmann
6a21827e97 Remove unused var
Change-Id: I187df1a6f5bf5d870820f60c6dca1ac3beb8cf22
2017-05-17 15:01:32 +02:00
Stephan Bergmann
133d06baef Remove unused var
Change-Id: Id0266ad01eaabf2d9555e99f4a4c1c2300bb8be7
2017-05-16 19:44:25 +02:00
Stephan Bergmann
189c3a098e Extend loplugin:comparisonwithconstant beyond integral types
Change-Id: Id3a8fd5d8b9975d3ae49af0648b39454310495fa
2017-05-16 17:19:11 +02:00
Stephan Bergmann
e85fcef1af Try to fix loplugin:comparisonwithconstant's rewrite-with-macros issue
...that had plagued 2e293a731c "new
loplugin/rewriter comparisonwithconstant" (in sal/osl/unx/pipe.cxx), and
auto-rewrite the remaining occurrences in sal (that the mentioned commit had
failed to address, for whatever reason)

Change-Id: I3dc3bae8dd92ba8bf576f6e06e7c9ee21f883661
2017-05-16 16:49:03 +02:00
Noel Grandin
482ef1bfe9 loplugin:comparisonwithconstant in accessibility
Change-Id: I934c78ec8daec656ca656d5c784f80895abfd2e4
Reviewed-on: https://gerrit.libreoffice.org/37666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16 11:57:44 +02:00
Noel Grandin
2e293a731c new loplugin/rewriter comparisonwithconstant
As per sberg' suggestion

Limit it to == and !=, because some people like the flow of inequalities
like: "0 < a && a < 42"

The changes to sal/ were made using the rewriter.

The rewriter still has one bug, in pipe.cxx, it managed to pick up
some random piece of macro. No idea why.

Change-Id: I01305f9c5396a4b6c7421d6e92f1b4b529388e82
Reviewed-on: https://gerrit.libreoffice.org/30962
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06 05:38:14 +00:00