Stephan Bergmann
446f172057
Prevent loplugin:unreffun on explicitly defaulted special members
...
...as started to appear (with sufficiently recent Clang versions only, it
appears) after c5fcb476ac
"toolkit: avoid
-Werror=deprecated-copy (GCC trunk towards GCC 9)":
> [CXX] toolkit/source/controls/spinningprogress.cxx
> toolkit/source/controls/spinningprogress.cxx:38:5: error: Unreferenced externally invisible function definition [loplugin:unreffun]
> SpinningProgressControlModel(SpinningProgressControlModel &&) = default;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: Id78cd2d801e9760dde9e0a594e2b62ec20840204
Reviewed-on: https://gerrit.libreoffice.org/58180
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2018-07-28 00:18:41 +02:00
Stephan Bergmann
e1ab044401
Improve loplugin:unreffun
...
...to avoid a false positive in --enable-qt5
> [build CXX] vcl/qt5/Qt5Widget.cxx
> /home/sbergman/lo/core/vcl/qt5/Qt5Widget.cxx:466:21: error: Unreferenced function declaration [loplugin:unreffun]
> friend QWidget* createQt5Widget(Qt5Frame& rFrame, QWidget* parent, Qt::WindowFlags f);
> ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
Change-Id: I01e47bc5f5147916737d62fe18ce5312a0221a3f
Reviewed-on: https://gerrit.libreoffice.org/55189
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2018-06-01 20:52:41 +02:00
Stephan Bergmann
b35bb38f18
Clean away temporarily added using declarations
...
Change-Id: I26734c13515394162d88351a1cbe2b20abdac865
2017-11-07 11:50:47 +01:00
Stephan Bergmann
f00d538544
Adapt loplugin:unreffun to clang-cl (uses of DllMain and wmain)
...
Change-Id: I6ef1c55ce0fb8fa350559612780a1091d8627d3e
Reviewed-on: https://gerrit.libreoffice.org/42915
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2017-09-29 13:32:36 +02:00
Andrea Gelmini
5262883672
Fix typos
...
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e
Reviewed-on: https://gerrit.libreoffice.org/35617
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-25 08:43:01 +00:00
Stephan Bergmann
d6ff3d49df
Plugin::isInUnoIncludeFile should not cover WORKDIR
...
...that got in, for no apparent reason, when various, slightly different
implementations of isInUnoIncludeFile got consolidated into one.
Change-Id: I64a9eb62703d57a0b7b57720ec9f251ffa780691
2016-10-19 10:56:35 +02:00
Noel Grandin
40fd53a238
loplugins: extract some common functionality
...
Change-Id: If470e1d9b481c9eda0829aa985152baf8fb46d7a
2016-10-18 08:51:07 +02:00
Stephan Bergmann
733198de1b
Remove support for Clang < 3.4
...
Change-Id: I81e97c5f720535b33dd3ce72d01151765e4e93a0
2016-06-29 09:15:25 +02:00
Stephan Bergmann
1ce7176ba1
Remove support for Clang < 3.3
...
Change-Id: I185852a738bac10dc6d331afccfcbc7ae1225cb1
2016-06-29 08:55:27 +02:00
Stephan Bergmann
01f3b95884
These version checks are about the Clang the plugins are built /against/
...
...not the (Clang) compiler they are being built /with/. (Also simplifies the
checking #if code.)
Change-Id: I416321be4ef4478785be40571f81500fd3b6feb8
2016-02-26 14:34:29 +01:00
Andrea Gelmini
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
Stephan Bergmann
623359af23
loplugin:unreffun: workaround for visibility-adding redecls
...
Change-Id: Ic18b44942f4fe02083c0e8167e8c8d4205e66abf
2015-06-09 12:44:31 +02:00
Stephan Bergmann
e48a233960
loplugin:unreffun: also warn about redundant redeclarations
...
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
Stephan Bergmann
9a741fcad4
loplugin:unreffun: also warn about unused function templates
...
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
2014-06-27 07:51:51 +02:00
Noel Grandin
a74193306a
compilerplugins: move isUnoIncludeFile to base class
...
to reduce copy-pasted code
Change-Id: I7728d85dea7d0161998c326d6648ca681a8250d0
2014-06-24 12:48:17 +02:00
Stephan Bergmann
e5199d3d78
Flag unreferrenced functions only declared in the main file, not an include
...
...which appears to be a good heuristic to identify functions that are either
unused or should better be declared just once in an include file. (It also
filters out SAL_DLLPUBLIC extern "C" function definitions, which are most likely
meant to be referenced dynamically via dlsym.)
Change-Id: I7fb78cb836b971791704851535dcfbda2b2f5bc0
2014-04-15 16:57:23 +02:00