Commit Graph

252 Commits

Author SHA1 Message Date
heiko tietze
60413c9800 Replace Galaxy icon theme by Colibre
Galaxy goes into an extension, fallback updated

Change-Id: I4b6998035857f01368b39d4f16b2639d8a665065
Reviewed-on: https://gerrit.libreoffice.org/53092
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-05 10:19:26 +02:00
Noel Grandin
18c2742946 loplugin:useuniqueptr in mysqlc
Change-Id: Ife3a044beae03c7623c1bd3c2ef6ce5595f97cca
Reviewed-on: https://gerrit.libreoffice.org/53223
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-23 08:14:00 +02:00
Stephan Bergmann
61d57bcebd Don't link Library_mysqlc against -lnsl
At least Fedora 28 glibc-2.27-8.fc28 no longer provides the nis development
headers and libraries. (It only still contains some binaries for backwards
compatibility, in the libnsl sub-package: "This package provides the legacy
version of libnsl library, for accessing NIS services.")

The -lnsl was present ever since 4946c62f29
"mysqlconnector: initial import from CWS mysqlnative", but appears to not be
necessary (at least any more).

Change-Id: I10b56cdc1a438fb2978125ae0acde0dbec747e78
Reviewed-on: https://gerrit.libreoffice.org/52536
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
2018-04-07 14:02:35 +02:00
Julien Nabet
932c9065ee Use for-range loops in mysqlc
Change-Id: I3ff3fa5dca6b6b9060b0b38d875e1b7dec1f8245
Reviewed-on: https://gerrit.libreoffice.org/52127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-30 07:03:40 +02:00
Noel Grandin
cb34e6083c loplugin:unusedmethods
Change-Id: I027adbe65edd5f07534bb36f9f54c55f30ba516e
Reviewed-on: https://gerrit.libreoffice.org/50998
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-12 07:36:37 +01:00
Noel Grandin
1b67ad6ff8 remove connectivity OSubComponent
push the logic that is still necessary down into the subclasses

Change-Id: I99424f0b3c654c5652991a4140b17ceb02224e50
Reviewed-on: https://gerrit.libreoffice.org/49087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02 11:21:36 +01:00
Stephan Bergmann
5072e01d07 More loplugin:cstylecast: mysqlc
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I4bc61dbaf5d920e75269564cd92b19ae05046ca6
2018-01-12 20:19:40 +01:00
Noel Grandin
3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Noel Grandin
6084ca8a63 loplugin:finalclasses in mysqlc
Change-Id: I3f0ae04c30e863c123404c6e99f7ae27bc5715c7
Reviewed-on: https://gerrit.libreoffice.org/44134
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-01 07:15:50 +01:00
Noel Grandin
9ee60319c6 loplugin:constmethod in idl,helpcompiler
Change-Id: I9b328fc0a3ebdd15a646ee6dab800ffbadb1aaef
Reviewed-on: https://gerrit.libreoffice.org/44050
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30 13:06:54 +01:00
Stephan Bergmann
60de56cf1a loplugin:includeform: mysqlc
Change-Id: I9c234873c47830b364e069cdedc64806ee7724ad
2017-10-23 22:46:02 +02:00
Noel Grandin
7af521827e use rtl::Reference in mysqlc
instead of manual ref-counting

Change-Id: I7b7c350613976463620a54757add6061cf383a4c
Reviewed-on: https://gerrit.libreoffice.org/43183
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06 10:21:26 +02:00
Noel Grandin
20bae560c0 throw more useful uno::Exception's
if we're going to throw the base class of the exception hierarchy,
we can at least put a useful message in there to make the source a little
bit easier to locate.

Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566
Reviewed-on: https://gerrit.libreoffice.org/42968
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01 18:17:11 +02:00
Julien Nabet
444730a67d tdf#103685: "Commands out of sync" when connecting to MySQL using direct
Thanks to Lionel for his great help

Change-Id: Ifcc1d72cca29c031f31da203cd1e3302ea0ea3e3
Reviewed-on: https://gerrit.libreoffice.org/42688
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-09-24 08:25:57 +02:00
Michael Stahl
b294020098 consistent naming of externals: mysqlcppconn -> mysql-connector-cpp
Change-Id: Ibfb3aa69895eef6023c38e2ff3b7ae98a05f5820
Reviewed-on: https://gerrit.libreoffice.org/42300
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-15 11:06:18 +02:00
Michael Stahl
871d75e9c2 consistent naming of externals: libmariadb -> mariadb-connector-c
The used version is actually named mariadb_client but since 2.1.0
upstream calls it MariaDB Connector/C.

Change-Id: I51b12a9be55151919585dec91a5fc802ff4fc86b
Reviewed-on: https://gerrit.libreoffice.org/42295
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-15 10:59:56 +02:00
Stephan Bergmann
b51fe8ddc1 Remove unused m_aBatchVector members
Change-Id: I7b7ff3295fa5eb87d113b48dcff0cf3c0b12b4ff
Reviewed-on: https://gerrit.libreoffice.org/41780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-01 13:40:35 +02:00
Julien Nabet
70d9ae239b Use vector and replace m_aBatchList by m_aBatchVector
Change-Id: I7c2c529eb78679f9733374bf0785773684c728c4
Reviewed-on: https://gerrit.libreoffice.org/41770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-31 21:44:10 +02:00
Noel Grandin
3dcf6dfcee remove unnecessary use of 'this->'
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02 13:45:36 +02:00
Noel Grandin
c9253818ec loplugin:oncevar
extend oncevar to any POD type

Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0
Reviewed-on: https://gerrit.libreoffice.org/40564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31 08:25:07 +02:00
Noel Grandin
4250b25c6a teach unnecessaryparen loplugin about identifiers
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10 09:57:24 +02:00
Noel Grandin
4b2262ab5b new loplugin unnecessaryparen
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05 11:08:48 +02:00
Noel Grandin
469076317d loplugin:unusedfields l10ntools..rsc
Change-Id: I78785eeab436910c9e8733924a7c43fa998ba36f
Reviewed-on: https://gerrit.libreoffice.org/39491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04 11:26:09 +02:00
Noel Grandin
93d42c1b23 loplugin:oncevar in l10ntools..mysqlc
Change-Id: Ifd4826f8ba4e10f2e012172fa693794d68bb6b4d
Reviewed-on: https://gerrit.libreoffice.org/39188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25 17:19:48 +02:00
Noel Grandin
cb37c5f0f3 loplugin:unusedfields in jvmfwk..mysqlc
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08
Reviewed-on: https://gerrit.libreoffice.org/39099
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23 08:59:20 +02:00
Noel Grandin
2ccde70d60 teach redundantcast plugin about functional casts
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30 08:50:31 +02:00
Jochen Nitschke
959496794c cleanup osl/diagnose.h includes
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09 15:41:46 +02:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25 09:31:31 +02:00
Andrea Gelmini
98ef3edb8a Fix typos
Change-Id: Id5811d092917c872715559f4508d01e4173d090c
Reviewed-on: https://gerrit.libreoffice.org/35636
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 11:02:47 +00:00
Stephan Bergmann
f6262b3dcb Remove redundant 'inline' keyword, Linux redux
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-07 08:12:52 +01:00
Andrea Gelmini
5bea199bae Fix typos
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b
Reviewed-on: https://gerrit.libreoffice.org/34803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02 12:39:35 +00:00
Stephan Bergmann
f89f9aa6ad With GCC -std=gnu++17, dynamic exception specifications cause an error
...instead of a warning (as with Clang), so this follow-up to
e16644fa1c "external/mysqlcppconn: Silence
-Wdynamic-exception-spec errors" patches the (few) dynamic exception
specifications out of external/mysqlcppconn completely

Change-Id: I83a42f1c09e60c15fad1564cf7c42eb3370485da
2017-02-23 12:20:49 +01:00
Stephan Bergmann
e16644fa1c external/mysqlcppconn: Silence -Wdynamic-exception-spec errors
...with Clang in C++17 mode

Change-Id: If51c0788439688f6fbd77c1a05cb3295ac6e8cb4
2017-02-16 18:11:24 +01:00
Noel Grandin
29337650a3 boost::scoped_ptr -> std::unique_ptr in mysqlc
Change-Id: I4c8d25ed451ab03d2b5d0e9977ab74fd2ea1bb04
Reviewed-on: https://gerrit.libreoffice.org/33870
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03 10:48:15 +00:00
Noel Grandin
f4826959c1 new loplugin:unusedenumconstants
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits

Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03 08:59:39 +00:00
Stephan Bergmann
ccb1b1251c Work around GCC 7 -Werror=implicit-fallthrough=
This is in !LIBO_INTERNAL_ONLY code, so cannot use SAL_FALLTHROUGH.  And even on
current <https://github.com/boostorg/config> master, BOOST_FALLTHROUGH does not
yet support [[fallthrough]] for GCC 7.

Change-Id: I5306c3949b13c517fe8ef643cf98c2021147617e
2017-01-31 10:55:16 +01:00
Stephan Bergmann
f669813835 Silence GCC 7 warnings in cppconn/exception.h
Change-Id: Ia924473d3dba11babee23f4137c645b9f8d86a8b
2017-01-31 10:41:35 +01:00
Stephan Bergmann
b61214c91d Remove dynamic exception specifications from !LIBO_INTERNAL_ONLY
...only odk/examples/ remains to be clean up

Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
2017-01-27 10:40:41 +01:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13 06:12:00 +00:00
Noel Grandin
a005fbeddc OSL_TRACE->SAL in framework..sal
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9
Reviewed-on: https://gerrit.libreoffice.org/31903
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13 06:10:04 +00:00
Noel Grandin
401d07f31f loplugin:datamembershadow
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
2016-11-17 11:19:55 +02:00
Noel Grandin
b1f8cf3782 loplugin:singlevalfields
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76
Reviewed-on: https://gerrit.libreoffice.org/30476
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02 13:06:37 +00:00
Stephan Bergmann
d4398c7767 Remove bogus comments about ~IPropertyArrayHelper not being virtual
...which isn't true at least ever since b525a3115f
"initial import", but got copy/pasted all over the place

Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014
2016-10-27 17:08:09 +02:00
Stephan Bergmann
07339d03af Remove obsolete workaround for SUNPRO 5 compiler
...copy/pasted into three more places

Change-Id: I6661244d0248af509cd867fc3e8c451551068a78
2016-09-20 07:55:10 +02:00
Noel Grandin
e592877844 loplugin:unusedenumvalues
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b
Reviewed-on: https://gerrit.libreoffice.org/28942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-18 11:02:45 +00:00
Stephan Bergmann
8be8152bcb loplugin:unnecessaryoverride in mysqlc
Change-Id: I7c8ecc8f675abf4495c991bdb680e31b59421e26
2016-07-15 12:29:52 +02:00
Stephan Bergmann
a6060e02f7 Fix typo relase_ChildImpl -> release_ChildImpl
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
2016-07-12 15:57:36 +02:00
Caolán McNamara
a7415828b8 Revert "tdf#88206 Change use of cppu::WeakImplHelper*"
this doesn't build, I think mysqlc is considered !LIBO_INTERNAL_ONLY
seeing as its an extension

This reverts commit 2d2a33934e.

Change-Id: I600b986632b90e482475628e09256ca5c2b0a6cf
2016-06-09 10:25:49 +01:00
krishna keshav
2d2a33934e tdf#88206 Change use of cppu::WeakImplHelper*
removed <cppuhelper/implbase1.hxx>

Change-Id: I2888e42eec480f0940c3e4f9bcc000c150d1161b
Reviewed-on: https://gerrit.libreoffice.org/26076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-09 07:10:15 +00:00
Stephan Bergmann
336b62080b Missing include
Change-Id: Id61e2de27ec307fa7773d3f0d5a0810005f1c364
2016-05-30 13:33:37 +02:00