mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
437,486 Commits 1 Branch 0 Tags
7b3d401fe8ec01dbcbe511b51f7022bd080b3e8d
Commit Graph

353 Commits

Author SHA1 Message Date
Andrea Gelmini
1a0250c6b8 Fix typo 
Change-Id: I27f9b30f76b6bbd255a346c00d64e2499e7f3b5e
Reviewed-on: https://gerrit.libreoffice.org/70360
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-04-07 08:04:52 +02:00
Arkadiy Illarionov
10a48c737d Simplify containers iterations in basctl, basegfx, basic, bridges 
Use range-based loop or replace with STL functions

Change-Id: I8594740103bdc2091c2d03d4b92bbe8393f5378c
Reviewed-on: https://gerrit.libreoffice.org/69223
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-03-16 20:16:46 +01:00
Noel Grandin
8b5e23eac3 log nice exception messages whereever possible 
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1
Reviewed-on: https://gerrit.libreoffice.org/68579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-03-07 07:12:39 +01:00
Noel Grandin
28239c4043 simplify UNO getTypes methods 
Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550
Reviewed-on: https://gerrit.libreoffice.org/68659
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-03-04 08:52:39 +01:00
Stephan Bergmann
e1e39fac22 Some more WIN32 -> _WIN32 
...at least some of which have presumably been missing from
ce43d0ae92 "use consistent #define checks for the
Windows platform" by accident (and some just clean up comments)

Change-Id: I5532685c7df96ae3c8a25b73d8064d7433964a9b
Reviewed-on: https://gerrit.libreoffice.org/68580
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2019-03-01 17:40:47 +01:00
Noel Grandin
587ac01f97 loplugin:indentation in basctl..bridges 
Change-Id: Ie4e27466c4258c6f774a3ebb82ec3a88c28fd753
Reviewed-on: https://gerrit.libreoffice.org/67525
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-08 10:01:05 +01:00
Andrea Gelmini
53a3181968 Fix typo 
Change-Id: I9b57e73303cb12e818cd761878d0c11c38f4cc3e
Reviewed-on: https://gerrit.libreoffice.org/67481
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-02-07 07:21:21 +01:00
Noel Grandin
30eb0839c5 loplugin:useuniqueptr in basic and framework 
Change-Id: I409c9c572eb8f3d68c8a387844b43988b4ab5c32
Reviewed-on: https://gerrit.libreoffice.org/64949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-12 07:28:49 +01:00
Noel Grandin
38187ec15b loplugin:singlevalfields extend to all static vars 
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528
Reviewed-on: https://gerrit.libreoffice.org/64710
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-07 07:38:24 +01:00
Andrea Gelmini
ee8cba8591 Fix typos 
Change-Id: Ie85b3a61ded8c6fd7a1f8c463912062669b3719b
Reviewed-on: https://gerrit.libreoffice.org/64357
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2018-12-01 02:13:11 +01:00
Noel Grandin
ccb2a1f650 clang-tidy readability-redundant-smartptr-get 
redundant get() call on smart pointer

Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd
Reviewed-on: https://gerrit.libreoffice.org/61837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-17 08:25:47 +02:00
Stephan Bergmann
206b5b2661 New loplugin:external 
...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-09-17 09:05:38 +02:00
Noel Grandin
c2139cafe6 loplugin:simplifyconstruct in accessibility..bridges 
Change-Id: I08f6a64b50f03d1b08027a2ac9e51442255d64bc
Reviewed-on: https://gerrit.libreoffice.org/59976
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-05 09:28:12 +02:00
Jochen Nitschke
89b47b5eb2 cppcheck: useInitializationList in basic 
Change-Id: I97fefc25076c2c163f6010745081772ee8c17712
Reviewed-on: https://gerrit.libreoffice.org/59908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-03 08:34:25 +02:00
Andrea Gelmini
718f63002e Fix typos 
Change-Id: I6ca53ead2b125618d0aceff05d5fdfa374662799
Reviewed-on: https://gerrit.libreoffice.org/58809
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-08-29 17:10:21 +02:00
Noel Grandin
d977e02ec6 unnecessary null check before dynamic_cast, in various 
Change-Id: I76ad0b3152030c29ee28f6a6cc80d0832188d02b
Reviewed-on: https://gerrit.libreoffice.org/58774
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-10 08:21:55 +02:00
Andrea Gelmini
618e1fdac1 Fix typos 
Change-Id: I563ea72a1e3870f5c362527f018c6b63607b4011
Reviewed-on: https://gerrit.libreoffice.org/57597
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-07-18 09:52:44 +02:00
Tor Lillqvist
cac718bfe6 Factor out AsyncQuitHandler to be usable elsewhere, too 
Or do we already have the corresponding functionality somewhere, and
SbModule::Run() could be changed to use that instead?

Change-Id: I6f45d4a023f9f9d9a24ab6934117a712ccbe75e2
Reviewed-on: https://gerrit.libreoffice.org/55048
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2018-05-30 11:28:35 +02:00
Jochen Nitschke
b4d36b5dcf remove some unused comphelper includes 
and fix the fallout

Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359
Reviewed-on: https://gerrit.libreoffice.org/52894
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2018-04-15 11:17:24 +02:00
Julien Nabet
3ceb01afc3 Use for range loops in basegfx and basic 
Change-Id: I5b2086c245695aeb30630150b3c5ccf61fbd6a56
Reviewed-on: https://gerrit.libreoffice.org/50280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-02-24 17:28:43 +01:00
Caolán McNamara
7faa218231 ofz#6311 still problems with SdrEdgeObj listening to same obj at start as end 
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30
Reviewed-on: https://gerrit.libreoffice.org/49821
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-16 00:35:10 +01:00
Tor Lillqvist
73256b9181 Decrease fragility in odd use cases with no current document 
Change-Id: I9966166561d4c6e577f3f7e8e04572f97a0b295e
Reviewed-on: https://gerrit.libreoffice.org/49450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-02-09 00:50:02 +01:00
Noel Grandin
44853cc8be loplugin:useuniqeptr in SbxVariable 
Change-Id: I788ec594589d9708e12db83a7371b5a8d9fed38c
 2018-01-19 08:58:46 +02:00
Noel Grandin
263d732569 loplugin:useuniqueptr in SbModule 
Change-Id: I20525bd69c91ff35c9e569525a0d4556bc184982
 2018-01-19 08:58:46 +02:00
Stephan Bergmann
3a40d3de89 More loplugin:cstylecast: basic 
Change-Id: I0bb219632da384ab047a2b1fc3f2b041dacaf2cb
 2018-01-15 09:07:14 +01:00
Stephan Bergmann
6070aaa47d More loplugin:cstylecast: basic 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I20b38196ee1b6a34384dc46d9de1b6e1b44947ae
 2018-01-12 20:29:14 +01:00
Noel Grandin
ead920a48a loplugin:redundantcast handle dynamic_cast 
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb
Reviewed-on: https://gerrit.libreoffice.org/43621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-10-21 15:44:11 +02:00
Mike Kaganski
daf7c3e732 basic: consistently use "" and <> in include directives 
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716
Reviewed-on: https://gerrit.libreoffice.org/43298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:43:46 +02:00
Tor Lillqvist
a1eecccadd Clean up a couple of overly verbose SAL_INFOs 
Change-Id: I2b17bfb95f687617967d4e43356d39aa3bb6e041
 2017-09-19 13:59:28 +03:00
Noel Grandin
4e70d0b6bf rename SBX errorcodes to BASIC 
Change-Id: Ia6c2d2379a2f6e9b1109e2c04edd5cdd9dcf242f
Reviewed-on: https://gerrit.libreoffice.org/41706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 19:50:11 +02:00
Noel Grandin
d347c24036 convert std::map::insert to std::map::emplace 
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 12:38:32 +02:00
Stephan Bergmann
c8fd385d61 loplugin:casttovoid: basic 
Change-Id: I4e70accf67d4d812b8998b0baa07cd04c27216ad
 2017-07-02 22:35:38 +02:00
Noel Grandin
6ee9f2c188 loplugin:oncevar accessibility..basic 
Change-Id: I8fb41b658ef0f6ad1774ea897eace3dc9bb12de6
Reviewed-on: https://gerrit.libreoffice.org/38969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 07:50:06 +02:00
Jochen Nitschke
a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Noel Grandin
a6aa57ff59 use ERRCODE_NONE instead of 0 
peeling off a small chunk of my ErrCode strong_int conversion

Change-Id: Idc89e8496083beed7608cba705cd981139eb7111
Reviewed-on: https://gerrit.libreoffice.org/38777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-14 15:42:31 +02:00
Jochen Nitschke
febbad7263 cleanup unused css/frame/* includes 
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 13:05:38 +02:00
Jochen Nitschke
a0b93fe081 cleanup unused css/script/ includes 
but keep exception includes in headers for now

Change-Id: I826828675a2d14b906e57068cbced2e790e12bce
Reviewed-on: https://gerrit.libreoffice.org/37846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-20 10:23:38 +02:00
Stephan Bergmann
f0fddb1d2d loplugin:stringcopy: basic 
Change-Id: I39d8ae76be2794d5e7b5a9979d7211823c995c2c
 2017-05-19 17:19:14 +02:00
Noel Grandin
2e51afc77c loplugin:comparisonwithconstant in basic 
Change-Id: Ie34a17d2fb465ffbe675ba4e99917d23959f1fb5
Reviewed-on: https://gerrit.libreoffice.org/37809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-19 12:53:34 +02:00
Johnny_M
2c3f58eff2 Translate German comments and debug strings (leftovers in dirs a... to c...) 
Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "a" to "c".

Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763
Reviewed-on: https://gerrit.libreoffice.org/37573
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-05-15 15:27:52 +02:00
Noel Grandin
12191a4f30 make loplugin constantparam smarter about string params 
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 13:52:30 +02:00
Noel Grandin
8fced917aa clang-tidy readability-simplify-boolean-expr in accessibility..cui 
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc
Reviewed-on: https://gerrit.libreoffice.org/36677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-19 14:38:35 +02:00
Noel Grandin
0514442730 no need to use OUStringToOString in SAL_INFO 
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2
Reviewed-on: https://gerrit.libreoffice.org/36451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-12 12:49:25 +02:00
Noel Grandin
ff339c89b5 loplugin:constantparam part2 
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-05 06:42:40 +00:00
Andrea Gelmini
7bc1c43800 Fix typos/translations, following 04644956e5 
No automatic tools

Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428
Reviewed-on: https://gerrit.libreoffice.org/30874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-02-21 13:34:20 +00:00
Tor Lillqvist
013d9789c7 Drop :: prefix from std in [a-b]*/ 
Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd
Reviewed-on: https://gerrit.libreoffice.org/34320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 21:50:23 +00:00
Michael Stahl
2e0e05aa3c basic: another SOLARIS check here converted to __sun 
Change-Id: Iec76b096cfcab4bd45b77bdb1438776bf5de69ca
 2017-02-08 12:58:37 +01:00
Noel Grandin
83721f4365 makeAny->Any in basctl..chart2 
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61
Reviewed-on: https://gerrit.libreoffice.org/33867
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:50:50 +00:00
Noel Grandin
4978328534 convert method names in tools::SvRef to be more like our other.. 
reference classes, uno::Reference and rtl::Reference.

Specifically rename Is()->is() and Clear()->clear().

Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae
Reviewed-on: https://gerrit.libreoffice.org/33576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 08:02:54 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00