Commit Graph

6 Commits

Author SHA1 Message Date
Stephan Bergmann
93d836b673 Silence loplugin:duplicatedefines for WIN32_LEAN_AND_MEAN (clang-cl)
...as seen at

> In file included from desktop/win32/source/QuickStart/QuickStart.cxx:29:
> In file included from include\systools/win32/uwinapi.h:25:
> include\prewin.h(38,9): error: duplicate defines [loplugin:duplicatedefines]
> #define WIN32_LEAN_AND_MEAN
>         ^
> desktop/win32/source/QuickStart/QuickStart.cxx(24,9): note: previous define [loplugin:duplicatedefines]
> #define WIN32_LEAN_AND_MEAN
>         ^

(An alternative fix could be to replace all those defines of WIN32_LEAN_AND_MEAN
prior to including windows.h with includes of prewin.h and postwin.h?)

Change-Id: I0271b5629af8f4ecfb3c90f1455bad399174f6ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87880
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03 23:39:47 +01:00
Stephan Bergmann
a169864a24 Adapt loplugin:duplicatedefines to include/premac.h
Change-Id: I2f79409f0fe2a18ba00585a35b6f1cf6243b7c1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86995
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-17 23:58:11 +01:00
Noel Grandin
b5ed969212 update and enable loplugin:duplicate-defines
Change-Id: I713b9985b2a69fe3c84069f19c772969e2631e46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85571
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14 20:24:22 +01:00
Stephan Bergmann
ab8fc2603c Fix loplugin::Entry ODR violation
(caused crashes with CLANGDEBUG=1 in compilerplugins/Makefile-clang.mk)

Change-Id: I43ba276f03c87c97b624a59f2b368422fd5b0a7b
Reviewed-on: https://gerrit.libreoffice.org/82982
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16 16:48:33 +01:00
Stephan Bergmann
9d99dc8a83 -Werror,-Winconsistent-missing-override
Change-Id: I4cfb01582e5cfef55909ae56fd14ce8ccd5c14be
Reviewed-on: https://gerrit.libreoffice.org/79990
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-02 08:19:26 +02:00
Noel Grandin
4609082699 new loplugin:duplicate-defines
Change-Id: I98e17e0a92ae5d51778b9a72c679ed262a6f5cb0
Reviewed-on: https://gerrit.libreoffice.org/79826
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30 10:25:13 +02:00