Commit Graph

413136 Commits

Author SHA1 Message Date
Caolán McNamara
6c4e37c826 bump libexttextcat to 3.4.5
Change-Id: Id561d4acb9347768d74233dea3e7b06ff7374477
Reviewed-on: https://gerrit.libreoffice.org/42546
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20 17:16:18 +02:00
Miklos Vajna
eef3b0182a EPUB export: add uno command to trigger the filter
This is quite similar to PDF, except that by default the File menu
doesn't advertise this command. Possible to add it via Tools ->
Customize -> Menus -> Search -> EPUB.

(Reasoning for having a dedicated UNO command for EPUB is an increasing
amount of users look at EPUB as the new PDF, given how non-reflowable
PDF is hard to read on mobile devices, while EPUB is primarily
reflowable.)

Change-Id: Ib80f784a630a192f5b6ffbbfc60cb565fda7ed37
2017-09-20 17:04:35 +02:00
Miklos Vajna
321c2d4426 Upgrade libxmlsec to 1.2.25
Part of the configure is upstreamed, drop those 3 hunks.

Change-Id: I5f2ad217aaba050969cb655091f33fe61970a512
2017-09-20 17:04:11 +02:00
Eike Rathke
ea572a4fc6 Resolves: tdf#99477 freeze first col/row always set a freeze
The previous implementation had the odd behavior that Freeze First
Column and Freeze First Row removed any frozen state (column or row) if
there was one, instead of freezing the actually selected choice.

Changed to
* Freeze First Column
  * always freezes the first column
    * removes another column freeze if there was one
    * keeps a row freeze if there is one
    * checks the Freeze Rows and Columns toggle box
* Freeze First Row
  * always freezes the first row
    * removes another row freeze if there was one
    * keeps a column freeze if there is one
    * checks the Freeze Rows and Columns toggle box
* Freeze Rows and Columns
  * freezes at the current cell cursor position if there was no freeze
    (toggle box was unchecked)
  * removes any freeze if there was one (toggle box was checked)

Change-Id: I38c4b6f0486ef8e93da0bb3a69a99e5c7709a21e
Reviewed-on: https://gerrit.libreoffice.org/41908
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-20 16:58:50 +02:00
Samuel Mehrbrodt
ecdf8f2803 pre-commit-hook: Also check xsl files for whitespace and tabs
Change-Id: Ibc1520735ab20787496564e8561a6bb5920a5538
Reviewed-on: https://gerrit.libreoffice.org/42280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20 16:12:11 +02:00
Samuel Mehrbrodt
28dff3780f Clean up xsl files
* Remove trailing spaces
* Use 4 spaces for indentation everywhere

See discussion at https://lists.freedesktop.org/archives/libreoffice/2017-September/078433.html

Change-Id: I0bb9a0b9b0502cdf0870529cea37ee9c4d1ffdf4
Reviewed-on: https://gerrit.libreoffice.org/41009
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20 16:11:23 +02:00
Serge Krot
732d2e8bb1 tdf#106939 Move OK, Help and Start buttons to bottom
Change-Id: I4c08723878a819139977ec4815505c5c02ca8e9f
Reviewed-on: https://gerrit.libreoffice.org/42326
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-20 16:01:20 +02:00
Caolán McNamara
28dcfd2608 improve scoping
Change-Id: I82e68bc00780ef37399b30f5374df4ef792546e9
Reviewed-on: https://gerrit.libreoffice.org/42540
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20 15:26:53 +02:00
Caolán McNamara
f9a48edc0a Related: tdf#101881 keys not handled by native menubar sent to vcl one
so 'o' pops up native menu, shift+o is unhandled by native, sent to
vcl one which pops up some shoddy emulated version of the o menu

Change-Id: Id6b0d27dd81f8a6d141cef79cc4825703c923636
Reviewed-on: https://gerrit.libreoffice.org/42538
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-20 15:23:24 +02:00
Michael Stahl
0ae13c77b6 xmloff,sw: some stylistic cleanup to conditional styles
Change-Id: I1722a0b3d67a7c8740daa5a131d7800319ee2373
2017-09-20 15:17:53 +02:00
Stephan Bergmann
2c7ec52b02 Missing dependency
otherwise CppunitTest_sw_rtfimport failed with

> ##Failure Location unknown## : Error
> Test name: testFdo52052::Import
> An uncaught exception of type com.sun.star.container.NoSuchElementException
> - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui
>
> ##Failure Location unknown## : Error
> Test name: testContSectionPageBreak::Import
> An uncaught exception of type com.sun.star.container.NoSuchElementException
> - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui
>
> ##Failure Location unknown## : Error
> Test name: testTdf59454::Import
> An uncaught exception of type com.sun.star.container.NoSuchElementException
> - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui
>
> ##Failure Location unknown## : Error
> Test name: testLndscpsxn::Import
> An uncaught exception of type com.sun.star.container.NoSuchElementException
> - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui
>
> ##Failure Location unknown## : Error
> Test name: testImportHeaderFooter::Import
> An uncaught exception of type com.sun.star.container.NoSuchElementException
> - file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/pagebreakmenu.ui

Change-Id: I10c12f4b0ab49ec747fa64cc0b5d4fca252ff590
2017-09-20 14:33:39 +02:00
Jan Holesovsky
012f153259 lok: Expose the automatic spell checking state in the UI.
Change-Id: I5c22ff70d3895b0f4a86eb8be85dde971604874a
Reviewed-on: https://gerrit.libreoffice.org/42480
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-09-20 14:18:31 +02:00
Michael Stahl
0581342a5b gbuild: remove obsolete comment
There is only one PCH since commit "kill gb_NoexPrecompiledHeader"
2bf530153e

Change-Id: I1b31462227df021068e8a6320d0613809d2503bc
2017-09-20 13:08:44 +02:00
Michael Stahl
adbf0374e9 filter,sc: try to prevent potential SeekToEndOfRecord infinite loops
SeekToEndOfRecord() now doesn't seek to EOF if the offset is too large;
break out of loops in the obvious cases where this could be problematic.

But don't use SAL_WARN_UNUSED_RESULT because unfortunately GCC doesn't
allow to explicitly suppress that with a (void) cast.

Change-Id: Ie0211075bf0f4ef271bb26bdfead5fb070875a2b
2017-09-20 13:08:43 +02:00
Noel Grandin
dc97ede7cf new loplugin flatten
look for places where we can flatten the control flow in a method by
exiting early with a throw, ie. instead of

   if (cond)
       stuff();
   else
       throw ex;

we  change it to:

   if (!cond)
      throw ex;
   stuff();

Change-Id: I8b6bdf883b325807c7e3a3ef698e4f4606e7d38b
2017-09-20 12:42:33 +02:00
Sabin Frandes
cb6fd6b342 tdf#112381 Macro Organizer: Move Run, Close, Help buttons to the bottom
Change-Id: Id08ce71bcd060121630c3a9194f8cfe663ca5822
Reviewed-on: https://gerrit.libreoffice.org/42331
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20 12:25:07 +02:00
Fridrich Štrba
53fc42e4be beanshell: don't remove the getPeer call, access it by reflection
Change-Id: I031580c6edd0d80727d940b4fd300308a905a383
2017-09-20 10:49:32 +02:00
David Tardon
8110931480 group java-requiring tests together
Change-Id: Ie4e5422d2a6cb01b4a899ed0982d60fe65c386d7
2017-09-20 09:54:03 +02:00
Jan-Marek Glogowski
69d0cb2ad7 Ignore DrawWorkStartupTimer on Scheduler shutdown
Change-Id: Ia0cf4311b42dfa170ce429a958a26afd9c70ff0c
2017-09-20 09:27:09 +02:00
Szymon Kłos
146a64bb52 tdf#112333 PPTX export animClr
Change-Id: Ibf230a6c4ddac4806dab235c3394778db26da38c
Reviewed-on: https://gerrit.libreoffice.org/42476
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-20 08:50:17 +02:00
Tor Lillqvist
6978f506a4 Bin some noise comments and ASCII graphics
Change-Id: Ib0e786b0e8401da3e3c93bf254727411774e8f43
2017-09-20 09:47:38 +03:00
Noel Grandin
e0aed14595 unused m_sNoSubjectST/m_sDefaultAttachmentST in SwMMResultEmailDialog
ever since

    commit ba0796b331
    Date:   Wed Dec 23 17:43:14 2015 +0100
    mailmerge: Killed the 'Save, print or send' page.

Change-Id: Id77cd6beb3eaa13ead848495d9f8661c83f60975
2017-09-20 08:42:30 +02:00
Noel Grandin
e159f8b128 unused maFilterService in filter_info_impl
since it was added in

    commit d0d152d4e3
    Date:   Fri Apr 4 15:34:02 2003 +0000
    INTEGRATION: CWS xmlfilter01 (1.1.2); FILE ADDED

Change-Id: I69bf6cad4e3d637c065d967a2b5915312cc23e93
2017-09-20 08:42:30 +02:00
Noel Grandin
31d7894d8b unused aDDLastRectPos in SvxIconChoiceCtrl_Impl
since

    commit bf2373daf5
    Date:   Tue Jul 26 23:32:40 2011 +0200
    callcatcher: remove unused methods

Change-Id: I2eef2bdcd40d4b4b1da8cf7ca95b0194ea99216f
2017-09-20 08:42:30 +02:00
Noel Grandin
dff3e4887d unused fields in XFormsEventConcrete
ever since

    commit 6297bf4e24
    Date:   Wed Mar 23 10:39:28 2005 +0000
    INTEGRATION: CWS eforms4 (1.1.2); FILE ADDED

Change-Id: Ic4915a9b31c3a5f0222da0a4fc8557b2cbe6078e
2017-09-20 08:42:30 +02:00
Noel Grandin
4174b5b08b unused m_aModuleIdentifier in StatusBarManager
Change-Id: I1f8260fd148b694337ea0440eb2edde4753b34c1
2017-09-20 08:42:30 +02:00
Noel Grandin
b92068bbe2 unused m_aModuleIdentifier in UIConfigurationManager
Change-Id: Idd4ced156201e81ee818d4b6b69e6c4d254f3387
2017-09-20 08:42:30 +02:00
Noel Grandin
e86b07e292 unused m_sUpdateTableName in OQueryController
ever since

    commit 2106d8e648
    Date:   Sun Jun 10 21:51:19 2012 +0100
    callcatcher: update unused code

Change-Id: I88a13c5c414a86a82efc6883d2e1602199569dc9
2017-09-20 08:42:30 +02:00
Noel Grandin
a0aff40f3e unused sNumCharFmtName fields
ever since

    commit 89ef4dea32
    Date:   Fri Jul 17 10:34:58 2015 +0200
    loplugin:unusedmethods cui

Change-Id: Ibfa3841168448d4f08075a684fa36262b303210f
2017-09-20 08:42:30 +02:00
Noel Grandin
6c5fdc3085 unused m_nFetchSize in OResultSet
since initial

    commit 77e4adbe47
    Date:   Mon Sep 17 22:50:49 2012 +0200
    mork driver implementation

Change-Id: I226c4065a5ab4404cc9e99eb3e026d153d1ccf08
2017-09-20 08:42:30 +02:00
Noel Grandin
0c9f104390 unused bPageToggle in GraphicImport_Impl
ever since

    commit 0929dfa83c
    Date:   Sat Jan 11 11:54:14 2014 +0100
    writerfilter: drop never generated rtf
{XAlign,FHDR,YAlign,XRelTo,YRelTo}

Change-Id: Icabe9ff848e3cc9918741e9c68d8f2312145fb74
2017-09-20 08:42:30 +02:00
Noel Grandin
beebcb8ee0 unused bVertFlip/bHoriFlip in GraphicImport_Impl
ever since

    commit 4a924576e4
    Date:   Wed Jan 15 20:24:41 2014 +0100
    writerfilter: drop unused BlipDib and FSP in doctok

Change-Id: I9bf644bdc4b37cb6c4a9a9ab7757c4a83a520cd7
2017-09-20 08:42:30 +02:00
Noel Grandin
1c0cbc87f2 unused m_xStorage in RTFDocumentImpl
ever since introduction in

    commit 328d154015
    Date:   Fri Jun 10 18:56:08 2011 +0200
    resolvePict: import the stream as a graphic object

Change-Id: Ife03094d721621cc592be9cd94899a4e40550330
2017-09-20 08:42:30 +02:00
Noel Grandin
107524b99f unused aCId in ScHTMLExport
ever since

    commit fa135fd0e0
    Date:   Tue May 31 10:30:35 2016 +0200
    remove unused SID constants and associated code

Change-Id: I47388fa5dcfec67bbcd9f7bf0a079d9376bc05af
2017-09-20 08:42:30 +02:00
Noel Grandin
4819162e45 simplify calling listeners
Change-Id: I4bf0d378003d1f54685f6c55c0314c117b243526
2017-09-20 08:42:30 +02:00
Serge Krot
8abc7ba978 tdf#98980 Update selection inside control when new slide layout is selected
Change-Id: Ibf8fe8d2fcdb5efef6df657607e65a791b67d4a0
Reviewed-on: https://gerrit.libreoffice.org/42462
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-20 03:49:57 +02:00
Bjoern Michaelsen
e73961022d no need to queue formats in header and footer ...
- we can call MakeFrames on them right away
- as there had been performance issues on mail merge here before, this
  might a bit quicker for suoer large documents.

Change-Id: Idd84d7e6a962d00d59e2981f63ed9db60377fa01
Reviewed-on: https://gerrit.libreoffice.org/42442
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20 01:04:33 +02:00
Bjoern Michaelsen
ce2fce9a41 tdf#112447: connect all objects
- fixes regression from 575e222a17

Change-Id: I686ce41c87e5b421e0382658404cf7bb153a4812
Reviewed-on: https://gerrit.libreoffice.org/42439
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20 01:04:11 +02:00
Tor Lillqvist
018f875cb0 Avoid API present from macOS 10.13 if building to run on older
utimensat() and futimens() are new in 10.13.

Change-Id: I03448adb17b40a646771c37179bd70c787547ca3
2017-09-20 00:19:47 +03:00
andreas kainz
856ba5f73f add signature icon cause the icon is available (in breeez)
Change-Id: If221848b1ef389a1816e5aab71f784ddd932c9bc
Reviewed-on: https://gerrit.libreoffice.org/42347
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-19 22:52:01 +02:00
Michael Stahl
ec100b7066 sc: fix infinite loop in XclImpDffConverter::ProcessShGrContainer()
... and also in XclImpDffConverter::ProcessDgContainer()

This was looping in CppunitTest_sc_filters_test, reportedly since
commit 7e8c38b697.

The problem is that checkSeek() doesn't actually seek until EOF
if the offset is too large.

Change-Id: I16226a88388dcac8069d6a4cad860470540466e3
2017-09-19 22:18:44 +02:00
Michael Stahl
ee599ea463 xmloff: fix stack-use-after-return in SvXMLExport::exportDoc()
PropertySetInfo(PropertyMapEntry const * pMap) stores the pointers,
and its lifetime is controlled by refcounting, so the lifetime
of aInfoMap can't be automatic.

ERROR: AddressSanitizer: stack-use-after-return on address ...
... is located in stack of thread T46
at offset 224 in frame SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum)

This frame has 39 object(s):
  ...
  [224, 288) 'aInfoMap' <== Memory access at offset 224 is inside this variable

Change-Id: I4eaa9d38bab708b222d999b0982100d7ef97e95c
2017-09-19 22:18:44 +02:00
Tor Lillqvist
eba34a557c connectx() is available only on Mac OS X 10.11 and newer
Compiling against the 10.13 SDK with --with-macosx-version-min-
required set to 10.9 or 10.10 (or defaulted, meaning 10.9) causes a
compilation error now. Earlier SDKs did not catch it if you were using
connectx() even if targeting pre-10.11.

Try the approach from https://github.com/curl/curl/pull/1336/commits .

Change-Id: I7cac294931c8afa6ff26a6ca9cf4491aff249de0
2017-09-19 23:03:05 +03:00
Eike Rathke
0961cfc50a Writer Web export to PNG,JPG: switch to proper SvFilterOptionsDialog
Change-Id: I6388ad03d4b94556f5a955d06c1f4e0d8c7188b1
Reviewed-on: https://gerrit.libreoffice.org/42501
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19 21:32:09 +02:00
Eike Rathke
51c7d52ee1 Writer does not support selection, so don't claim it would
Though it doesn't change anything UI wise.
See also commit cb9d99dbb5

Change-Id: Ic5e0e411325945f91a00b58da5341eeecd7b6623
Reviewed-on: https://gerrit.libreoffice.org/42500
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19 21:11:55 +02:00
Tor Lillqvist
d00110cf55 Accept macOS 10.13
Change-Id: I52fb11c8830a5a78c7a9181708f1727b473069e3
2017-09-19 22:06:48 +03:00
Eike Rathke
7c8db52424 Writer export to PNG,JPG: switch to proper SvFilterOptionsDialog
With all bells and whistles, instead of the crude size/dpi JPG dialog
even for PNG.

Change-Id: I695a78643e07900822ec9253ac818efd52339cc0
Reviewed-on: https://gerrit.libreoffice.org/42498
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19 21:03:00 +02:00
Eike Rathke
9d46ee5e17 Call getCurrentPageWriter() only for Writer
Change-Id: I81dd61c33a0bc69e43d3325b297c44e5b7b732bd
Reviewed-on: https://gerrit.libreoffice.org/42496
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19 20:49:32 +02:00
Eike Rathke
5214e841b6 Detect Writer doc independent of selection, we'll need that later
Change-Id: Ieddbcd3e8b750ec4b32643aec0433f8638ee46ee
Reviewed-on: https://gerrit.libreoffice.org/42495
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19 20:43:57 +02:00
Eike Rathke
cb9d99dbb5 DocumentToGraphicRenderer: suppress selection for Writer, it doesn't work
See FIXME comment.

Change-Id: I7511f5b498029fedcbd0c39d5ec67288782330ae
Reviewed-on: https://gerrit.libreoffice.org/42493
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19 20:31:23 +02:00