mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
443,275 Commits 1 Branch 0 Tags
89c8f34c31c423321d10067f5250e51c3d901b56
Commit Graph

2153 Commits

Author SHA1 Message Date
Noel Grandin
ead34a4d34 no need to store reference to Import here 
can just cast the parent member

Change-Id: I990bd4da3afbd78da819038c7907c28de87faaaf
Reviewed-on: https://gerrit.libreoffice.org/82567
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-11-13 10:26:35 +01:00
Stephan Bergmann
7f305223fa New loplugin:conditionalstring 
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3
Reviewed-on: https://gerrit.libreoffice.org/81946
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-11-02 21:47:38 +01:00
Noel Grandin
b6f1995566 loplugin:unusedfields 
Change-Id: I7dd5fc3d53df63fd2ee2caa71586f0f5e13f187e
Reviewed-on: https://gerrit.libreoffice.org/81078
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 11:17:20 +02:00
Noel Grandin
74f938bb10 loplugin:unusedmethods 
Change-Id: I95e63105654952d12c1dfd62f51593de114be569
Reviewed-on: https://gerrit.libreoffice.org/81077
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-19 07:59:43 +02:00
Noel Grandin
f13c6ad5f0 new loplugin:bufferadd 
look for OUStringBuffer append sequences that can be turned
into creating an OUString with + operations

Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6
Reviewed-on: https://gerrit.libreoffice.org/80809
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-15 14:33:57 +02:00
Caolán McNamara
d0a537a26a drop some unnecessary includes 
Change-Id: I07693dd5199a1fcc08c7ba25bd986d9da76958b3
Reviewed-on: https://gerrit.libreoffice.org/80720
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-13 16:18:08 +02:00
Caolán McNamara
b883c7142b rename FontPrevWindow back to SvxFontPrevWindow 
Change-Id: Ife6f7bbc64f397e502d50c629769a8b637a591c8
Reviewed-on: https://gerrit.libreoffice.org/80718
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-13 16:17:33 +02:00
Caolán McNamara
3e88285083 no longer need bInterimBuilder 
Change-Id: Ieff1e34de9665c80ded39d605656fe7d0626aec7
Reviewed-on: https://gerrit.libreoffice.org/80716
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-13 16:17:04 +02:00
Caolán McNamara
226fcda0a8 weld ConditionalFormattingDialog 
Change-Id: I87c03555c5555b12a1be997e368a96d9b07d2b63
Reviewed-on: https://gerrit.libreoffice.org/80689
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-13 16:16:24 +02:00
Noel Grandin
cdbac696fb simplify "a = a +" to "a +=" 
mostly so that my stringadd loplugin can point out places to improve

Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5
Reviewed-on: https://gerrit.libreoffice.org/80618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-11 07:18:11 +02:00
Stephan Bergmann
7d361e96c9 loplugin:redundantpointerops 
(All related to uses of std::shared_ptr, which builds against libstdc++
apparently missed (fix forthcoming) and which I only now found with my macOS
build against libc++.)

Change-Id: If581e689f0e5ff62d9ce35513c9ff87b00328766
Reviewed-on: https://gerrit.libreoffice.org/80548
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-10-09 20:42:44 +02:00
Noel Grandin
231e16d909 loplugin:redundantpointerops simplify *p.get() 
Change-Id: I12517651fb3f777fd08e384992bb3e84b340ad85
Reviewed-on: https://gerrit.libreoffice.org/80382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-08 08:26:23 +02:00
Noel Grandin
9ba86e80ec Convert various RPTUI_ID_* to SfxUInt16Item 
Change-Id: I261c30c35d3967ece7078b8529a42e646c00a90f
Reviewed-on: https://gerrit.libreoffice.org/80249
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-05 09:10:41 +02:00
Noel Grandin
9db8406b83 loplugin:virtualdead 
Change-Id: I86bae18ed2682871032aeb2a178f49f3e4601129
Reviewed-on: https://gerrit.libreoffice.org/80129
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-03 16:34:45 +02:00
Noel Grandin
b74c4b7c67 loplugin:stringadd in package..sax 
Change-Id: I1f8b626ae99bca6e31e7c4aa9c8a1fc016b76e5c
Reviewed-on: https://gerrit.libreoffice.org/79890
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-10-01 10:51:39 +02:00
Caolán McNamara
468729d649 drop unnecessary includes and update pch 
Change-Id: Id7fa7d5b95c32fdc738a18208eb95eaec102d937
Reviewed-on: https://gerrit.libreoffice.org/79523
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-09-26 09:55:44 +02:00
Noel Grandin
5440274a2a loplugin:constmethod in reportdesign 
Change-Id: I0076890abb4b5bb179171353b19097f6ebf8aa31
Reviewed-on: https://gerrit.libreoffice.org/79542
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-09-26 03:04:57 +02:00
Arkadiy Illarionov
1d398fb983 tdf#39593 use getUnoTunnelImplementation 
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd
Reviewed-on: https://gerrit.libreoffice.org/79350
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
 2019-09-23 15:47:12 +02:00
Andrea Gelmini
196e7ad850 Fix typos 
Change-Id: I111acf563106f43cadb36f35823dc655255a1317
Reviewed-on: https://gerrit.libreoffice.org/78923
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-09-15 08:56:36 +02:00
Ilhan Yesil
260caebf8a tdf#45789 [API CHANGE] Automatic row height in reports 
The controls have now an AutoGrow flag which is saved as
style:min-row-height instead of style:row-height on
style:table-row-properties in content.xml.
In this case the table row height will be allowed to grow to accommodate
the content.

Note: in the conceptual model of reportdesigner this is a per-control
property but in the current implementation, it is a per-row property in
the ODF file. Thus, as soon as one control in the row has the AutoGrow
property set, they all do.

Change-Id: I95c25599e06af0f2f12e72a7cfc0881206f02039
Reviewed-on: https://gerrit.libreoffice.org/53977
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins
 2019-09-13 10:45:01 +02:00
Arkadiy Illarionov
f599c31fe6 tdf#39593 use isUnoTunnelId 
Adapt getUnoTunnelId methods where required: rename or make public.

Change-Id: I0fd2120bf9f0ff1aa690329a65ff64a154c89315
Reviewed-on: https://gerrit.libreoffice.org/78680
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-09-06 11:55:50 +02:00
Andrea Gelmini
22ef2a15bb Fixing "...." 
Change-Id: Id005a7531d546dd43de13b49bcb3e93081c5ad8d
Reviewed-on: https://gerrit.libreoffice.org/78679
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-09-06 09:15:58 +02:00
Tamás Zolnai
6cc5baa0a1 tdf#118710 - Report Builder Character Settings dialog Highlighting tab page 
doesn't set background.
Regression from:
62fb96e075

Change-Id: Ie60a4b4d988ba00b3a425dda73ed6ffeb40394c9
Reviewed-on: https://gerrit.libreoffice.org/78340
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
 2019-08-31 14:40:14 +02:00
Noel Grandin
715e7370a1 loplugin:returnconstval in fpicker..reportdesign 
Change-Id: I59c55a858b2706d1327c837abc158dceca02360e
Reviewed-on: https://gerrit.libreoffice.org/78058
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-08-24 20:29:39 +02:00
Julien Nabet
7d3041beb9 tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor 
in hwpfilter, include/test, io, linguistic, oox, pyuno, reportdesign

Change-Id: I5c265c4fde85dd6d7faab8ae82809c4a0e6dd69b
Reviewed-on: https://gerrit.libreoffice.org/77646
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-17 20:10:43 +02:00
Caolán McNamara
d30ab819b8 tdf#125340 transport preferred dialog parent down the migration dialog 
Change-Id: Icb7bab35eac3ae08fb82d73f559ef161dd1820c3
Reviewed-on: https://gerrit.libreoffice.org/77606
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-08-17 16:31:11 +02:00
Arkadiy Illarionov
edcdfe5477 Simplify Sequence iterations in postprocess..sax 
Use range-based loops, STL and comphelper functions

Change-Id: If738d8f4e792c4686870183b0c0fdfbb61fd3351
Reviewed-on: https://gerrit.libreoffice.org/77245
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
 2019-08-17 14:08:33 +02:00
Noel Grandin
aea932b58b loplugin:sequenceloop in postprocess..reportdesign 
Change-Id: I86b9174c37e4a347a3a8ac6c2707052167e6fdc0
Reviewed-on: https://gerrit.libreoffice.org/77522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-08-15 20:21:55 +02:00
Andrea Gelmini
0286f76b84 Fix typos 
Change-Id: I7e6f758649b57840a764ca6d9bab47951b07c573
Reviewed-on: https://gerrit.libreoffice.org/77253
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-12 09:38:47 +02:00
Stephan Bergmann
9b55b5d5f9 Improved loplugin:stringconstant (now that GCC 7 supports it): reportdesign 
Change-Id: I18c97a976c7d8d17ffba22185fb47010b628eef0
Reviewed-on: https://gerrit.libreoffice.org/76657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-07-31 12:56:10 +02:00
Noel Grandin
b71e02dd5b dispose() methods should clear their smart pointers 
especiall the ref-counted ones

Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7
Reviewed-on: https://gerrit.libreoffice.org/76102
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-23 06:46:13 +02:00
Noel Grandin
140b070bb1 loplugin:referencecasting in reportdesign 
Change-Id: I911bfc95f479d130052a51143dd3073287853a8f
Reviewed-on: https://gerrit.libreoffice.org/75975
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-20 13:10:10 +02:00
Caolán McNamara
e2cd1f41b8 cid#1448383 Resource leak in object 
Change-Id: I07af4d48db887c184be824a2d1939b800f837d4e
Reviewed-on: https://gerrit.libreoffice.org/75801
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-07-18 09:37:28 +02:00
Arkadiy Illarionov
f926de93c4 tdf#39593 Remove SvxUnoDrawMSFactory::concatServiceNames 
Replace with comphelper::concatSequences

Change-Id: I6b16104fac6ac5fdfcb6f322da4a5b8405d5d999
Reviewed-on: https://gerrit.libreoffice.org/75315
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-07-15 13:06:38 +02:00
Julien Nabet
e011bf1c75 Revert "cid#1448383: Resource leak in object (reportdesign/formula)" 
I should have use delete or unique_ptr

This reverts commit 99ec957948.

Change-Id: I746c2307ca0d4d6cdbe8dbb1c6fd6de624666726
Reviewed-on: https://gerrit.libreoffice.org/75144
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-07-05 22:08:09 +02:00
Julien Nabet
99ec957948 cid#1448383: Resource leak in object (reportdesign/formula) 
Change-Id: Ia57e6961dab9be857e81289f8d2d20f82f24643d
Reviewed-on: https://gerrit.libreoffice.org/75099
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-07-04 20:15:54 +02:00
Noel Grandin
4583911575 improve loplugin:simplifyconstruct 
Change-Id: If863d28c6db470faa0d22273020888d4219e069e
Reviewed-on: https://gerrit.libreoffice.org/74559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-25 13:53:21 +02:00
Arkadiy Illarionov
a4261757b8 tdf#39593 Remove reportdesign::OSection::getImplementation 
Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I3d0837ff3f47392e09ef276f141a8459add7a5ad
Reviewed-on: https://gerrit.libreoffice.org/74471
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
 2019-06-21 19:38:17 +02:00
Mike Kaganski
cb28e48bfd Drop INetURLObject::GetName and INetURLObject::GetExtension 
They are just synonyms for GetLastName and GetFileExtension resp.

Change-Id: Ic498c7025cc421b830394ed94d64529fd74fe7dd
Reviewed-on: https://gerrit.libreoffice.org/74448
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-06-21 00:47:22 +02:00
Arkadiy Illarionov
adc295a1b2 Add comphelper::getUnoTunnelImplementation template 
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_*

Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596
Reviewed-on: https://gerrit.libreoffice.org/74107
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-06-17 08:56:36 +02:00
Noel Grandin
48f62672ab loplugin:logexceptionnicely in package..reportdesign 
Change-Id: Ib5438d346fa95299848aaf2144e54f5551c0a906
Reviewed-on: https://gerrit.libreoffice.org/74100
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-15 19:58:07 +02:00
Gabor Kelemen
a7ceb3352a tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b
Reviewed-on: https://gerrit.libreoffice.org/73476
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-06-11 08:48:04 +02:00
Stephan Bergmann
c18e2ea2a5 New loplugin:data 
...following up on 1453c2c8f1 "prefer vector::data
to &vector[0]"

Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01
Reviewed-on: https://gerrit.libreoffice.org/72765
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-05-22 16:35:20 +02:00
Arkadiy Illarionov
0e4c542f7a Use hasElements to check Sequence emptiness in [l-r]* 
Similar to clang-tidy readability-container-size-empty

Change-Id: Idd67f332b04857a39df26bad1733aae21236f105
Reviewed-on: https://gerrit.libreoffice.org/71764
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2019-05-17 11:20:15 +02:00
Noel Grandin
a361231b13 fix wrong SET/QUERY flags passed to uno::Reference 
By creating deleted methods for the wrong calls.

Avoids the compiler needing to construct a temporary

Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a
Reviewed-on: https://gerrit.libreoffice.org/72103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-05-13 08:15:27 +02:00
Caolán McNamara
d56ee7339f remove unused RefEdit/RefButton 
and rename WeldRefEdit/WeldRefButton back

Change-Id: I3aab8585d4ba1017cc755bf21e827522e7ee6980
Reviewed-on: https://gerrit.libreoffice.org/71957
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-11 20:31:04 +02:00
Caolán McNamara
1156f981ac an is used before a vowel sound 
not before vowels with a consonant sound so its a url not an url

Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2
Reviewed-on: https://gerrit.libreoffice.org/72062
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 10:01:13 +02:00
Gabor Kelemen
4709cd82c7 tdf#62699 Drop pass-through header file include/svx/svdattr.hxx 
Change-Id: I04289589196ac69b31f75989d9252c79d03c890f
Reviewed-on: https://gerrit.libreoffice.org/71633
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-05-10 09:14:59 +02:00
Noel Grandin
e0382c3ad7 avoid copying when placing items into SfxItemSet 
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0
Reviewed-on: https://gerrit.libreoffice.org/71941
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-05-09 08:47:50 +02:00
Caolán McNamara
feecbabd01 weld FormulaDialog 
drop xFocusWin hack, I don't see what gain it gives

Change-Id: I31952b5440797e6209ed1de6b546f1e4c0238d08
Reviewed-on: https://gerrit.libreoffice.org/71675
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-07 13:08:13 +02:00