Commit Graph

206 Commits

Author SHA1 Message Date
Stephan Bergmann
8c8d955998 Clean up C-style casts from pointers to void
Change-Id: If8783896136470a0664f1cbac061e30576ef96a4
2015-03-28 19:09:26 +01:00
Julien Nabet
b63571f510 Typos
Change-Id: I3475be796cf2655d9b619b86c9686aeef4b97b82
2014-12-20 16:39:24 +01:00
Stephan Bergmann
7c6aa647e8 svtools: Use appropriate OUString functions on string constants
Change-Id: Ifa7ea9bf840cacb701dd4b5fb0904870bc3cf407
2014-12-18 14:12:34 +01:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method"
This reverts commit 05050cdb23,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
Noel Grandin
cb7ede2d99 convert vcl StateChangedType to enum class
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:32 +00:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Tor Lillqvist
c6542e4f7a WaE: macro is not used
Change-Id: I37ec7e6104dc9526b1792f163fe58ec8673274c2
2014-08-27 13:26:11 +03:00
Tor Lillqvist
93b35682c4 WaE: Unreferenced function definitions
Change-Id: I8c21bfd70e5afb6d4f9a0a57f9946074c1b16a52
2014-08-27 13:26:10 +03:00
Caolán McNamara
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
Tor Lillqvist
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
Palenik Mihály
a5cc3ce566 Convert DLG_COLLECTION_VIEW to .ui
Conflicts:
	include/svtools/fileview.hxx
	svtools/source/contnr/fileview.cxx

Change-Id: I78b590410ec4e55eeecd2da8ab79738f05e403b5
Reviewed-on: https://gerrit.libreoffice.org/9981
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-02 08:47:13 +00:00
Szymon Kłos
f90eb33a26 DLG_FPICKER_EXPLORERFILE conversion to .ui
Change-Id: I5d8f5d0182fb6af5111b60caa29912d313c2efa0
2014-06-30 16:31:47 +01:00
Noel Grandin
cc25f70ef1 compareTo -> equals
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate

Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00
Thomas Arnhold
a325ce63db fix-includes.pl: svtools
Change-Id: I509299306ab6cd97c96e9a26d4674f983bbffbec
2014-05-11 01:55:40 +02:00
Jan Holesovsky
261b1ad80a '!= false' is redundant, and confusing - kill it.
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09 22:28:44 +02:00
Noel Grandin
b7d30cb50e svtools: sal_Bool->bool
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
Stephan Bergmann
fa72a0e94d Remove unused code
Change-Id: Ifaab2aecec65ec6e81056e5fca430df8ca3af908
2014-04-09 10:15:47 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Noel Grandin
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
Noel Grandin
b4d4ede795 svtools/svtabbax.hxx: sal_Bool->bool
Change-Id: I2441e15d2b32b897561cb404a925390299fea6d8
2014-03-25 14:32:54 +02:00
Noel Grandin
f7074d8de5 svtools: sal_Bool->bool
Change-Id: I2044e6c1f15579b6051fad5d36fcfa8795f88953
2014-03-24 08:12:10 +02:00
Noel Grandin
9604eb8758 svtools: sal_Bool->bool
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
2014-03-24 08:12:09 +02:00
Caolán McNamara
19efab6828 coverity#982471 Dereference after null check
Change-Id: I00c47ffa1f03e1c6e921efbc41ef01252c1c64b7
2014-03-15 20:55:49 +00:00
Alexander Wilms
bee1cc83ec Remove visual noise from svtools
Change-Id: I7c2b74a449fb20aae5bc643e24a22cf6f732136d
Reviewed-on: https://gerrit.libreoffice.org/8320
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:14:09 +00:00
Takeshi Abe
4a9347fa32 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I8e11ffe888aac8887c4c0875c41de51f343debae
2014-02-25 16:33:15 +09:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Samuel Mehrbrodt
4f743082c1 fdo#34170 Disable deleting in the native Open Dialog
Change-Id: I0ccd4b06b2db399711004c3e6505a28353604aeb
Reviewed-on: https://gerrit.libreoffice.org/6892
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02 05:03:01 -06:00
Caolán McNamara
282a6fb530 Finish rework of QueryDeleteDlg_Impl
This reverts commit a74b3e89c9.

Change-Id: Id670a2b66e61d3a4dceb9640d6ae34e9116691c0
2013-11-28 09:17:48 +00:00
Caolán McNamara
02d4eb7438 convert query delete dialog to .ui
Change-Id: I0ab09c2c54bba4a287ef0f7cc812596958373e15
2013-11-27 16:52:11 +00:00
Noel Grandin
5112f6a6c6 remove RTL_CONSTASCII_STRINGPARAM in OString constructor
Convert code like:
    OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
    OString aKeyName("NDX");
which compiles down to the same code

Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20 13:56:07 +02:00
Stephan Bergmann
a2505ae731 SAL_WARN_UNUSED INetURLObject
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11 16:50:05 +01:00
Noel Grandin
81f5c65f75 remove unnecessary use of OUString constructor in SVTOOLS module
Change-Id: Iad58b125f16226cc6afa9d88d2c792065bbc244f
2013-11-08 08:44:34 +02:00
Caolán McNamara
91e181ea58 remove uses of COMPARE_*
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-21 14:26:32 +01:00
Caolán McNamara
ccd2240332 CID#1079290 uninitialized member
Change-Id: Ibc75fed4b5282d3caeccac54a884ff5dde3d1910
2013-10-08 16:38:04 +01:00
Noel Grandin
d616f1aacb another attempt to fix windows build
after my OUString changes. Seems like windows really doesn't like
  OUString tmp;
  bool b;
  tmp +=  b ? "1" : "0";

Change-Id: Ie53b4fa36b5ae462fe922feec76e13588d38f1db
2013-08-22 12:09:29 +02:00
Noel Grandin
1984e24f0a fix windows build after my String->OUString changes
One of the changes is inside an "#ifdef WNT" block, so I missed it.
The other change is because MSVC is not quite as smart when it
comes to matching the "const char *" OUString constructors.

Change-Id: I60f2ccb719630bab2a178cecc2f84b7a706ad230
2013-08-22 11:18:17 +02:00
Noel Grandin
7df895abf5 convert include/svtools/file*.hxx from String to OUString
Change-Id: Ie0e07c61caba1e15475900622c97e0f0426558d6
2013-08-22 10:49:25 +02:00
Michael Stahl
fa96ed925f Revert "fdo#63926 - remove extra include paths in svtools/ and sfx2/"
This reverts commit 1cbdcc31b8.

Sadly this was going in the wrong direction...
2013-08-15 17:19:01 +02:00
Radu Ioan
1cbdcc31b8 fdo#63926 - remove extra include paths in svtools/ and sfx2/
- removed some paths from include
- more of this kind wil follow

Change-Id: I0255d8dd338d82dfd4ac3027c34cddea493f105d
Reviewed-on: https://gerrit.libreoffice.org/5281
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-05 10:22:35 +00:00
Stephan Bergmann
03535b9160 Remove obsolete RestrictedPath env var support
Change-Id: Ia4ea7d60d7b69c863c1e891887060265e73e1cb6
2013-05-14 19:14:34 +02:00
Julien Nabet
f53cbe59fb Some cppcheck cleaning
Change-Id: I07ef58fd99bc9fc4fd601570b59f9a3581824aa9
2013-04-07 21:31:01 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Thomas Arnhold
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
elixir
7d1f4cdec3 fdo#38838: Converting String/UniString to OUString
Change-Id: If64db96005fcd8a42e4fa24041867b99183965f9
Reviewed-on: https://gerrit.libreoffice.org/2586
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-11 15:50:44 +00:00
Jean-Noël Rouvignac
63b0ce97ba fdo#38838 searched, replaced and removed String::CreateFromInt32().
I ran the following code replace:
    s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/

And finally removed String::CreateFromInt32().

Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5
Reviewed-on: https://gerrit.libreoffice.org/2279
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-24 12:59:02 +00:00