Commit Graph

530 Commits

Author SHA1 Message Date
Andrzej Hunt
8d1ca883b1 EMF+: Only draw endcap outline if not filled, fix endcap scaling.
Change-Id: I4520eea08e43ccd657c1db03b258ef84612da971
Reviewed-on: https://gerrit.libreoffice.org/7726
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-30 11:24:47 +00:00
Stephan Bergmann
460c15be2e Apparently broken bitmask operation
Change-Id: Id4dfa3d4676b50a86fd6044d501de15b122bb7f1
2014-01-28 20:24:36 +01:00
Caolán McNamara
766a512a88 coverity#1158489 Uninitialized scalar field
Change-Id: Ibe8600f8ad38859cd79d52528f970d99f0b8f536
2014-01-23 16:02:12 +00:00
Caolán McNamara
d113e328ef longparas: remove now broken STRING_LEN uses
Change-Id: Ie2de4680e07e26416fc52d4c22b5bececb190cc1
2014-01-14 09:33:09 +00:00
Caolán McNamara
d4dd5c34db longparas: convert ValidateKashidas to sal_Int32
we can use -1 as the failure return code as return value is always checked and
isolated from the rest of the code.

Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
2014-01-13 20:35:21 +00:00
Andrzej Hunt
9b1ceabd5f EMF+: actually use lineJoin attribute for polygons.
Change-Id: I5b369703333332598353d9817f0253bbe5fc3601
2014-01-01 17:40:16 +00:00
Andrzej Hunt
83f2b3c590 EMF+: mapping can rotate the width vector, so use resulting length.
Otherwise (i.e. with non-vertical lines) the width will be incorrect,
and can result in lines disappearing as the resulting X component
can be tiny/approaching zero.

Change-Id: Icf3b7c10c627594600b517b8ff445f8df87c56f8
2014-01-01 17:07:56 +00:00
Andrzej Hunt
793f14db15 EMF+: Add EMFPlusPointR detection to EMFPPath.
Change-Id: Iff1ae9806ee05654762b313ed00ada206e51337f
2013-12-27 11:30:36 +00:00
Andrzej Hunt
d8dedc775c EMF+: Integer coordinate values are signed.
Change-Id: I5babcec50d48dc2a6288a01685db61fbb7058680
2013-12-26 20:26:12 +00:00
Norbert Thiebaud
4c539fac01 vcl get rid of xub_StrLen and STRING_LEN in outdev3
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)

Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-18 01:54:16 +00:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
Matúš Kukan
131f3230d9 EMF+: Fill line cap object if EmfPlusCustomLineCapDataFillPath is set.
Change-Id: I7b53a8f18e1fb24b1ae0322bdf0980e431a0725f
2013-12-06 15:04:11 +01:00
Jan Holesovsky
eb45c69b64 EMF+: Log the stride too.
Change-Id: I903d8e5629c578f292307bf3abdb2f58ef9dd92c
2013-12-05 09:08:09 +01:00
Matúš Kukan
f115ec6ce1 EMF+: Do not ignore source rectangle of the image to be rendered.
Change-Id: I4f861c7653c89d8f1ca73696e885f33f7bfc3b06
2013-12-04 17:46:41 +01:00
Thorsten Behrens
05d2994c13 Further XCanvas != XBitmapCanvas cleanup.
It seems I missed a few places in
21ec9beae2, getting that straight
now hopefully.

Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
2013-11-29 18:26:48 +01:00
Thorsten Behrens
72aa51185f Revert "Resolves: fdo#71527 make presenter console not crash/useless"
This reverts commit 639aa8e726.

Change-Id: I0ac1a7ada530791e2d34d2f0802213c869ea48a1
2013-11-29 18:25:55 +01:00
Caolán McNamara
639aa8e726 Resolves: fdo#71527 make presenter console not crash/useless
Basically reverts the pieces of
21ec9beae2 to make XSpriteCanvas a
XBitmapCanvas again

Otherwise PresenterHelper::loadBitmap is not an XBitmapCanvas
and so VclFactory::createBitmap cannot succeed

Change-Id: I197adf98e915102f383ee050a8ea16d1e41cecf2
2013-11-28 17:02:53 +00:00
Jan Holesovsky
acd5edd3d4 EMF+: Line thickness has to be considered when drawing the caps.
Change-Id: I6043ee3c214f453afaef06125993c73be624c07e
2013-11-27 11:54:53 +01:00
Tor Lillqvist
b64d5dc6a4 WaE: potentially uninitialized local variable 'pPattern' used
Change-Id: Ic000edc60a9c5ae7d64fab9bf8b6c2a88bcec223
2013-11-26 10:04:09 +02:00
Stephan Bergmann
9abd09f04b -Werror,-Wunused-const-variable
Change-Id: I25fa3ea9e0101de7b17c17ef44da6d7b26a46017
2013-11-26 09:02:05 +01:00
Jan Holesovsky
ad8875e2a0 EMF+: Set the stroke attributes on the custom line caps.
This finally makes the rendering of the custom line caps nice & complete.

Change-Id: If35ef1c44f34f5d5e6c50789c907105d03e96fca
2013-11-25 22:11:31 +01:00
Jan Holesovsky
ff98a070eb EMF+: Render custom line cap data.
Change-Id: Ic5e2e2d105fb006503b63e4e162d4dc09dab9e68
2013-11-25 22:11:31 +01:00
Jan Holesovsky
20f9413f17 EMF+: Parse custom line cap data for start and end line caps.
Change-Id: I3a5f79e22500f53c3c61c173e0827c250b2a8fd0
2013-11-25 14:10:47 +01:00
Jan Holesovsky
172acd5bea EMF+: Small cleanup & more logging in preparation for line starts & ends.
Change-Id: I584f8a1680c6aa7b51b948a00213c285387b77c3
2013-11-25 14:10:47 +01:00
Jan Holesovsky
40977516a5 EMF+: Implement line dashing.
Change-Id: I9eb21c0a8b5baa5b0080845f61b12fc65034d959
2013-11-25 14:10:46 +01:00
Jan Holesovsky
6f6b12cb24 EMF+: Stroke size is always supposed to be absolute.
Change-Id: I7221311e5dee6384dc2d1c071bf6f1c61811895a
2013-11-25 14:10:45 +01:00
Noel Grandin
2241fd5302 remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::equalsIgnoreAsciiL
Convert code like:
    aStr.equalsIgnoreAsciiCaseL(RTL_CONSTASCII_STRINGPARAM("XGRAD_SEQ_BEGIN"))
to:
    aStr.equalsIgnoreAsciiCase("XGRAD_SEQ_BEGIN")
which compiles down to the same code.

Change-Id: Ia69289d853d292b2f27b68863cb6f6ecdbf1a71e
2013-11-22 08:07:18 +02:00
Noel Grandin
6eac9deadd remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsL
Convert code like this:
    if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aStr == "rem")
which compiles down to the same code.

Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
2013-11-21 13:29:29 +02:00
Noel Grandin
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"
This reverts commit acebbee971.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
2013-11-20 16:38:28 +02:00
Noel Grandin
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20 13:56:08 +02:00
Stephan Bergmann
39b594337d -Werror,-Wunused-member-function
Change-Id: I92c83ead449452679e539fad2316d391a1b59a62
2013-11-14 10:15:01 +01:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
Muthu Subramanian
3d0d0717e8 n#812793: Reverting the workaround. 2013-10-10 14:51:04 +05:30
Thorsten Behrens
21ec9beae2 XCanvas does no longer imply XBitmapCanvas
Remove the implication that XCanvas IS-A XBitmapCanvas, i.e. one can
access underlying pixels. That's a preparation for display-list based
canvas implementations, and was a rather silly assumption in the first
place.

Also fixes up all client sites.

Change-Id: I7a3d6f68ef46fe94b23cce7759cc0b8b6ca4dae9
2013-10-07 17:33:45 +02:00
Noel Grandin
abe49a8427 convert CPPCANVAS module from String to OUString
Change-Id: I12a219a50cc3a9b07c9852cc0d417f71797b9e15
2013-09-17 09:05:43 +02:00
Fridrich Štrba
21ee132af1 Revert some random work-in-progress that is most probably bitrotten
Revert "EMF+: aBaseTransform is a hardcoded identity matrix, don't bother with it"

This reverts commit 2b700a710e.

Revert "Pass also the bounding box in device units to the EMF+ part"

This reverts commit f387c5da5a.
2013-08-30 14:37:27 +02:00
Caolán McNamara
b9fa1e20f3 build on higher debug levels
Change-Id: I7f4d85f3e26ab8b19dae05c6907840b97a8af1d6
2013-08-24 14:02:48 +01:00
Eike Rathke
358d1a9948 use static LanguageTag::convertTo...() for standalone conversions
If no LanguageTag instance is at hand use the static methods to convert
between BCP 47 string, Locale and MS-LangID instead of creating
temporary instances.

Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
2013-07-13 11:55:16 +02:00
Mark Wielaard
cb14b1e56d Fix memory leak in EMFPPen.
Delete dashPattern, compoundArray, customStartCap and customEndCap
arrays if they were created in the destructor.

Change-Id: I5f3821b1ab0ac31a9cd4bc402c04090585953573
Reviewed-on: https://gerrit.libreoffice.org/4821
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-07-11 04:02:51 +00:00
Caolán McNamara
1970b28c5c merge duplicated code
Change-Id: Ib13f17a0fe3173f4cd0ae7139f56badb39dcb6cb
2013-07-10 09:50:06 +01:00
Caolán McNamara
6a9dc1a045 remove last XubString uses in cppcanvas
Change-Id: I2ebc11a972f9a806889e13e7f69e20cd91d2ae6e
2013-07-10 09:50:05 +01:00
Radu Ioan
61db96daa8 fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: I26761cf1d4c1cfe21dec7d8ede6df6f177bf2c3e
Reviewed-on: https://gerrit.libreoffice.org/4620
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-07-03 07:59:33 +00:00
Stephan Bergmann
fdcd77cdd7 warning C4305: 'argument' : truncation from 'double' to 'float'
Change-Id: Ieee74fd7e7cec65304dd5de9c1368f5449b66407
2013-06-12 17:27:37 +02:00
Armin Le Grand
e717d1dcce Resolves: #i121237# Rework/Cleanup of Region code...
due to missing complete support for B2DPolygon class

(cherry picked from commit cab10eeb7878edf224a004fd7640bd4adf8d3c51)

Conflicts:
	cppcanvas/source/mtfrenderer/implrenderer.cxx
	svx/source/sdr/overlay/overlaymanagerbuffered.cxx
	svx/source/svdraw/svdpntv.cxx
	vcl/aqua/source/gdi/salgdi.cxx
	vcl/inc/region.h
	vcl/inc/unx/gtk/gtkgdi.hxx
	vcl/inc/vcl/regband.hxx
	vcl/inc/vcl/region.hxx
	vcl/os2/source/gdi/salgdi.cxx
	vcl/source/gdi/bmpacc3.cxx
	vcl/source/gdi/outdev2.cxx
	vcl/source/gdi/outmap.cxx
	vcl/source/gdi/regband.cxx
	vcl/source/gdi/region.cxx
	vcl/source/window/window.cxx
	vcl/unx/generic/gdi/pspgraphics.cxx
	vcl/unx/headless/svpgdi.cxx
	vcl/unx/headless/svppspgraphics.cxx
	vcl/win/source/gdi/salgdi.cxx

Change-Id: Iee9a66ff431c3cecb7603e445147b67715de0f7d

Remove unused variable to prevent compiler warning

(cherry picked from commit 0ac65ccf079e3e22ac23cbe7ae546504c863c31f)

Change-Id: Icbcaa9d576a7e560d96debc7360bdbe9090b3fd3

Wrong comparison with bool corrected

(cherry picked from commit 612cefdcf6176b6bb847ce899d89af40ef313a90)

Change-Id: I1cf5de6734b588f78d8e870ba7b7860634b461ce
2013-06-12 14:31:10 +01:00
Fridrich Štrba
2b700a710e EMF+: aBaseTransform is a hardcoded identity matrix, don't bother with it
Change-Id: Ifa4f42c4f17a70c7238347a13897ef6742eb4679
2013-06-12 10:03:55 +02:00
Fridrich Štrba
f387c5da5a Pass also the bounding box in device units to the EMF+ part
Change-Id: I71d3029d4b3aafdc44d82b0bd9db9a54f9b8b81f
2013-06-12 07:03:49 +02:00
Fridrich Štrba
721f82c9bf Use a local variable for the points
Change-Id: Ibd274ecd7eaeadaaef9f2a17a0d721355a561431
2013-06-11 11:41:23 +02:00
Fridrich Štrba
eb0a738d1b Refactor a bit the code while reading it
Change-Id: I58693bb4ffe0f59365069a87fc30081ddf226eaa
2013-06-11 11:41:23 +02:00
Fridrich Štrba
2933de9ce0 Fix typo and make the debug output a bit more readable
Change-Id: I45cb5303bfcc1f3df8455ac454f3e1b3fc5a11e0
2013-06-11 11:41:23 +02:00