Commit Graph

372 Commits

Author SHA1 Message Date
Chirag Manwani
38969497cb tdf#97640 Fixed-Width Font for Beanshell Editor
Change-Id: I809253a4f0481c825368d9c608cac77e64376aa0
Reviewed-on: https://gerrit.libreoffice.org/22404
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-17 07:34:11 +00:00
Caolán McNamara
e384e3851d coverity#1326200 Explicit null dereferenced
Change-Id: I39ed18b55657e375b1c22f97c49a0e43aedce4f5
2016-02-16 09:50:16 +00:00
Caolán McNamara
84d126c6b6 coverity#1326199 Explicit null dereferenced
extensionDb is always the same

Change-Id: I57b59f09b3f55757844a6aab6c6698857da2e15b
2016-02-16 09:50:16 +00:00
Caolán McNamara
b3e0bd62f5 coverity#1326399 Dereference null return value
Change-Id: I7828cdfcda5d4065fc3dafee744757292753abb5
2016-02-04 15:47:11 +00:00
Caolán McNamara
9b6cc4f409 coverity#1326631 DE: Dropped or ignored exception
Change-Id: If1f4f46ba51360eff3537f6804286adfe16c4a0e
2016-02-04 10:46:08 +00:00
Caolán McNamara
bd5bc033fd coverity#1326630 DE: Dropped or ignored exception
Change-Id: I495c1b5d9d0e03a92330fe6b9371183471aee7bb
2016-02-04 10:46:08 +00:00
Caolán McNamara
a7cf2bc5fc coverity#1326629 DE: Dropped or ignored exception
Change-Id: Ifb82c92eb0eaa019a19deee3dce375204576e2ee
2016-02-04 10:46:08 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Noel Grandin
b5df54c5bc java: add some @Override annotations
Change-Id: I291db1dff5ab3ce40fda6f822a0e3ff1e6ef36c1
Reviewed-on: https://gerrit.libreoffice.org/19855
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 11:14:56 +00:00
Noel Grandin
b73db446ac java: combine nested if statements
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-05 14:55:15 +02:00
Caolán McNamara
2f9bd9ac4d cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I5578dc3885945c013064cecf2ca86e7ca734368f
2015-10-25 15:41:02 +00:00
Caolán McNamara
d6a3c5786b coverity#1326446 Dereference null return value
Change-Id: I18b3e0cc30e05e9a53a0f7ae9997b9f190f192f4
2015-10-25 15:41:01 +00:00
Caolán McNamara
337661a989 coverity#1326446 Dereference null return value
Change-Id: Ief00b565147bd4a08c4fd6de9df71d9126dc1f75
2015-10-22 16:45:09 +01:00
Caolán McNamara
9740a474a4 coverity#1326429 Dereference null return value
Change-Id: Ib047f6cb255610422afb423006b58e0da7eacead
2015-10-22 16:45:09 +01:00
Caolán McNamara
86d275366a coverity#1326553 Dereference before null check
Change-Id: I1fe2e0477f136f31b854672878d0544d9492d51b
2015-10-20 21:18:35 +01:00
Caolán McNamara
f8ce21a346 coverity#1326552 Dereference before null check
Change-Id: I5a3fb6b5e9966a8e0c5dd0175e4f4f3292025a2c
2015-10-20 21:18:35 +01:00
Caolán McNamara
e9fc41292b Revert "coverity#1327168 see if stock SuppressWarnings is sufficient to"
that didn't work

This reverts commit 04a7df738a.

Change-Id: I5e4dfc28c03668eebb0fe8056beede7ef0b05ee5
2015-10-20 21:18:31 +01:00
Noel Grandin
a2fa0ded8a cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I98e5590f61434ed1b1081b5b592622f9bcf037ec
2015-10-16 12:50:49 +02:00
Caolán McNamara
04a7df738a coverity#1327168 see if stock SuppressWarnings is sufficient to
silence UrF: Unread field, some sources online suggest that it
might be the case

Change-Id: I2287da343e97bec93e0aaf7a82a408c18ab76d9b
Reviewed-on: https://gerrit.libreoffice.org/19396
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-15 15:59:27 +00:00
Caolán McNamara
585757d3fe coverity#1326240 Explicit null dereferenced
Change-Id: Ic84b5fbff0fbd7b8a750a7e40f2dffafe868b5d5
2015-10-15 14:26:06 +01:00
Caolán McNamara
f1e4e73dfc coverity#1326238 Explicit null dereferenced
Change-Id: Id02dcf1a1fac22eae0a2e01596521eefee9ecbf3
2015-10-15 14:26:06 +01:00
Caolán McNamara
52e8a80628 coverity#1326236 Explicit null dereferenced
Change-Id: Ic89c9b39f5f9c260581130da528bc0f514d4ef06
2015-10-15 14:26:05 +01:00
Caolán McNamara
5d5e14e97e coverity#1326899 HE: Equal objects must have equal hashcodes
and...

coverity#1326898 HE: Equal objects must have equal hashcodes
coverity#1326897 HE: Equal objects must have equal hashcodes
coverity#1326896 HE: Equal objects must have equal hashcodes
coverity#1326895 HE: Equal objects must have equal hashcodes

Change-Id: Ic9cb7542c1bf0608a97e5b4756b737cdf1bb4bd8
2015-10-15 09:12:36 +01:00
Noel Grandin
06907141b9 cid#1326116 Unchecked return value
Change-Id: If33ea9c4e4388cc1b7d15847f32dd2228b047363
2015-10-15 09:29:29 +02:00
Noel Grandin
a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Noel Grandin
3cc4b81b76 java:using "this" with a static field makes no sense
Change-Id: I79a38ff2ec50d3a3687cac7ed7688bbbcaf2208c
2015-10-14 16:07:50 +02:00
Caolán McNamara
d9bb701494 coverity#1326568 Unused value
Change-Id: Idf1efef484d3a89bd56ba9a6807d4191ef95cb41
2015-10-14 15:02:41 +01:00
Caolán McNamara
6946b688f6 coverity#1327113 UrF: Unread field
Change-Id: I4cc7faaf0ac74c4e1baa2e978d8dea9bc8d7b6d0
2015-10-14 15:02:41 +01:00
Caolán McNamara
d46134e55b coverity#1327178 UuF: Unused field
Change-Id: Ie9ed1f86a3a51d766987d631605dc561e9748f99
2015-10-14 15:02:41 +01:00
Noel Grandin
43cbaac5b9 cid#1326361 Data race condition
Change-Id: Ia61737232d816bb05f3aedbe76e7905262906a79
2015-10-14 12:30:57 +02:00
Noel Grandin
fb451a14c0 cid#1326674 DLS: Dead local store
Change-Id: I8168d3703022c9a1baed6e82c43a04ffa0ca52c0
2015-10-14 12:05:51 +02:00
Noel Grandin
ec0c4ce0a0 cid#1326345 Check of thread-shared field evades lock acquisition
Change-Id: I11fc66358c13c6bb1b6f109980384131b38ef18b
2015-10-14 09:55:16 +02:00
Andrea Gelmini
5d5dc059cb Fix typos
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28 12:35:58 +00:00
Noel Grandin
0c18bedb73 java: 'final static' to 'static final'
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15 08:45:19 +00:00
Noel Grandin
efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Julien Nabet
1101ae6772 Typo: deleteing->deleting
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
2015-02-21 10:56:21 +01:00
Stephan Bergmann
f1f6edaae1 Make LogUtils.getTrace actually work
Change-Id: I59e2b93ed1142bac22ead08cc101e27cfa3e02df
2015-02-16 11:27:14 +01:00
Stephan Bergmann
3336a5071b rhbz#1192732: Revert "From the context of the code, this field should...
...not be static."  This reverts commit
6d4c1f0d4a.  Whatever made the author of that
commit think rhinoWindow shouldn't be static, it clearly needs to be, as in
edit()'s Runnable.run(), the usage of rhinoWindow at the end relies on
rhinoWindow being set via the

  new ScriptEditorForJavaScript(context, url)

call to initUI() (or else rhinoWindow already being set from a previous such
call if already editor != null).
2015-02-16 10:45:50 +01:00
Andras Timar
b55ef81671 typo: langugage -> language
Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
2015-01-23 15:01:37 +01:00
Noel Grandin
3ab2d3a2c5 fdo#88256 fix crash when running javascript macro
caused by my commit 8583da1e93
"java: remove unused fields"

Change-Id: Ibcd6462e8229a0a6cb98ebfd16ce5d2ea45ca931
2015-01-13 10:38:48 +02:00
Noel Grandin
e92d3e9007 java: scripting: fix bug in removing model from map
found by PMD

Change-Id: I4bd35dd30f6c77aad96932216d8459b812004a88
2014-12-19 10:41:54 +02:00
Noel Grandin
08ece8d873 java: revert part of commit, scripting/ is public API
revert part of my commit
7557f23b31
"java: reduce visibility of fields and methods"

Change-Id: I2049a154b60b165d4d2217495935442d6da66e97
2014-12-11 15:20:09 +02:00
Noel Grandin
7557f23b31 java: reduce visibility of fields and methods
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11 06:09:03 +00:00
Noel Grandin
7d812b09b5 java: unused imports
Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08
Reviewed-on: https://gerrit.libreoffice.org/13403
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:03:50 +00:00
Noel Grandin
c199b76d88 java: remove some unused local variables
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05 11:15:57 +02:00
Noel Grandin
db203e59d6 java: remove some unused fields
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
2014-12-05 11:15:56 +02:00
Noel Grandin
58eab57648 java: final fields that can be static
found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25 06:06:48 +00:00
Noel Grandin
0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:03:29 +00:00