mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
388,143 Commits 1 Branch 0 Tags
8fd8a8875def353db34c68ee74d40772b83bae4c
Commit Graph

92 Commits

Author SHA1 Message Date
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Noel Grandin
fe0e43a376 loplugin:unusedmethods unused return value in scripting 
Change-Id: I9b203e255eddce59c37df1a94884e459df034459
 2016-01-14 11:45:21 +02:00
Caolán McNamara
bea8a7ad63 cppcheck: noExplicitConstructor 
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
 2015-12-29 19:46:23 +00:00
Noel Grandin
8ac44ca189 loplugin:unusedfields in scripting 
Change-Id: Ida8fb31bd85f4807d74daab3d022d8e6340a774d
 2015-12-22 09:53:26 +02:00
Noel Grandin
a508f639a0 mark UNO structs as SAL_WARN_UNUSED, where possible 
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
 2015-11-26 13:26:25 +02:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Stephan Bergmann
65464ed098 loplugin:nullptr (automatic rewrite) 
Change-Id: I9b7d8de65780325175d24965057596b88d3c0f05
 2015-11-10 10:31:37 +01:00
Stephan Bergmann
801b914324 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: If0f1446a25f423b8cbfe6346f7a691f4f2618ad0
 2015-11-06 09:36:56 +01:00
Noel Grandin
0eb9f56db5 use uno::Reference::set method instead of assignment 
Change-Id: I2b592fd3327f4bbe4685e84711dc9d6f19222a97
 2015-11-05 07:41:29 +02:00
Noel Grandin
d95a27f944 com::sun::star->css in scaddins,sccomp,scripting 
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4
Reviewed-on: https://gerrit.libreoffice.org/19629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-28 06:31:27 +00:00
Caolán McNamara
7462cfde6d coverity#1308579 Uncaught exception 
Change-Id: I6bd1f9cdf69865972de9c22106a95e1ebf9a74f7
 2015-06-29 09:43:34 +01:00
Caolán McNamara
9202cab167 coverity#1308598 Uncaught exception 
Change-Id: Id65e076641506e128c27cec4f50bc677e808fa95
 2015-06-29 09:43:31 +01:00
Caolán McNamara
6f823d85f7 coverity#1308548 Uncaught exception 
Change-Id: I62d538799a814346df4de00dc232a04376e77ad7
 2015-06-28 20:52:35 +01:00
Caolán McNamara
a4fdbaf546 coverity#1308512 Uncaught exception 
Change-Id: Iacdf2e25fb041ec7e2bae8a505604ef538ee9dac
 2015-06-28 17:55:48 +01:00
Noel Grandin
4ea281a3cc cppcheck:redundantAssignment 
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
 2015-06-15 13:34:14 +02:00
Stephan Bergmann
4446cdf20b loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I14d1c6f703c83bc4a0259ce68e93a315bbfdde4e
 2015-06-08 16:27:44 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations 
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
 2015-03-17 12:25:11 +01:00
Julien Nabet
7da92fdcb0 cppcheck: Possible inefficient checking for <var> emptiness 
Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
 2015-01-04 19:11:13 +01:00
Michael Weghorn
17fc7aa3b8 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I390607e002e93cf7a6babc26d9be084d9f185058
 2014-12-21 20:18:17 +01:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Norbert Thiebaud
39c8834d21 coverity#1209004 Unchecked return value 
Change-Id: I8749a5d6f176406e181312d94a1e643974d87617
 2014-10-05 13:26:10 -05:00
Caolán McNamara
d375986dae coverity#707084 Uncaught exception 
Change-Id: I89459f7a77fcb5785cfb2e8288326fce65202d9c
 2014-09-02 15:36:28 +01:00
Stephan Bergmann
70946992d4 Fix some *_component_getFactory function types 
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
 2014-08-28 16:11:33 +02:00
Noel Grandin
533c6cb6ba fixes for up-casting to Reference<XInterface> 
Fix regressions introduced with
6a043e9c0a "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-06-25 17:10:43 +02:00
Julien Nabet
d59da701c6 Related fdo#58774 Alternative dialog Find & Replace for Writer 
After having installed the extension from http://extensions.libreoffice.org/extension-center/alternative-dialog-find-replace-for-writer/releases/1.4
I had a crash, extract of bt:
5  0x00002aaad3ee13df in rtl::OUString::copy (this=0x7fffffff2510, beginIndex=147, count=-15) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:1481
6  0x00002aaad3edc10e in stringresource::StringResourcePersistenceImpl::implScanLocaleNames (this=0x8e2bba0, aContentSeq=uno::Sequence of length 24 = {...})
    at /home/julien/compile-libreoffice/libreoffice/scripting/source/stringresource/stringresource.cxx:1728

So add a quick check to be sure iDot > iSlash

Change-Id: I944a852d6cc9a35c451985ac96032f0d848136e8
 2014-06-21 22:33:17 +02:00
Noel Grandin
db246b491c scripting: remove SAL_THROW macro 
Change-Id: I535a57d043ac51926ae6f640d721d0dd1571c3fa
 2014-06-05 08:17:52 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Noel Grandin
b2096deaff various loplugin:passsequencebyref 
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
 2014-05-14 16:54:27 +02:00
Noel Grandin
2ff8ae7c9e scripting: sal_Bool->bool 
Change-Id: I1550c49cce2ad64f9d62b06ec20512a750f83b84
 2014-04-24 10:53:16 +02:00
Caolán McNamara
e57401aeb0 coverity#704287 Logically dead code 
Change-Id: Iab22d2d12319bc01f9aebc1dcf40f47881d40446
 2014-03-29 18:12:06 +00:00
Donizete Waterkemper
c4cff5a645 fdo#54938: Convert some places to use cppu::supportsService 
Change-Id: Ib941c6ec82d81b1da815561eee87ee91dc8de200
Reviewed-on: https://gerrit.libreoffice.org/8443
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
 2014-03-03 15:53:46 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
b0308236d2 Remove visual noise from scripting 
Change-Id: Id9f177a20d911ce1e041407aa556c9cf13f0efc8
Reviewed-on: https://gerrit.libreoffice.org/8305
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 08:37:40 -06:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
dbac5ccaf8 bool improvements 
Change-Id: I0ef2adc0bd4a4764c38094b2b7d27c3453ecc117
 2014-01-28 20:26:23 +01:00
Noel Grandin
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls 
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
 2014-01-07 09:43:37 +02:00
Noel Grandin
2ac50736e4 remove unnecessary use of OUString constructor in SCRIPTING module 
Change-Id: I87dd775949d1d3cc2c191e84e57b49cd66ecc750
 2013-11-11 08:36:06 +02:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Marcos Paulo de Souza
ee5661ecd3 fdo#54938: Adapt supportsService implementations.. 
to cppu::supportsService

Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-22 10:28:10 +00:00
Takeshi Abe
f4004429d3 Mark as const 
Change-Id: Ic81dd60fadecf72f25792903985f2b387df7a7a0
 2013-08-19 07:47:34 +09:00
Eike Rathke
6b2aaa7d23 resolved fdo#67444 don't push_back() with already reserved size 
Change-Id: I5660bdf07ad0adae053508bed1805369850c1134
 2013-08-07 12:02:58 +02:00
Eike Rathke
38522416bd use LanguageTag::getMatchingFallback() 
Change-Id: Ib6fd9581728bdd7c32ccec9ce538d9b4c5658b04
 2013-07-11 17:48:14 +02:00
Eike Rathke
3f1a58884e added FIXME-BCP47 comments 
Change-Id: I9e47a22f8a061461bfb0f21e74ae001e719f04b6
 2013-07-10 21:48:15 +02:00
Noel Grandin
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise 
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2013-05-22 10:44:29 +00:00
Stephan Bergmann
617e7c6231 Missing include 
Change-Id: I1be082b7db5592ad5090cf3ffaafe708bb1d9be4
 2013-04-16 19:07:36 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00