Commit Graph

95 Commits

Author SHA1 Message Date
Julien Nabet
2b60e64c18 Use const_iterator when possible (whole dbaccess)
Change-Id: I3d10a7914353b384fc7a2195a70398869f675211
Reviewed-on: https://gerrit.libreoffice.org/23570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-28 18:39:16 +00:00
melikeyurtoglu
6e2de428a4 tdf#57950 Replace chained O(U)StringBuffer::append() with operator+
Change-Id: I2576c997d5b82fd8bdfd0c9430c7a1e11d7e07df
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/22049
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-18 21:37:07 +00:00
Stephan Bergmann
89c4edc13f loplugin:nullptr (automatic rewrite)
Change-Id: I2bba104b1bff30910864e45b5b032533099742ff
2015-11-10 10:31:22 +01:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Noel Grandin
7dc5e8731f com::sun::star->css in dbaccess
Change-Id: I4fbdd3fb7d1e0ad4423148aaaed3a15aebb26d14
2015-08-03 13:38:44 +02:00
Caolán McNamara
64385c7555 cppcheck: noExplicitConstructor
Change-Id: I999923031c573f361bc421eab84e68a4a130d688
2015-07-05 21:22:31 +01:00
Stephan Bergmann
cc7ae77764 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I2d1b59cf13c3944b24ad54dc63e20b83a9c8a015
2015-04-01 08:38:29 +02:00
Stephan Bergmann
2b86f17f05 dbaccess: Use appropriate OUString functions on string constants
Change-Id: Iea28ad5e1a469830e002471517197365fd6de3ee
2014-12-15 10:11:27 +01:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Stephan Bergmann
b396ae62f7 dbaccess: sal_Bool -> bool
Change-Id: Ifad71823e72be71cbd9f9f58a51f4553ff54e4d4
2014-09-12 16:15:27 +02:00
Noel Grandin
fee4efcb54 dbaccess: sal_Bool->bool
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
2014-04-17 11:17:21 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
Stephan Bergmann
cfedbdea58 Remove newly unused getUnoTunnelImplementationId functions
...after recent clean-up of getImplementationId implementations.

Change-Id: I2a11f6ddf03dc7852b7e8e50dc6284a7215a0113
2014-03-11 13:03:20 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Arnaud Versini
5b2ba8ed5d DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Conflicts:
	dbaccess/source/ui/dlg/tablespage.cxx

Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 16:20:10 +00:00
Noel Grandin
d9648d3567 remove unnecessary sal_Unicode casts in DBACCESS module
Change-Id: I4c4ab5d672e994b1e8e3beac027d3f4e8f700714
2013-11-14 08:17:30 +02:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
Jelle van der Waa
2ec606730b fdo#62475 removed pointless comments
Conflicts:
	dbaccess/source/filter/xml/xmlfilter.cxx
	dbaccess/source/ui/dlg/ConnectionPage.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/odbcconfig.cxx
	dbaccess/source/ui/querydesign/querycontroller.cxx

Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-27 16:11:09 +00:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Julien Nabet
f62cb42d06 cppcheck: fix reassign
Change-Id: Ic1f02c6734cbb0ac4846f0003f70091d5d5b4315
2013-06-07 00:05:58 +02:00
Miklos Vajna
e894e57aab dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer needed
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
2013-04-25 11:02:34 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Noel Grandin
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
Lionel Elie Mamane
9330b97595 fdo#61564 when WrappedTargetException not in specification, do not throw it!
Change-Id: Id3c995557f320b1d0241f0ef5d94b1c9aeb66528
2013-03-02 08:11:03 +01:00
Marcos Paulo de Souza
a1808e0d38 Remove more STRINGPARAM macros form dbaccess
Change-Id: I283ccd03dc811dda2f10963f400cd517f42ea7b3
Reviewed-on: https://gerrit.libreoffice.org/1878
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2013-01-27 17:31:43 +00:00
Noel Grandin
abcbababca fdo#46808, Convert comphelper::MimeConfigurationHelper to XComponentContext
Change-Id: I74b4f0c4a84f02b218102405eaba24cf47f654ce
2013-01-15 09:56:03 +02:00
Marcos Paulo de Souza
0f2a3a3bdc Removed some RTL_* macros and rtl:: prefixes in dbaccess
Change-Id: I467ad9307536e6cdd32ebcdd40539bd5f8614c85

Conflicts:
	dbaccess/source/core/dataaccess/documentcontainer.cxx
2013-01-10 10:24:09 +01:00
Noel Grandin
b9a4a0b965 fdo#46808, Convert connectivity::SQLError to use XComponentContext...
...instead of comphelper::ComponentContext.

Change-Id: I40384c2d7cfcabd06506321d686dd8e7c7c5f266
2012-12-10 08:05:49 +02:00
Noel Grandin
2cf0f6ea36 fdo#46808, use service constructor for ucb::CachedDynamicResultSetStubFactory
Change-Id: Iea7b21621c5d341468976507684a9c01f0822034
2012-11-30 13:59:47 +01:00
Michael Meeks
577cf8ff67 re-base on ALv2 code. 2012-06-14 17:41:07 +01:00
Caolán McNamara
5dcf536b69 merge the 5 ConstAsciiString duplicate classes together
a) merge them together and move it into comphelper
b) turn it into a POD rather than having vast amounts
of destructors registered into the cxa_atexit chain

Change-Id: I04d3b9d7804f8e233013c916df9d617a0f84f96a
2012-05-17 14:03:26 +01:00
Szabolcs Dezsi
8a01ee6243 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 14:30:05 +02:00
Takeshi Abe
5d9b072cef removed duplicate includes in dbaccess 2012-03-30 00:42:35 +09:00
Luboš Luňák
3f765e5bb2 replace usage of OUString::replace*AsciiL() with string literal overloads 2012-03-12 13:35:57 +01:00
Stephan Bergmann
9ab0b38e95 Various string function clean up
Added:
* rtl::OString::matchL
* rtl::OString::endsWith
* rtl::OString::endsWithL
* rtl::OString::indexOfL
* rtl::OString::replaceFirst
* rtl::OString::replaceAll
* rtl::OString::getToken
* rtl::OUString::endsWith
* rtl::OUString::replaceFirst
* rtl::OUString::replaceFirstAsciiL
* rtl::OUString::replaceFirstAsciiLAsciiL
* rtl::OUString::replaceAll
* rtl::OUString::replaceAllAsciiL
* rtl::OUString::replaceAllAsciiLAsciiL
* rtl::OUString::getToken
plus underlying C functions where necessary

Deprecated:
* comphelper::string::remove
* comphelper::string::getToken

Removed:
* comphelper::string::searchAndReplaceAsciiL
* comphelper::string::searchAndReplaceAllAsciiWithAscii
* comphelper::string::searchAndReplaceAsciiI
* comphelper::string::replace
* comphelper::string::matchL
* comphelper::string::matchIgnoreAsciiCaseL
* comphelper::string::indexOfL

Also fixed some apparent misuses of RTL_CONSTASCII_USTRINGPARAM ->
RTL_CONSTASCII_STRINGPARAM.
2012-02-15 15:41:09 +01:00
Olivier Hallot
545921f914 Fix for fdo43460 Part XII getLength() to isEmpty()
Part XII
Module
dbaccess
2011-12-21 09:52:48 +01:00
Norbert Thiebaud
281b13ce89 remove include of pch header in dbaccess 2011-11-27 13:04:48 -06:00
Caolán McNamara
742925d6e5 catch exceptions by reference 2011-03-28 16:08:55 +01:00
Thomas Arnhold
fbcbfa9d34 Move OSL_ENSURE(sal_False,...) to OSL_FAIL(...) 2011-03-19 14:05:01 +01:00
serval
3571121d40 Some cppcheck cleaning 2011-01-15 17:09:39 +00:00
Takeshi Abe
98ab2fdde6 remove dead codes and undesired comments 2010-11-23 07:40:17 +01:00
Wol
9b6062afb3 Spelling mistakes, and deleting unwanted comments and commented code 2010-11-10 08:50:30 +01:00
Norbert Thiebaud
84869b63b4 merge vosremoval-mutex.diff
In practice the changeset is 'inspired' by vosremoval-mutex.diff
but was essentially redone manually
2010-10-25 17:54:56 -05:00
Norbert Thiebaud
921136c693 use SolarMutexGuard to guard the SolarMutex 2010-10-25 17:54:56 -05:00
Gil Forcada
58ccb8ca29 Removed comments, trailing spaces and death code (2) 2010-10-13 12:25:14 +02:00
Sebastian Spaeth
6450d1a7f5 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:12 +02:00
Petr Mladek
dc8c15ae62 remove include guards using fixguard.py 2010-10-05 17:58:28 +02:00
Frank Schoenheit [fs]
c73b3e8ea9 autorecovery: merged changes from m74. Still need to find out how to re-do two patches (to module_hidden_ooo.scp and file_ooo.scp in scp2/source/ooo) which do not apply anymore. 2010-03-11 11:26:05 +01:00
Jens-Heiner Rechtien
1708f6091b changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Frank Schoenheit [fs]
56cc145c6e autorecovery: allow for a human-readable DocumentServiceName instead of this strange class ID when creating a document definition 2010-02-05 22:03:01 +01:00