981 Commits

Author SHA1 Message Date
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Caolán McNamara
49cecd8b41 Related: fdo#74242 hook up a selection and caret change for multiline edits
a) split the textengine selection changed broadcast into a text selection changed
and text caret change event
b) handle both in existing places that handled the text selection event
c) listen for them in VclMultiLineEdit and translate to
VCLEVENT_EDIT_SELECTIONCHANGED VCLEVENT_EDIT_CARETCHANGED events
d) profit from the VCLEVENT_EDIT_SELECTIONCHANGED and
VCLEVENT_EDIT_CARETCHANGED handling in
accessibility/source/standard/vclxaccessibleedit.cxx for VCLXAccessibleEdits

Change-Id: I09187e76ae4eb189ee9469e388374154087faf80
2014-02-19 15:32:00 +00:00
Caolán McNamara
da13dd9a35 Related: fdo#74242 #i104470# we now have a seperate CARET_CHANGED event
so cursoring left and right in normal non-multiline edit widgets should
give a11y cursor-changed events

Change-Id: I91e86e43d049793912b3ffcc2802bb9aa4b3857c
2014-02-19 11:07:12 +00:00
Michael Stahl
368cff78a4 accessibility: add some missing locks in new code
Change-Id: Ic38a07c592a89973ca1df807505f87910e84a17f
2014-02-11 12:52:22 +01:00
Caolán McNamara
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
Stephan Bergmann
660c1889c9 std::less is the default here
Change-Id: I57428772187d3487668eca2f553c74e18e4f736e
2014-02-07 18:43:31 +01:00
Stephan Bergmann
2935c2999e auto_ptr -> scoped_ptr
Change-Id: I05c461deca118f1a1b75d94b4d00ce797987e8d6
2014-02-07 18:43:31 +01:00
Stephan Bergmann
2b04d0a17f Avoid unnecessary heap allocation
Change-Id: I7bc1a0960cc100c51b90c50838a5ef620f3c763f
2014-02-07 18:43:30 +01:00
Chris Sherlock
51a68b4992 Doxygen warnings corrected
* Doxygen spits out a lot of warnings about not being able to find
  match function signatures, etc. This is because in some headers we
  have a using namespace statement, in others it gets confused between
  ::Window and Window (!).

* Wrong use of tags:
  + Lots of @seealso - should be @see
  + Wrong usage of @overload - corrected with the right function
    signature
  + HTML tags that doxygen doesn't recognize removed

Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-05 09:14:53 +00:00
Caolán McNamara
0be44f7d15 fix ambiguities
Change-Id: Ice46cfbe8a21c5e641e09070128b8f412411c9d9
2014-02-04 14:57:37 +00:00
Herbert Dürr
59238ef422 Related: #i123862# use O*String's isEmpty() method...
to check for emptiness in modules starting with 'a'

Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 40b2ffbb1036c2f2db50965525009213d8fd6343)

Conflicts:
	accessibility/source/extended/accessibleiconchoicectrl.cxx
	accessibility/source/extended/textwindowaccessibility.cxx
	accessibility/source/standard/vclxaccessiblebox.cxx
	accessibility/source/standard/vclxaccessibletoolboxitem.cxx
	automation/source/server/recorder.cxx
	automation/source/server/statemnt.cxx
	avmedia/source/framework/mediacontrol.cxx
	avmedia/source/framework/soundhandler.cxx
	avmedia/source/gstreamer/gstplayer.cxx
	avmedia/source/viewer/mediawindow.cxx

Change-Id: I8e6d6754282634f6931a2e7f73f08f70c23d452e
2014-02-04 12:14:11 +00:00
Stephan Bergmann
bfe5448939 bool improvements
Change-Id: I09ac60e907b7c0a78934dce05343e2ba2b6df49f
2014-01-28 20:26:30 +01:00
Steve Yin
05534b5523 Resolves: #i124008# listbox entry's are selected automatically...
on mouse over instead of mouse click

(cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3)

Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28 11:37:23 +00:00
Caolán McNamara
ab4b2e0b56 coverity#983594 Uncaught exception
Change-Id: Ic49f88b44216a24df8a236b755d22b2537245c5f
2014-01-28 11:29:14 +00:00
Caolán McNamara
420ca6138c coverity#706219 Uncaught exception
Change-Id: I1c2566337347679453bee46a78a4a0ecd7fdd2fb
2014-01-28 11:29:14 +00:00
Alexandre Vicenzi
4bdf9a0247 fdo#63154 Removed unused solar.h reference
Change-Id: I6b2f9e04e2232570c8bb9f36252b23a70c5f7525
Reviewed-on: https://gerrit.libreoffice.org/7604
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-23 09:48:42 +00:00
Norbert Thiebaud
a1a545aa98 coverity#1132668 : missing break in switch
Change-Id: Ia759081e7ccc9105898f25025ea567d900d33b13
2014-01-19 15:29:26 -06:00
Norbert Thiebaud
2a77e7a310 coverity#1158122 : Explicit null dereferenced
Change-Id: I6ffec6e69ca5ddb01998653d2f7637ed062bdc80
2014-01-19 15:14:55 -06:00
Norbert Thiebaud
8db51361dc coverity#1132662 Dereference after null check
Change-Id: Iaccf8bb7903702d2bed3c4fc2195172e18ead6c7
2014-01-19 15:11:09 -06:00
Norbert Thiebaud
9fd10cca8e coverity#1132661 Dereference after null check
Change-Id: Ida147599810b0aff4a7ebd00b90475b1c6cd1366
2014-01-19 15:07:28 -06:00
Norbert Thiebaud
014a0e5d6f coverity#1132660 Dereference after null check
Change-Id: Ib184d73f2ced3beca8540a37bab74c4a712170ba
2014-01-19 14:59:29 -06:00
Anderson Roberto
330c6cb59a fdo#57950: Remove chained appends in accessibility
Change-Id: I4ba583a891933068ab4003307d09693180c7b61f
Reviewed-on: https://gerrit.libreoffice.org/7436
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-01-15 10:47:57 +00:00
Michael Stahl
158b4df603 svtools: rename IAccessibleTableControl::dispose()
... to not confuse it with XComponent::dispose().

Change-Id: I056fdf77f9116d1c22f8ca9313a0ea313fb1c4aa
2013-12-16 16:21:09 +01:00
Michael Stahl
449e0c9c73 accessibility: don't crash if the TableControl is dead
AccessibleGridControlAccess: clear the m_pTable member in dispose() so
it is no longer accessed later.

Change-Id: I490c84ce1bee55c9c69eb29b81ddfbe808301797
2013-12-16 16:21:09 +01:00
Michael Stahl
9eccfd86ee accessibility: Mutex cleanup in AccessibleGridControl* classes
For unknown reasons this uses both SolarMutex and a OBaseMutex::m_aMutex
to lock some but not all methods, which seems odd.

- remove a third mutex AccessibleGridControl::m_aMutex that appears
  unused
- lock OBaseMutex::m_aMutex in AccessibleGridControlBase::isAlive()
  which accesses rBHelper members, which should be sufficient
- lock SolarMutex in all UNO methods
- remove misc weird stuff like TC_SolarMethodGuard

Change-Id: I8321757fb4a5043a05c23f2dc9801f5d8c8d911e
2013-12-16 16:21:08 +01:00
Takeshi Abe
526a60086c Drop duplicate #include
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
2013-12-08 17:20:40 +09:00
David Ostrovsky
130833f80e fdo#39956 Delete JAB
JAB has been discontinued in favor of the native IA2 bridge.

Change-Id: I88461f73c620507d3e97b077ea2abdd2229322e1
Reviewed-on: https://gerrit.libreoffice.org/6819
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-12-05 05:31:43 -06:00
Herbert Dürr
5585c4f2bf Related: #i123768# [ia2] remove pseudo-automatic noisy comments
Change-Id: I346518267294556ce529966fe168440de05a38c6
2013-11-28 14:33:55 +00:00
Stephan Bergmann
382421189f Improve exception message
Change-Id: I06ffe3088546d55b29d61ccfae16937d8a7ce9e8
2013-11-27 09:15:14 +01:00
Stephan Bergmann
1533129759 Revert sense in VCLXAccessibleBox::getAccessibleActionCount again
...this had been switched from "m_bIsDropDownBox ? 1 : 0" to "m_bIsDropDownBox ?
0 : 1" in efb23f29983f87104a684e7fab00b84fc59d131d "Integrate branch of
IAccessible2" for no apparent reason and broke JunitTest_testtools_unoapi.

Change-Id: I276d2f452648387a5fa693349cf868787b2d48e1
2013-11-27 09:12:38 +01:00
Stephan Bergmann
62fcdfa34a -Werror,-Wunused-private-field
...fixed more thoroughly than 49c1964b427c9f2f169ba4d826d346adc7555ae0 "WaE:
private field 'm_bCompoundControlChild' is not used."

Change-Id: Ief1093c054fe272b82da78ab103e8ca3feb72b90
2013-11-26 15:56:33 +01:00
Tor Lillqvist
49c1964b42 WaE: private field 'm_bCompoundControlChild' is not used
Change-Id: I656c044de766e274f4938facc3a85b6152ba79ed
2013-11-26 16:11:36 +02:00
Stephan Bergmann
383c7a4b90 statement aligned as second statement in if body but not in a statement block
Change-Id: I237148ec56164994e5c3168ef5b7dfc56588cad9
2013-11-26 14:41:27 +01:00
Stephan Bergmann
cbb8e6d1b6 -Werror,-Wunused-variable
Change-Id: I4a501430d6ea8fdf6d2ae748fd3e122846c0b4cd
2013-11-26 14:34:33 +01:00
Tor Lillqvist
378963fdb2 WaE: unreachable code
Change-Id: I21cce258c0cc978bd8a45148102787d3c4017e64
2013-11-26 15:14:46 +02:00
Caolán McNamara
e579d45354 Document::ProcessWindowEvent now just forwards to baseclass
Change-Id: Ia4c224105e15c8eea90a9c98161981ff10661044
2013-11-26 10:24:30 +00:00
Steve Yin
efb23f2998 Integrate branch of IAccessible2
(cherry picked from commit e2f90c93c97f3cf137c348ed302c6470f398aa70)

Change-Id: I44ce0d69f3e7364038b00b1ba0f0d27e60132a37

WaE: Prevent uninitialized variable warnings.

(cherry picked from commit b989f4074ea70729d527b307bfbe49e01a0d3646)
2013-11-26 10:24:24 +00:00
Michael Stahl
31b91f6f8a --enable-ia2 no longer disables Java access bridge
Just install both; 448727e598ca0c35ee9cd6f2c25a847c8147943b already made
IA2 an experimental feature with fallback to Java access bridge if
experimental mode is disabled.

Change-Id: I4ca64adbc586bd87b4d28087709f5c2e02bf7990
2013-11-21 15:14:43 +01:00
David Ostrovsky
b4f2dc2b64 Add --enable-ia2 configuration option
Change-Id: I950c47bd95d5bb4aacf9e584c8e2eeef461af71f
2013-11-19 10:02:23 +00:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Andrzej J.R. Hunt
2549be5a75 Add namespace to accessbility's TkResMgr.
Previously this conflicted with include/toolkit/helper/tkresmgr.hxx,
breaking the Android build.

Change-Id: I195e18e42a5978fd7d415a8afaa007b3bee33190
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-15 10:31:35 +01:00
Bjoern Michaelsen
04dead1c6b make l10n buildable separately
- this renames the 'almost' module target to non-l10n
- and adds a l10n target which is intended to only build l10n parts of
  the product
- packagers should then be able to build l10n and non-l10n parts of the
  product independently, thus:
   - enable quicker rebuilds
   - distribution of load
   - updates to l10n without a full rebuild
   - security fixes to binaries without rebuilding all l10n
- the new targets are called build-l10n-only and build-non-l10n-only
- note this is not intended to move a concept of split packages
  upstream -- while this exsists in distros, the number of test
  scenarios for this would explode upstream

Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863

Conflicts:
	filter/Module_filter.mk
2013-11-14 16:45:02 +01:00
Michael Stahl
8e602afd1e stop looking for Jar files in solver
Change-Id: I4d2a93fa7395354fbf2893df9e254ab39fa365af
2013-10-25 11:42:40 +02:00
Thomas Arnhold
f852bda5ec clean up some include guards
Conflicts:
	sw/source/ui/inc/content.hxx

Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6
Reviewed-on: https://gerrit.libreoffice.org/6388
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-23 10:28:07 +00:00
Michael Stahl
4fc7deb7b0 fix STL assert in accessibility::AccessibleGridControl::commitTableEvent
While running some JunitTest, crashes on an attempt to delete entries
of an empty vector m_pImpl->m_pTable->m_pCellVector.

The entries are created on-demand by
AccessibleGridControlTable::getAccessibleChild(), so presumably that
hadn't been called yet when the rows were deleted.

Also fix bizarre abuse of all applicable variable naming conventions.

(regression from 2095b2e1d44a158418d17836019352ed92f95d21)

Change-Id: Id2d70ca4601a166718629c0fe922f805dd72eec1
2013-10-04 14:46:24 +02:00
Michael Stahl
da21e9de6a require OAccessibleContextHelper to be initialized with SolarMutex
OAccessibleContextHelper methods are locked by OExternalLockGuard
which effectively only locks its ExternalMutex (i.e. SolarMutex);
so ensure that all sub-classes actually pass in a SolarMutex
by removing the default constructor.

(since these classes are in comphelper they can only use the
SolarMutex indirectly)

This uncovers that AccessibleToolPanelDeckTabBarItem and
OAccessibleControlContext did not pass in SolarMutex before.

Change-Id: Ib9085eeee6225f7c74b158e72f04b1bf62622071
2013-10-04 14:46:24 +02:00
Caolán McNamara
98de5b40c8 Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-25 19:24:23 +02:00
Noel Grandin
e6d91ff224 convert ACCESSIBILITY module from String to OUString
Change-Id: Ia4d2e1feef575cb911e981fbb8b6359755ab0dd9
2013-09-17 09:05:40 +02:00