mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

2415 Commits

Author SHA1 Message Date
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings 
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
 2014-07-01 10:56:14 +01:00
Norbert Thiebaud
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp() 
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
 2014-06-27 17:08:04 +02:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations 
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
 2014-06-27 15:27:39 +02:00
Joren De Cuyper
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels 
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-06-23 09:01:25 +00:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Stephan Bergmann
0e44fb66e5 loplugin:staticcall 
Change-Id: Ida2e09b88c9df0d70c8298020d768e6386714edd
 2014-06-13 17:54:22 +02:00
Caolán McNamara
9a1298cf86 coverity#1213488 Uncaught exception 
Change-Id: Iee4e5dd2936979a9bcb8bd5db781e51551270a7f
 2014-06-13 09:50:53 +01:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Noel Grandin
0e507ae031 various: remove SAL_THROW macro 
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
 2014-06-05 08:17:52 +02:00
Takeshi Abe
b32ee04731 Avoid possible memory leaks in case of exceptions 
Change-Id: I1988d2766d8bdeb5f8a22a5673dcff9b898dd637
 2014-05-31 22:30:40 +09:00
Thomas Arnhold
5e62d30fa2 update_pch 
Change-Id: I5316693452427ed76a7738b090de023b110caa40
 2014-05-28 15:53:10 +02:00
Thomas Arnhold
92b447876d css already means ::com::sun::star 
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
 2014-05-27 14:00:28 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Jan Holesovsky
7aa79223d7 bnc#467278: Introduce a warning that changes to VBA macros cannot be saved. 
As an InfoBar, so hopefully not annoying...

Change-Id: I5d4e79273edc03829fdab2d6d5a291576c954e4b
 2014-05-22 17:31:27 +02:00
Thomas Arnhold
3db8d606d5 hrc and src files: squeeze multiple newlines 
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
 2014-05-19 20:04:22 +02:00
Tsutomu Uchino
c9f3c508bb Resolves: #i76558# jump by Enter key on the Object catalog 
(cherry picked from commit 7bc75c1a7b05d81631ebccf05bf022636d1a3a14)

Conflicts:
	basctl/source/basicide/objdlg.cxx
	basctl/source/basicide/objdlg.hxx

Change-Id: Id3fa3686fd60df192c02cc8137c9bc59e68c1d49
 2014-05-19 08:57:45 +01:00
Thomas Arnhold
70895b691e remove legacy svheader.hxx 
none of the corresponding headers is included...

Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
 2014-05-15 17:47:39 +02:00
Noel Grandin
248145f99e Find places where uno::Sequence is passed by value. 
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-14 08:10:22 +00:00
Jan Holesovsky
261b1ad80a '!= false' is redundant, and confusing - kill it. 
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
 2014-05-09 22:28:44 +02:00
Thomas Arnhold
569ff6727e update_pch: add a bunch of pch files 
I had to fix some source files because of macro redefinitions and such stuff.

Small modules like basic have a great win, too:

make basic.clean && time make basic:

                with    w/o
                 pch    pch
accessibility    23s  1m59s
basctl           30s  1m42s
basic            56s  1m35s
comphelper       23s    51s
editeng          48s  2m04s
forms            40s  1m40s
unotools         19s    38s
sd             3m37s  4m33s

Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f
Reviewed-on: https://gerrit.libreoffice.org/9293
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-09 19:50:42 +00:00
Caolán McNamara
13c01aac25 coverity#1209811 Dereference before null check 
Change-Id: I7e3778e5203438bc5db942c813a03896d7df895b
 2014-05-09 09:43:15 +01:00
Caolán McNamara
148b9a23fa coverity#1209554 Explicit null dereferenced 
Change-Id: Iacf4373221b93a97e030b09501cc91589f2fdff7
 2014-05-07 15:47:24 +01:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false" 
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
 2014-05-05 12:47:48 +02:00
Noel Grandin
883481fd20 Improve TabBar return types 
DeactivatePage() goes from returning long to returning bool.
StartRenaming goes from returning long to returning bool.
AllowRenaming goes from returning long to returning a
constant from a new enum.

Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca
Reviewed-on: https://gerrit.libreoffice.org/9161
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-04-28 11:37:37 +00:00
Caolán McNamara
0eb160ef13 coverity#736993 Uncaught exception 
Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
 2014-04-25 20:19:11 +01:00
Caolán McNamara
7f49f4227b coverity#736992 Uncaught exception 
Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
 2014-04-25 20:19:11 +01:00
Caolán McNamara
2d4c90e82e coverity#736990 Uncaught exception 
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
 2014-04-25 20:19:11 +01:00
Thomas Arnhold
71e028f29c basic macro dialog: let it expand vertically, too 
it already expands horizontally, however hexpand is not set...

Change-Id: I8e0bfb9dfc841c66eeb2d14f5f73a997b6862cb5
 2014-04-24 22:00:15 +02:00
Thomas Arnhold
4996fad625 fdo#77886: add language: expand list if dialog gets resized 
Yes, I actually figured out how to do that ;)

Change-Id: I9c62f57bbd07f44c9bf94a308a49df8c82eb2097
 2014-04-24 14:43:44 +02:00
Thomas Arnhold
83397d7cd2 manage breakpoints: expand list if dialog gets resized 
Change-Id: I818a19a0a95991c97be539761d1f75e247880256
 2014-04-24 14:43:43 +02:00
Thomas Arnhold
702f9c5176 huge hrc and src file cleanup 
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
 2014-04-23 22:49:57 +00:00
Thomas Arnhold
5973c2d34a fixincludeguards.sh: basctl 2014-04-19 11:10:07 +02:00
Jan Holesovsky
29d5ce2d88 sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too. 
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
 2014-04-18 22:51:06 +02:00
Jan Holesovsky
b731d71c67 sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE. 
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is
several methods defined at once, and only the last one has a body.

This is extremely confusing and hard to read; let's kill that nonsense.

Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
 2014-04-18 22:51:06 +02:00
Jan Holesovsky
8c3ab6093a sfx2: Kill SFX_STATUSBAR_REGISTRATION macro. 
Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
 2014-04-18 22:51:06 +02:00
Jan Holesovsky
72d8c94dfa sfx2: Kill SFX_FEATURED_CHILDWINDOW_REGISTRATION macro. 
Change-Id: I9bf1c2404eeb6c59525061157e91b8777f2da540
 2014-04-18 22:51:05 +02:00
Jan Holesovsky
f4d61eca61 sfx2: Kill SFX_CHILDWINDOW_REGISTRATION macro. 
Change-Id: Icd56e0cee1ce0283e8a1cbaafc81ecca25469185
 2014-04-18 22:51:04 +02:00
Jan Holesovsky
9f83ea4bc6 sfx2: Kill SFX_POPUPMENU_REGISTRATION macro. 
Change-Id: Ie68ccbe5874ec7c7e1bb73cb2937e06bb4910cd0
 2014-04-18 22:49:27 +02:00
Eike Rathke
5e91217c6a no temporary instance of SvtLanguageTable necessary here 
Change-Id: I3172e4d174a7f632a4259bd7330b41d3f065daed
 2014-04-17 23:15:02 +02:00
Eike Rathke
0424163d03 no temporary instance of SvtLanguageTable necessary here 
Change-Id: Iabb3aadf35eb6b3575d916f2400f606264572537
 2014-04-17 23:15:02 +02:00
Noel Grandin
23dc4e1a00 basctl: sal_Bool->bool 
Change-Id: I85e1e94557a238f629151d9ce46a502efed3696d
 2014-04-15 15:23:28 +02:00
Caolán McNamara
380d4600d7 use TriState instead of sal_Bool as there's three possibilities 
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
 2014-04-08 09:18:33 +01:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
6ef2df7b9b Remove remaining DBG_NAME* uses 
...that had been used for DBG_CTOR, DBG_PROF, etc.

Change-Id: I8eac38e24b7110511feb7813aaf5a20ab82bdbe0
 2014-03-28 17:26:09 +01:00
Stephan Bergmann
1714f4d3e8 Remove remaining DBG_CTOR etc. remnants from basctl 
Change-Id: I383021580f69ac51ca65f3464bf863b800ccd931
 2014-03-28 15:02:18 +01:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Stephan Bergmann
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE 
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
 2014-03-26 11:54:55 +01:00
Noel Grandin
436cd90095 svtools: sal_Bool->bool 
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
 2014-03-25 14:32:56 +02:00
Noel Grandin
9278df2c21 sfx2: sal_Bool->bool 
Change-Id: I73acb3a150b01114d32274a6842f6db9654b3e63
 2014-03-19 09:21:24 +02:00