mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
9263b101c39172cbcf04189c515bca80cb15f3aa
Commit Graph

2154 Commits

Author SHA1 Message Date
Caolán McNamara
8c5f5aab2e convert export basic dialog to .ui (600th .ui conversion) 
Change-Id: I67511e69f763761cd1631263fccd0704daf1886b
 2013-12-31 21:34:07 +00:00
Caolán McNamara
79c1b86e20 MessageDialog isn't ready for this usage just yet 
Change-Id: If6c886ac4115dd0a030660fd0147491815fa411a
 2013-12-31 21:34:06 +00:00
Caolán McNamara
40c6f8362c convert new lib dialog to .ui 
and a drive-by on some no .src InfoBox and ErrorBoxes to MessageDialog

Change-Id: Ideb58a0042ed45a49bff9b336622dfe11bb363ab
 2013-12-31 21:11:46 +00:00
Caolán McNamara
978172bb00 don't access beyond end of empty string 
Change-Id: Ie772d7a60fd65b93ca66c543eb2786ce7f109004
 2013-12-31 20:49:12 +00:00
Caolán McNamara
ec6050497a convert goto line dialog to .ui 
Change-Id: I4c4ec4f2169d001e6f09c9c7bb06a4b0b327a2f8
 2013-12-31 20:28:16 +00:00
Julien Nabet
203fbb1605 cppcheck: fix var reassigned 
Change-Id: I9db36a231ea846929f8860d089d77d0126242c26
 2013-12-27 15:02:32 +01:00
Caolán McNamara
2544a2a810 convert organize macros dialog to .ui 
Change-Id: I210ab0bb294ddfefc3f60cffe64b72e5d8fa4650
 2013-12-24 09:49:40 +00:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
075a0b30c8 No need for DlgEdObj::supportsService to be virtual 
Change-Id: Ib324adb4bc894f16c051fe956c25e37b0502006c
 2013-12-18 14:14:53 +01:00
Norbert Thiebaud
4c539fac01 vcl get rid of xub_StrLen and STRING_LEN in outdev3 
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)

Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2013-12-18 01:54:16 +00:00
Stephan Bergmann
07ab0d43b5 Get rid of DECLARE_STL_VECTOR 
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
 2013-12-06 08:04:23 +01:00
Stephan Bergmann
0c55303581 Get rid of DECLARE_STL_STDKEY_SET 
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
 2013-12-05 18:36:21 +01:00
Stephan Bergmann
0ee2cddfbd Properly encapsulate svt::TextWindowPeer 
Change-Id: Iffa67c345a03852ad7872031b4c5a87e223ffcad
 2013-11-27 11:35:24 +01:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Norbert Thiebaud
cde4fdb2d0 basctl: include <> for external includes 
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
 2013-11-11 22:37:25 -06:00
Ivan Timofeev
560b276136 fdo#71306: fix printing from basic ide 
regression from e13a3d566e

Change-Id: I0d734e112038746aa48df669d4b82b644a95c220
 2013-11-08 13:02:21 +04:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression 
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
 2013-11-04 10:11:08 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Stephan Bergmann
176ac1e616 Remove unnecessary SyntaxHighlighter::Tokenizer statefulness 
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it.

Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
c99267b326 Fold SyntaxHighlighter::initialize into ctor 
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused.

Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
6aa24e7565 Move implementation details to syntaxhighlight.cxx 
(and clean up a little)

Change-Id: I6e660708d8ca1509b89b306cd428dc38c8b03f2c
 2013-10-28 13:48:14 +01:00
Stephan Bergmann
f5e8be8bb1 Remove unused SimpleTokenizer_Impl::nLine/nCol 
...which are never read; remove thereby unused parameters from functions.

Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
 2013-10-28 13:48:13 +01:00
Marcos Paulo de Souza
704f95e525 fdo#54938: More uses of cppu::supportsService 
Change-Id: I90a7a07a43559b8d7e1d4b886b2624255200d46b
Reviewed-on: https://gerrit.libreoffice.org/6406
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-25 08:19:58 +00:00
Noel Grandin
7a06928bcf convert code to use OUString::endsWith 
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
 2013-10-23 08:29:15 +02:00
Stephan Bergmann
93e652d1fa HighlightPortion's indizes into strings should be sal_Int32 
(Had to fix type of some variables holding TextPaM::GetIndex() values from
sal_uLong to sal_uInt16 to avoid -Werror,-Wsign-compare failures when comparing
those against HightlightPortion's nEnd.)

Change-Id: Ia8a0ba682ae28e86e394ee48adff3225eb8de053
 2013-10-22 18:19:18 +02:00
Stephan Bergmann
9932749854 Use conventional std::vector idioms 
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
 2013-10-22 18:19:18 +02:00
Stephan Bergmann
b7f20ef33f Unwind HighlightPortions typedef 
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
 2013-10-22 18:19:18 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Thomas Arnhold
67aec43915 cleanup 
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
 2013-10-16 05:41:26 +02:00
Tor Lillqvist
81f94edc63 What (who?) are OW and MTF? 
Change-Id: I47b9b91d72e423c0ef37eaa9f081e755adfc36d6
 2013-10-12 09:34:51 +03:00
Tor Lillqvist
5705102c02 Test WNT instead of the vague UNX 
Change-Id: I99aa82d29d056afde92d258fd5cdf13359f9b74c
 2013-10-12 09:30:34 +03:00
Jan Holesovsky
be19400649 Basic: When we warned & stopped the program, don't warn again. 
It's extremely annoying to have to dismiss the warning with every keypress ;-)

Change-Id: Ie117085ef25676065aedd0744cf618e1b566688b
 2013-10-11 16:58:54 +02:00
Stephan Bergmann
383ad54a25 -Werror,-Wunused-variable 
Change-Id: Iac999c157d0d3fdb737bd2d92240e252cfb05333
 2013-10-11 11:21:33 +02:00
Jan Holesovsky
ec3a4bfbf5 Fix whitespace. 
Change-Id: I76acfa77eea862a1562521eea5160ed054f68650
 2013-10-11 08:52:13 +02:00
Caolán McNamara
8bf74a9e51 CID#738562 uninitialized member 
Change-Id: I65f64b1604c9c0aa3538d6e9384014fd44e16c0b
 2013-10-07 09:16:23 +01:00
Caolán McNamara
78d47adbf2 CID#738561 uninitialized member 
Change-Id: Icac2ca781f067975746d4b861fcbd60e6577b64e
 2013-10-07 09:16:23 +01:00
Caolán McNamara
2b5caba5d8 CID#738560 uninitialized member 
Change-Id: I270455041b73450e6ed1fc5a05e68c88db4310ab
 2013-10-07 09:16:23 +01:00
Caolán McNamara
c4597f281e CID#984418 unused returned pointer 
Change-Id: I92864b2491882e0553b87d9d87d126ec30ef3974
 2013-10-07 09:16:22 +01:00
Caolán McNamara
ea8d6dd3db CID#984417 unused returned pointer 
Change-Id: I638d7d89b7c1414aac34bcf1c92fdde8eee98e2a
 2013-10-07 09:16:22 +01:00
Caolán McNamara
61d05a58fb CID#738954 unused returned pointer 
Change-Id: Ieb47b91dd745db400c7ad4756167de758a625a64
 2013-10-07 09:16:22 +01:00
Caolán McNamara
717f214e66 CID#738559 uninitialized member 
Change-Id: I68d9c84dbaa1a9a8d60d572027fcbc1d8c481e8e
 2013-10-03 13:24:07 +01:00
Caolán McNamara
df3cc933d3 CID#738558 uninitialized members 
Change-Id: I159693ff794482c772186947fa6ce5cb9aa71ad6
 2013-10-03 13:20:06 +01:00
Stephan Bergmann
8f6f93adfe -Werror,-Wdeprecated-declarations 
Change-Id: I22101fec4b75e567153c6401ab754e1a5e158a77
 2013-10-02 16:49:37 +02:00
Noel Grandin
9a5997374f convert basctl module from String to OUString 
Change-Id: Iac38d4fd5d1d8b5c305bbb20eb1b40a7c7dec9bf
 2013-10-01 10:08:40 +02:00
Caolán McNamara
81202ae748 Related: fdo#38838 remove UniString::CompareIgnoreCaseToAscii 
Change-Id: I4a9b34d63d2534a35aa9a878b8c2bec15262c2be
 2013-09-22 20:32:02 +01:00
Noel Grandin
6f2adb1a04 convert basctl/source/inc/basobj.hxx from String to OUString 
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
 2013-09-17 09:06:16 +02:00
Noel Power
751e238c78 fix for fdo#69173 crasher 
the layout changes for the basic IDE ( for the object browser and object
catalog ) seem flacky, I have seen since those changes have been introduced
some strange ( but random ) behaviour ( like the odd unrepeatable core ( maybe
related to this ) and also sometimes Modules appearing in the tree under the
wrong nodes etc. I'm no expert in the basic IDE code but this patch seems to
fix the problem.
However there is one drawback, in the core inducing scenario the tree view
( object catalog ) dissappears, this is because the patch suppresses the
problematic layout in this case ( as the layout seem not to be currently able
to deal with 'no-existent' (recently) deleted current window )
Probably in this scenario a fallback currentwin (instead of nil) could be set
this would behave better but ideally. Ultimately the layout class should
probably be modified ( possibly redesigned )

Change-Id: I9d1e23bd6fc4aae32aa78da8278c318f7051136a
 2013-09-13 10:10:19 +01:00
Tor Lillqvist
cbfe56c3bc WaE: C4101: 'ex' : unreferenced local variable 
Change-Id: I804bafb4057e1bb409b7f30d79554f2773cb3967
 2013-09-03 15:46:47 +03:00