Noel Grandin
96710f8e46
convert OUString::match to OUString::endsWith
...
Convert code like:
rTxt.match( "---", rTxt.getLength()-3 )
to:
rTxt.endsWith( "---" )
Change-Id: Iada74c5e714f7234f25b326526843a36255d5599
2014-03-19 08:55:21 +02:00
Noel Grandin
39c7532933
basic: prefer passing OUString and OString by reference
...
Change-Id: I8121204cdb37d4e1d8967397f3e45bdab6aaddad
2014-03-13 08:39:26 +02:00
Stephan Bergmann
90dcd2ac13
basic: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: I7f0d75c5eaa62f012cb2ae19c5107c09cbc6936a
2014-03-10 17:39:52 +01:00
Stephan Bergmann
25cedf1dc7
Introduce com.sun.star.beans.theIntrospection singleton
...
...deprecating com.sun.star.beans.Introspection (single-instance) service.
Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
2014-03-07 10:33:07 +01:00
Noel Grandin
f6d97d00cd
remove unused code in basic/CodeCompleteDataCache
...
Specifically:
CodeCompleteDataCache::GetVars() const
CodeCompleteDataCache::SetVars(boost::unordered_map const&)
CodeCompleteDataCache::print() const
Change-Id: I59fb6f50ff47747c3cac959302bf6b7c4f4d79d3
2014-02-28 08:33:14 +02:00
Stephan Bergmann
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
6a38eace8c
Remove visual noise from basic
...
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:09:17 +00:00
Norbert Thiebaud
295bc8703f
basic: remove use of sal_uIntptr in favor of more appropriate type
...
Change-Id: Ie878f43c7245838519fe7477b039827b079dde63
Reviewed-on: https://gerrit.libreoffice.org/8214
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-25 00:26:43 +00:00
Matteo Casalin
83aa6d8180
Remove some temporaries around calls to SvNumberFormatter methods
...
Change-Id: Ib03c97a52df120bac1ac9b2b9d2e52431ead1027
2014-02-24 09:08:35 +01:00
Alexander Wilms
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Tobias Lippert
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Stephan Bergmann
12f1faf7bf
svl: sal_Bool -> bool
...
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
Noel Grandin
b2878af322
more SvStream:operator>> conversion
...
Convert the template based read_lenPrefixed methods to regular
methods.
Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:32:11 +00:00
Noel Grandin
15535e32dd
convert SvStream::operator>> methods to ReadXXX methods
...
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
Markus Mohrhard
70b3006002
fix crash when importing unsupported macro content, related fdo#59374
...
Change-Id: I960c8174454074fd9ddb27fb17244d782c4cb24c
2014-02-12 01:01:35 +01:00
Stephan Bergmann
bd20500cf3
Simplify access to theCoreReflection singleton
...
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
2014-02-07 12:03:03 +01:00
Andras Timar
ac6e8ac7e4
typo fixes in comments
...
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
Julien Nabet
527eb5ae5c
Typo: applictaion -> application
...
Change-Id: I2d578cb417bb1e814dcf3007f500fe8ff77510f7
2014-02-06 21:51:36 +01:00
Michael Stahl
6c820a2816
basic: _FIND_STATIC likely not an error in SbiExprNode::GenElement()
...
All other _FIND_* are explicitly not errors, and probably CWS npower10
forgot to adapt this assertion.
Change-Id: If721c275eb1bc31d76140898602b41e11c23d82e
Reviewed-on: https://gerrit.libreoffice.org/7863
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2014-02-05 10:16:09 +00:00
Herbert Dürr
a5090ccf75
Related: #i123862# use O*String's isEmpty() method...
...
to check for emptiness in modules starting with 'b'
Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 87204b0f4062ef8fc8f138ad15f4378da609d4e2)
Conflicts:
basctl/source/basicide/baside2.cxx
basctl/source/basicide/bastype2.cxx
basctl/source/basicide/localizationmgr.cxx
basctl/source/dlged/dlgedobj.cxx
basic/source/basmgr/basmgr.cxx
basic/source/basmgr/vbahelper.cxx
basic/source/classes/sbunoobj.cxx
basic/source/comp/sbcomp.cxx
basic/source/runtime/iosys.cxx
basic/source/runtime/methods.cxx
basic/source/runtime/methods1.cxx
basic/source/runtime/step2.cxx
basic/source/uno/namecont.cxx
basic/source/uno/scriptcont.cxx
binaryurp/source/bridge.cxx
binaryurp/source/bridgefactory.cxx
binaryurp/source/reader.cxx
binaryurp/source/unmarshal.cxx
bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
bridges/source/cpp_uno/shared/vtablefactory.cxx
bridges/source/jni_uno/jni_data.cxx
Change-Id: I37bd84e0a1d6426759dba81854faf32c88147fe1
2014-02-04 12:47:59 +00:00
Thomas Arnhold
326bec33e0
some more continuous corrections
2014-02-03 14:01:40 +01:00
Alexandre Vicenzi
25d089e09d
fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter.
...
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab
Reviewed-on: https://gerrit.libreoffice.org/7731
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30 10:48:40 +00:00
Stephan Bergmann
f96f38f8f8
bool improvements
...
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
2014-01-28 20:26:30 +01:00
Caolán McNamara
5c734f440a
coverity#738565 Uninitialized scalar field
...
Change-Id: Ie969773240bd7ecdcf56d7c533010d0aa32872c8
2014-01-28 11:29:15 +00:00
Caolán McNamara
8cccfb8f8f
coverity#441077 Dereference after null check
...
Change-Id: Ia6a04846068e0bc500942e9a2dc6ee2e72d9d527
2014-01-27 14:38:39 +00:00
Caolán McNamara
4e8692a3bf
coverity#984078 Uninitialized scalar field
...
Change-Id: I36b4a8c7d047f392fdbbe167a0e801b9a6d80b03
2014-01-27 14:38:38 +00:00
Caolán McNamara
3848819cac
coverity#707652 Uninitialized scalar field
...
Change-Id: I6d561955454b0619255296704812b41a10ffe962
2014-01-27 14:38:38 +00:00
Caolán McNamara
fd7dbe5a15
coverity#707651 Uninitialized scalar field
...
Change-Id: I6e497d60e72efd1df6c271ce6bf8d5e46ba09ea7
2014-01-27 14:38:38 +00:00
Caolán McNamara
81926e66d1
coverity#707650 Uninitialized pointer field
...
Change-Id: I6843ce28f3e1395a2ab3c5515f393cce5096674b
2014-01-27 14:38:38 +00:00
Caolán McNamara
7acea5ae4c
coverity#707649 Uninitialized scalar field
...
Change-Id: I1a95a051463860dc9c7b087bfaf17f3b70f297ee
2014-01-27 14:38:37 +00:00
Caolán McNamara
a8d7c510b4
coverity#707629 Uninitialized scalar field
...
Change-Id: I0e3d9d4dad46e9b88be11cc9ac2c7d3c0c4b6f6e
2014-01-27 14:38:37 +00:00
Caolán McNamara
7593b006df
coverity#736909 Allocation too small for type
...
Change-Id: I330ebdfd94d0c30b40e180e307d7543c09fd334b
2014-01-24 15:27:57 +00:00
Caolán McNamara
28793abda5
coverity#736908 Allocation too small for type
...
Change-Id: Ic41c5071957f5e95322971f8ec3ef864edecdb20
2014-01-24 15:26:47 +00:00
Caolán McNamara
fcf23e8a44
coverity#706117 Allocation too small for type
...
Change-Id: I1bb2bd26e533cf5b7de5225f0bcf323446e69f63
2014-01-24 15:22:55 +00:00
Noel Grandin
16a2e90335
remove SvStream::operator<< methods
...
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
Noel Grandin
d803483f6a
convert more SvStream::operator<< calls
...
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.
Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:39 +00:00
Julien Nabet
4eda1a0293
Add some unit-tests for Mid vb function (includes fdo#73771)
...
Change-Id: Ib5ee18207897cbe16a818096769cdb055dc9dad7
Reviewed-on: https://gerrit.libreoffice.org/7583
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2014-01-22 13:56:51 +00:00
Stephan Bergmann
6cccf0f388
bool improvements
...
Change-Id: I64288207adb083e006b4acc5e7f26d647236a443
2014-01-21 18:24:03 +01:00
Julien Nabet
ff48f28f71
Resolves: fdo#73771 Non-standard behaviour for Function Mid
...
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2
Reviewed-on: https://gerrit.libreoffice.org/7539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 15:50:51 +00:00
Markus Mohrhard
5f893db57d
how should I fix this memory leak??
2014-01-19 18:28:39 +01:00
Markus Mohrhard
d3b60aa648
CID#706118: possibly invalid cast
2014-01-19 18:15:49 +01:00
Stephan Bergmann
1b33a38e32
Whatever those "true" arguments to SotStorage ctor may once have meant
...
...is lost to history, but they are effectively equivalent to pssing default
SorageMode nStorageMode = 0 today, as the only thing that is done with that
nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx)
is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED
(0x44).
Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
2014-01-17 18:45:13 +01:00
Andras Timar
99159a618f
fdo#73698 check for empty aOut
...
Change-Id: I0da26ef746553618bd8aee69f21ff0d1261efbf6
Reviewed-on: https://gerrit.libreoffice.org/7474
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-01-17 06:09:55 +00:00
Andras Timar
da67f5b162
Environment variables can contain >127 characters
...
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a
2014-01-16 17:00:32 +01:00
Noel Grandin
c648d08720
convert SvStream::operator<< overloads to more explicit methods
...
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
Stephan Bergmann
0d29aab156
bool improvements
...
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
2014-01-14 18:11:10 +01:00
Noel Grandin
b69864f3f8
re-write SvStream operator<< to non-overloaded methods
...
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:24 +00:00
Herbert Dürr
9e77ddcd19
Resolves: #i123817# prepare codebase for updating to boost 1.55
...
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)
Conflicts:
basic/source/comp/parser.cxx
basic/source/comp/token.cxx
dbaccess/source/ui/dlg/generalpage.cxx
sc/source/ui/unoobj/chart2uno.cxx
vcl/quartz/salbmp.cxx
Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
2014-01-06 16:32:20 +00:00
Andras Timar
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Stephan Bergmann
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00