Thomas Arnhold
ee1de94276
typo: persistance -> persistence
2014-03-29 19:16:18 +01:00
Thomas Arnhold
7d3b9d3333
typo: optimisation -> optimization
2014-03-29 19:16:18 +01:00
Thomas Arnhold
8bb09efc92
typo: approriate -> appropriate
2014-03-29 19:16:17 +01:00
Takeshi Abe
ee6895c61f
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: I3d26325995995f658cd6adcc80e0716cfcee7de0
2014-03-27 23:25:20 +09:00
Stephan Bergmann
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Stephan Bergmann
98666e8625
No need for a virtual OPropertyContainer::getTypes
...
(and rename to getBaseTypes for clarity)
Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
Stephan Bergmann
36784563ed
OAccessibleContextWrapperHelper does not implement XAccessibleContext
...
...but rather some (non-virtual) base functionality for use in derived classes
(that do implement XAccessibleContext)
Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
2014-03-14 14:29:24 +01:00
Stephan Bergmann
9b7f17dd30
Fix races in AsyncEventNotifier::execute
...
* m_aDeadProcessors was useless; for one, removeEventsForProcessor could never
have run (and set m_aDeadProcessors) between execute's reading from aEvents
and checking m_aDeadProcessors (because of the use of aMutex in both
functions), and if that were addressed, there would always be a race that
execute would run a processor that has just been removed. Clients have to be
aware that a call to removeEventsForProcessor is just an optimization hint,
but does not guarantee that the given processor is not called from the execute
thread after removeEventsForProcessor returns.
* The sequence
aGuard.clear(); aPendingActions.reset(); aPanedingActions.wait();
could cause calls to aPendingActions.set() to get lost, both for signalling
new content in the queue and for signalling termination.
Change-Id: I43293e3d5090c2d46db8bc8ed6fb9c71e049d55c
2014-03-14 12:20:42 +01:00
Noel Grandin
358be80f65
comphelper,connectivity: prefer passing OUString by reference
...
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
Stephan Bergmann
22684273d5
forward*PropertyValue functions need not be SAL_CALL
...
...and _bSuccess parameter is unused
Change-Id: Iee5e1d5c2d4272f342b2867bfe76f8c87dcd69d4
2014-03-13 14:00:03 +01:00
Stephan Bergmann
61c44a9929
comphelper::OIHWrapNoFilterDialog does not implement XInitialization
...
Change-Id: Idce153607c3deb3f0a1809b9d18cbcc6f30cf04d
2014-03-13 12:50:12 +01:00
Stephan Bergmann
e3e1f9f30d
Leftover SAL_CALL
...
Change-Id: I895b2132ee752f191f30d6adc0af35cad005afe5
2014-03-11 14:54:30 +01:00
Stephan Bergmann
ff19246a81
OPropertyStateHelper::getTypes isn't an override of XTypeProvider::getTypes
...
Change-Id: I633c711aabbd2ec7d1385d106b512f14672393f1
2014-03-11 13:03:20 +01:00
Stephan Bergmann
2726f2a785
comphelper: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: I8da24ffd5eb1ac1fe6a6d2312ddc4ab13828bf07
2014-03-10 17:39:53 +01:00
Stephan Bergmann
25cedf1dc7
Introduce com.sun.star.beans.theIntrospection singleton
...
...deprecating com.sun.star.beans.Introspection (single-instance) service.
Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
2014-03-07 10:33:07 +01:00
Stephan Bergmann
7211162081
Clean up uses of rtl_ustr_ascii_shortenedCompareIgnoreAsciiCase_WithLength
...
Change-Id: Ie37614dac882bfe05f8ce595ae6b20326dce872e
2014-03-01 19:28:14 +01:00
Caolán McNamara
ec9e5a0f5d
coverity#1187647 try and help coverity out here
...
Change-Id: I94a0dad8113b8b6ac06ddf5456ff8c35d7c64fc1
2014-02-27 12:58:51 +00:00
Caolán McNamara
697ec96e61
coverity#1187646 unused mpAbort
...
Change-Id: I1fc3f0253c2af4779ba59b5b85ea7fc400226177
2014-02-27 12:58:50 +00:00
Alexander Wilms
a67c2a12bc
Remove visual noise from comphelper
...
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89
Reviewed-on: https://gerrit.libreoffice.org/8242
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:42:45 -06:00
Stephan Bergmann
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Caolán McNamara
6fbe00f9b6
coverity#983702 Uncaught exception
...
Change-Id: I3a0b4c8fe4208d0945860f6b4e1b31852aef8502
2014-02-25 16:12:23 +00:00
Jacobo Aragunde Pérez
c69ae9f8f8
comphelper: EmbeddedObjectContainer::GetObjectStream methods
...
These methods were added to provide access to the stream to the
embedded object itself.
Change-Id: I0a47a54852cddbd5ddd0a6599bba21999afd96ba
2014-02-24 13:24:52 +01:00
Jacobo Aragunde Pérez
20a174ac12
comphelper: code refactor
...
Change-Id: Ica71d0691cf02aeaa03b6570015d9828cd7daeed
2014-02-24 13:24:51 +01:00
Alexander Wilms
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
d12e472474
comphelper: sal_Bool -> bool sequel
...
Change-Id: I2b9bd19abf4510fccef0374a539069cb8222ccae
2014-02-19 14:31:09 +01:00
Stephan Bergmann
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
Stephan Bergmann
faced6b5f7
ucbhelper: sal_Bool -> bool
...
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-17 17:55:18 +01:00
Stephan Bergmann
f45183d26f
Unwind comphelper::OPropertyContainer_Base typedef
...
Change-Id: Ied87e18f8297fb8e85fdbcab38d719664e3ed066
2014-02-12 12:03:28 +01:00
Caolán McNamara
3ec9bccaab
silence coverity#1027865 Out-of-bounds access
...
and coverity#1027864
Change-Id: Ic3d1b91ef77ab3510c7428b7135dd9f249d56b4b
2014-02-07 09:03:48 +00:00
Andras Timar
ac6e8ac7e4
typo fixes in comments
...
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
Alexandre Vicenzi
e17cf91032
fdo#54938 Convert comphelper and vcl to cppu::supportsService
...
Change-Id: I391a7324bf92208fe632dac17874943343b1f65a
Reviewed-on: https://gerrit.libreoffice.org/7757
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-05 14:29:57 +00:00
Stephan Bergmann
d98d2ad0cb
Remove needless SAL_DLLPRIVATE annotations
...
Change-Id: Ib8d1eae0dce29756da626c73db75f59666bb0ea5
2014-02-03 16:05:10 +01:00
Stephan Bergmann
9e77c2fb7c
Remove UNOIDL "array" and "union" vaporware remnants
...
...and deprecate what cannot be removed for compatibility.
Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
Caolán McNamara
9bd0e895a4
coverity#1079000 Uncaught exception
...
Change-Id: I7ffee42abe03c34d68b6168328143666d72e7efc
2014-01-29 16:41:32 +00:00
Stephan Bergmann
1b574435a5
bool improvements
...
Change-Id: I17c451d33d6d5e4edf0304ff47d63ac878d7e5d9
2014-01-28 20:24:39 +01:00
Caolán McNamara
7cc3e9ca0c
coverity#706277 Uncaught exception
...
Change-Id: I1941e0a3a662faaac1fb9374437f3984b3a5c6d8
2014-01-27 17:03:04 +00:00
Caolán McNamara
0535281003
coverity#707679 Uninitialized scalar field
...
Change-Id: I41c98456506a3ef843362b20c4db4a8d409319d6
2014-01-27 15:23:17 +00:00
Caolán McNamara
7677c52ae1
coverity#705787 Dereference before null check
...
Change-Id: I4d6e4ddaa104a025349c55ab75263004a6b2b6bf
2014-01-27 15:23:17 +00:00
Norbert Thiebaud
8df4ce0ebe
coverity#1130481 : Uninitialized scalar field
...
Change-Id: I41025a3dfe16af9417b1ae8c7668c76cb501c7b9
2014-01-26 22:40:27 -06:00
Stephan Bergmann
930202b0b2
Maybe this bool clean-up avoids false -Werror=maybe-uninitialized on Android
...
Change-Id: Iab12cc703d190e79650f73c646a2fbb60c6685c5
2014-01-22 15:03:23 +01:00
Eike Rathke
db6f8f9f89
fdo#73549 do not resolve empty locale here if not determined yet
...
Change-Id: Iad03d6209a2b4024b27c6195195e5aa557c295fe
2014-01-19 15:04:08 +01:00
Noel Grandin
82625bb98e
remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
...
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
Andras Timar
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Stephan Bergmann
962d4b35bd
css.logging.SimpleLogRing.create() calls initialize w/ empty Arguments
...
Change-Id: Iffcab3831b40ce309aa20fdb825328ebb4dd1064
2013-12-19 20:52:25 +01:00
Stephan Bergmann
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
Stephan Bergmann
ab9e014d6f
Some clean-up
...
Change-Id: I8ea3018efb01069b9a0555d9ac4ddfa89a990ba8
2013-12-12 15:10:35 +01:00
Stephan Bergmann
3f3c755475
Remove newly unused comphelper/TypeGeneration.hxx
...
Change-Id: Ia63e07fa6f56f4797e2741f6800cb96559ff4928
2013-12-12 15:10:35 +01:00
Stephan Bergmann
45c0a6174d
Simplify comphelper::PropertyInfo
...
...as its sole two uses (in sw) are already fine with initializing arrays of
it dynamically, there is no harm in changing it and thereby getting rid of the
last use of comphelper/TypeGeneration.hxx.
Change-Id: I11931dbbec48dac5a694a59cf6425206c806fbfb
2013-12-12 15:10:35 +01:00
Stephan Bergmann
83e191e25d
Do not use C++-UNO internal static_type functions in client code
...
...use cppu::UnoType instead.
Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
Stephan Bergmann
a62c2a5fa5
Don't hold css::uno::Type instances by pointer
...
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it. Plus some const clean-up.
Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-12 08:26:40 +01:00