188 Commits

Author SHA1 Message Date
Luboš Luňák
ade47d3d67 make it easy to get a parent of an AST node
Clang API doesn't provide this, but it's occasionally needed, and so far
the way has been inspecting the highest possible node in AST and walking down
and remembering, which is complicated, error-prone and annoying.

Change-Id: Id5b72cb5ebfc069e90efe6d673c0ef18ebcdab61
2013-06-20 07:21:31 +02:00
Luboš Luňák
50d248aa3f work around the C++11 __float128 problem with libstdc++ headers and clang
Change-Id: Ia1b443d22b3b7f6f93f1ad8c5fa760b0f1da3b83
2013-06-13 20:08:16 +02:00
Stephan Bergmann
89d47f818a Ignore warnings in Clang headers
(as occur at least in trunk Clang builds)

Change-Id: I7e74200ae1042133fa04477e39e46fd2f01cc1b0
2013-06-05 23:37:14 +02:00
Stephan Bergmann
3d963884cb Adapt UPDATE_FILES=<module> to headers being moved to include/
Change-Id: I6af5236358a51a51514d646c809147db56b2464b
2013-06-05 23:32:16 +02:00
Luboš Luňák
0df04e0331 fix plugin build with clang < 3.3
Change-Id: If2eb7595ca7d25f6d491e332bb3060061d3b42a7
2013-06-02 16:33:25 +02:00
Luboš Luňák
6d114cda2c make compiler plugin warnings follow WaE
Change-Id: I72f1a11ce86d66e773e66116c725310df77fce39
2013-05-31 20:00:54 +02:00
Luboš Luňák
c4cca49f49 obey --enable-werror when building clang plugin
Change-Id: I8ca9b09a6ffd4b2f00740563fa9682fdabb26b3d
2013-05-31 20:00:54 +02:00
Luboš Luňák
6b1f64ed09 reoder stuff in makefile
At the top should be stuff to set manually if needed.

Change-Id: I516ac6df8102f00f6fc34c4c87d040688fcc2e99
2013-05-31 20:00:54 +02:00
Luboš Luňák
b0a650ff8a update for PPCallbacks API changes in Clang3.3
Change-Id: I8493afa8e2264a42fba090c9c72f36f36cb2d165
2013-05-31 20:00:54 +02:00
Luboš Luňák
a0d320096c mark all virtuals in the clang plugin as override
In order to help catch Clang API changes.

Change-Id: I5738f5dff405f7a2dd377c983fb32c1c7a2ff921
2013-05-31 20:00:53 +02:00
Noel Grandin
6a043e9c0a Use the new type-checking Reference constructor to reduce code noise
Also create a Clang compiler plugin to detect such cases.

Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-05-22 10:44:29 +00:00
Luboš Luňák
9cb21a3342 check for double modifications in compiler plugins
A different way to do 1c0669af2f1f58e6431b5e489ac48a883e242ba7.
Sometimes one piece of code can be represented several times in the AST,
e.g. with default function arguments.

Change-Id: Ic7799fa0bd918a638bdc8ebef69e6aa91d355bdc
2013-05-06 16:51:45 +02:00
Luboš Luňák
d870271c23 compiler plugin for RTL_CONSTASCII_USTRINGPARAM removal
Change-Id: Ibc487aa78d9eba3f936b4f4cc0298adfaef60d5c
2013-05-06 16:51:45 +02:00
Luboš Luňák
d01768c31a Revert "ignore already seen locations in compiler plugins"
This does not always work well, e.g. when building a return value
in a return statement from a temporary, there is CXXConstructExpr
containing CXXTemporaryObjectExpr, which both share the same location.
This reverts commit 1c0669af2f1f58e6431b5e489ac48a883e242ba7.
2013-05-06 16:49:36 +02:00
Luboš Luňák
a0da672521 ignore already seen locations in compiler plugins
Change-Id: Icba8dfa61aee7237af569b2414b1cf4ce93ca476
2013-05-06 16:49:36 +02:00
Luboš Luňák
6f16cfb5a6 Fix handling range in removeText().
Turns out removeText( SourceRange ) treats it as a token range, so it's
not always character-exact if used for removal of only several characters
from a token (e.g. an identifier).

Change-Id: I0223d52da90f9535d9ef1d48b0f56d69131536c8
2013-05-06 16:49:36 +02:00
Luboš Luňák
e6c20364e7 add const
Change-Id: I71236b9ca6300372ba00c85401cf19f6c0e7ac99
2013-05-02 18:19:59 +02:00
Tor Lillqvist
294ad90704 Update location of log-areas.dox
Change-Id: If54a3d7047f13ae9c9345c21737a89afee645403
2013-04-24 11:42:09 +03:00
Luboš Luňák
b8dd396976 base for unusedcode compiler plugin
Needs work to actually do something useful, but the basics are there.

Change-Id: I193922f2f5572760c8c20def0f9b830138f47fef
2013-04-22 17:56:47 +02:00
Luboš Luňák
5f8a2dc398 removeforwardstringdecl clang plugin has been used, move it
Change-Id: I3bccfa773448e17ac3c8ece6b99f85c6d399b0cf
2013-04-07 14:23:12 +02:00
Luboš Luňák
c3ffd741b2 compiler plugin to check incorrect #ifdef for config_XXX.h macros
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html

Change-Id: Ibba9d3dcc87d6d6eee58ab3690a8f87339d00956
2013-04-04 13:05:02 +02:00
Luboš Luňák
996b6fc92b don't explicitly delete PPCallbacks-based compiler plugin actions
If the class is based on PPCallbacks too, Clang internals will delete
the instance.

Change-Id: I6dd83d800e6cca17eb0b5de23c8994f11c087fd5
2013-04-04 13:05:02 +02:00
Peter Foley
43e873b257 silence compilerplugin build
Change-Id: I4397575e4665e8a257d0bd3e15245d996a48a1f4
2013-03-30 13:01:08 -04:00
Luboš Luňák
c63e6c38c9 adjust unused compiler plugins for ASTContext to CompilerInstance change too
Change-Id: I415ed25586408d7e7df9457f7c637a8c6d13d35d
2013-03-28 18:08:05 +01:00
Luboš Luňák
153a69cad2 pass around CompilerInstance rather than ASTContext
It's possible to get the latter from the former, and the former
is useful for other things too (access to the preprocessor, for example).

Change-Id: I708d709129fd3a35bf7c63da4de09c2e696b382d
2013-03-28 18:01:00 +01:00
Luboš Luňák
9ab15ecc4f -Wextra for compiler plugins
Change-Id: I246dcf1d2c099c510435d21f0dd47e3c098456f2
2013-03-28 18:01:00 +01:00
Stephan Bergmann
24387f1c58 A plugin to find suboptimal equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: Id2572982ca899223b89016ee7482ccb960032805
2013-03-19 11:02:28 +01:00
Stephan Bergmann
f9e96c3641 Enable -std=c++11 for compilerplugins/clang
Change-Id: I4849656b16c2a7103217870050b0de3ccb97af56
2013-03-19 11:02:28 +01:00
Tor Lillqvist
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
Marc-André Laverdière
847749e975 Fixed compilation error of Clang plugins on Ubuntu/Mint
Change-Id: Ib08c5075034e0e16c5541f05425ef15d2cc3a6f6
Reviewed-on: https://gerrit.libreoffice.org/2045
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-02-11 10:09:17 +00:00
Luboš Luňák
857a392654 make it possible to limit what files will be modified by a compiler plugin
Change-Id: I4e3e8f5ca5e5b5b59b1bd067281f90940dd893b1
2013-02-09 18:48:31 +01:00
Luboš Luňák
8f1a01ad00 fix check whether a file is in a directory
Make sure / is appended, otherwise /foo might match /foobar/file .

Change-Id: I36469916b72b407c8f0c9c255099ee671039cf17
2013-02-09 18:48:31 +01:00
Luboš Luňák
1b535267df treat all source files as not up to date only with FORCE_COMPILE_ALL
So running the compiler plugin can be done either with FORCE_COMPILE_ALL=1
for simplicity, running the plugin on all source files for the target,
or it's possible to use make's -W option (or touch files manually) to
run it only for selected files.

Change-Id: Ifa82bbe91dc1e179af9db8fbf99271bcf03a1d47
2013-02-09 18:48:31 +01:00
Luboš Luňák
c3de6c1a58 create an output dir that's already needed by $(shell ...)
Otherwise there's an error message e.g. during a clean build.

Change-Id: I42efd08e014a4ebe25cfd1a497f622e5ea5c39ad
2013-02-07 17:05:21 +01:00
Luboš Luňák
5535195c63 make sure the default target for compilerplugins is building
CLANGFORCE was the first in the makefile after
c6ffe17631cccf11fbe00479d2169116d494a7da and therefore the default

Change-Id: Id3b86a1ea2c27479067f7f55a977da3e6e8a2dfb
2013-02-07 17:05:18 +01:00
Luboš Luňák
4fd910a096 tutorial examples for writing new Clang plugin actions
http://wiki.documentfoundation.org/Clang_plugins

Change-Id: Ieb4fc186490e81ab961c094ca0a7fcdabc0f348f
2013-02-02 22:59:46 +01:00
Luboš Luňák
18e615189d a bit more reliable detection of removed/added sources
Change-Id: I7fdde46334c648ab6cba54210e31fada87dcfb55
2013-02-02 22:59:46 +01:00
Luboš Luňák
276953ef21 remove not needed #include
Change-Id: I0fa791733407199db5be2cc9606ac9be1da64188
2013-02-02 22:59:45 +01:00
Luboš Luňák
f5ee30c3ee append [loplugin] automatically in report() rathen than manually everywhere
Change-Id: I2f98622f152ae0c7ac8d1113d6380f686ac7234c
2013-02-02 22:59:45 +01:00
Luboš Luňák
b4392c575e always use the report() helper
Change-Id: I2966fdb5bd98b1ddf718079584acf90a3e3a3700
2013-02-02 22:59:45 +01:00
Luboš Luňák
108a95630d move clang plugin that's no longer needed
But still keep it in case it'd be needed again, or simply
as a starting reference.

Change-Id: If519e1320e1bd6dce7746b57172324b33504051e
2013-02-02 22:59:44 +01:00
Luboš Luňák
a1c61eb112 move documentation of plugins to the .cxx files
It's mostly there already anyway, no need to duplicate it.

Change-Id: I5b066f90725a064fb0746e1411900e835e3f66c3
2013-02-02 22:59:44 +01:00
Luboš Luňák
c6ffe17631 automatically link all .cxx files in clang/ into the plugin
This means that just moving sources to the dir will enable the plugin
action in that source, without modifying any sources, so those changes
would not be accidentally committed when using a rewriter to change
LO sources.

Change-Id: Ic5a9c52dbf1939a1e78ad39ed6691ce3a1f399df
2013-02-02 22:59:44 +01:00
Luboš Luňák
a7c3adb773 avoid having to manuall modify sources when adding a new clang plugin
Now each one registers in its .cxx file.

Change-Id: I811c0d4400c2bdccc1c287269378d7e8ad8743ce
2013-02-02 22:59:44 +01:00
Luboš Luňák
b8f932b6a5 move plugin handling to separate source files
Change-Id: Ifa1af34121bda9ca3250d09a3b8a46ea226795ed
2013-02-02 22:59:44 +01:00
Luboš Luňák
5ceaa68ca5 one more config/ -> config_host/ fix after the rename
Change-Id: I347790e1ca2ee6a27303d3644aa1459ff76ba4b0
2013-02-01 14:23:46 +01:00
Luboš Luňák
9b11db8486 rewriters no longer create .new files, they modify sources directly
Change-Id: I24bce9dcf46367b5658071ed692d346bb01a83a3
2013-01-31 14:48:43 +01:00
Luboš Luňák
03910bdfd9 point to our wiki page on clang rather than clang homepage
Change-Id: Ia54040c7ed02e6a2d62dd93890a7d1467dd83a40
2013-01-11 14:58:58 +01:00
Luboš Luňák
d9a5c6bdf0 fix detection whether to ignore a source file or not
When compiling using icecream, the whole input is one file fed from stdin,
so getBufferName() is "<stdin>", so get the filename from #line directives.

Change-Id: Ie87937b10b0c7e8ddfa57a405b80fd9bde68dd0a
2013-01-11 14:58:58 +01:00
Luboš Luňák
62532ad485 do not set our clang timestamp to the timestamp of the clang binary
If the clang binary comes from a package which had been built before
any of our clang related sources were changed the last time, the timestamp
would be older and so there would be no rebuild. So do the stamp handling
the usual way, clang upgrades will work fine, downgrades will not, but
that's the same problem like with downgrading a library and its headers.

To somewhat mitigate the problem (Clang plugin doesn't get cleaned by
'make clean'), include the full Clang version (which includes SVN revision)
in config_clang.h and make all Clang plugin code include that, so
at least configure re-run will trigger a rebuild if necessary.

Change-Id: I993197f79e92e36105092c92c33b2e1db343e975
2013-01-06 18:23:04 +01:00