mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

781 Commits

Author SHA1 Message Date
Stephan Bergmann
46cf9aed39 SAL_WARN_UNUSED css::uno::Type 
Change-Id: I3b165e2a4414fd3d6c3cede5eb39beffa9fe7576
 2014-01-08 11:48:04 +01:00
Lionel Elie Mamane
a5ce8c77a0 fdo#72916 correct rounding of time part of DateTime 
Change-Id: I135478755f9e5a844119129b470fef8de2cd0409
 2013-12-21 16:49:50 +01:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Noel Grandin
2ac31b06ae Unnecessary use of OUString constructor inside OUStringBuffer constructor 
Convert code like:
    OUStringBuffer sVal(OUString("0x"));
to:
    OUStringBuffer sVal("0x");

Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
 2013-12-17 11:49:05 +02:00
Noel Grandin
8548abbac5 Remove unnecessary use of OUString constructor in OUStringBuffer::append calls 
Convert code like
  aStrBuffer.append(OUString(" AS "));
to
  aStrBuffer.append(" AS ");

Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
 2013-12-17 11:49:04 +02:00
Noel Grandin
909b27df48 remove unnecessary double calls to OUString constructor 
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
 2013-12-17 11:49:04 +02:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions 
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
 2013-12-17 11:49:03 +02:00
Stephan Bergmann
b0926378ac Clean up includes of comphelper/stl_types.hxx 
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
 2013-12-06 17:56:11 +01:00
Stephan Bergmann
0c55303581 Get rid of DECLARE_STL_STDKEY_SET 
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
 2013-12-05 18:36:21 +01:00
Noel Grandin
3af99e4d59 convert equalsAsciiL calls to startsWith calls 
Convert code like:
    aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
    aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.

Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
 2013-11-20 10:07:31 +02:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Julien Nabet
5bacd0d1c4 Fix some wrong copy paste 
Change-Id: I3ad6f62393cb22b350d6b50086963ebc7d2a8f5e
 2013-11-18 22:17:28 +01:00
Julien Nabet
30e5bdcbf5 m_uInt8 not m_nInt8 
Change-Id: I54524b6c7c19202bee049b61edc3f8e0a1e4fde0
 2013-11-17 22:20:14 +01:00
Stephan Bergmann
ab5d1fbfb4 SAL_WARN_UNUSED com::sun:⭐:uno::Any 
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
 2013-11-14 21:02:40 +01:00
Stephan Bergmann
2b9d8d6b2f -Werror,-Wunused-member-function 
Change-Id: Iea28e36ca398018acbae44517c378bb4b188a0b0
 2013-11-14 10:15:02 +01:00
Stephan Bergmann
a1aea9418f -Werror,-Wunused-member-function 
Change-Id: I7f59e3ac50a055486cd1f1dd2d887d38a3ad92c7
 2013-11-14 10:15:01 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Lionel Elie Mamane
79bd39ac61 fdo#65108 inter-module includes <> 
Change-Id: Ie8ca0b1aa7b56ea1d62c9eed798c56ca78464c44
 2013-11-09 18:39:56 +01:00
Lionel Elie Mamane
7b9a9a4986 make firebird-sdbc an experimental feature 
Change-Id: I0f2453e23d18597cfe1ad2a4cd4902b15f0a8f7d
 2013-11-09 18:39:18 +01:00
José Guilherme Vanz
2bb5f4773c fdo#54938: Convert to use cppu::supportsService 
Change-Id: I5b8e08bad3d83b6df23127377c0700fcd27ff084
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2013-11-04 12:24:18 +01:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Tor Lillqvist
526e754b2a WaE: while loop has empty body 
Not just a warning, but clearly an accidental editing error.

Change-Id: Ib708b1de774d56d6c4b144c4e10e280f8181b67b
 2013-10-31 10:46:55 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Lionel Elie Mamane
373e4d33c1 connectivity commontools DatabaseMetaData: provide for getUDTs, too 
Change-Id: Id361ac34f400922893f6a906e4345eed2be1b2d2
 2013-10-25 10:09:21 +02:00
Lionel Elie Mamane
60b67b7e39 janitorial: indentation 
Change-Id: I0b571a9fe719c4f18f89638eb62434dd0813bd01
 2013-10-25 10:09:21 +02:00
Noel Grandin
7a06928bcf convert code to use OUString::endsWith 
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
 2013-10-23 08:29:15 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Lionel Elie Mamane
6940532b81 Revert "fdo#68657 bool->string conversion to 1/0, not "true"/"false" 
This reverts commit b89fb0d03ead22f023f367c9a9d046d3d41ba1cf.

It was intended for stble branch only; in master, we let the
incompatible change go through, but we have introduced a
work-around to get the old behaviour again.
 2013-10-20 19:28:19 +02:00
Lionel Elie Mamane
5dde691e3e an ORowSetValue constructed from a boolean is a boolean 
as opposed to a bit

Change-Id: Ife1c8cef5ca1266e161da3a9190e744dd70ec2fd
 2013-10-20 19:27:27 +02:00
Lionel Elie Mamane
b89fb0d03e fdo#68657 bool->string conversion to 1/0, not "true"/"false 
This matches what OO.org / older versions of LibreOffice did, and which was inadvertently changed in 2bd856e6

Reviewed-on: https://gerrit.libreoffice.org/6275
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>

Conflicts:
	connectivity/source/commontools/FValue.cxx

Change-Id: I1d45ea975a096c599a996caafc41e4aa06d35fcd
 2013-10-20 11:16:39 +02:00
Lionel Elie Mamane
a1c6000984 per SQL standard, BIT is 0/1 but BOOLEAN is true/false 
Change-Id: If088cd33c19bccddbf145a44d19bf37adf638f3b
 2013-10-17 16:20:19 +02:00
Lionel Elie Mamane
ffff474592 respect reference values in checkboxes 
Change-Id: Ifd0953f779f530af6b190425794f009a891f0afb
 2013-10-16 18:45:22 +02:00
Lionel Elie Mamane
5c5df097e6 janitorial: bool is bool, not sal_Bool 
Change-Id: Ia6fbde0521d503c3d774ebd265097804d375ed3b
 2013-10-16 18:45:20 +02:00
Lionel Elie Mamane
b9fac5769d string->bool conversion recognise "1"/"0" additionally to "true"/"false" 
since that is what the conversion in the other direction recognises.
It also recognises the "true"/"false" written by LibreOffice versions affected by fdo#68657

Change-Id: I213c23a19e4857905da93eeb2be1b9714215594a
 2013-10-16 18:45:18 +02:00
Marcos Paulo de Souza
2b91dc3ae6 fdo#54938: Adapt connectivity module to use cppu::supportsService 
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-09 15:03:38 +00:00
Michael Stahl
3ca5b83368 fix Apple g++ 4.2.1 warning in DBTypeConversion::toDateTime 
Change-Id: I467494c1731999c50883f96301b00a3dc1282c73
 2013-09-13 14:05:40 +02:00
Andrzej J.R. Hunt
7b12446f34 Fix throwFunctionNotSupportedException. 
Would have caused eternal recursion, probably was intended to use
throwGenericSQLException or similar, but throwing the correct
exception is probably cleaner anyway.

Change-Id: Ic4afa623bfcd57eb68ef6cfbf737862fd40eaaa2
 2013-09-12 20:01:56 +01:00
Andrzej J.R. Hunt
9f46834fbf Explicitly wrap char as OUString. 
Currently this causes some (all?) gcc to break.

Change-Id: If6d802f5a763904d06107fa99731dd4512f18052
 2013-09-12 19:57:06 +01:00
Andrzej J.R. Hunt
7a6fd503b1 Remove sal_char* from dbexception and some cleanup. 
Change-Id: I81909e4542bd5e8d1f8ae182c3c17f9bbea9745d
Reviewed-on: https://gerrit.libreoffice.org/5881
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:33:02 +00:00
Andrzej J.R. Hunt
4216518982 Update implementations of ColumnLocate::findColumn to throw on invalid column. 
Change-Id: I7a9354ecd35a70a005c6c50e38d27de9b33332bd
Reviewed-on: https://gerrit.libreoffice.org/5922
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:26:12 +00:00
Tor Lillqvist
5326020f85 WaE: Unreachable code: Use SAL_WNOUNREACHABLE_CODE_PUSH/POP 
Cleaner than my first attempt.

This reverts commit aa4868de78b3a3893722f7a079f4d05e18abd8db.

Change-Id: I9c92be72e69292731983a53fc2de29ba333071c9
 2013-09-04 15:00:06 +03:00
Tor Lillqvist
aa4868de78 WaE: Unreachable code 
Noticed by the MS linker when doing link-time code generation (!). In
all cases, a "return" after a call to a function that always throws an
exception. To avoid other compilers perhaps warning about missing
return of a value, put the "returns" inside ifdefs.

Change-Id: I83aa04cb5c3ff8413d3ed4dc85fb57f2a41fd589
 2013-09-04 01:39:26 +03:00
Marcos Paulo de Souza
1d3483ed27 Remove some unused code from unusedcode.easy 
Change-Id: Ic3e96eebbb914c5b905a8c58532ead9cb01dd41d
Reviewed-on: https://gerrit.libreoffice.org/5721
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-09-01 09:15:44 +00:00
Philipp Riemer
5f68458112 delete more code that was commented out 
Change-Id: I8a37b482ca4abb440691b2490e43ecd93a8dbbc5
 2013-08-31 22:41:11 +02:00
Philipp Riemer
78ced6235b fix indentation 
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
 2013-08-31 22:41:11 +02:00
Philipp Riemer
160a4dd9a3 deleted code that was commented out 
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I7a67c3768c0d7e36784ee88fc46680037acb244d
 2013-08-31 22:41:11 +02:00
Philipp Riemer
bf42b6f9f5 fdo#62475 - remove visual noise 
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
 2013-08-31 22:41:10 +02:00
Stephan Bergmann
2410b3c3dd TPropertyValueLessFunctor must actually compare for "<" 
Change-Id: I584a410d90531a0f7b784e62f94c39e715713cf1
 2013-08-29 16:08:02 +02:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf() 
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
 2013-08-21 15:10:35 +02:00